aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
Commit message (Collapse)AuthorAgeFilesLines
* Changelog entry [ci-skip]Guillermo Iguaran2017-05-151-0/+4
|
* Improvements for SQLite rake task.Guillermo Iguaran2017-05-151-7/+18
| | | | | | * Use NOT IN in SQL query * Quote table names propertly * Use array form of command invocation
* Update SchemaDumper.ignore_tables docsGuillermo Iguaran2017-05-151-2/+2
|
* Respect 'ignore_tables' in SQLite structure dumpGuillermo Iguaran2017-05-152-1/+30
|
* Respect 'ignore_tables' in MySQL structure dumpGuillermo Iguaran2017-05-152-0/+22
|
* Respect `ignore_tables` in Postgres structure dumpRusty Geldmacher2017-05-152-0/+14
| | | | | | When using `sql` as the schema format, or even just doing `rake db:structure:dump`, it would be good to respect the list of ignored tables that has been configured.
* Merge pull request #28919 from ↵Kasper Timm Hansen2017-05-121-1/+1
|\ | | | | | | | | meinac/fix_ambigious_exception_message_of_select_query_method Fix ambigious error message of select query method [ci skip]
| * Fix ambigious error message of select query methodMehmet Emin INAC2017-05-081-1/+1
| |
* | Merge pull request #29043 from kamipo/dont_eager_loading_if_unneeded_for_existsAaron Patterson2017-05-113-4/+6
|\ \ | | | | | | Don't eager loading if unneeded for `FinderMethods#exists?`
| * | Don't eager loading if unneeded for `FinderMethods#exists?`Ryuta Kamizono2017-05-113-4/+6
| | | | | | | | | | | | Fixes #29025.
* | | Defer loading each DB Tasks class from AR DatabaseTasksAkira Matsuda2017-05-111-6/+6
|/ / | | | | | | | | | | Because we don't need to load tasks for DBs that we don't use for the current app. Also, these Tasks classes load AR::Base in their class level, and so immediately kick :active_record on_load hooks. This used to happen when we were loading tasks, not when we run a task.
* | Should escape meta characters in regexpRyuta Kamizono2017-05-0710-26/+26
| |
* | Fix `warning: ambiguous first argument`Ryuta Kamizono2017-05-061-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ``` % ARCONN=sqlite3 be ruby -w -Itest test/cases/quoting_test.rb test/cases/quoting_test.rb:92: warning: ambiguous first argument; put parentheses or a space even after `/' operator test/cases/quoting_test.rb:96: warning: ambiguous first argument; put parentheses or a space even after `/' operator Using sqlite3 Run options: --seed 9495 ..................................... Finished in 0.046403s, 797.3622 runs/s, 1120.6172 assertions/s. 37 runs, 52 assertions, 0 failures, 0 errors, 0 skips ```
* | Merge pull request #28989 from matthewd/quoted_id-deprecationMatthew Draper2017-05-062-2/+22
|\ \ | | | | | | Clarify deprecation message for #quoted_id
| * | Clarify deprecation message for #quoted_idMatthew Draper2017-05-052-2/+22
| | | | | | | | | | | | | | | In this case, it's the method definition that's more at fault, rather than the current caller.
* | | Remove unused `DelegationTest#call_method`Ryuta Kamizono2017-05-061-27/+7
| | | | | | | | | | | | `DelegationTest#call_method` is no longer used since 9d79334a.
* | | Don't pass `arel.engine` to `Arel::SelectManager.new`Ryuta Kamizono2017-05-053-9/+6
| | | | | | | | | | | | | | | | | | The argument of `Arel::SelectManager.new` is `table`, not `engine`. https://github.com/rails/arel/blob/v8.0.0/lib/arel/select_manager.rb#L10
* | | Remove useless `target_records_from_association`Ryuta Kamizono2017-05-041-11/+3
|/ / | | | | | | Since through association is always loaded by `preloader.preload`.
* | Should test against `Relation#bound_attributes`Ryuta Kamizono2017-05-041-8/+12
| | | | | | | | Since legacy `Relation#bind_values` was removed in b06f64c.
* | Merge pull request #28974 from kamipo/extract_bind_param_and_bind_attributeRafael França2017-05-0311-51/+38
|\ \ | | | | | | Extract `bind_param` and `bind_attribute` into `ActiveRecord::TestCase`
| * | Extract `bind_param` and `bind_attribute` into `ActiveRecord::TestCase`Ryuta Kamizono2017-05-0411-51/+38
| | | | | | | | | | | | These are used in tests from anywhere.
* | | Remove duplicated `test_merging_reorders_bind_params`Ryuta Kamizono2017-05-041-9/+0
|/ / | | | | | | | | | | The same test exists in `test/cases/relation/merging_test.rb`. https://github.com/rails/rails/blob/v5.1.0/activerecord/test/cases/relation/merging_test.rb#L94-L101
* | Add type caster to `RuntimeReflection#alias_name`Jon Moss2017-05-025-3/+13
| | | | | | | | | | Since we have been using this `Arel::Table` since 111ccc832bc977b15af12c14e7ca078dad2d4373, in order to properly handle queries, it's important that we properly type cast arguments.
* | Merge pull request #28938 from kamipo/deprecate_supports_statement_cacheRafael França2017-05-016-22/+12
|\ \ | | | | | | Deprecate `supports_statement_cache?`
| * | Deprecate `supports_statement_cache?`Ryuta Kamizono2017-05-016-22/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `supports_statement_cache?` was introduced in 3.1.0.beta1 (104d0b2) for bind parameter substitution, but it is no longer used in 3.1.0.rc1 (73ff679). Originally it should respect `prepared_statements` rather than `supports_statement_cache?` (fd39847). One more thing, named `supports_statement_cache?` is pretty misreading. We have `StatementCache` and `StatementPool`. However, `supports_statement_cache?` doesn't mean `StatementCache`, but `StatementPool` unlike its name. https://github.com/rails/rails/blob/v5.1.0/activerecord/lib/active_record/statement_cache.rb https://github.com/rails/rails/blob/v5.1.0/activerecord/lib/active_record/connection_adapters/statement_pool.rb
* | | Merge pull request #28930 from kamipo/use_flat_mapRafael França2017-05-011-1/+1
|\ \ \ | |/ / |/| | Use `flat_map` rather than `map(&:...).flatten`
| * | Use `flat_map` rather than `map(&:...).flatten`Ryuta Kamizono2017-04-291-1/+1
| | |
* | | Cleanup CHANGELOGs [ci skip]Ryuta Kamizono2017-04-301-1/+1
|/ / | | | | | | | | | | * Remove trailing spaces. * Add backticks around method and command. * Fix indentation.
* | Stop creating duplicate Struct instancesJon Moss2017-04-281-23/+15
| | | | | | | | | | | | Just use one `Event` class. Reduces duplication, makes the tests easier to read. It might seem like each tests needs a different kind of Struct, since we make a new one for each test case.
* | Also raise error when VERSION is nilRafael Mendonça França2017-04-272-3/+4
| | | | | | | | Fix #28905
* | Evaluate belongs_to :default option against the owner, not the associationGeorge Claghorn2017-04-272-1/+19
|/
* Restore `fixtures :author_addresses`Ryuta Kamizono2017-04-2721-26/+26
| | | | | This change reverted in eac6f369 but it is needed for data integrity. See #25328.
* Merge pull request #28883 from yahonda/fix28797Rafael França2017-04-262-3/+8
|\ | | | | PostgreSQL 10 does not convert `CURRENT_DATE` into `('now'::text)::date`
| * PostgreSQL 10 allows `CURRENT_DATE` and `CURRENT_TIMESTAMP` as default functionsYasuo Honda2017-04-262-3/+8
| | | | | | | | | | | | | | | | | | | | | | Address #28797 In the previous versions of PostgreSQL, `CURRENT_DATE` converted to `('now'::text)::date` and `CURRENT_TIMESTAMP` converted to `now()`. Refer these discussions and commit at PostgreSQL : https://www.postgresql.org/message-id/flat/5878.1463098164%40sss.pgh.pa.us#5878.1463098164@sss.pgh.pa.us https://github.com/postgres/postgres/commit/0bb51aa96783e8a6c473c2b5e3725e23e95db834
* | Merge pull request #28881 from bogdanvlviv/verbose-migrationRafael França2017-04-262-2/+17
|\ \ | | | | | | Set consistent typecast ENV["VERBOSE"]
| * | Refactor DatabaseTasksMigrateTest#test_migrate_receives_correct_env_varsbogdanvlviv2017-04-261-1/+16
| | | | | | | | | | | | | | | Add cases to ensure that environment variables VERBOSE and VERSION have correct typecast.
| * | Refactor AR::Tasks::DatabaseTasks::migratebogdanvlviv2017-04-261-1/+1
| |/ | | | | | | | | Set consistent type cast ENV["VERBOSE"]: ENV["VERBOSE"] is true if it not equal "false"
* | Merge pull request #28885 from kamipo/remove_useless_test_caseRafael França2017-04-262-13/+0
|\ \ | | | | | | Remove useless test case
| * | Remove useless test caseRyuta Kamizono2017-04-262-13/+0
| |/ | | | | | | | | Cannot call private methods in `@klass` against `CollectionProxy` (inherites `Relation`) because using `public_send` in `method_missing`.
* | Merge pull request #28891 from sodabrew/patch-1Rafael França2017-04-261-2/+0
|\ \ | | | | | | Remove mysql2 database adapter default username root
| * | Remove mysql2 database adapter default username rootAaron Stone2017-04-261-2/+0
| | |
* | | Revert "Merge pull request #27636 from ↵Rafael Mendonça França2017-04-2624-182/+98
|/ / | | | | | | | | | | | | | | | | mtsmfm/disable-referential-integrity-without-superuser-privilege-take-2" This reverts commit c1faca6333abe4b938b98fedc8d1f47b88209ecf, reversing changes made to 8c658a0ecc7f2b5fc015d424baf9edf6f3eb2b0b. See https://github.com/rails/rails/pull/27636#issuecomment-297534129
* / Lock connection before checking it inMatthew Draper2017-04-261-6/+8
|/
* Merge pull request #28828 from kamipo/fix_extending_modules_on_associationRafael França2017-04-253-10/+25
|\ | | | | Mixin `CollectionProxy::DelegateExtending` after `ClassSpecificRelation`
| * Mixin `CollectionProxy::DelegateExtending` after `ClassSpecificRelation`Ryuta Kamizono2017-04-223-10/+25
| | | | | | | | | | | | | | | | | | | | `ClassSpecificRelation` has `method_missing` and the `method_missing` is called first. if an associated class has the missing method in a relation, never reach to the `method_missing` in the `CollectionProxy`. I extracted `DelegateExtending` and included it to the delegate class that including `ClassSpecificRelation` to fix the issue. Fixes https://github.com/rails/rails/pull/28246#issuecomment-296033784.
* | Merge pull request #28831 from kamipo/respond_to_missing_should_be_privateRafael França2017-04-255-26/+18
|\ \ | | | | | | `respond_to_missing?` should be private
| * | `respond_to_missing?` should be privateRyuta Kamizono2017-04-225-26/+18
| |/ | | | | | | | | | | | | Follow up of 03d3f036. Some of `respond_to?` were replaced to `respond_to_missing?` in 03d3f036. But the visibility is still public. It should be private.
* | Fix MigratorTest#test_migrator_verbositybogdanvlviv2017-04-261-1/+1
| | | | | | | | | | | | | | Add `ActiveRecord::Migration.verbose = true` to be sure that verbose is turned on in the test. Related to #28865
* | Merge pull request #28853 from kamipo/replace_regexp_zRafael França2017-04-253-14/+14
|\ \ | | | | | | Replace \Z to \z
| * | Replace \Z to \zRyuta Kamizono2017-04-243-14/+14
| |/ | | | | | | \Z was a mistake of \z. Replace \Z to \z to prevent newly \Z added.
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-11 00:31:10 +0000