Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | call methods on AR::Model after ClassMethods module is defined | Aaron Patterson | 2012-08-24 | 1 | -1/+2 |
| | |||||
* | Extract ActiveRecord::SessionStore from Rails | Prem Sichanugrist | 2012-08-24 | 8 | -583/+3 |
| | | | | | This functionality will be available from gem `active_record-session_store` instead. | ||||
* | ivar will always be defined, so stop checking | Aaron Patterson | 2012-08-23 | 1 | -3/+1 |
| | |||||
* | Model.select takes a variable list of arguments. | Isaac Sanders | 2012-08-23 | 2 | -11/+20 |
| | | | | | | This is a cleaner version of #6916. Closes #3165. | ||||
* | Update the documentation for the :autosave option | David Celis | 2012-08-23 | 1 | -1/+3 |
| | | | | | | | | | | | I've noticed a caveat with the :autosave option biting people before. Questions arise about why they must explicitly save an associated object in their own before_save callbacks. I've updated the documentation as such to note to users that the :autosave callback occurs before any user defined callbacks. They must save the associated record themselves if altering it in their own callbacks. Signed-off-by: David Celis <david@davidcelis.com> | ||||
* | Merge pull request #6606 from amatsuda/ar_relation_model_method | Rafael Mendonça França | 2012-08-21 | 2 | -0/+6 |
|\ | | | | | AR::Relation#model would be a better API than AR::Relation#klass | ||||
| * | AR::Relation#model would be a better API than AR::Relation#klass | Akira Matsuda | 2012-06-03 | 2 | -0/+6 |
| | | |||||
* | | Merge pull request #7225 from rails/eager_load | José Valim | 2012-08-21 | 2 | -0/+12 |
|\ \ | | | | | | | Improve eager load on Rails | ||||
| * | | Get rid of config.preload_frameworks in favor of config.eager_load_namespaces | José Valim | 2012-08-21 | 2 | -0/+12 |
| | | | | | | | | | | | | | | | | | | | | | The new option allows any Ruby namespace to be registered and set up for eager load. We are effectively exposing the structure existing in Rails since v3.0 for all developers in order to make their applications thread-safe and CoW friendly. | ||||
* | | | Use a model without counter cache to test read-only attributes | Rafael Mendonça França | 2012-08-21 | 1 | -9/+10 |
|/ / | |||||
* | | reset_counters() was crashing when there were multiple belongs_to ↵ | Dave Desrochers | 2012-08-21 | 8 | -2/+36 |
| | | | | | | | | | | | | associations with the same foreign key. This closes #5200. | ||||
* | | Refactor AR::Result or inherits. Because we have redundant codes about | kennyj | 2012-08-22 | 3 | -18/+4 |
| | | |||||
* | | Rename to test_mysql_strict_mode_disabled_dont_override_global_sql_mode | Yasuo Honda | 2012-08-22 | 2 | -6/+8 |
| | | | | | | | | | | | | | | | | | | Reason since MySQL 5.6.6-m9 the `sql_mode` default value is `NO_ENGINE_SUBSTITUTION`. This default parameter change is out of control from Rails. This test verifies Rails not overriding the default `@@GLOBAL.sql_mode` value by checking if `@@GLOBAL.sql_mode` is the same as `@@SESSION.sql_mode`. | ||||
* | | Use instance_accessor: false instead of instance_writer. | kennyj | 2012-08-21 | 7 | -11/+29 |
| | | |||||
* | | Add CHANGELOG entry for #6986 | Rafael Mendonça França | 2012-08-21 | 1 | -0/+5 |
| | | |||||
* | | Round usec when writing timestamp attribute. | kennyj | 2012-08-21 | 2 | -5/+29 |
| | | |||||
* | | Minor refactoring in Active Record model schema methods | Carlos Antonio da Silva | 2012-08-21 | 1 | -5/+3 |
| | | | | | | | | | | | | * Use each_key instead of generating intermediate keys array. * Use each_with_object instead of inject to build hash. * Use ternary to return instead of if + assignment. | ||||
* | | removing dead code | Aaron Patterson | 2012-08-20 | 1 | -19/+7 |
| | | |||||
* | | define singleton methods rather than adding and removing methods | Aaron Patterson | 2012-08-20 | 1 | -45/+32 |
| | | |||||
* | | remove dead code | Aaron Patterson | 2012-08-20 | 1 | -78/+36 |
| | | |||||
* | | initialize instance variables for transactions to remove conditionals | Aaron Patterson | 2012-08-20 | 2 | -8/+7 |
| | | |||||
* | | This method is useless without a block, so remove test | Aaron Patterson | 2012-08-20 | 1 | -11/+9 |
| | | |||||
* | | remove unused variable | Aaron Patterson | 2012-08-20 | 1 | -1/+1 |
| | | |||||
* | | initialize instance variables to avoid conditionals | Aaron Patterson | 2012-08-20 | 1 | -2/+7 |
| | | |||||
* | | fix whitespace errors | Aaron Patterson | 2012-08-20 | 1 | -2/+2 |
| | | |||||
* | | Remove private verify readonly attr method | Carlos Antonio da Silva | 2012-08-19 | 1 | -5/+1 |
| | | | | | | | | | | | | | | | | | | | | This method was added to be shared between update_attribute and update_column in 50725cec397d4fa0ecf1dda4e6ae845a993f1ba7, but since update_attribute was removed, and update_column has changed to delegate to update_columns, the method is not used anywhere anymore. Also remove "key.to_s" conversion when raising readonly error, since the key is being interpolated. | ||||
* | | Fix "last equality wins" logic in relation merge | Ernie Miller | 2012-08-19 | 2 | -14/+12 |
| | | | | | | | | | | | | This is a real fix (as compared to the band-aid in b127d86c), which uses the recently-added equality methods for ARel nodes. It has the side benefit of simplifying the merge code a bit. | ||||
* | | Merge pull request #7377 from ↵ | Carlos Antonio da Silva | 2012-08-18 | 3 | -1/+11 |
|\ \ | | | | | | | | | | | | | brainopia/use_inversed_parent_for_first_and_last_child Use inversed parent for first and last child of has_many association | ||||
| * | | Use inversed parent for first and last child of has_many association | brainopia | 2012-08-18 | 3 | -1/+11 |
| | | | |||||
* | | | Get rid of some arguments by using the accessors | Carlos Antonio da Silva | 2012-08-18 | 1 | -30/+31 |
| | | | | | | | | | | | | | | | Cleans up a lot of noise from arguments being passed from one method to another. | ||||
* | | | Move multiparameter attribute logic to a class | Carlos Antonio da Silva | 2012-08-18 | 1 | -72/+84 |
| | | | | | | | | | | | | | | | This should make it easier to refactor and improve this code, and remove complexity with params going around here and there. | ||||
* | | | Some more cleanup to use Hash#values_at, and some method docs | Carlos Antonio da Silva | 2012-08-18 | 1 | -3/+7 |
| | | | |||||
* | | | Use cached column information to instantiate time object | Carlos Antonio da Silva | 2012-08-18 | 1 | -6/+6 |
| | | | |||||
* | | | Refactor blank date parameter validation | Carlos Antonio da Silva | 2012-08-18 | 1 | -2/+6 |
| | | | |||||
* | | | Refactor missing parameter validation based on position | Carlos Antonio da Silva | 2012-08-18 | 2 | -8/+12 |
| | | | |||||
* | | | Reuse already fetched column to check for :time | Carlos Antonio da Silva | 2012-08-18 | 1 | -5/+6 |
| | | | | | | | | | | | | | | | Avoid doing a new column lookup for the attribute, since we already have the column to check for the klass. | ||||
* | | | Refactor some code in multiparameter assignment | Carlos Antonio da Silva | 2012-08-18 | 1 | -26/+25 |
| | | | | | | | | | | | | | | | Move some methods to the top to better organize them, since they're used right at the beginning of the multiparameter assignment method chain. | ||||
* | | | Extract nested parameter assignment to a separate method | Carlos Antonio da Silva | 2012-08-18 | 1 | -3/+6 |
|/ / | |||||
* | | Merge pull request #7380 from ↵ | Aaron Patterson | 2012-08-17 | 2 | -2/+21 |
|\ \ | | | | | | | | | | | | | ernie/fix-nomethoderror-on-non-attribute-equalities Fix merge error when Equality LHS is non-attribute | ||||
| * | | Fix merge error when Equality LHS is non-attribute | Ernie Miller | 2012-08-17 | 2 | -2/+21 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This is at best a band-aid for a more proper fix, since it won't truly handle the removal of the previous equality condition of these other nodes. I'm planning to put in some work on ARel toward supporting that goal. Related: rails/arel#130, ernie/squeel#153, ernie/squeel#156 | ||||
* | | | Pull more serialize code into a lazy included module | Jon Leighton | 2012-08-17 | 1 | -60/+63 |
| | | | |||||
* | | | don't call method unless we need to | Jon Leighton | 2012-08-17 | 1 | -1/+1 |
| | | | |||||
* | | | align them assignments | Jon Leighton | 2012-08-17 | 1 | -4/+4 |
| | | | |||||
* | | | Optimize for the happy path | Jon Leighton | 2012-08-17 | 1 | -11/+14 |
| | | | | | | | | | | | | | | | | | | Checking respond_to? incurs overhead, and most of the time when assigning attributes it will return true. So just handle the NoMethodError instead. | ||||
* | | | Avoid #any? | Jon Leighton | 2012-08-17 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | | | any? will check that each item in the array is truthy, as opposed to !empty? which will simply check that the array has length. For an empty array, !empty? still seems to be faster than any? | ||||
* | | | The default value can be set once in #column_defaults | Jon Leighton | 2012-08-17 | 2 | -9/+16 |
| | | | | | | | | | | | | Rather than doing it every time an instance is instantiated. | ||||
* | | | Optimize instantiation for models which don't use serialize | Jon Leighton | 2012-08-17 | 1 | -13/+20 |
| | | | | | | | | | | | | Those z's were hard to type. | ||||
* | | | Avoid deep_dup when intantiating. | Jon Leighton | 2012-08-17 | 1 | -2/+5 |
| | | | | | | | | | | | | | | | deep_dup is slow. we only need to dup the values, so just do that directly. | ||||
* | | | column default extraction should handle newlines. | Aaron Patterson | 2012-08-17 | 2 | -2/+10 |
| | | | | | | | | | | | | Fixes #7374 | ||||
* | | | Merge pull request #7352 from aripollak/microsecond-timestamp | Rafael Mendonça França | 2012-08-17 | 4 | -3/+10 |
|\ \ \ | | | | | | | | | Fix occasional microsecond conversion inaccuracy |