Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Revert "Don't overwrite unsaved updates when loading an association but ↵ | José Valim | 2010-06-11 | 3 | -17/+3 |
| | | | | | | | | preserve the order of the loaded records. [#4642 state:open]" This commit introduced a regression described in ticket [#4830]. This reverts commit 0265c708b9696c3943518ad5f3dabdc22c5eba11. | ||||
* | class_attribute is not a direct replacement of class_inheritable_*. | José Valim | 2010-06-10 | 1 | -2/+6 |
| | | | | | | If you are setting a hash or an array in class_attribute or you need to freeze it, to ensure people won't modify it in place or you need to dup it on inheritance. | ||||
* | Validators should at model level and not at AR:Base level [Closes #4804] | Neeraj Singh | 2010-06-10 | 1 | -0/+10 |
| | | | | | | [#4804 state:resolved] Signed-off-by: David Heinemeier Hansson <david@loudthinking.com> | ||||
* | Cut down even further on rake -T noise | David Heinemeier Hansson | 2010-06-09 | 1 | -13/+13 |
| | |||||
* | Silence even more noisy rake task docs | David Heinemeier Hansson | 2010-06-09 | 1 | -12/+12 |
| | |||||
* | Don't overwrite unsaved updates when loading an association but preserve the ↵ | James Le Cuirot | 2010-06-09 | 3 | -3/+17 |
| | | | | | | order of the loaded records. [#4642 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Make sure about which is the first element of the query, fixes a postgresql ↵ | Santiago Pastorino | 2010-06-09 | 1 | -2/+2 |
| | | | | | | 8.4 failing test Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | SQLite2Adapter doesn't exist | Santiago Pastorino | 2010-06-09 | 1 | -1/+1 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Make logic for after_commit and after_rollback :on option work like it does ↵ | Brian Durand | 2010-06-08 | 1 | -18/+33 |
| | | | | | | | | for validation callbacks. [#2991 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | Revert "Temporarily revert "Update after_commit and after_rollback docs and ↵ | Jeremy Kemper | 2010-06-08 | 5 | -9/+440 |
| | | | | | | | | tests to use new style API with an :on options instead of on_* suffix." and "Add after_commit and after_rollback callbacks to ActiveRecord that are called after transactions either commit or rollback on all records saved or destroyed in the transaction."" This reverts commit 1b2941cba1165b0721f57524645fe378bee2a950. [#2991] | ||||
* | Clarify Fixture#key_ and value_list | Jeremy Kemper | 2010-06-08 | 1 | -7/+5 |
| | |||||
* | Merge remote branch 'docrails/master' | Xavier Noria | 2010-06-08 | 1 | -1/+1 |
|\ | |||||
| * | Merge remote branch 'rails/master' | Xavier Noria | 2010-06-08 | 22 | -499/+84 |
| |\ | |||||
| * | | update docs before_validation_on_create => before_validation(:on => :create) | Santiago Pastorino and José Ignacio Costa | 2010-06-07 | 1 | -1/+1 |
| | | | |||||
* | | | Avoid PostgreSQL and MySQL tests warnings. | Emilio Tagua | 2010-06-08 | 2 | -3/+6 |
| | | | | | | | | | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | | | Fix ActiveRecord::Base.compute_type swallowing NoMethodError. [#4751 ↵ | Andrew Bloomgarden | 2010-06-08 | 3 | -1/+22 |
| |/ |/| | | | | | | | | | state:resolved] Signed-off-by: David Heinemeier Hansson <david@loudthinking.com> | ||||
* | | Add parentheses to avoid warnings when running AR tests. | Emilio Tagua | 2010-06-08 | 1 | -4/+4 |
| | | | | | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | | Bump Arel to 0.4.0 | Emilio Tagua | 2010-06-08 | 1 | -1/+1 |
| | | | | | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | | Temporarily revert "Update after_commit and after_rollback docs and tests to ↵ | Jeremy Kemper | 2010-06-08 | 5 | -440/+9 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | use new style API with an :on options instead of on_* suffix." and "Add after_commit and after_rollback callbacks to ActiveRecord that are called after transactions either commit or rollback on all records saved or destroyed in the transaction." This reverts commits d2a49e4b1f30c5997e169110eed94a55aee53f56 and da840d13da865331297d5287391231b1ed39721b. [#2991] Conflicts: activerecord/CHANGELOG activerecord/lib/active_record/transactions.rb activerecord/test/cases/transaction_callbacks_test.rb | ||||
* | | Get ready for beta 4 | David Heinemeier Hansson | 2010-06-08 | 2 | -2/+2 |
| | | |||||
* | | forcing encoding on 1.9 when dealing with "binary" columns [#4612 ↵ | Aaron Patterson | 2010-06-08 | 1 | -0/+4 |
| | | | | | | | | | | | | state:resolved] Signed-off-by: wycats <wycats@gmail.com> | ||||
* | | Fix multiple self-referencing eager loads failing to join multiple times | Ernie Miller | 2010-06-08 | 2 | -3/+11 |
| | | | | | | | | | | | | [#4679 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | | Merge remote branch 'rsim/oracle_enhanced_rails3' | wycats | 2010-06-07 | 11 | -41/+48 |
|\ \ | |||||
| * | | compare sorted arrays in relations_test | Raimonds Simanovskis | 2010-06-04 | 1 | -1/+1 |
| | | | | | | | | | Oracle does not guarantee that SELECT will return records ordered by primary key | ||||
| * | | ignore raw_sql_ table alias that is used by Oracle adapter | Raimonds Simanovskis | 2010-06-04 | 1 | -1/+2 |
| | | | |||||
| * | | fix test_belongs_to_with_primary_key_joins_on_correct_column test on Oracle | Raimonds Simanovskis | 2010-06-04 | 1 | -0/+4 |
| | | | |||||
| * | | Downcase quoted table name in regex in count_aliases_from_table_joins | Raimonds Simanovskis | 2010-06-04 | 1 | -1/+2 |
| | | | | | | | | | | | | Oracle adapter's quote_table_name returns quoted table name in uppercase and therefore it should be downcased before scanning downcased join_sql | ||||
| * | | Fixed adapter tests not to assert LIMIT and OFFSET in SQL strings | Raimonds Simanovskis | 2010-06-04 | 1 | -13/+4 |
| | | | | | | | | | | | | Fixed adapter test cases that were failing in oracle because the asserts were looking for the presence of offset and limit which are not available in oracle. Changed the tests to check that the sql injection is not present in the output so that the tests are database adapter agnostic. | ||||
| * | | ignore selects from data dictionary views when running tests on Oracle | Raimonds Simanovskis | 2010-06-04 | 1 | -1/+1 |
| | | | |||||
| * | | assert log output match in case insensitive mode to avoid failure when ↵ | Raimonds Simanovskis | 2010-06-04 | 1 | -2/+2 |
| | | | | | | | | | | | | quoted table name is in uppercase (when using Oracle) | ||||
| * | | downcase table names in aliased_table_name_for and ↵ | Raimonds Simanovskis | 2010-06-04 | 1 | -2/+4 |
| | | | | | | | | | | | | references_eager_loaded_tables? methods (as Oracle quoted table names are in uppercase) | ||||
| * | | test fixes for Oracle enhanced adapter: | Raimonds Simanovskis | 2010-06-04 | 2 | -3/+3 |
| | | | | | | | | | | | | | | | latest oracle_enhanced adapter does automatic shortening of index names ignore select from all_triggers table in assert_queries | ||||
| * | | do order by id when finding first fixture to ensure that it is correct one | Raimonds Simanovskis | 2010-06-04 | 1 | -1/+1 |
| | | | | | | | | | | | | (as otherwise was failing under JRuby and oracle_enhanced adapter) | ||||
| * | | Oracle enhanced adapter now supports shortening of default generated index ↵ | Raimonds Simanovskis | 2010-06-04 | 1 | -12/+10 |
| | | | | | | | | | | | | names, some additional tests now pass | ||||
| * | | Reduced size of table name prefix and suffix in migrations test as in Oracle ↵ | Raimonds Simanovskis | 2010-06-04 | 1 | -3/+4 |
| | | | | | | | | | | | | identifier name cannot be larger than 30 characters | ||||
| * | | Explicitly set Topic model last_read attribute as Date value when Oracle ↵ | Raimonds Simanovskis | 2010-06-04 | 2 | -3/+10 |
| | | | | | | | | | | | | | | | | | | enhanced adapter is used (otherwise some tests are failing which assume that this attribute will have Date value) | ||||
| * | | create DateTime value with local offset as later it is compared to Time ↵ | Raimonds Simanovskis | 2010-06-04 | 1 | -1/+3 |
| | | | | | | | | | | | | | | | | | | value with local offset (otherwise test is failing for oracle_enhanced JDBC adapter) | ||||
* | | | This test shouldn't rely on the order of the data returned by select | Santiago Pastorino | 2010-06-07 | 1 | -1/+1 |
| | | | | | | | | | | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | | | Really make include_root_in_json default to true [#3770 state:resolved] | José Valim | 2010-06-08 | 1 | -11/+8 |
| |/ |/| | |||||
* | | Make the logic for nested_records_changed_for_autosave? simpler. | José Valim | 2010-06-07 | 1 | -9/+5 |
| | | | | | | | | [#4648 state:resolved] | ||||
* | | Fixing test class names and refactor line in autosave association | Carlos Antonio da Silva | 2010-06-07 | 3 | -7/+7 |
| | | | | | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | | Require active support/string/conversions so constantize can be used in ↵ | Tom Meier | 2010-06-07 | 1 | -0/+1 |
| | | | | | | | | | | | | associations.rb Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | | MySQL: require 2.7 or later so we can rely on result.each_hash | Jeremy Kemper | 2010-06-05 | 1 | -49/+8 |
| | | |||||
* | | Whoops. _run_*_callbacks is private | wycats | 2010-06-04 | 1 | -1/+1 |
| | | |||||
* | | Use faster form of running callbacks | wycats | 2010-06-04 | 1 | -1/+1 |
| | | |||||
* | | removes Array#random_element and backports Array#sample from Ruby 1.9, ↵ | Xavier Noria | 2010-06-05 | 2 | -8/+8 |
|/ | | | | thanks to Marc-Andre Lafortune | ||||
* | Properly cache association_collection#scopes calls having arguments | Pratik Naik | 2010-06-04 | 3 | -1/+16 |
| | |||||
* | Special treatement for Relation#select { with block } | Pratik Naik | 2010-06-02 | 2 | -1/+19 |
| | |||||
* | Configure generators before invoking. | José Valim | 2010-06-02 | 1 | -0/+1 |
| | |||||
* | Unforce tzinfo from AS | Santiago Pastorino | 2010-06-01 | 1 | -0/+1 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> |