aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
Commit message (Collapse)AuthorAgeFilesLines
* [ci skip] Clarify DDL term in ActiveRecord::TransactionsAlex Kitchens2016-06-271-4/+4
|
* Remove unnecessary `assert_valid_default`Ryuta Kamizono2016-06-252-14/+0
| | | | | This was added at c7c3f73 but it never raised because MySQL cannot create text/blob columns with a default value.
* nodoc `ActiveRecord::AttributeSet::YAMLEncoder`Jon Moss2016-06-241-1/+1
| | | | | | | | | As mentioned in 7b86ea6715ee987e61a7f3bd8e72b1bbfcfbbbe7, this is an internal class. [ci skip] r? @sgrif
* Revert "[ci skip] better docs for ↵Jon Moss2016-06-241-17/+0
| | | | | | | | ActiveRecord::AttributeSet::YAMLEncoder#decode" This reverts commit 7ea502ae141fc26b736c7a73bdf7a676b1f9fc87, per internal discussion with @sgrif -- this is documenting the implementation of a class that isn't intended to be public API.
* Merge pull request #25506 from y-yagi/return_correct_from_enum_typeSean Griffin2016-06-242-0/+6
|\ | | | | return correct type from `EnumType`
| * return correct type from `EnumType`yuuji.yaginuma2016-06-242-0/+6
| |
* | Removed a forgotten `with_exclusive_scope` test:Edouard CHIN2016-06-241-6/+0
| | | | | | | | - `with_exclusive_scope` was removed in this commit d242e467819a428ad7e302968e4c9fa1e26d9326
* | [ci skip] Update Documentation on ActiveRecord::InheritanceAlex Kitchens2016-06-231-1/+2
|/
* [ci skip] better docs for ActiveRecord::AttributeSet::YAMLEncoder#decodeDavid Elliott2016-06-211-0/+17
|
* [ci skip] fix typo in ActiveRecord::ConnectionHandlingAlex Kitchens2016-06-201-1/+1
|
* Merge pull request #23301 from ppworks/improve_mysqldumpArthur Nogueira Neves2016-06-172-4/+5
|\ | | | | Improve mysqldump
| * Skip comments when exec mysqldumpNaoto Koshikawa2016-01-282-4/+5
| |
* | Move code style configuration files to root directoryJon Moss2016-06-162-54/+0
| | | | | | | | | | | | | | | | | | I think these are meant to be in the root directory, not in `/activerecord`? :grimacing: r? @sgrif [ci skip]
* | Merge pull request #24773 from ralinc/fix-silent-fail-on-psql-commandArthur Nogueira Neves2016-06-163-3/+18
|\ \ | | | | | | PostgreSQL: Fix db:structure:load silent failure on SQL error
| * | PostgreSQL: Fix db:structure:load silent failure on SQL errorRalin Chimev2016-05-103-3/+18
| | | | | | | | | | | | | | | | | | | | | | | | The command line flag "-v ON_ERROR_STOP=1" should be used when invoking psql to make sure errors are not suppressed. Example: psql -v ON_ERROR_STOP=1 -q -f awesome-file.sql my-app-db Fixes #23818.
* | | Merge pull request #25271 from kamipo/prevent_range_error_for_existsSean Griffin2016-06-153-10/+6
|\ \ \ | | | | | | | | Prevent `RangeError` for `FinderMethods#exists?`
| * | | Prevent `RangeError` for `FinderMethods#exists?`Ryuta Kamizono2016-06-163-6/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `FinderMethods#exists?` should return a boolean rather than raising an exception. `UniquenessValidator#build_relation` catches a `RangeError` because it includes type casting due to a string value truncation. But a string value truncation was removed at #23523 then type casting in `build_relation` is no longer necessary. aa06231 removes type casting in `build_relation` then a `RangeError` moves to `relation.exists?`. This change will remove the catching a `RangeError`.
| * | | Avoid type casting in uniqueness validatorRyuta Kamizono2016-06-041-5/+2
| | | | | | | | | | | | | | | | | | | | Type casting in uniqueness validator is for a string value truncation. It was removed at #23523.
* | | | Merge pull request #25339 from prathamesh-sonpatki/reuse-validate-index-lengthRafael França2016-06-151-7/+7
|\ \ \ \ | | | | | | | | | | Reuse validate index length
| * | | | Reuse existing validate_index_length! methodPrathamesh Sonpatki2016-06-091-7/+7
| | | | | | | | | | | | | | | | | | | | - Followup of https://github.com/rails/rails/commit/1ea6cc11211dc89e3e14b2b641a3cca8a0a91d55.
* | | | | Fix postgresql query_cache testArthur Neves2016-06-141-0/+1
| | | | |
* | | | | Respect the current `connected?` method when calling `cache`Arthur Neves2016-06-142-2/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Before we enable query caching we check if the connection is connected. Before this fix we were always checking against the main connection, and not the model connection.
* | | | | Remove not needed line on testArthur Neves2016-06-141-1/+0
| | | | |
* | | | | Fix error message to talk about the scale not precision of the typeRafael Mendonça França2016-06-131-1/+1
| | | | | | | | | | | | | | | | | | | | Fixes #25391
* | | | | Merge pull request #24756 from ↵Rafael Mendonça França2016-06-131-2/+2
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | gsamokovarov/always-inherit-from-application-record Always genererate models with ApplicationRecord parent
| * \ \ \ \ Merge branch 'master' into always-inherit-from-application-recordGenadi Samokovarov2016-05-3084-2368/+740
| |\ \ \ \ \
| * | | | | | Always genererate models with ApplicationRecord parentGenadi Samokovarov2016-04-281-11/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently, if we generate a model while `app/model/application_record.rb` isn't present, we'll end up with a model with an `ActiveRecord::Base` parent _and_ a newly generated `app/models/application_record.rb`. While the behavior for choosing an `ActiveRecord::Base` was chosen for an easier migration math to 5.0, generating the `app/model/application_record.rb` file kinda contradicts with it. In any case, I think we should decide on a behavior and stick to it. Here, I'm changing the generated parent to always be `ApplicationRecord` and to always create `app/model/application_record.rb` if it doesn't exist.
* | | | | | | Merge pull request #25319 from morgoth/generate-application-record-firstRafael França2016-06-131-10/+2
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Generate application_record.rb file before model file
| * | | | | | | Generate application_record.rb file before model fileWojciech Wnętrzak2016-06-081-10/+2
| | |_|_|/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously model file was generated first, which resulted in inheriting from `ActiveRecord::Base`, but since application_record.rb is generated as well, it should already be used.
* | | | | | | Merge pull request #25374 from ↵Sean Griffin2016-06-132-9/+5
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | kamipo/fix_calculate_with_string_in_from_and_eager_loading Fix `calculate` with a string value in `from` and eager loading
| * | | | | | | Fix `calculate` with a string value in `from` and eager loadingRyuta Kamizono2016-06-132-9/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `construct_relation_for_association_calculations` pass a string value to `construct_join_dependency` when setting a string value in `from`. It should not pass a string value, but always `joins_values`. Related #14834, #19452. Fixes #24193.
* | | | | | | | Merge pull request #25372 from kamipo/remove_assert_date_from_dbSean Griffin2016-06-132-5/+1
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | Remove unnecessary `assert_date_from_db`
| * | | | | | | | Remove unnecessary `assert_date_from_db`Ryuta Kamizono2016-06-122-5/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `assert_date_from_db` was added at 6a2104d for SQL Server. But latest sqlserver adapter work to pass expected behavior since 8e4624b.
* | | | | | | | | Add codeclimate and rubocop config filesSean Griffin2016-06-132-0/+54
| |/ / / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We're going to be experimenting with a new bot for them. This will not cause anything to start affecting new PRs yet, but it will have data sent to them so they can do "dry run" stuff on their end. The rubocop file is based on our documented style guide. I've only included rules which are either already consistently applied throughout the entire codebase, or where added lines should be following the guideline regardless of the surrounding code (such as hash syntax)
* | | | | | | | Merge pull request #25362 from maclover7/jm-rm-ar-requireEileen M. Uchitelle2016-06-121-2/+0
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | Remove unnecessary model requires
| * | | | | | | | Remove unnecessary model requiresJon Moss2016-06-101-2/+0
| | |_|_|_|/ / / | |/| | | | | |
* | | | | | | | Remove outdated comments [ci skip]Ryuta Kamizono2016-06-121-12/+0
| |/ / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | These comments were added at dd257a3ccb30ab181cd48d3d81bc7f23bb45f36f but outdated since #2086.
* | | | | | | Fix typoFrancesco Rodriguez2016-06-121-1/+1
| | | | | | | | | | | | | | | | | | | | | [ci skip]
* | | | | | | Fix `or` result SQL [ci skip]Ryuta Kamizono2016-06-111-1/+1
|/ / / / / /
* | | | | | Remove dead code from testsSean Griffin2016-06-091-17/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This code was added in 81286f858770e0b95e15af37f19156b044ec6a95, but was not used by that commit and does not appear to have ever been used.
* | | | | | Merge pull request #25329 from ↵Sean Griffin2016-06-091-1/+1
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | yahonda/allow_oracle_bind_value_syntax_in_loj_test Allow Oracle bind parameter syntax `:a1` in test_join_conditions_added_to_join_clause
| * | | | | | Allow Oracle bind parameter syntax `:a1`Yasuo Honda2016-06-081-1/+1
| |/ / / / /
* / / / / / Fix typoAbhishek Jain2016-06-091-2/+2
|/ / / / /
* | | | | Fix sqlite3 test failureRyuta Kamizono2016-06-042-3/+3
| | | | | | | | | | | | | | | | | | | | Sqlite3 test failure is due to 66ebbc4952f6cfb37d719f63036441ef98149418.
* | | | | Dont re-define class SQLite3Adapter on testArthur Neves2016-06-032-108/+98
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We were declaring in a few tests, which depending of the order load will cause an error, as the super class could change. see https://github.com/rails/rails/commit/ac1c4e141b20c1067af2c2703db6e1b463b985da#commitcomment-17731383
* | | | | Merge pull request #25243 from sukesan1984/add_i18n_validation_testYves Senn2016-06-031-4/+2
|\ \ \ \ \ | | | | | | | | | | | | Add i18n_validation_test
| * | | | | Add i18n_validation_testsukesan19842016-06-021-4/+2
| | | | | | | | | | | | | | | | | | | | | | | | add active record uniqueness validation test for { on: [:create, :update] } condition.
* | | | | | Ensure that records with unselected fields can be updatedSean Griffin2016-06-022-0/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As part of refactoring mutation detection to be more performant, we introduced the concept of `original_value` to `Attribute`. This was not overridden in `Attribute::Uninitialized` however, so assigning ot an uninitialized value and calling `.changed?` would raise `NotImplementedError`. We are using a sentinel value rather than checking the result of `original_attribute.initialized?` in `changed?` because `original_value` might go through more than one node in the tree. Fixes #25228
* | | | | | Fix failing testsSean Griffin2016-06-023-5/+17
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently CI is broken due to 56a61e0 and c4cb686. This occurred because the failures are not present on SQLite which is what I normally run locally before pushing. The optimizations to our YAML size were dropping mutations, as `with_type` didn't set the previous value if it'd already been read (that method was never really designed to be used with values on individual objects, it was previously only used for defaults). I'm questioning whether there's a better place to be handling the exclusion of the type, but this will fix the failing build. Additionally, there was a bug in `remove_foreign_key` if you passed it an options hash containing `to_table`. This now occurs whenever removing a reference, as we always normalize to a hash. [Sean Griffin & Ryuta Kamizono]
* | | | | Make Active Record emit significantly smaller YAMLSean Griffin2016-05-318-7/+82
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reduces the size of a YAML encoded Active Record object by ~80% depending on the number of columns. There were a number of wasteful things that occurred when we encoded the objects before that have resulted in numerous wins - We were emitting the result of `attributes_before_type_cast` as a hack to work around some laziness issues - The name of an attribute was emitted multiple times, since the attribute objects were in a hash keyed by the name. We now store them in an array instead, and reconstruct the hash using the name - The types were included for every attribute. This would use backrefs if multiple objects were encoded, but really we don't need to include it at all unless it differs from the type at the class level. (The only time that will occur is if the field is the result of a custom select clause) - `original_attribute:` was included over and over and over again since the ivar is almost always `nil`. We've added a custom implementation of `encode_with` on the attribute objects to ensure we don't write the key when the field is `nil`. This isn't without a cost though. Since we're no longer including the types, an object can find itself in an invalid state if the type changes on the class after serialization. This is the same as 4.1 and earlier, but I think it's worth noting. I was worried that I'd introduce some new state bugs as a result of doing this, so I've added an additional test that asserts mutation not being lost as the result of YAML round tripping. Fixes #25145
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-08 06:49:13 +0000