aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | | | Merge pull request #35449 from pjrebsch/quoting-empty-rangeRyuta Kamizono2019-03-113-2/+20
|\ \ \ \ \ \ | | | | | | | | | | | | | | Quote empty ranges like other empty enumerables
| * | | | | | Quote empty ranges like other empty enumerablesPatrick Rebsch2019-03-073-2/+20
| |/ / / / /
* | | | | | Merge pull request #35121 from utilum/warning_tried_to_create_proc_without_blockKasper Timm Hansen2019-03-103-6/+6
|\ \ \ \ \ \ | | | | | | | | | | | | | | Ruby 2.7 warning: creating a Proc without a block
| * | | | | | Ruby 2.7 warning: creating a Proc without a blockutilum2019-02-133-6/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As of [Revision 66772]( https://bugs.ruby-lang.org/projects/ruby-trunk/repository/trunk/revisions/66772) `Proc.new` without giving a block emits `warning: tried to create Proc object without a block`. This commit fixes cases where Rails test suit tickles this warning. See CI logs: https://travis-ci.org/rails/rails/jobs/487205819#L1161-L1190 https://travis-ci.org/rails/rails/jobs/487205821#L1154-1159 https://travis-ci.org/rails/rails/jobs/487205821#L1160-L1169 https://travis-ci.org/rails/rails/jobs/487205821#L1189 https://travis-ci.org/rails/rails/jobs/487254404#L1307-L1416 https://travis-ci.org/rails/rails/jobs/487254405#L1174-L1191
* | | | | | | Merge pull request #35559 from ↵Kasper Timm Hansen2019-03-091-0/+2
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ashishprajapati/ashishprajapati/important_textual_improvements Added missing guide links in documentation and minor wording fix
| * | | | | | | Added missing guide links in README documentation and minor wording fix [ci ↵ashishprajapati2019-03-101-0/+2
| | |/ / / / / | |/| | | | | | | | | | | | | | | | | | | skip]
* | | | | | | PostgreSQL: Add `add_pg_encoders` and `add_pg_decoders` in `connect`Ryuta Kamizono2019-03-101-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It is to work that on `reconnect!` after `disconnect!`. https://buildkite.com/rails/rails/builds/59378#1efea538-cfca-4d43-8b7e-ae78e97227c8
* | | | | | | Don't test `disconnect!` if in memory dbRyuta Kamizono2019-03-101-8/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | `disconnect!` will lose all tables and fixtures if in memory db.
* | | | | | | SQLite3: Set `busy_timeout` in `configure_connection`Ryuta Kamizono2019-03-101-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | It is to work that on `reconnect!` after `disconnect!`
* | | | | | | Fix `reconnect!` to work after `disconnect!`Ryuta Kamizono2019-03-103-11/+25
| | | | | | |
* | | | | | | Fixed autosave association test typoShailesh Kalamkar2019-03-091-1/+1
| | | | | | |
* | | | | | | Merge pull request #35552 from abhaynikam/fix-remaining-set-of-links-in-gemspecRyuta Kamizono2019-03-103-3/+3
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Update some more links to https
| * | | | | | | Fix links in gemspec and docs from http to https.Abhay Nikam2019-03-093-3/+3
| | | | | | | |
* | | | | | | | Update upsert_all documentation [ci skip]Sharang Dashputre2019-03-091-3/+2
| | | | | | | |
* | | | | | | | Merge pull request #35527 from tight/improve_doc_of_automatic_inverse_ofRyuta Kamizono2019-03-091-2/+3
|\ \ \ \ \ \ \ \ | |/ / / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | Improve doc of automatic inverse_of detection [ci skip]
| * | | | | | | Improve doc of automatic inverse_of detectionFrançois D2019-03-081-2/+3
| |/ / / / / /
* | | | | | | Merge pull request #35531 from boblail/issue-35519Ryuta Kamizono2019-03-091-3/+7
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Update documentation on upsert_all so that it is correct for Postgres [ci skip]
| * | | | | | | Update documentation on upsert_all so that it is correct for PostgresBob Lail2019-03-081-3/+7
| |/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Details in https://github.com/rails/rails/issues/35519 In short, MySQL and Sqlite3 allow a record to be both inserted _and_ replaced in the same operation. Postgres (and the SQL-2003 rules for MERGE) do not. Postgres's rationale seems to be that the operation would be nondeterministic. I think it's OK for Rails users to have a different experience with this feature depending on their database; but I think you should be able to follow the examples in the docs on any database.
* / / / / / / Minor documentation fixes related to bulk insert [skip ci]Vishal Telangre2019-03-091-10/+13
|/ / / / / /
* | | | | | Merge pull request #35512 from kamipo/delegate_onlyRyuta Kamizono2019-03-073-2/+6
|\ \ \ \ \ \ | | | | | | | | | | | | | | Delegate `only` query method to relation as with `except`
| * | | | | | Delegate `only` query method to relation as with `except`Ryuta Kamizono2019-03-073-2/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I've found the skewness of delegation methods between `except` and `only` in a88b6f2. The `only` method is closely similar with `except` as `SpawnMethods`. https://github.com/rails/rails/blob/e056b9bfb07c4eb3bcc6672d885aadd72bec574f/activerecord/lib/active_record/relation/spawn_methods.rb#L53-L67 It is preferable both behaves the same way.
* | | | | | | Merge pull request #35503 from samjohn/cannot-grammar-correctionXavier Noria2019-03-075-5/+5
|\ \ \ \ \ \ \ | |/ / / / / / |/| | | | | | Replace “can not” with “cannot”.
| * | | | | | Replace “can not” with “cannot”.Samantha John2019-03-065-5/+5
| | | | | | |
* | | | | | | Refactor AR::Querying to extract `QUERYING_METHODS` listRyuta Kamizono2019-03-072-27/+33
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This makes to ease testing `QUERYING_METHODS`.
* | | | | | | Fix incorrect identifier quoting [ci skip]Ryuta Kamizono2019-03-071-2/+2
| | | | | | |
* | | | | | | Just inherit `ForeignKeyChangeColumnTest` for with prefix/suffix testsRyuta Kamizono2019-03-071-17/+5
| | | | | | |
* | | | | | | Move all Arel constructions from uniqueness validator into connection adapterRyuta Kamizono2019-03-073-7/+6
| | | | | | |
* | | | | | | [ci skip]Fix typo: constaint -> constraintwillnet2019-03-071-2/+2
|/ / / / / /
* | | | | | Merge pull request #35497 from eileencodes/parse-yaml-without-erb-for-rake-tasksEileen M. Uchitelle2019-03-061-1/+1
|\ \ \ \ \ \ | | | | | | | | | | | | | | Load YAML for rake tasks without parsing ERB
| * | | | | | Load YAML for rake tasks without parsing ERBeileencodes2019-03-061-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This change adds a new method that loads the YAML for the database config without parsing the ERB. This may seem odd but bear with me: When we added the ability to have rake tasks for multiple databases we started looping through the configurations to collect the namespaces so we could do `rake db:create:my_second_db`. See #32274. This caused a problem where if you had `Rails.config.max_threads` set in your database.yml it will blow up because the environment that defines `max_threads` isn't loaded during `rake -T`. See #35468. We tried to fix this by adding the ability to just load the YAML and ignore ERB all together but that caused a bug in GitHub's YAML loading where if you used multi-line ERB the YAML was invalid. That led us to reverting some changes in #33748. After trying to resolve this a bunch of ways `@tenderlove` came up with replacing the ERB values so that we don't need to load the environment but we also can load the YAML. This change adds a DummyCompiler for ERB that will replace all the values so we can load the database yaml and create the rake tasks. Nothing else uses this method so it's "safe". DO NOT use this method in your application. Fixes #35468
* | | | | | | Add some whitespace for readability.Kasper Timm Hansen2019-03-062-0/+14
| | | | | | |
* | | | | | | Fix test case name after file extractionKasper Timm Hansen2019-03-061-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Although the old name had a certain persistence, this ain't the kind of file we're in now.
* | | | | | | Handle blank inserts like update_all; raise upfront.Kasper Timm Hansen2019-03-062-7/+5
| | | | | | |
* | | | | | | Allow `remove_foreign_key` with both `to_table` and `options`Ryuta Kamizono2019-03-067-33/+32
| |_|_|_|/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Foreign keys could be created to the same table. So `remove_foreign_key :from_table, :to_table` is sometimes ambiguous. This allows `remove_foreign_key` to remove the select one on the same table with giving both `to_table` and `options`.
* | | | | | [ci skip] Fix typo beacuse -> becauseAbhay Nikam2019-03-061-1/+1
| | | | | |
* | | | | | Ensure `clear_cache!` clears the prepared statements cacheRyuta Kamizono2019-03-065-26/+25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since #23461, all adapters supports prepared statements, so that clears the prepared statements cache is no longer database specific. Actually, I struggled to identify the cause of random CI failure in #23461, that was missing `@statements.clear` in `clear_cache!`. This extracts `clear_cache!` to ensure the common concerns in the abstract adapter.
* | | | | | Add insert_all to ActiveRecord models (#35077)Bob Lail2019-03-0512-17/+613
|/ / / / / | | | | | | | | | | | | | | | | | | | | Adds a method to ActiveRecord allowing records to be inserted in bulk without instantiating ActiveRecord models. This method supports options for handling uniqueness violations by skipping duplicate records or overwriting them in an UPSERT operation. ActiveRecord already supports bulk-update and bulk-destroy actions that execute SQL UPDATE and DELETE commands directly. It also supports bulk-read actions through `pluck`. It makes sense for it also to support bulk-creation.
* | | | | Reset `connection_handlers` to default when any test dirties thatRyuta Kamizono2019-03-051-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Most existing tests expects `connection_handlers` has only one default handler, but the test added at #34779 dirties that. We need to reset `connection_handlers` to default in that case. Closes #35471.
* | | | | Fix typo in test nameSharang Dashputre2019-03-051-1/+1
| | | | |
* | | | | Merge pull request #35434 from matthewd/faster-isolated-arMatthew Draper2019-03-052-2/+56
|\ \ \ \ \ | | | | | | | | | | | | Copy the forking isolated test runner from railties
| * | | | | Clean up AR's isolated test runnerMatthew Draper2019-03-052-3/+21
| | | | | |
| * | | | | Copy the forking isolated test runner from railtiesMatthew Draper2019-03-051-2/+38
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | All the tests have a substantial chunk of identical setup effort (in cases/helper.rb); this makes isolated tests run much faster, without any change to the variety of how we load files.
* | | | | | Allow `truncate` for SQLite3 adapter and add `rails db:seed:replant` (#34779)Bogdan2019-03-049-0/+213
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Add `ActiveRecord::Base.connection.truncate` for SQLite3 adapter. SQLite doesn't support `TRUNCATE TABLE`, but SQLite3 adapter can support `ActiveRecord::Base.connection.truncate` by using `DELETE FROM`. `DELETE` without `WHERE` uses "The Truncate Optimization", see https://www.sqlite.org/lang_delete.html. * Add `rails db:seed:replant` that truncates database tables and loads the seeds Closes #34765
* | | | | | Fix typo in CHANGELOG.md [ci skip]Sharang Dashputre2019-03-041-1/+1
| | | | | |
* | | | | | Deprecate mismatched collation comparison for uniquness validatorRyuta Kamizono2019-03-046-12/+86
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In MySQL, the default collation is case insensitive. Since the uniqueness validator enforces case sensitive comparison by default, it frequently causes mismatched collation issues (performance, weird behavior, etc) to MySQL users. https://grosser.it/2009/12/11/validates_uniqness_of-mysql-slow/ https://github.com/rails/rails/issues/1399 https://github.com/rails/rails/pull/13465 https://github.com/gitlabhq/gitlabhq/commit/c1dddf8c7d947691729f6d64a8ea768b5c915855 https://github.com/huginn/huginn/pull/1330#discussion_r55152573 I'd like to deprecate the implicit default enforcing since I frequently experienced the problems in code reviews. Note that this change has no effect to sqlite3, postgresql, and oracle-enhanced adapters which are implemented as case sensitive by default, only affect to mysql2 adapter (I can take a work if sqlserver adapter will support Rails 6.0).
* | | | | | Move changelog entry about `reselect` method to the section of the next releasebogdanvlviv2019-03-041-9/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes https://github.com/rails/rails/pull/33611#discussion_r261549790 Related to https://3.basecamp.com/3076981/buckets/24956/chats/12416418@1631552581 [ci skip]
* | | | | | Merge pull request #35460 from abhaynikam/33611-follow-up-on-add-reselectRyuta Kamizono2019-03-044-2/+16
|\ \ \ \ \ \ | | | | | | | | | | | | | | Fixed reselect throwing NoMethodError on ActiveRecord.
| * | | | | | Fixed reselect throwing NoMethodError on ActiveRecord.Abhay Nikam2019-03-034-2/+16
| | | | | | |
* | | | | | | Remove unnecessary `current_adapter?(:OracleAdapter)` for index lengthYasuo Honda2019-03-032-14/+6
|/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Follow up #35455, there are two more test cases unnecessary `if current_adapter?(:OracleAdapter)` ```ruby $ ARCONN=oracle bin/test test/cases/associations/eager_test.rb -n test_include_has_many_using_primary_key Using oracle Run options: -n test_include_has_many_using_primary_key --seed 62842 . Finished in 50.280024s, 0.0199 runs/s, 0.0398 assertions/s. 1 runs, 2 assertions, 0 failures, 0 errors, 0 skips $ ``` ``` $ ARCONN=oracle bin/test test/cases/migration/index_test.rb -n test_add_index Using oracle Run options: -n test_add_index --seed 52034 . Finished in 13.152620s, 0.0760 runs/s, 0.0000 assertions/s. 1 runs, 0 assertions, 0 failures, 0 errors, 0 skips $ ```
* | | | | | Merge pull request #35457 from yahonda/run_delte_all_testRyuta Kamizono2019-03-031-19/+17
|\ \ \ \ \ \ | | | | | | | | | | | | | | Oracle database can run `delete` with `order by` and`fetch first n rows only`
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-02 01:08:49 +0000