aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | Add missing test cases for schema dumping defaultsSean Griffin2014-06-061-0/+29
| | | |
* | | | credit JoseLuis Torres for #15051. [JoseLuis Torres]Yves Senn2014-06-061-1/+1
| | | | | | | | | | | | | | | | [ci skip]
* | | | `ActiveRecord::SchemaMigration` has no primary key.Yves Senn2014-06-063-0/+24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Before this patch, using `ActiveRecord::Base.primary_key_prefix_type` with `:table_name_with_underscore` would change the `SchemaMigration` model to have a primary key. This resulted in broken queries for PG because it tried to return the inserted PK (which does not exist). Closes #15051. Closes #15419.
* | | | test refactor, don't hardcode default for `table_name_prefix`.Yves Senn2014-06-061-1/+2
| | | |
* | | | test refactor, don't hardcode `primary_key_prefix_type` default.Yves Senn2014-06-061-0/+3
| | | | | | | | | | | | | | | | /cc @zuhao
* | | | serialized Type should delegate `type_cast_for_write` to underlying TypeYves Senn2014-06-062-1/+36
|/ / / | | | | | | | | | | | | | | | | | | This adds a regression test for #14411, which was fixed by #15503. Closes #14411 Closes #14595
* | | Merge pull request #15503 from sgrif/sg-json-hstore-storageYves Senn2014-06-069-20/+29
|\ \ \ | | | | | | | | Bring type casting behavior of hstore/json in line with serialized
| * | | Bring type casting behavior of hstore/json in line with serializedSean Griffin2014-06-049-20/+29
| | | | | | | | | | | | | | | | | | | | `@raw_attributes` should not contain the type-cast, mutable version of the value.
* | | | `bin/rake db:migrate:status` works with legacy migration numbers.Yves Senn2014-06-065-4/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | The migration numbers were normalized different ways. This left the task output in an inconsistent state. Closes #15538.
* | | | Merge pull request #14971 from versioncontrol/#14785Yves Senn2014-06-063-1/+26
|\ \ \ \ | | | | | | | | | | | | | | | Baseclass becomes! subclass
| * | | | Fix Baseclass becomes! subclass.Edo Balvers2014-05-133-1/+26
| | | | |
* | | | | Remove optimization that was required with whiny nilsSean Griffin2014-06-051-8/+0
| | | | | | | | | | | | | | | | | | | | Whiny nils is no longer a thing, so we no longer need this optimization
* | | | | Fix behavior of handling BC era dates.edogawaconan2014-06-053-3/+17
| | | | | | | | | | | | | | | | | | | | BC era year is (astronomical year + 1) and starts from 1 BC.
* | | | | Merge pull request #15512 from akshay-vishnoi/delete-deprecated-methodYves Senn2014-06-053-54/+5
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | Remove deprecated method ActiveRecord::Migrator.proper_table_name
| * | | | | Remove deprecated method ActiveRecord::Migrator.proper_table_nameAkshay Vishnoi2014-06-053-54/+4
| | | | | |
* | | | | | Fix inverse associations testLeandro Facchinetti2014-06-041-1/+1
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | `InverseHasManyTests#test_parent_instance_should_be_shared_within_create_block_of_new_child` was mistakenly the same as `InverseHasManyTests#test_parent_instance_should_be_shared_within_build_block_of_new_child`.
* | | | | have an actual `NullColumn` object and update docs accordingly.Yves Senn2014-06-044-5/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Follow up to #15438 and #15502. /cc @sgrif
* | | | | Merge pull request #15502 from sgrif/sg-use-null-columnYves Senn2014-06-042-23/+23
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | Use null column for association key types
| * | | | | Use null column for association key typesSean Griffin2014-06-042-23/+23
| | |/ / / | |/| | |
* | | | | Merge pull request #15504 from sgrif/sg-postgres-defaultsRafael Mendonça França2014-06-042-48/+11
|\ \ \ \ \ | | | | | | | | | | | | Collapse PG default extractoin of most types to single regex
| * | | | | Collapse PG default extractoin of most types to single regexSean Griffin2014-06-042-48/+11
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | For any type that is represented as a string and then type cast, we do not need separate regular expressions for the various types. No function will match this regex. User defined types *should* match this, so that the type object can decide what to do with the value.
* | | | | Merge pull request #15463 from geopet/refactor_xml_compute_typeRafael Mendonça França2014-06-042-6/+7
|\ \ \ \ \ | |/ / / / |/| | | | Refactor XML serializer to not depend on `serialized_attributes`
| * | | | Refactor XML serializer to not depend on `serialized_attributes`Geoff Petrie & Sean Griffin2014-06-011-3/+5
| | | | |
| * | | | Test the serialized types of virtual columns in XMLGeoff Petrie & Sean Griffin2014-06-012-4/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The previous tests were passing, because nothing ever looked at the generated XML. What was previously being generated was `<firstname type="NilClass">...`, which is not consistent with all other cases where there is not a known type.
* | | | | Merge pull request #15500 from ↵Yves Senn2014-06-041-2/+2
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | prathamesh-sonpatki/change-wording-of-explanation-about-precision-and-scale-of-decimal-numbers Change wording of explanation about precision & scale of decimal numbers [ci skip]
| * | | | | Change wording of explanation about precision & scale of decimal numbers [ci ↵Prathamesh Sonpatki2014-06-041-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | skip]
* | | | | | Merge pull request #15482 from laurocaetano/fix-regression-for-eager-loadCarlos Antonio da Silva2014-06-044-2/+27
|\ \ \ \ \ \ | |/ / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix regression on eager loading association based on SQL query rather than existing column. Conflicts: activerecord/CHANGELOG.md
| * | | | | Fix regression on eager loading association based on SQL query ratherLauro Caetano2014-06-034-2/+27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | than existing column. Fixes #15480.
* | | | | | Cleaned up duplicated CHANGELOG entry [ci skip]Godfrey Chan2014-06-031-3/+2
| | | | | |
* | | | | | reuse available belongs_to? methodeileencodes2014-06-033-5/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Reflection has a `belongs_to?` method. Instead of checking for `macro == :belongs_to` throughout the source reuse existing method. I also bumped `foreign_key_present?` method onto on line because the `belongs_to?` makes it shorter than other longer lines in the same class.
* | | | | | Merge pull request #15438 from sgrif/sg-null-columnRafael Mendonça França2014-06-035-14/+40
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Return a null column when no column exists for an attribute Conflicts: activerecord/CHANGELOG.md
| * | | | | | Return a null column when no column exists for an attributeSean Griffin2014-06-035-14/+40
| | | | | | |
* | | | | | | Merge pull request #15172 from notEthan/active_record_pretty_printRafael Mendonça França2014-06-033-0/+95
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | implement ActiveRecord::Base#pretty_print Conflicts: activerecord/CHANGELOG.md
| * | | | | | | implement ActiveRecord::Base#pretty_print + changelogEthan2014-05-293-0/+95
| | | | | | | |
* | | | | | | | Merge pull request #15492 from sgrif/sg-dirty-defaultsRafael Mendonça França2014-06-035-2/+40
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | Keep column defaults in type cast form
| * | | | | | | | Keep column defaults in type cast formSean Griffin2014-06-035-2/+40
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The contract of `_field_changed?` assumes that the old value is always type cast. That is not the case for the value in `Column#default` as things are today. It appears there are other public methods that assume that `Column#default` is type cast, as well. The reason for this change originally was because the value gets put into `@raw_attributes` in initialize. This reverts to the old behavior on `Column`, and updates `initialize` to make sure that the values are in the right format.
* | | | | | | | | force table creationAaron Patterson2014-06-031-2/+3
| | | | | | | | |
* | | | | | | | | Revert "test pg, we don't care about the internal state of `column#default`."Yves Senn2014-06-037-0/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Revert "test pg, remove unused column assignments. Follow up to 254cdf47" Related to #15492 This reverts commit 254cdf4728291277f3fbaa854f34495030e476b4. This reverts commit 4bcf9029452e0c760af04faab6b549710401e8cf. There are public methods that assume `Column#default` is type casted. The return value of `Column#default` is publicly relevant and should not change. /cc @sgrif
* | | | | | | | | Merge pull request #15486 from sgrif/sg-binary-quotingMatthew Draper2014-06-045-47/+83
|\ \ \ \ \ \ \ \ \ | |_|_|_|/ / / / / |/| | | | | | | | Refactor quoting of binary data to not be based on the column type
| * | | | | | | | Refactor quoting of binary data to not be based on the column typeSean Griffin2014-06-035-47/+83
| |/ / / / / / /
* | | | | | | | test pg, remove unused column assignments. Follow up to 254cdf47Yves Senn2014-06-035-12/+0
| | | | | | | |
* | | | | | | | pg, preserve money type when dumping schema and extract money default.Yves Senn2014-06-037-22/+39
| | | | | | | |
* | | | | | | | test pg, rm unused requires.Yves Senn2014-06-0311-27/+0
| |_|/ / / / / |/| | | | | |
* | | | | | | Merge pull request #15487 from sgrif/sg-bit-limitYves Senn2014-06-033-32/+32
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Respect limit for PG bit strings
| * | | | | | | Respect limit for PG bit stringsSean Griffin2014-06-033-32/+32
| | | | | | | |
* | | | | | | | Merge pull request #15442 from sgrif/sg-refactor-field-changedYves Senn2014-06-036-36/+39
|\ \ \ \ \ \ \ \ | |/ / / / / / / |/| | | | | | | Refactor determination of whether the field has changed
| * | | | | | | Refactor determination of whether the field has changedSean Griffin2014-06-036-36/+39
| |/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | The types know more about what is going on than the dirty module. Let's ask them!
* | | | | | | pg, preserve type when schema dumping bit and bit varying columns.Yves Senn2014-06-037-12/+44
| | | | | | |
* | | | | | | test pg, move bit string type tests into `bit_string_test.rb`.Yves Senn2014-06-033-42/+80
| | | | | | |
* | | | | | | test pg, we don't care about the internal state of `column#default`.Yves Senn2014-06-035-9/+0
|/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | That data is internal to Active Record. What we care about is that new records have the right default value.
generated by cgit v1.2.3 (git 2.25.1) at 2024-10-31 17:06:41 +0000