aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
Commit message (Collapse)AuthorAgeFilesLines
...
| | * | test, show current adapter behavior for `add_column limit: nil`.Yves Senn2014-04-041-0/+8
| | | | | | | | | | | | | | | | | | | | | | | | This is an illustration of https://github.com/rails/rails/pull/13435#issuecomment-33789752 Removing the limit from the PG and SQLite adapter solves the issue. MySQL is still affected by the issue.
| | * | PostgreSQL and SQLite, remove varchar limit. [Vladimir Sazhin & Toms Mikoss ↵Yves Senn2014-04-046-5/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | & Yves Senn] There is no reason for the PG adapter to have a default limit of 255 on :string columns. See this snippet from the PG docs: Tip: There is no performance difference among these three types, apart from increased storage space when using the blank-padded type, and a few extra CPU cycles to check the length when storing into a length-constrained column. While character(n) has performance advantages in some other database systems, there is no such advantage in PostgreSQL; in fact character(n) is usually the slowest of the three because of its additional storage costs. In most situations text or character varying should be used instead.
| * | | Fix the test defining the models in the right placeRafael Mendonça França2014-04-044-15/+16
| | | |
| * | | Add CHANGELOG entry for #11650 [ci skip]Rafael Mendonça França2014-04-041-0/+6
| | | |
| * | | Merge pull request #11650 from prathamesh-sonpatki/renameRafael Mendonça França2014-04-049-19/+37
| |\ \ \ | | | | | | | | | | | | | | | Renamed private methods _create_record and _update_record
| | * | | [Active Record] Renamed private methods create_record and update_recordPrathamesh Sonpatki2014-02-209-19/+37
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is to ensure that they are not accidentally called by the app code. They are renamed to _create_record and _update_record respectively. Closes #11645
| * | | | Merge pull request #14562 from jefflai2/collection_proxyRafael Mendonça França2014-04-044-0/+23
| |\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | CollectionProxy uses the arel of its association's scope. Conflicts: activerecord/CHANGELOG.md
| | * | | | CollectionProxy uses the arel of its association's scope.Jefferson Lai2014-04-024-0/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | CollectionProxy should be able to reuse the behavior (methods) of its parent class, but with its own state. This change allows CollectionProxy to use the arel object corresponding to its association's scope.
* | | | | | Merge pull request #12016 from roderickvd/uuid_fixesRafael Mendonça França2014-04-0410-10/+69
|\ \ \ \ \ \ | |/ / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Auto-generate stable fixture UUIDs on PostgreSQL Conflicts: activerecord/CHANGELOG.md activerecord/lib/active_record/fixtures.rb activerecord/test/cases/adapters/postgresql/uuid_test.rb activesupport/CHANGELOG.md
| * | | | | Auto-generate stable fixture UUIDs on PostgreSQL.Roderick van Domburg2014-01-0711-17/+74
| | | | | | | | | | | | | | | | | | | | | | | | Fixes: #11524
* | | | | | Remove unused variableRafael Mendonça França2014-04-041-1/+1
| | | | | |
* | | | | | Prevent state leak in test.Guo Xiang Tan2014-04-031-17/+16
| |_|_|/ / |/| | | | | | | | | | | | | | This will allow us to run the tests in random order.
* | | | | Block a few default Class methods as scope name.Arthur Neves2014-04-034-1/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add tests to make sure scopes cannot be create with names such as: private, protected, public. Make sure enum values don't collide with those methods too.
* | | | | Merge pull request #14572 from laurocaetano/with_options_and_scopeRafael Mendonça França2014-04-035-0/+23
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix error when using `with_options` with lambda. Conflicts: activerecord/CHANGELOG.md
| * | | | | Fix error when using `with_options` with lambda.Lauro Caetano2014-04-035-0/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It was causing error when using `with_options` passing a lambda as its last argument. class User < ActiveRecord::Base with_options dependent: :destroy do |assoc| assoc.has_many :profiles, -> { where(active: true) } end end It was happening because the `option_merger` was taking the last argument and checking if it was a Hash. This breaks the HasMany usage, because its last argument can be a Hash or a Proc. As the behavior described in this test: https://github.com/rails/rails/blob/master/activesupport/test/option_merger_test.rb#L69 the method will only accept the lambda, this way it will keep the expected behavior. See 9eaa0a34
* | | | | | Merge pull request #14569 from matthewd/sqlite_relative_deprecatedRafael Mendonça França2014-04-035-24/+64
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Revise 'sqlite3:' URL handling for smoother upgrades Conflicts: activerecord/CHANGELOG.md
| * | | | | | Complete change of `sqlite3:///` path handlingMatthew Draper2014-04-033-17/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | That which was now relative is now absolute.
| * | | | | | Revise 'sqlite3:' URL handling for smoother upgradesMatthew Draper2014-04-035-25/+88
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Restore the 4.0 behaviour for 'sqlite3:///', but deprecate it. We'll change to the absolute-path interpretation in 4.2. The current "correct" spellings for in-memory, relative, and absolute URLs, respectively, are: sqlite3::memory: sqlite3:relative/path sqlite3:/full/path Substantially reverses/defers fbb79b517f3127ba620fedd01849f9628b78d6ce. Uncovered by @guilleiguaran while investigating #14495, though that sounds like a different issue.
* | | | | | | Merge pull request #14570 from matthewd/uri_deprecation_warningRafael Mendonça França2014-04-032-24/+76
|\ \ \ \ \ \ \ | |_|/ / / / / |/| | | | | | Avoid a spurious deprecation warning for database URLs
| * | | | | | Avoid including DB details in exception messagesMatthew Draper2014-04-031-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The keys are quite sufficient; we shouldn't be throwing passwords around.
| * | | | | | Avoid a spurious deprecation warning for database URLsMatthew Draper2014-04-032-23/+75
| |/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is all about the case where we have a `DATABASE_URL`, and we have a `database.yml` present, but the latter doesn't contain the key we're looking for. If the key is a symbol, we'll always connect to `DATABASE_URL`, per the new behaviour in 283a2edec2f8ccdf90fb58025608f02a63948fa0. If the key is a string, on the other hand, it should always be a URL: the ability to specify a name not present in `database.yml` is new in this version of Rails, and that ability does not stretch to the deprecated use of a string in place of a symbol. Uncovered by @guilleiguaran while investigating #14495 -- this actually may be related to the original report, but we don't have enough info to confirm.
* | | | | | Merge pull request #14561 from tgxworld/refactor_run_without_connectionYves Senn2014-04-0310-64/+44
|\ \ \ \ \ \ | | | | | | | | | | | | | | Add ConnectionHelper to refactor tests.
| * | | | | | Add ConnectionHelper to refactor tests.Guo Xiang Tan2014-04-0310-64/+44
| |/ / / / /
* / / / / / Treat blank UUID values as nilDmitry Lavrov2014-04-033-1/+21
|/ / / / /
* | | | | We can conditional define the tests depending on the adapter orRajarshi Das2014-04-021-7/+5
| | | | | | | | | | | | | | | | | | | | connection.
* | | | | PostgreSQL, Support for materialized views. [Dave Lee & Yves Senn]Dave Lee2014-04-024-12/+35
| |/ / / |/| | | | | | | | | | | | | | | Expand the query used in #table_exists? to include materialized views in the kinds of relations it searches.
* | | | cleanup, `reset_pg_session` in range_test.rbYves Senn2014-04-021-2/+5
| | | | | | | | | | | | | | | | | | | | Also do not use transactional fixtures. We drop the type and the table after every run, so there is nothing for the transaction to clean up.
* | | | Allow postgresql enum_test to be run in random order.Guo Xiang Tan2014-04-013-9/+21
| | | | | | | | | | | | | | | | Creating and dropping similar tables within the same connection causes postgresql to look up old values in the cache of tables which have already been dropped.
* | | | Clarify 'database does not exist' message and implementation.Jeremy Kemper2014-04-016-26/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Clarify what the situation is and what to do. * Advise loading schema using `rake db:setup` instead of migrating. * Use a rescue in the initializer rather than extending the error message in-place. * Preserve the original backtrace of other errors by using `raise` rather than raising again with `raise error`. References 0ec45cd15d0a2f5aebc75e23d841b6c12f3ba763
* | | | fix, adjust OID query without range support to include required fields.Yves Senn2014-04-011-3/+4
| | | | | | | | | | | | | | | | | | | | This is a follow-up fix to f7a6b115fea9f675190a79b701c7034214678f19 and 06082f66d541e581110406bbac3bc395bace3f86
* | | | refactor, use `typtype` instead of `typinput` to segment PG types.Yves Senn2014-04-011-3/+3
| | | |
* | | | PostgreSQL, register custom domains. Closes #14305.Yves Senn2014-04-013-1/+68
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch registers custom domains in our OID-type_map. They will behave exactly as the type specified by `pg_type.typbasetype`. /cc @matthewd
* | | | Merge pull request #14513 from senny/pg/responsible_oidRafael Mendonça França2014-04-016-107/+104
|\ \ \ \ | | | | | | | | | | PostgreSQL determine `Column#type` through corresponding OID. #7814
| * | | | PostgreSQL determine `Column#type` through corresponding OID. #7814Yves Senn2014-04-016-107/+104
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I ran the whole test suite and compared the old to the new types. Following is the list of types that did change with this patch: ``` DIFFERENT TYPE FOR mood: NEW: enum, BEFORE: DIFFERENT TYPE FOR floatrange: NEW: floatrange, BEFORE: float ``` The `floatrange` is a custom type. The old type `float` was simply a coincidence form the name `floatrange` and our type-guessing.
* | | | | refactor assert_sql query to reuse capture_sqleileencodes2014-03-311-3/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | set assert_sql to reuse the capture_sql method from above instead of repeating the code in response to comments on issue #14546
* | | | | Merge pull request #14546 from ↵Aaron Patterson2014-03-313-2/+23
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | eileencodes/fix_delete_all_to_not_use_IN_statement Fix delete all to not produce sql in statement
| * | | | | fix delete_all to remove records directlyeileencodes2014-03-311-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When delete_all is run on a CollectionProxy and has a dependency of delete_all the SQL that is produced has an IN statement. (DELETE FROM `associated_model` where `associated_model` .`parent_id` = 1 AND `associated_model`.`id` IN (1, 2, 3...)). This only happens if the association is not loaded (both loaded and non-loaded delete_all should behave the same. This is a huge problem when it comes to deleting many records because the query becomes very slow. Instead the SQL produced should be (DELETE FROM `assoicated_model` where `associated_model`.`parent_model_id`=1). I fixed this by making sure the check for loaded and destroy also makes sure that the dependent is not delete_all, so the conditional goes to the else and deletes the records directly without the IN statement.
| * | | | | add test to compare sql statements in delete_all queryeileencodes2014-03-311-1/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | delete_all sql if an association is not loaded should behave the same as if the association is loaded. This test ensures the SQL statements are exactly the same.
| * | | | | add capture_sql method to compare sql statements and compareeileencodes2014-03-311-0/+6
| |/ / / / | | | | | | | | | | | | | | | | | | | | Other methods compare specific patterns, this method outputs the actual sql query that is generated.
* | | | | Merge pull request #14532 from thedarkone/polymorphic-preload-fixAaron Patterson2014-03-313-34/+28
|\ \ \ \ \ | |/ / / / |/| | | | Fix polymorphic preloads on NOT NULL _type columns
| * | | | Simplify Preloader#grouped_records code.thedarkone2014-03-303-25/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The new method relies on AR::Associations::Association knowing about both reflection and a model class. AR::Base#association now raises a descriptive error when trying to access non-existent associations. Previously it would blow up with a confusing NoMethodError: undefined method `association_class' for nil:NilClass.
| * | | | Fix polymorphic preloads on NOT NULL _type columns.thedarkone2014-03-302-10/+12
| | | | | | | | | | | | | | | | | | | | Defer to Association#klass instead of having a custom/duplicate code.
* | | | | refactor, put `PostgreSQLColumn` into `column.rb`.Yves Senn2014-03-312-218/+222
| | | | | | | | | | | | | | | | | | | | | | | | | We have `connection_adapters/column.rb` so it's easier to remember that the column in in a separate file.
* | | | | fix mysql buildsLuke Steensen2014-03-301-1/+1
| | | | |
* | | | | fix bug on non empty defaults for pg array columnsLuke Steensen2014-03-304-2/+25
| | | | | | | | | | | | | | | | | | | | fixes #10613
* | | | | No need to call to_symRafael Mendonça França2014-03-301-2/+2
|/ / / / | | | | | | | | | | | | It is already called inside type_to_sql method.
* | | | Refactor test to use DdlHelper.Guo Xiang Tan2014-03-292-167/+198
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Follow-Up to https://github.com/rails/rails/pull/14400 This ensures that all tables are removed after each test and thereby allowing us to run the tests in a random order.
* | | | Merge pull request #14524 from tgxworld/fix_unsubscribe_from_notificationsYves Senn2014-03-294-12/+12
|\ \ \ \ | | | | | | | | | | | | | | | Fix tests not unsubscribing from Notifications.
| * | | | Fix tests not unsubscribing from Notifications.Guo Xiang Tan2014-03-284-8/+8
| | | | | | | | | | | | | | | | | | | | See https://github.com/rails/rails/blob/master/activesupport/lib/active_support/notifications.rb#L131
* | | | | Merge pull request #14526 from chancancode/fix_ar_equalityXavier Noria2014-03-293-8/+9
|\ \ \ \ \ | | | | | | | | | | | | Ensure we are returning either `true` or `false` for `#==`
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-09 04:53:53 +0000