aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | | | | | | | Prevent the counter cache from being decremented twicedm1try2013-11-113-1/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | when destroying a record on a has_many :through association. :destroy method has own counter_cache callbacks.
* | | | | | | | | | Unifies mysql and mysql2 casting of booleans.Yves Senn2013-11-114-9/+16
| | | | | | | | | |
* | | | | | | | | | test cases to describe the MySQL boolean behavior.Yves Senn2013-11-111-0/+91
| | | | | | | | | |
* | | | | | | | | | Do not count "SHOW CREATE TABLE" queries when testing against mysqlAkira Matsuda2013-11-111-1/+1
| | | | | | | | | |
* | | | | | | | | | tidy Active Record CHANGELOG. [ci skip].Yves Senn2013-11-111-1/+3
| | | | | | | | | |
* | | | | | | | | | Avoid sorting an Array including objects from different ClassesAkira Matsuda2013-11-111-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | addresses "ArgumentError: comparison of VerySpecialComment with SpecialComment failed" in ActiveRecord::DelegationRelationTest#test_#sort!_delegation_is_deprecated
* | | | | | | | | | Load test fixtures where data are neededAkira Matsuda2013-11-111-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Without this, some tests here were not actually testing anything.
* | | | | | | | | | Merge pull request #12834 from dredozubov/has_one_association_replacementYves Senn2013-11-113-4/+26
|\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | Fixes problem with replacing has_one association record with itself
| * | | | | | | | | | Fixes problem with replacing has_one association record with itselfDenis Redozubov2013-11-113-4/+26
| | |_|/ / / / / / / | |/| | | | | | | |
* | | | | | | | | | A tiny grammatical fixAkira Matsuda2013-11-111-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [ci skip]
* | | | | | | | | | autoload ChangeColumnDefinition (Fixes #12835)Anton Kalyaev2013-11-111-0/+1
| |/ / / / / / / / |/| | | | | | | |
* | | | | | | | | Merge pull request #12749 from iantropov/issue_5303Rafael Mendonça França2013-11-101-0/+4
|\ \ \ \ \ \ \ \ \ | |/ / / / / / / / |/| | | | | | | | | | | | | | | | | Add test for ActiveRecord::Relation YAML serialization, for #5303 issue
| * | | | | | | | Add test for ActiveRecord::Relation YAML serialization, for #5303 issueIvan Antropov2013-11-031-0/+4
| | | | | | | | |
* | | | | | | | | use complete Relation API and not only `Model.all.merge!`.Yves Senn2013-11-091-88/+83
| | | | | | | | |
* | | | | | | | | Change array check for better aesthetics / reading the codeCarlos Antonio da Silva2013-11-091-1/+1
| | | | | | | | |
* | | | | | | | | Merge pull request #12821 from arunagw/aa-removed-missleading-messageYves Senn2013-11-092-2/+2
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | clarified missleading message
| * | | | | | | | | Changed message for Model.inspectArun Agrawal2013-11-092-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (No database connection) sounds not be able to connect database. see more #12804
* | | | | | | | | | improve Active Record Store docs when using PG types. [ci skip].Yves Senn2013-11-091-3/+4
| | | | | | | | | |
* | | | | | | | | | type casted PG bytea values are represented as a Hash.Yves Senn2013-11-091-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a follow up to: 97f0d9a0dd12e7ad634815eecfeff866f64aad92 This change is also related to: df0edafac9eb47cd971970a9e7b13a3eaddf214e
* | | | | | | | | | Document the bind returnRafael Mendonça França2013-11-091-0/+3
| | | | | | | | | |
* | | | | | | | | | Avoid shot circuit return.Rafael Mendonça França2013-11-091-8/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This will make the conditional and to code clear
* | | | | | | | | | Improve changelogs formatting [ci skip]Carlos Antonio da Silva2013-11-091-8/+8
| | | | | | | | | |
* | | | | | | | | | Don't use Active Support where we don't need toRafael Mendonça França2013-11-093-3/+3
| | | | | | | | | |
* | | | | | | | | | Fix typo in AR store docs [ci skip]Carlos Antonio da Silva2013-11-091-1/+1
|/ / / / / / / / /
* | / / / / / / / log bind variables after they were type casted.Yves Senn2013-11-095-10/+36
| |/ / / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The log output used to be confusing in situation where type casting has "unexpected" effects. For example when finding records with a `String`. BEFORE: irb(main):002:0> Event.find("im-no-integer") D, [2013-11-09T11:10:28.998857 #1706] DEBUG -- : Event Load (4.5ms) SELECT "events".* FROM "events" WHERE "events"."id" = $1 LIMIT 1 [["id", "im-no-integer"]] AFTER: irb(main):002:0> Event.find("im-no-integer") D, [2013-11-09T11:10:28.998857 #1706] DEBUG -- : Event Load (4.5ms) SELECT "events".* FROM "events" WHERE "events"."id" = $1 LIMIT 1 [["id", 0]]
* | | | | | | | Mark broken test as pendingRafael Mendonça França2013-11-082-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This will avoid the broken window effect in our test suite
* | | | | | | | Remove more skipRafael Mendonça França2013-11-084-13/+7
| | | | | | | |
* | | | | | | | Don't skip tests if we don't need to.Rafael Mendonça França2013-11-0830-1023/+966
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We can conditional define the tests depending on the adapter or connection. Lets keep the skip for fail tests that need to be fixed.
* | | | | | | | Merge pull request #12791 from jasonayre/ja/fix_autoload_errorRafael Mendonça França2013-11-072-0/+6
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | add autoload :TransactionState to fix Marshal.load issues
| * | | | | | | | revised changelog comment to be less than 80 charsJason Ayre2013-11-071-2/+2
| | | | | | | | |
| * | | | | | | | add autoload :TransactionState to fix Marshal.load issuesJason Ayre2013-11-072-0/+6
| | |_|_|/ / / / | |/| | | | | |
* | | | | | | | Warning removed for ruby-headRashmi Yadav2013-11-071-1/+1
| |_|_|_|/ / / |/| | | | | |
* | | | | | | Merge branch 'master' of github.com:rails/docrailsVijay Dev2013-11-072-0/+7
|\ \ \ \ \ \ \ | |/ / / / / / |/| | | | | |
| * | | | | | refine usage docs of `store` in combination with `hstore` and `json`.Yves Senn2013-11-061-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | refs #11561 #12700
| * | | | | | Hstore and JSON fields are not supported with storeRobin Dupret2013-10-301-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The use of `store` on Hstore fields (for instance) is not needed because serialization aimed to interact with Ruby objects and not with provided field types
| * | | | | | warning about saving models with dirty attributesDamien Mathieu2013-10-231-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | See #8328
* | | | | | | Stop using method missing for singleton delegation.Aaron Patterson2013-11-061-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This saved about 46 array allocations per request on an extremely simple application. The delegation happened in the notification subsystem which is a hotspot, so this should result in even more savings with larger apps. Squashed commit of the following: commit 41eef0d1479526f7de25fd4391d98e61c126d9f5 Author: Aaron Patterson <aaron.patterson@gmail.com> Date: Wed Nov 6 16:32:31 2013 -0800 speed up notifications commit 586b4a18656f66fb2c518fb8e8fee66a016e8ae6 Author: Aaron Patterson <aaron.patterson@gmail.com> Date: Wed Nov 6 16:31:05 2013 -0800 speed up runtime registry methods commit b67d074cb4314df9a88438f785868cef77e583d7 Author: Aaron Patterson <aaron.patterson@gmail.com> Date: Wed Nov 6 16:28:12 2013 -0800 change method name and make it public
* | | | | | | bring back constant to expose the enum mapping as HWIA.Yves Senn2013-11-062-4/+19
| | | | | | |
* | | | | | | update the AR enum docs to match the actual behavior. [ci skip]Yves Senn2013-11-061-5/+3
| |_|_|/ / / |/| | | | |
* | | | | | store enum mapping using `Strings` instead of `Symbols`.Yves Senn2013-11-052-3/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This allows to assign both `String` and `Symbol` values to the enum without having to call `to_sym`, which is a security problem.
* | | | | | direct enum assignment rasies ArgumentError for unknown values.Yves Senn2013-11-052-1/+18
| | | | | |
* | | | | | define enum methods inside a `Module` to make them overwritable.Yves Senn2013-11-053-13/+34
| | | | | |
* | | | | | Merge pull request #12390 from kennyj/rename_to_association_methodsRafael Mendonça França2013-11-054-7/+7
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Renamed generated_feature_methods to generated_association_methods. Conflicts: activerecord/lib/active_record/associations/builder/association.rb activerecord/lib/active_record/associations/builder/singular_association.rb activerecord/test/cases/base_test.rb
| * | | | | | Renamed generated_feature_methods to generated_association_methods.kennyj2013-09-285-12/+12
| | | | | | |
* | | | | | | Remove private API testRafael Mendonça França2013-11-051-10/+0
| | | | | | |
* | | | | | | Use 1.9 Hash syntax consistentlyPablo Torres2013-11-051-1/+1
| | | | | | |
* | | | | | | ask the fixture set for the sql statementsAaron Patterson2013-11-042-11/+17
| | | | | | |
* | | | | | | The enum value constant isn't used, so rm it for now.Aaron Patterson2013-11-042-27/+7
| | | | | | |
* | | | | | | stop doing the same calculation over and overAaron Patterson2013-11-041-4/+5
| | | | | | |
* | | | | | | fix copy & paste test-case naming. [ci skip]Yves Senn2013-11-041-1/+1
| | | | | | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-05 01:21:09 +0000