Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | | | | | | cleanliness in method parameters | Andrey Deryabin | 2012-04-25 | 1 | -1/+1 | |
|/ / / / / | ||||||
* | | | | | Fix build. It seems that the Mocha's behavior were changed. | kennyj | 2012-04-25 | 2 | -3/+9 | |
| | | | | | ||||||
* | | | | | Merge pull request #5887 from mcrowe/document-relation-merge | Vijay Dev | 2012-04-23 | 1 | -0/+14 | |
|\ \ \ \ \ | | | | | | | | | | | | | Add documentation to the SpawnMethods#merge method. | |||||
| * | | | | | Add documentation to the SpawnMethods#merge method. | Mitch Crowe | 2012-04-17 | 1 | -0/+14 | |
| | | | | | | ||||||
* | | | | | | be sure to currectly fetch PK name from MySQL even if the PK has some custom ↵ | Akira Matsuda | 2012-04-19 | 2 | -1/+31 | |
|/ / / / / | | | | | | | | | | | | | | | | option | |||||
* | | | | | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-04-18 | 1 | -1/+1 | |
|\ \ \ \ \ | ||||||
| * | | | | | Revert "Added documentation to explain what happens if you don't set any ↵ | Rodrigo Flores | 2012-04-12 | 1 | -5/+2 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | values for the dependent option on has_many" This reverts commit 820a677d8622a540188704941a31871ed4d61461. | |||||
| * | | | | | Added documentation to explain what happens if you don't set any values for ↵ | Rodrigo Flores | 2012-04-12 | 1 | -2/+5 | |
| | | | | | | | | | | | | | | | | | | | | | | | | the dependent option on has_many | |||||
| * | | | | | Fix typo on the add_index. | kennyj | 2012-04-13 | 1 | -1/+1 | |
| |/ / / / | ||||||
* | | | | | Update Rails 3.2.3 release date in changelogs as March 30, 2012 | Michael de Silva | 2012-04-16 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | The release date details have been taken from http://weblog.rubyonrails.org/2012/3/30/ann-rails-3-2-3-has-been-released/ | |||||
* | | | | | opening a connection will block if the pool is full | Aaron Patterson | 2012-04-15 | 2 | -20/+63 | |
| | | | | | ||||||
* | | | | | Automatically create indexes for references/belongs_to statements in migrations. | Joshua Wood | 2012-04-14 | 6 | -5/+145 | |
| | | | | | ||||||
* | | | | | Merge pull request #5837 from yahonda/new_sequence_name_is_too_long | Jon Leighton | 2012-04-14 | 1 | -4/+4 | |
|\ \ \ \ \ | | | | | | | | | | | | | Fix ORA-00972 error at test_rename_table_with_prefix_and_suffix | |||||
| * | | | | | Fix ORA-00972 error at test_rename_table_with_prefix_and_suffix | Yasuo Honda | 2012-04-13 | 1 | -4/+4 | |
| | | | | | | ||||||
* | | | | | | extract deprecated code for #find, #first, #last, #all | Jon Leighton | 2012-04-13 | 1 | -105/+36 | |
| | | | | | | ||||||
* | | | | | | extract deprecated #calculate code | Jon Leighton | 2012-04-13 | 1 | -83/+25 | |
| | | | | | | ||||||
* | | | | | | move code out to active_record_deprecated_finders | Jon Leighton | 2012-04-13 | 1 | -7/+2 | |
| | | | | | | ||||||
* | | | | | | fix tests | Jon Leighton | 2012-04-13 | 7 | -81/+74 | |
| | | | | | | ||||||
* | | | | | | Merge pull request #5832 from kennyj/fix_5267 | Jon Leighton | 2012-04-13 | 2 | -3/+7 | |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | Fix a wrong return value from reset_sequence_name method. | |||||
| * | | | | | | Fix wrong return value from reset_sequence_name method. | kennyj | 2012-04-14 | 2 | -3/+7 | |
| | | | | | | | ||||||
* | | | | | | | move some of the update_all implementation to active_record_deprecated_finders | Jon Leighton | 2012-04-13 | 1 | -27/+14 | |
| | | | | | | | ||||||
* | | | | | | | now we can just manipulate the values hash in #only and #except | Jon Leighton | 2012-04-13 | 4 | -36/+26 | |
| | | | | | | | ||||||
* | | | | | | | use a hash to store relation values | Jon Leighton | 2012-04-13 | 5 | -52/+74 | |
|/ / / / / / | ||||||
* | | | | | | doesn't make sense for select! to take a block | Jon Leighton | 2012-04-13 | 1 | -8/+3 | |
| | | | | | | ||||||
* | | | | | | remove apply_finder_options call from AssociationScope | Jon Leighton | 2012-04-13 | 4 | -9/+15 | |
| | | | | | | ||||||
* | | | | | | Make Relation#extending work like other value methods | Jon Leighton | 2012-04-13 | 5 | -27/+22 | |
| | | | | | | ||||||
* | | | | | | Add Relation#merge! | Jon Leighton | 2012-04-13 | 2 | -9/+17 | |
| | | | | | | ||||||
* | | | | | | assert valid keys | Jon Leighton | 2012-04-13 | 3 | -0/+11 | |
| | | | | | | ||||||
* | | | | | | Allow Relation#merge to take a hash | Jon Leighton | 2012-04-13 | 4 | -49/+95 | |
| | | | | | | ||||||
* | | | | | | we have no need for the ASSOCIATION_METHODS constant | Jon Leighton | 2012-04-13 | 4 | -15/+11 | |
| | | | | | | ||||||
* | | | | | | we don't need to test that constant assignment works | Jon Leighton | 2012-04-13 | 1 | -15/+0 | |
| | | | | | | ||||||
* | | | | | | refactoring | Jon Leighton | 2012-04-13 | 1 | -36/+45 | |
| | | | | | | ||||||
* | | | | | | Extract clusterfuck method for surgery | Jon Leighton | 2012-04-13 | 2 | -71/+92 | |
|/ / / / / | ||||||
* | | | | | mention that coercion only happens when the primary key is an integer and ↵ | Reg Braithwaite | 2012-04-12 | 1 | -2/+2 | |
| | | | | | | | | | | | | | | | | | | | | use +to_i+ formatting | |||||
* | | | | | Documents that ActiveRecord's find by id uses to_i to coerce its arguments ↵ | Reg Braithwaite | 2012-04-12 | 1 | -1/+3 | |
| | | | | | | | | | | | | | | | | | | | | to integers | |||||
* | | | | | Add bang versions of relation query methods. | Jon Leighton | 2012-04-12 | 3 | -84/+194 | |
|/ / / / | | | | | | | | | | | | | | | | | The main reason for this is that I want to separate the code that does the mutating from the code that does the cloning. | |||||
* | | | | Some refactor for association. | kennyj | 2012-04-12 | 3 | -8/+7 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Remove unused association_class method. * Remove a unnecessary assignment. * Move @updated to BelongsToAssociation that only reference this instance variable. * Reset @stale_state at the reset method. I think this place is right place. | |||||
* | | | | move apply_finder_options to active_record_deprecated_finders | Jon Leighton | 2012-04-12 | 1 | -22/+0 | |
| | | | | ||||||
* | | | | add active_record_deprecated_finders as a dep | Jon Leighton | 2012-04-12 | 2 | -0/+3 | |
| | | | | ||||||
* | | | | Merge pull request #5720 from kennyj/should_use_klass_method | Jon Leighton | 2012-04-11 | 2 | -1/+2 | |
|\ \ \ \ | | | | | | | | | | | Get a properly aliased_table_name, when we use a polymorphic association. | |||||
| * | | | | Get a properly aliased_table_name, when we use a polymorphic association. | kennyj | 2012-04-04 | 2 | -1/+2 | |
| | |/ / | |/| | | ||||||
* | | | | Override AR::Relation methods in NullRelation. | Juanjo Bazán | 2012-04-11 | 2 | -0/+86 | |
| | | | | | | | | | | | | So a NullRelation (Relation#none) is chainable with database methods. | |||||
* | | | | Corrected grammatical errors in schema_dumper and scoping/default | dcurtis | 2012-04-10 | 2 | -2/+2 | |
| | | | | ||||||
* | | | | Fix delete_all when chained with joins. | Rafael Mendonça França | 2012-04-10 | 4 | -17/+59 | |
| | | | | | | | | | | | | | | | | Closes #5202 and #919 | |||||
* | | | | Merge pull request #5718 from benedikt/master | Jeremy Kemper | 2012-04-08 | 4 | -6/+13 | |
|\ \ \ \ | | | | | | | | | | | Removes caching from ActiveRecord::Core::ClassMethods#relation | |||||
| * | | | | Adds test to check that circular preloading does not modify Model.unscoped ↵ | Benedikt Deicke | 2012-04-03 | 3 | -4/+8 | |
| | | | | | | | | | | | | | | | | | | | | (as described in #5667) | |||||
| * | | | | Removes caching from ActiveRecord::Core::ClassMethods#relation | Benedikt Deicke | 2012-04-03 | 3 | -6/+9 | |
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The #relation method gets called in four places and the return value was instantly cloned in three of them. The only place that did not clone was ActiveRecord::Scoping::Default::ClassMethods#unscoped. This introduced a bug described in #5667 and should really clone the relation, too. This means all four places would clone the relation, so it doesn't make a lot of sense caching it in the first place. The four places with calls to relations are: activerecord/lib/active_record/scoping/default.rb:110:in `block in build_default_scope'" activerecord/lib/active_record/scoping/default.rb:42:in `unscoped'" activerecord/lib/active_record/scoping/named.rb:38:in `scoped'" activerecord/lib/active_record/scoping/named.rb:52:in `scope_attributes'" | |||||
* | / / | fix markup error [ci skip] | Vijay Dev | 2012-04-08 | 1 | -1/+1 | |
| |/ / |/| | | ||||||
* | | | Merge pull request #5716 from jurriaan/tr-gsub-cleanup | Santiago Pastorino | 2012-04-04 | 2 | -3/+3 | |
|\ \ \ | | | | | | | | | Updated/changed unneeded tr/gsubs | |||||
| * | | | Updated/changed useless tr/gsubs | Jurriaan Pruis | 2012-04-03 | 2 | -3/+3 | |
| |/ / |