aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
Commit message (Collapse)AuthorAgeFilesLines
...
* | | Remove `require 'arel/visitors/bind_visitor'`Ryuta Kamizono2015-05-193-4/+0
| | | | | | | | | | | | | | | This line introduced by the commit fd398475 for using `Arel::Visitors::BindVisitor`. Currently it is not used.
* | | Merge pull request #20212 from kamipo/avoid_heredocRafael Mendonça França2015-05-191-20/+5
|\ \ \ | | | | | | | | Avoid the heredoc in one line queries and simple queries
| * | | Avoid the heredoc in one line queries and simple queriesRyuta Kamizono2015-05-191-20/+5
| |/ / | | | | | | | | | Related with #20028.
* / / Eliminate the duplication code of `StatementPool`Ryuta Kamizono2015-05-194-92/+36
|/ /
* | Merge pull request #20175 from eugeneius/copy_schema_cache_after_forkRafael Mendonça França2015-05-183-24/+49
|\ \ | | | | | | Add schema cache to new connection pool after fork
| * | Add schema cache to new connection pool after forkEugene Kenny2015-05-173-24/+49
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Active Record detects when the process has forked and automatically creates a new connection pool to avoid sharing file descriptors. If the existing connection pool had a schema cache associated with it, the new pool should copy it to avoid unnecessarily querying the database for its schema. The code to detect that the process has forked is in ConnectionHandler, but the existing test for it was in the ConnectionManagement test file. I moved it to the right place while I was writing the new test for this change.
* | | Merge pull request #20187 from yui-knk/refactor/type_intRafael Mendonça França2015-05-181-3/+6
|\ \ \ | | | | | | | | Refactoring `ActiveRecord::Type::Integer` limit
| * | | Refactoring `ActiveRecord::Type::Integer` limityui-knk2015-05-181-3/+6
| | | |
* | | | Merge pull request #20192 from kamipo/divide_to_column_options_handling_methodsRafael Mendonça França2015-05-182-10/+34
|\ \ \ \ | | | | | | | | | | Divide methods for handling column options separately
| * | | | Divide methods for handling column options separatelyRyuta Kamizono2015-05-182-10/+34
| | |/ / | |/| |
* | | | Merge pull request #20190 from kamipo/fix_serial_with_quoted_sequence_nameRafael Mendonça França2015-05-182-1/+10
|\ \ \ \ | | | | | | | | | | Fix `serial?` with quoted sequence name
| * | | | Fix `serial?` with quoted sequence nameRyuta Kamizono2015-05-182-1/+10
| |/ / /
* | | | Merge pull request #20082 from sh6khan/nested-attributes-docsEileen M. Uchitelle2015-05-181-0/+5
|\ \ \ \ | | | | | | | | | | docs for updating nested attributes while creating parent record
| * | | | docs for updating nested attributes while creating parent record [cish6khan2015-05-181-0/+5
| | | | | | | | | | | | | | | | | | | | skip]
* | | | | sqlite3_mem has an existing connectionMatthew Draper2015-05-181-1/+3
| |_|/ / |/| | | | | | | | | | | | | | | We must account for receiving one less call to #new_connection, but the test otherwise remains valid.
* | | | better `add_reference` documentation. [ci skip]Yves Senn2015-05-182-20/+18
| |/ / |/| | | | | | | | | | | | | | | | | | | | | | | This patch - reduces the duplication among the `reference`-family methods. - better explains all the optians available for `add_reference`. - redirects to user from `references` to `add_reference`. Originated by #20184.
* | | Pass over CHANGELOGS [ci skip]Prathamesh Sonpatki2015-05-161-2/+3
| | |
* | | Merge pull request #14938 from thedarkone/pool-lock-fixMatthew Draper2015-05-165-92/+577
|\ \ \ | | | | | | | | Reducing AR::ConPool's critical (synchronized) section
| * | | AR::ConPool - remove synchronization around connection cache.thedarkone2015-05-143-84/+436
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Renamed `@reserved_connections` -> `@thread_cached_conns`. New name clearly conveys the purpose of the cache, which is to speed-up `#connection` method. The new `@thread_cached_conns` now also uses `Thread` objects as keys (instead of previously `Thread.current.object_id`). Since there is no longer any synchronization around `@thread_cached_conns`, `disconnect!` and `clear_reloadable_connections!` methods now pre-emptively obtain ownership (via `checkout`) of all existing connections, before modifying internal data structures. A private method `release` has been renamed `thread_conn_uncache` to clear-up its purpose. Fixed some brittle `thread.status == "sleep"` tests (threads can go into sleep even without locks).
| * | | AR::ConPool - establish connections outside of critical section.thedarkone2015-05-143-28/+136
| | | |
| * | | AR::ConPool - reduce post checkout critical section.thedarkone2015-05-143-14/+38
| | | | | | | | | | | | | | | | Move post checkout connection verification out of mutex.synchronize.
* | | | Remove redundant require 'set' linesMehmet Emin İNAÇ2015-05-153-3/+0
| | | |
* | | | Merge pull request #20113 from claudiob/remove-rails31-refsYves Senn2015-05-142-18/+3
|\ \ \ \ | |/ / / |/| | | [ci skip] Remove comments about Rails 3.1
| * | | [ci skip] Remove comments about Rails 3.1claudiob2015-05-112-18/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Stems from https://github.com/rails/rails/pull/20105#issuecomment-100900939 where @senny said: > From my point of view, all the docs (guides, API) are version bound. > They should describe that version and continue to be available when newer versions are released. > The cross referencing can be done by the interested user.
* | | | Merge pull request #20150 from karanarora/Typo-fixRafael Mendonça França2015-05-131-1/+1
|\ \ \ \ | | | | | | | | | | remove redundant parenthesis
| * | | | remove redundant parenthesiskaranarora2015-05-141-1/+1
| | | | |
* | | | | Merge pull request #20121 from matthewrudy/remove-sanitize-hashSean Griffin2015-05-131-3/+1
|\ \ \ \ \ | | | | | | | | | | | | Remove call to sanitize_sql_hash_for_conditions
| * | | | | remove documentation for sanitize_sql_for_conditions with a HashMatthew Rudy Jacobs2015-05-121-2/+1
| | | | | |
| * | | | | Remove call to sanitize_sql_hash_for_conditionsMatthew Rudy Jacobs2015-05-121-1/+0
| | |/ / / | |/| | | | | | | | | | | | | This method has already been removed.
* | | | | invalid sti error message contains the full class name.Yves Senn2015-05-132-1/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This can resolve confusing situation when a top level constant exists but a namespaced version is identified. Related to #19531.
* | | | | Merge branch 'sti-subclass-from-attributes' of ↵Yves Senn2015-05-134-6/+23
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://github.com/agrobbin/rails into agrobbin-sti-subclass-from-attributes Conflicts: activerecord/CHANGELOG.md
| * | | | | allow setting of a demodulized class name when using STIAlex Robbin2015-05-114-6/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If your STI class looks like this: ```ruby class Company < ActiveRecord::Base self.store_full_sti_class = false class GoodCo < Company end class BadCo < Company end end ``` The expectation (which is valid) is that the `type` in the database is saved as `GoodCo` or `BadCo`. However, another expectation should be that setting `type` to `GoodCo` would correctly instantiate the object as a `Company::GoodCo`. That second expectation is what this should fix.
* | | | | | :nodoc: postgresql add_columnTony Miller2015-05-131-3/+1
| | | | | |
* | | | | | Merge pull request #20126 from drcapulet/masterRafael Mendonça França2015-05-133-10/+31
|\ \ \ \ \ \ | | | | | | | | | | | | | | Add full set of MySQL CLI options to support SSL authentication when using db:structure dump and load
| * | | | | | Add full set of MySQL CLI options to support SSL authentication when using ↵Alex Coomans2015-05-123-10/+31
| | |/ / / / | |/| | | | | | | | | | | | | | | | db:structure dump and load
* | | | | | Merge pull request #20131 from vngrs/missing_doc_about_assign_attributeRafael Mendonça França2015-05-121-1/+2
|\ \ \ \ \ \ | | | | | | | | | | | | | | Add more detailed comment about _assign_attribute method [ci skip]
| * | | | | | Add more detailed comment about _assign_attribute method [ci skip]Mehmet Emin İNAÇ2015-05-131-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | fix minor problems
* | | | | | | Refactor abstract_mysql_adapter type_to_sql methodMehmet Emin İNAÇ2015-05-131-21/+33
|/ / / / / /
* / / / / / [ci skip] Don’t encourage `sudo gem install`claudiob2015-05-121-1/+1
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I think we are better off leaving `sudo` outside of the documented way of installing gems (`activerecord`, `actionpack`, …). We don’t want newbies to think that `sudo` is required or, even worse, than they actually have to type `[sudo] gem install`. In most scenarios, `sudo` is not needed to install gems, and people who do need it, probably already know about it. What do you think? :grin:
* / / / / [ci skip] Fix comment, since Rails 3.1 is outclaudiob2015-05-111-2/+1
|/ / / /
* | | | [ci skip] Stop explaining finders for Rails 3claudiob2015-05-101-14/+2
| | | | | | | | | | | | | | | | | | | | Now that master points at Rails 5, we might not need to explain how things used to work in Rails 3. Or we might… up to you :grin:
* | | | [ci skip] Fix comment of `ActiveRecord::Associations#association_instance_get`yui-knk2015-05-111-1/+1
| | | |
* | | | change GeneratedFeatureMethods to GeneratedAssociationMethods in docsRob Looby2015-05-081-1/+1
| |/ / |/| | | | | | | | the module name was changed in 8e814a0ac0768816974d2bfd68d33d931592751e
* | | Merge pull request #20068 from mcfiredrill/nodoc-postgresql-rename-columnYves Senn2015-05-081-1/+1
|\ \ \ | | | | | | | | :nodoc: rename_column in postgresql/schema_statements.rb [ci skip]
| * | | :nodoc: rename_column in postgresql/schema_statements.rbTony Miller2015-05-081-1/+1
| | | | | | | | | | | | | | | | | | | | Its already doc'ed in activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb
* | | | remove duplicate test.Yves Senn2015-05-081-10/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The old `test_create_bang_returns_falsy_when_join_record_has_errors` had a missleading name and was a duplicate of `test_save_should_not_raise_exception_when_join_record_has_errors`. Since it had an assertion on the return value I renamed it accordingly and got rid of the duplicate test.
* | | | tests, extract helpers to modify global state.Yves Senn2015-05-071-46/+55
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | Make sure that tests do not hardcode the default value. For example `test_instantiation_doesnt_try_to_require_corresponding_file` always restored the configuration to `true` regardless of what it's original value was. Extract a helper to make the global modification consistent across tests.
* | | Merge pull request #20047 from mcfiredrill/make-subquery-for-privateRafael Mendonça França2015-05-061-13/+13
|\ \ \ | | | | | | | | make AbstractAdapter#subquery_for private
| * | | make AbstractAdapter#subquery_for privateTony Miller2015-05-061-13/+13
| | | |
* | | | copy-edits the docs of dump_schemas [ci skip]Xavier Noria2015-05-061-3/+4
| | | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-05 22:11:58 +0000