aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
Commit message (Collapse)AuthorAgeFilesLines
* properly namespace the fixture exceptionAaron Patterson2012-03-222-7/+3
|
* Avoid another blank line in generated migration and remove assertion as per ↵Marcelo Silveira2012-03-211-1/+1
| | | | @spastorino request
* Deprecate eager-evaluated scopes.Jon Leighton2012-03-2120-83/+159
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Don't use this: scope :red, where(color: 'red') default_scope where(color: 'red') Use this: scope :red, -> { where(color: 'red') } default_scope { where(color: 'red') } The former has numerous issues. It is a common newbie gotcha to do the following: scope :recent, where(published_at: Time.now - 2.weeks) Or a more subtle variant: scope :recent, -> { where(published_at: Time.now - 2.weeks) } scope :recent_red, recent.where(color: 'red') Eager scopes are also very complex to implement within Active Record, and there are still bugs. For example, the following does not do what you expect: scope :remove_conditions, except(:where) where(...).remove_conditions # => still has conditions
* Avoid obscure &Proc.new thingJon Leighton2012-03-211-2/+2
|
* Remove valid_scope_name? check - use rubyJon Leighton2012-03-212-30/+1
| | | | | | | scope is syntactic sugar for defining a class method. Ruby allows redefining methods but emits a warning when run with -w. So let's not implement our own logic for this. Users should run with -w if they want to be warned about redefined methods.
* no need for castJon Leighton2012-03-211-1/+0
|
* no need for lvarJon Leighton2012-03-211-3/+1
|
* Merge pull request #5532 from mhfs/migration_blank_lineJosé Valim2012-03-211-1/+1
|\ | | | | Remove blank line from generated migration
| * Remove blank line from generated migrationMarcelo Silveira2012-03-201-1/+1
| |
* | Generate Migration Thats Adds Removed IndexTravis Jeffery2012-03-211-0/+3
|/ | | | | When generating a migration that removes a field with an index, the down will add both the field and its index.
* changed all.map to pluckSandeep2012-03-191-1/+1
|
* Merge pull request #3329 from armstrjare/autosave_collection_new_record_bugJosé Valim2012-03-182-1/+16
|\ | | | | Autosave association doesn't save all records on a new record for a collection association if there are records marked for destruction
| * Fix bug with autosave collection association on new record with a marked for ↵Jared Armstrong2012-03-182-1/+16
| | | | | | | | destroy record in autosave collection.
* | Merge pull request #5486 from kennyj/fix_5435Aaron Patterson2012-03-171-0/+1
|\ \ | | | | | | Fix GH #5435. db:structure:dump should be re-enable.
| * | Fix GH #5435. db:structure:dump should be reenable.kennyj2012-03-171-0/+1
| | |
* | | Fix typo in ActiveRecord::Relation#blank? testRuben Davila2012-03-171-1/+1
| | |
* | | Updates 'modyfing' typo to 'modifying'Jonathan R. Wallace2012-03-171-1/+1
| | |
* | | Merge pull request #5321 from pfeiffer/uniqueness_validator_conditionsJosé Valim2012-03-172-2/+30
|\ \ \ | |/ / |/| | Add :conditions option to uniqueness validator
| * | Correct grammar in documentationMattias Pfeiffer2012-03-071-1/+1
| | |
| * | Change syntax to accept an AR::Relation instead of old conditions hash/array.Mattias Pfeiffer2012-03-072-4/+10
| | |
| * | Add :conditions option to uniqueness validatorMattias Pfeiffer2012-03-072-2/+24
| | |
* | | Fix ActiveRecord::Relation#blank? testsRafael Mendonça França2012-03-161-12/+15
| | |
* | | Merge pull request #5469 from yakko/masterJosé Valim2012-03-161-0/+19
|\ \ \ | | | | | | | | tests for Relation .present? .blank?
| * | | test relation presence fixThiago Almeida2012-03-161-4/+4
| | | |
| * | | tests for Relation .present? and .blank? are check cases and shouldn't force ↵Thiago Almeida2012-03-161-0/+19
| | | | | | | | | | | | | | | | sql-count
* | | | Merge pull request #5467 from bogdan/initialize_callbacksJosé Valim2012-03-161-1/+1
|\ \ \ \ | |_|_|/ |/| | | ActiveRecord::Core#initialize: improve performance
| * | | ActiveRecord::Core#initialize: improve performanceBogdan Gusiev2012-03-151-1/+1
| | | |
* | | | Merge pull request #5461 from yakko/masterJosé Valim2012-03-161-0/+4
|\ \ \ \ | | |/ / | |/| | relation .present? and .blank? should not query SELECT COUNT(DISTINCT id)
| * | | relation .present? and .blank? should not query SELECT COUNT(DISTINCT id)Thiago Almeida2012-03-161-0/+4
| | | |
* | | | Merge pull request #5327 from kennyj/fix_explicitly_inheraitance_columnAaron Patterson2012-03-152-1/+12
|\ \ \ \ | |/ / / |/| | | Don't reset inheritance_column when setting explicitly.
| * | | Don't reset inheritance_column when setting explicitly.kennyj2012-03-082-1/+12
| | | |
* | | | errors should probably be logged as errorsAaron Patterson2012-03-151-20/+19
| | | |
* | | | Address the dump file format for hstoreYasuo Honda2012-03-151-1/+1
| | | |
* | | | Fix GH #5430. A Payload name for schema_search_path should be SCHEMA.kennyj2012-03-152-1/+8
| |/ / |/| |
* | | Expand changelog and upgrading rails guide with IdentityMap infoCarlos Antonio da Silva2012-03-131-1/+10
| | |
* | | Remove IdentityMapCarlos Antonio da Silva2012-03-1329-945/+35
| | |
* | | Merge branch 'master' of github.com:lifo/docrailsVijay Dev2012-03-131-1/+3
|\ \ \
| * | | added clarification stating the counter_cache attribute needs to be created ↵Michael de Silva2012-03-111-1/+3
| | | | | | | | | | | | | | | | on the associate class via a migration
* | | | Fix GH #5399. connection_pools's keys are ↵kennyj2012-03-142-2/+8
| | | | | | | | | | | | | | | | ActiveRecord::Base::ConnectionSpecification objects.
* | | | Merge pull request #5294 from robinroestenburg/masterAaron Patterson2012-03-123-26/+53
|\ \ \ \ | | | | | | | | | | Refactoring of `arel_attributes_values` method
| * | | | Removed flag attributes.Robin Roestenburg2012-03-063-22/+35
| | | | |
| * | | | Refactored method arel_attributes_values.Robin Roestenburg2012-03-061-20/+34
| | | | |
* | | | | make sure connections returned after close are marked as in_useAaron Patterson2012-03-122-4/+27
| | | | |
* | | | | deprecated clear_stale_active_connections! can call #reap instead of ↵Jonathan Rochkind2012-03-121-1/+2
| | | | | | | | | | | | | | | | | | | | no-op'ing, #reap does the same thing
* | | | | Add documentation for find_or_create_by_{attribute}! method.Andrew White2012-03-121-0/+3
| | | | |
* | | | | Add dynamic find_or_create_by_{attribute}! method.Andrew White2012-03-127-2/+80
| | | | |
* | | | | fix activerecord query_method regression with offset into FixnumDenis Jean2012-03-122-1/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | add test to show offset query_methods on mysql & mysql2 change test to cover public API
* | | | | In AR depths use &:to_i before :uniq to process mixed arrays likes ["1", 1] ↵Alexey Vakhov2012-03-092-1/+8
| | | | | | | | | | | | | | | | | | | | correct
* | | | | Fix my name in the CHANGELOG to follow the conventionRafael Mendonça França2012-03-091-0/+11
| | | | | | | | | | | | | | | | | | | | Also add missing entries and use the formating convention
* | | | | ensure that released connections move between threadsAaron Patterson2012-03-081-0/+18
| | | | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-12 10:08:42 +0000