| Commit message (Collapse) | Author | Age | Files | Lines |
|\
| |
| | |
Added *instance_writer: false* to stored/serialized attributes.
|
| | |
|
|/
|
|
| |
While it's interesting to have the results array, it can make a console or a webpage freeze if there are a lot of them.
So this limits the number of records displayed in #inspect to 10 and tells how much were effectively found.
|
|\
| |
| | |
Disable query cache for lock queries
|
| |
| |
| |
| | |
Fixes #867
|
| |
| |
| |
| |
| | |
See 07314e64fd62fb8e6165c8c539420160da9437e9.
Also fix some tabs in AR Changelog.
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The reason for removing the previous implementation of `#inspect` was
that it hid from you that you were dealing with a `Relation` rather than
an `Array`.
But it is still useful to be able to see the records, particularly if you're
writing something like the following in tests:
assert_equal [foo], Post.where(:bar)
If the assertion fails, you want to see what records were actually
loaded.
So this implementation makes it clear that you've got a `Relation`, but
also shows your records.
|
|\
| |
| | |
Make ArgumentError message more consistent in nested attributes
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This patch fixes quoting for ActiveSupport::Duration instances:
# before
>> ActiveRecord::Base.connection.quote 30.minutes
=> "'--- 1800\n...\n'"
# after
>> ActiveRecord::Base.connection.quote 30.minutes
=> "1800"
Also, adds a test for type casting ActiveSupport::Duration instances.
Related to #1119.
|
| |
| |
| |
| |
| | |
Mocha is already required by AS::TestCase, so remove the duplicate
requires.
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Examples:
add_reference :products, :supplier, polymorphic: true, index: true
remove_reference :products, :user
`add_belongs_to` and `remove_belongs_to` are
acceptable.
|
| | |
|
|/
|
|
|
|
|
| |
Also fix some wrong formatting.
Related discussion:
https://github.com/rails/rails/commit/ab72040b74f742b6676b2d2a5dd029bfdca25a7a#commitcomment-1525256
|
|
|
|
| |
connection.tables returns an array of strings
|
| |
|
|\
| |
| | |
Refactor migration test_helper
|
| |
| |
| |
| | |
and create_join_table_test
|
| | |
|
|\ \
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Add :default and :null options to column_exists? method
Examples:
column_exists?(:testings, :taggable_id, :integer, null: false)
column_exists?(:testings, :taggable_type, :string, default: 'Photo')
|
| |/
| |
| |
| | |
Also fix failures in check options for nil
|
|\ \
| | |
| | |
| | |
| | | |
Conflicts:
activemodel/lib/active_model/errors.rb
|
| | | |
|
| | |
| | |
| | |
| | | |
option [ci skip]
|
| | | |
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Since plugins were removed, we can clean up a few methods in engines.
We also use this opportunity to move `load_console`, `load_tasks` and
`load_runner` to Rails::Engine. This means that, if someone wants to
improve script/rails for engines to support console or runner commands,
part of the work is already done.
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Since composed_of was removed in 051747449e7afc817c599e4135bc629d4de064eb,
these tests were working "by mistake", due to the matching "address"
string in the error message, but with a different error message than the
expected multiparameter assignment error.
Since "address" is not an attribute from Customer anymore, the error was
"undefined method klass for nil", where nil was supposed to be the
column object.
|
| | |
| | |
| | |
| | |
| | | |
All other multiparameter assignment tests are in the same file, so it
makes sense to have all of them here.
|
| | |
| | |
| | |
| | | |
does not have TIME data type.
|
| | | |
|
| |/
|/|
| |
| | |
SQLite3 driver to correctly generate a time column instead of datetime
|
|\ \
| | |
| | | |
Fix wrong testcase for db:test:prepare, and wrong environment in AR rake task.
|
| | | |
|
|\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Add polymorphic option to model generator
For instance,
$ rails g model Product supplier:references{polymorphic}
generate model with `belongs_to :supplier, polymorphic: true` association and appropriate migration.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
For instance,
$ rails g model Product supplier:references{polymorphic}
generate model with `belongs_to :supplier, polymorphic: true` association and appropriate migration.
Also fix model_generator_test.rb#L196 and #L201
|
| |/ /
|/| |
| | |
| | | |
which ids start from 1000 as a default.
|
| | |
| | |
| | |
| | |
| | |
| | | |
test starts with a clean slate.
Fixes #6867.
|
| | |
| | |
| | |
| | |
| | | |
Try to use more destructive methods on *args when applicable, to avoid
creating new objects.
|
|\ \ \
| | | |
| | | | |
exists?(false) returns false
|