aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #6997 from kennyj/fix_stored_attributesJosé Valim2012-07-074-2/+16
|\ | | | | Added *instance_writer: false* to stored/serialized attributes.
| * Added *instance_writer: false* for stored/serialized attributes.kennyj2012-07-074-2/+16
| |
* | Limit the number of records in Relation#inspectDamien Mathieu2012-07-063-3/+22
|/ | | | While it's interesting to have the results array, it can make a console or a webpage freeze if there are a lot of them. So this limits the number of records displayed in #inspect to 10 and tells how much were effectively found.
* Merge pull request #6985 from sidonath/disable-query-cache-for-locksRafael Mendonça França2012-07-062-1/+17
|\ | | | | Disable query cache for lock queries
| * Disable query cache for lock queriesDamir Zekic2012-07-062-1/+17
| | | | | | | | Fixes #867
* | Update release notes with AR::Relation#inspect change [ci skip]Carlos Antonio da Silva2012-07-061-3/+3
| | | | | | | | | | See 07314e64fd62fb8e6165c8c539420160da9437e9. Also fix some tabs in AR Changelog.
* | Show the records in Relation#inspectJon Leighton2012-07-063-6/+17
|/ | | | | | | | | | | | | | | | | The reason for removing the previous implementation of `#inspect` was that it hid from you that you were dealing with a `Relation` rather than an `Array`. But it is still useful to be able to see the records, particularly if you're writing something like the following in tests: assert_equal [foo], Post.where(:bar) If the assertion fails, you want to see what records were actually loaded. So this implementation makes it clear that you've got a `Relation`, but also shows your records.
* Merge pull request #6927 from parndt/patch-3Carlos Antonio da Silva2012-07-052-3/+3
|\ | | | | Make ArgumentError message more consistent in nested attributes
| * Made ArgumentError messages consistent.Philip Arndt2012-07-062-3/+3
| |
* | Add documentation for inheritance_column methodVitor Balocco2012-07-051-1/+3
| |
* | fix quoting for ActiveSupport::Duration instancesFrancesco Rodriguez2012-07-043-1/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch fixes quoting for ActiveSupport::Duration instances: # before >> ActiveRecord::Base.connection.quote 30.minutes => "'--- 1800\n...\n'" # after >> ActiveRecord::Base.connection.quote 30.minutes => "1800" Also, adds a test for type casting ActiveSupport::Duration instances. Related to #1119.
* | remove duplicate requires of mocha.Aaron Patterson2012-07-031-1/+0
| | | | | | | | | | Mocha is already required by AS::TestCase, so remove the duplicate requires.
* | Don't need to use delete in the options hashRafael Mendonça França2012-07-032-3/+2
| |
* | Add changelog entry for references statementsAleksey Magusev2012-07-031-0/+13
| |
* | Refactor references schema definitionsAleksey Magusev2012-07-032-34/+24
| |
* | Make references statements reversibleAleksey Magusev2012-07-032-4/+40
| |
* | Add references schema statementsAleksey Magusev2012-07-033-1/+149
| | | | | | | | | | | | | | | | | | | | Examples: add_reference :products, :supplier, polymorphic: true, index: true remove_reference :products, :user `add_belongs_to` and `remove_belongs_to` are acceptable.
* | Don't mark the store as changed if an attribute isn't changed.kennyj2012-07-032-2/+10
| |
* | Update 4.0 Release Notes with changelogs [ci skip]Carlos Antonio da Silva2012-07-021-3/+3
|/ | | | | | | Also fix some wrong formatting. Related discussion: https://github.com/rails/rails/commit/ab72040b74f742b6676b2d2a5dd029bfdca25a7a#commitcomment-1525256
* Use strings for the table namesRafael Mendonça França2012-07-011-1/+1
| | | | connection.tables returns an array of strings
* Unify the collation API for the database adptersRafael Mendonça França2012-07-016-15/+15
|
* Merge pull request #6914 from lexmag/migration_testsRafael Mendonça França2012-07-012-37/+11
|\ | | | | Refactor migration test_helper
| * Refactor migration test_helperAleksey Magusev2012-07-012-37/+11
| | | | | | | | and create_join_table_test
* | Update AR and AP changelogs [ci skip]Carlos Antonio da Silva2012-06-301-1/+13
| |
* | Merge pull request #6913 from lexmag/column_exists_optionsCarlos Antonio da Silva2012-06-302-10/+18
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | Add :default and :null options to column_exists? method Examples: column_exists?(:testings, :taggable_id, :integer, null: false) column_exists?(:testings, :taggable_type, :string, default: 'Photo')
| * | Add more options to column_exists? methodAleksey Magusev2012-06-302-10/+18
| |/ | | | | | | Also fix failures in check options for nil
* | Merge branch 'master' of github.com:lifo/docrailsVijay Dev2012-06-302-5/+15
|\ \ | | | | | | | | | | | | Conflicts: activemodel/lib/active_model/errors.rb
| * | update AR::FinderMethods#exists?(false) example [ci skip]Francesco Rodriguez2012-06-281-5/+7
| | |
| * | Mention effect of accepts_nested_attributes_for on association autosave ↵Chris Gunther2012-06-271-0/+8
| | | | | | | | | | | | option [ci skip]
* | | Fix collation database task to use begin..rescue..endCarlos Antonio da Silva2012-06-301-4/+6
| | |
* | | Extract collation tasks to database tasks.kennyj2012-07-018-8/+88
| | |
* | | Remove ActiveRelation#inspectBrian Cardarella2012-06-293-5/+5
| | |
* | | Remove unused responsibilities and add a few load definitions to enginesJosé Valim2012-06-291-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | Since plugins were removed, we can clean up a few methods in engines. We also use this opportunity to move `load_console`, `load_tasks` and `load_runner` to Rails::Engine. This means that, if someone wants to improve script/rails for engines to support console or runner commands, part of the work is already done.
* | | Added an entry about fda24312d3 in the CHANGELOG.kennyj2012-06-291-0/+15
| | |
* | | Require URIChris Bandy2012-06-281-0/+2
| | |
* | | Support collate and ctype on the PostgreSQL.kennyj2012-06-294-1/+40
| | |
* | | fixing typo in from documentationSubba Rao Pasupuleti2012-06-281-2/+2
| | |
* | | Remove some aggregation tests related to composed_ofCarlos Antonio da Silva2012-06-282-21/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since composed_of was removed in 051747449e7afc817c599e4135bc629d4de064eb, these tests were working "by mistake", due to the matching "address" string in the error message, but with a different error message than the expected multiparameter assignment error. Since "address" is not an attribute from Customer anymore, the error was "undefined method klass for nil", where nil was supposed to be the column object.
* | | Move newly added multiparameter tests to base_test fileCarlos Antonio da Silva2012-06-282-35/+36
| | | | | | | | | | | | | | | All other multiparameter assignment tests are in the same file, so it makes sense to have all of them here.
* | | Skip test_setting_time_attribute because Oracle databaseYasuo Honda2012-06-281-0/+2
| | | | | | | | | | | | does not have TIME data type.
* | | fix: limit of enum columns of mysqlYamada Masaki2012-06-285-0/+41
| | |
* | | Fixes #6825, adds tests covering cases and error possibilities, also changes ↵Mauricio Linhares2012-06-273-16/+58
| |/ |/| | | | | SQLite3 driver to correctly generate a time column instead of datetime
* | Merge pull request #6880 from kennyj/fix_20120628Carlos Antonio da Silva2012-06-271-1/+1
|\ \ | | | | | | Fix wrong testcase for db:test:prepare, and wrong environment in AR rake task.
| * | Fix wrong environment. env should be RAILS_ENV or test.kennyj2012-06-281-1/+1
| | |
* | | Merge pull request #6856 from lexmag/polymorphic_generatorsCarlos Antonio da Silva2012-06-271-1/+1
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add polymorphic option to model generator For instance, $ rails g model Product supplier:references{polymorphic} generate model with `belongs_to :supplier, polymorphic: true` association and appropriate migration.
| * | | Add polymorphic option to model generatorAleksey Magusev2012-06-271-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | For instance, $ rails g model Product supplier:references{polymorphic} generate model with `belongs_to :supplier, polymorphic: true` association and appropriate migration. Also fix model_generator_test.rb#L196 and #L201
* | | | Address test_basic_model test error with Oracle enhanced adapterYasuo Honda2012-06-271-1/+1
| |/ / |/| | | | | | | | which ids start from 1000 as a default.
* | | Setup each test with default ActiveRecord timezone settings to ensure each ↵Erich Menge2012-06-261-20/+8
| | | | | | | | | | | | | | | | | | test starts with a clean slate. Fixes #6867.
* | | Use args.flatten! in query methods when applicableCarlos Antonio da Silva2012-06-251-7/+12
| | | | | | | | | | | | | | | Try to use more destructive methods on *args when applicable, to avoid creating new objects.
* | | Merge pull request #6544 from flexoid/issue-6431Piotr Sarnacki2012-06-253-6/+14
|\ \ \ | | | | | | | | exists?(false) returns false