aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
Commit message (Collapse)AuthorAgeFilesLines
* Add CHANGELOG entry for #15071 [ci skip]Rafael Mendonça França2014-05-161-0/+8
|
* Merge pull request #15071 from leafac/issues/11985Rafael Mendonça França2014-05-162-4/+18
|\ | | | | Fix `Relation#delete_all` inconsistency
| * Fix `Relation#delete_all` inconsistencyLeandro Facchinetti2014-05-162-4/+18
| | | | | | | | | | | | | | | | | | When relation scopes include one of `uniq`, `group`, `having` or `offset`, the generated query ignores them and that causes unintended records to be deleted. This solves the issue by restricting the deletion when those scopes are present. rails/rails#11985
* | Remove unecessary requireArthur Neves2014-05-161-2/+0
| |
* | Remove the assignment for real this time.Zachary Scott2014-05-161-2/+2
| | | | | | | | | | | | cc: https://github.com/rails/rails/commit/a11e2fcff8cdc9691b977d8330abe63024f8c732#commitcomment-6353614 and 0369dbf
* | prepend mutates the string so we can remove the assignmentRafael Mendonça França2014-05-161-1/+1
| |
* | Reuse the force_clear_transaction_record_stateRafael Mendonça França2014-05-161-1/+1
| |
* | Missed if :bomb:Rafael Mendonça França2014-05-161-1/+1
| |
* | Add a specific method to force the transaction record state clearRafael Mendonça França2014-05-161-5/+8
| | | | | | | | | | | | We are using that code path in only one place so we should not add a conditional to all the other cases. This will avoid performance regressions on the old paths.
* | Merge pull request #15125 from arthurnn/small_refactoring_transaction_clearGodfrey Chan2014-05-162-4/+19
|\ \ | | | | | | Small refactoring on clear_transaction_record_state
| * | Clear transaction state if callback raise rollbackArthur Neves2014-05-152-1/+14
| | |
| * | Small refactoring on clear_transaction_record_stateArthur Neves2014-05-151-3/+5
| | | | | | | | | | | | | | | | | | Make sure when we clean the `@_start_transaction_state` var we do it in the same code-path. Also this makes `clear_transaction_record_state`, more consistent with `restore_transaction_record_state`
* | | Remove code related to adapter which are no longer in repoArun Agrawal2014-05-162-31/+1
| | | | | | | | | | | | As we have remove code for these adapters so no need to have tasks
* | | formatting pass through CHANGELOGS. [ci skip]Yves Senn2014-05-161-5/+5
|/ /
* | Changed extract_limit in class Column to return correct mysql float and ↵Aaron Nelson2014-05-163-0/+47
| | | | | | | | double limits
* | :scissors:Rafael Mendonça França2014-05-143-4/+0
| |
* | Methods of these modules are internalRafael Mendonça França2014-05-142-14/+14
| | | | | | | | | | They should not be used on people application so they should not be present on the API documentation.
* | Merge pull request #15088 from kares/shareable-modulesRafael Mendonça França2014-05-1411-68/+67
|\ \ | | | | | | | | | [postgres] remove (outer) sub-class declarations with nested modules/classes
| * | PostgreSQLAdapter::Utils seems to be only used from a single spot - quite ↵kares2014-05-144-40/+34
| | | | | | | | | | | | redundant
| * | move PostgreSQL's DatabaseStatements out of the PostgreSQLAdapter name-spacekares2014-05-142-7/+7
| | |
| * | PostgreSQL's SchemaStatements seems a could candidate for re-use (with AR-JDBC)kares2014-05-142-8/+7
| | |
| * | introduce AR::ConnectionAdapters::PostgreSQL for sharing modules (with AR-JDBC)kares2014-05-147-15/+21
| | | | | | | | | ... 'shared' OID, ArrayParser and Cast helpers, also re-arranged Column's dependencies
* | | Don't use Active Support where it is not needed.Rafael Mendonça França2014-05-141-1/+3
| | | | | | | | | | | | | | | parent_name is a string of nil, never a blank string so we don't need to use presence.
* | | Merge pull request #14871 from kassio/kb-fixes-namespaced-habtmRafael Mendonça França2014-05-147-1/+43
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Fix how to compute class name on habtm namespaced. Conflicts: activerecord/CHANGELOG.md
| * | | Fix how to compute class name on habtm namespaced.Kassio Borges2014-05-137-1/+42
| | | | | | | | | | | | | | | | | | | | | | | | Thank's for @laurocaetano for the help with tests. :smiley: Fixes #14709
* | | | Merge pull request #15078 from nbudin/fix_merger_filter_binds_comparison_masterRafael Mendonça França2014-05-145-1/+32
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Make filter_binds filter out symbols that are equal to strings Conflicts: activerecord/CHANGELOG.md
| * | | | Make filter_binds filter out symbols that are equal to stringsNat Budin2014-05-145-1/+32
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ActiveRecord::Relation::Merger's filter_binds method does not filter out bind variables when one of the attribute nodes has a string name, but the other has a symbol name, even when those names are actually equal. This can result in there being more bind variables than placeholders in the generated SQL. This is particularly an issue for PostgreSQL, where this is treated as an error. This patch changes the filter_binds method to make it convert both attribute names to strings before comparing.
* | | | | rake, remove frontbase related tasks from Active Record Rakefile.Yves Senn2014-05-141-46/+0
| | | | |
* | | | | Merge pull request #15110 from kuldeepaggarwal/fix-warningRafael Mendonça França2014-05-141-1/+1
|\ \ \ \ \ | | | | | | | | | | | | remove warning `ambiguous first argument; put parentheses or even spaces`
| * | | | | remove warning `ambiguous first argument; put parentheses or even spaces`Kuldeep Aggarwal2014-05-151-1/+1
| | | | | |
* | | | | | [ci skip]add updated information, ref[#522c0fd]Kuldeep Aggarwal2014-05-141-0/+2
|/ / / / /
* | | / / Fix inheritance of stored_attributes (fixes #14672)Jessica Yao2014-05-143-5/+37
| |_|/ / |/| | | | | | | | | | | [Brad Bennett, Jessica Yao, & Lakshmi Parthasarathy]
* | | | remove count vareileencodes2014-05-131-4/+2
| | | | | | | | | | | | | | | | this change was unneccsary as nothing was gained from it
* | | | rename delete_all_records to delete_or_nullify_all_recordseileencodes2014-05-133-8/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Rename delete_all_records because this name better describes what the method is doing. We can then remove :all from the hm:t version and pull out the unoptimized call to load_target in delete_records and pass it directly.
* | | | remove need for :all symboleileencodes2014-05-131-13/+6
| | | | | | | | | | | | | | | | | | | | | | | | Refactor delete_count method to only handle delete_all or nullify/nil cases and not destroy and switch to if/else rather than case statement. This refactoring allows removal of :all symbol usage.
* | | | begin refactoring delete_records methodeileencodes2014-05-133-13/+30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Refactor by creating two methods delete_all_records and delete_records to be called by delete_all and delete (or destroy) respectively. This reduces the number of conditionals required to handle _how_ records get deleted. The new delete_count method handles how scope is applied to which delete action. A delete_all_records method also has to be called in has_many_through association because of how the methods are chained. This will be refactored later on.
* | | | Merge pull request #15092 from kares/pg-array-parserRafael Mendonça França2014-05-132-27/+27
|\ \ \ \ | | | | | | | | | | [postgres] include PgArrayParser directly
| * | | | [postgres] include PgArrayParser directly and only load/include ArrayParser ↵kares2014-05-132-27/+27
| | |/ / | |/| | | | | | | | | | if not found
* | | | pg, clarify default behavior for composite types.Yves Senn2014-05-131-7/+94
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * by default composite types are mapped as `OID::Identity` and issue a warning * the user is advised to register his own `OID::Type` to make use of composite types Registering a new `OID::Type` does currently not allow to specify the type casting behavior when writing to the database. In order for it to work we need to use the values within `@attributes`. They are already being type casted and are ready to be written to the DB. See https://github.com/rails/rails/blob/57643c961feb24b662620d330e71103a830003e8/activerecord/lib/active_record/attribute_methods.rb#L460-L462
* | | | extract pg type map initialization process to `TypeMapInitializer`.Yves Senn2014-05-132-65/+74
|/ / /
* | | test, move all pg array tests into `postgresql/array_test.rb`.Yves Senn2014-05-132-51/+29
| | |
* | | docs, explain usage of `count` + `select`. Closes #15065. [ci skip]Yves Senn2014-05-131-0/+8
|/ /
* | test, use `columns_hash[]` in place of `columns.find {}`.Yves Senn2014-05-128-12/+12
| |
* | pg, `change_column_default` accepts `[]`. Closes #11586.Yves Senn2014-05-124-3/+18
| |
* | pg, map `char` and `name` types as string. [dark-panda & Yves Senn]Yves Senn2014-05-123-0/+33
| | | | | | | | Closes #10802.
* | pg, fix Infinity and NaN values conversion.Innokenty Mihailov2014-05-123-3/+30
|/ | | | Before this patch `Infinity`, `-Infinity` and `Nan` were read as `0`.
* Handle other pk types in PostgreSQL gracefully.Patrick Robertson2014-05-123-1/+33
| | | | | | | | | | | | | | In #10410 it was noted that you can no longer create PK's with the type of bigserial in PostgreSQL in 4.0.0.rc1. This is mostly because the newer adapter is checking for column type with the id column instead of just letting it pass through like it did before. Side effects: You may just create a PK column of a type that you really don't want to be your PK. As far as I can tell this was allowed in 3.2.X and perhaps an exception should be raised if you try and do something extremely dumb.
* Merge pull request #14999 from yahonda/modify_bind_variable_nameYves Senn2014-05-121-2/+3
|\ | | | | | | | | | | | | Modify assert conditions not to be affected by each database bind variable naming conventions Closes #14999.
| * Modify assert conditions not to be affectedYasuo Honda2014-05-121-2/+3
| | | | | | | | by each database bind variable naming conventions
* | Update attribute_methods.rbGuillermo Iguaran2014-05-111-1/+1
| | | | | | Improve documentation
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-10 21:49:43 +0000