aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #10713 from senny/10693_fix_primary_key_option_on_has_manyRafael Mendonça França2013-05-234-2/+15
|\ | | | | Fix the `:primary_key` option for `has_many` associations.
| * Fix the `:primary_key` option for `has_many` associations.Yves Senn2013-05-234-2/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When removing records from a `has_many` association it used the `primary_key` defined on the association. Our test suite didn't fail because on all occurences of `:primary_key`, the specified column was available in both tables. This prevented the code from raising an exception but it still behaved badly. I added a test-case to prevent regressions that failed with: ``` 1) Error: HasManyAssociationsTest#test_has_many_assignment_with_custom_primary_key: ActiveRecord::StatementInvalid: SQLite3::SQLException: no such column: essays.first_name: UPDATE "essays" SET "writer_id" = NULL WHERE "essays"."writer_id" = ? AND "essays"."first_name" IS NULL ```
* | deprecate Validator#setup (to get rid of a respond_to call). validators do ↵Nick Sutterer2013-05-231-6/+1
|/ | | | their setup in their constructor now.
* Add CHANGELOG entry for 99860582b2b1c0fc42bf84c52aac57b243d42678Rafael Mendonça França2013-05-221-0/+6
|
* remove code duplicationNeeraj Singh2013-05-221-2/+3
|
* Merge pull request #10714 from tkhr/extract_test_from_base_test.rb_in_ARCarlos Antonio da Silva2013-05-224-45/+54
|\ | | | | Extract tests code out from AR's base_test.rb
| * Extract AR::Persistence#becomes's test code out from base_test.rbTakehiro Adachi2013-05-222-13/+13
| | | | | | | | | | The method got extracted out from AR::Base in commit d916c62cfc7c59ab6411407a05b946d3dd7535e9, but the tests never did.
| * Extract AR::AttributeMethods#attribute_for_inspect's test code out from ↵Takehiro Adachi2013-05-222-8/+8
| | | | | | | | | | | | | | base_test.rb The method itself got extracted out from ActiveRecored::Base in commit ceb33f84933639d3b61aac62e5e71fd087ab65ed, but the test code never did.
| * Extract AR::Core#inspect and AR::Core.inspect's test code from base_test.rbTakehiro Adachi2013-05-222-24/+33
| | | | | | | | | | The methods got moved to core.rb in commit b2c9ce341a1c907041f55461aefebb0321280cb5, but the tests never did.
* | reverse comparison because of strange AS behaviorAaron Patterson2013-05-211-1/+1
| | | | | | | | http://tenderlovemaking.com/2013/05/21/one-danger-of-freedom-patches.html
* | just set the default argument, a nil parent should be an errorAaron Patterson2013-05-211-2/+1
| |
* | fold the collection rather than multiple assigmentsAaron Patterson2013-05-211-3/+2
| |
* | use drop rather than calculate the array lengthAaron Patterson2013-05-211-1/+1
| |
* | Merge branch 'bindwhere'Aaron Patterson2013-05-212-20/+42
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | * bindwhere: avoid creating a set if no where values are removed remove bind values for where clauses that were removed push partitioning up so bind elimination can get the removed wheres push partion logic down and initialization logic up partition the where values so we can access the removed ones
| * | avoid creating a set if no where values are removedAaron Patterson2013-05-212-0/+14
| | |
| * | remove bind values for where clauses that were removedAaron Patterson2013-05-212-9/+18
| | |
| * | push partitioning up so bind elimination can get the removed wheresAaron Patterson2013-05-211-5/+3
| | |
| * | push partion logic down and initialization logic upAaron Patterson2013-05-211-15/+11
| | |
| * | partition the where values so we can access the removed onesAaron Patterson2013-05-201-1/+6
| |/
* | Merge pull request #10711 from senny/10660_rake_db_test_prepare_needs_configRafael Mendonça França2013-05-211-1/+1
|\ \ | | | | | | the rake task `db:test:prepare` needs to load the configuration
| * | the rake task `db:test:prepare` needs to load the configurationYves Senn2013-05-211-1/+1
| |/ | | | | | | Without loading the configuration the task will not perform any work.
* / In batches test @total was assigned but not used. Use it in tests instead of ↵Alexander Balashov2013-05-211-7/+5
|/ | | | Post.count
* eliminate some conditionalsAaron Patterson2013-05-201-3/+3
|
* change method name to reflect what it actually does.Aaron Patterson2013-05-201-2/+2
|
* save the where values in variables so we don't need to look them up allAaron Patterson2013-05-201-4/+5
| | | | the time
* pass where values to the helper function rather than rely on internal stateAaron Patterson2013-05-201-4/+4
|
* Merge pull request #10692 from vipulnsward/fix_test_3José Valim2013-05-191-1/+1
|\ | | | | Fix wrong `case_sensitive` in uniqueness validity test
| * Fix wrong `case_sensitive` in uniqueness validity testVipul A M2013-05-201-1/+1
| |
* | Fix typo in test name and documentationVipul A M2013-05-202-2/+2
|/
* Merge branch 'master' of github.com:lifo/docrailsVijay Dev2013-05-197-10/+42
|\
| * copy edits[ci skip]Vijay Dev2013-05-192-12/+9
| |
| * Added some more documentation for define_readers and define_writer of the ↵aditya-kapoor2013-05-153-0/+15
| | | | | | | | Association and its inherited classes
| * Added some more documentation for ↵aditya-kapoor2013-05-151-0/+11
| | | | | | | | ActiveRecord::Associations::Builder::Association class
| * Added documentation for ActiveRecord::Associations::Builder::Association classaditya-kapoor2013-05-151-0/+4
| |
| * improved doc for ActiveRecord#find_by_sql method (Refs #10599) [ci skip]Anton Kalyaev2013-05-141-3/+4
| |
| * Added documentation for model migration generationaditya-kapoor2013-05-141-0/+4
| |
| * emphasize that callbacks are called in destroy_allNeeraj Singh2013-05-132-7/+7
| | | | | | | | | | | | | | Cleaned up rdoc a bit emphasizing that callbacks are called. Also removed the stress on the fact that records are always removed. If callbacks return false then records will not be deleted.
* | Fxied some typosPrathamesh Sonpatki2013-05-181-1/+1
| |
* | Merge pull request #10676 from tkhr/add-test-to-counter_cache_test.rbRafael Mendonça França2013-05-185-4/+18
|\ \ | | | | | | Add test to counter cache test.rb
| * | Fix tests which started to fail due to commit ↵Takehiro Adachi2013-05-182-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | 0123c39f41e2062311b2197e6e230ef8ad67e20e Due to commit 0123c39f41e2062311b2197e6e230ef8ad67e20e, column topic.unique_replies_count has been added, and these test started to fail since the tests depends on the topic tables column info.
| * | Add test to AR's counter_cache_test.rbTakehiro Adachi2013-05-183-0/+14
| | | | | | | | | | | | | | | | | | | | | According to https://github.com/rails/rails/blob/b601399b72ab56cc01368f02615af99f45d1 4f02/activerecord/lib/active_record/counter_cache.rb#L14, u can pass more then one association to the `reset_counters` method.
* | | stop swallowing exceptions in assert_queries. Methods that raise anAaron Patterson2013-05-171-2/+2
| | | | | | | | | | | | | | | exception are unlikely to pass this assertion, but since the assertions raise an exception, the original exception is lost.
* | | stop doing assingments in an iteratorAaron Patterson2013-05-171-2/+6
| | |
* | | include bind values from the default scopeAaron Patterson2013-05-172-6/+5
|/ /
* | let Ruby do the is_a check for usAaron Patterson2013-05-161-3/+4
| |
* | test refactorAaron Patterson2013-05-161-5/+2
| |
* | Add more data to AR::UnknownAttributeErrorBogdan Gusiev2013-05-163-1/+22
| | | | | | | | | | | | | | | | | | begin Topic.new("hello" => "world") rescue ActiveRecord::UnknownAttributeError => e e.record # => #<Topic ... > e.attribute # => "hello" end
* | Merge pull request #10619 from alno/top_level_array_in_postgres_jsonAaron Patterson2013-05-163-1/+17
|\ \ | | | | | | Support array as root element in Postgresql JSON columns
| * | Support array as root element in JSONAlexey Noskov2013-05-143-1/+17
| | |
* | | Check if APP_RAKEFILE is definedPiotr Sarnacki2013-05-161-1/+1
| | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-04 17:21:20 +0000