Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
| * | | | Documentation for where and where! methods on relations. | David Paschich | 2012-06-18 | 1 | -0/+92 | |
| | | | | | | | | | | | | | | | | Based on examples seen in the Rails test suite. [ci skip] | |||||
* | | | | fix invalid syntax and sqlite rake failing tests | Francesco Rodriguez | 2012-06-18 | 4 | -6/+9 | |
| | | | | ||||||
* | | | | add :nodoc: to AR::Tasks and update to follow the coding conventions | Francesco Rodriguez | 2012-06-18 | 4 | -208/+226 | |
| | | | | ||||||
* | | | | check if sqlite3 file exists before remove | Francesco Rodriguez | 2012-06-18 | 1 | -3/+3 | |
| | | | | ||||||
* | | | | Merge pull request #6761 from freelancing-god/db-rake | Jon Leighton | 2012-06-17 | 10 | -156/+983 | |
|\ \ \ \ | | | | | | | | | | | Get logic out of db rake tasks, and into classes and objects | |||||
| * | | | | Rails is the default (but now override able) source for environment and path. | Pat Allan | 2012-06-17 | 4 | -43/+57 | |
| | | | | | ||||||
| * | | | | Cleaning up after some warnings, adding slightly higher-level tests. | Pat Allan | 2012-06-17 | 6 | -9/+309 | |
| | | | | | ||||||
| * | | | | One line db:create/db:drop tasks. | Pat Allan | 2012-06-17 | 2 | -55/+50 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Now isn't that better? And yes, I know that private has no impact on class methods - it's a visual distinction, not a technical one. | |||||
| * | | | | db:drop and some of db:test:purge. | Pat Allan | 2012-06-17 | 8 | -52/+243 | |
| | | | | | ||||||
| * | | | | db:create for PostgreSQL pulled out into a class. | Pat Allan | 2012-06-17 | 6 | -36/+99 | |
| | | | | | ||||||
| * | | | | db:create for MySQL now much cleaner. | Pat Allan | 2012-06-17 | 6 | -37/+230 | |
| | | | | | ||||||
| * | | | | Confirm connection is not established if file exists. | Pat Allan | 2012-06-17 | 1 | -1/+10 | |
| | | | | | ||||||
| * | | | | A beginning of sorts. | Pat Allan | 2012-06-17 | 4 | -12/+74 | |
| | | | | | | | | | | | | | | | | | | | | Minimal implementation that supports db:create SQLite replacement | |||||
* | | | | | Merge pull request #6759 from dylanahsmith/only-catch-standard-error | Santiago Pastorino | 2012-06-17 | 3 | -6/+6 | |
|\ \ \ \ \ | | | | | | | | | | | | | Avoid unnecessary catching of Exception instead of StandardError. | |||||
| * | | | | | Avoid unnecessary catching of Exception instead of StandardError. | Dylan Smith | 2012-06-17 | 3 | -6/+6 | |
| | | | | | | ||||||
* | | | | | | Adding `load_config` task as dependency. | Cairo Noleto | 2012-06-16 | 1 | -14/+14 | |
|/ / / / / | | | | | | | | | | | | | | | | Without this, some tasks won't load configurations like custom engines. | |||||
* | | | | | Don't read csv file during executing db:fixtures:load. | kennyj | 2012-06-17 | 1 | -1/+1 | |
| | | | | | ||||||
* | | | | | no need to define methods in included hook | Jon Leighton | 2012-06-15 | 1 | -13/+13 | |
| | | | | | ||||||
* | | | | | Fix deprecation warnings when using ↵ | Jon Leighton | 2012-06-15 | 2 | -3/+40 | |
| | | | | | | | | | | | | | | | | | | | | config.active_record.mass_assignment_sanitizer= | |||||
* | | | | | Fix observers with AR::Model | Jon Leighton | 2012-06-15 | 3 | -3/+6 | |
| | | | | | ||||||
* | | | | | Fix config.active_record.whitelist_attributes with AR::Model | Jon Leighton | 2012-06-15 | 3 | -3/+40 | |
| | | | | | ||||||
* | | | | | Simplify AR configuration code. | Jon Leighton | 2012-06-15 | 24 | -265/+348 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | Get rid of ActiveModel::Configuration, make better use of ActiveSupport::Concern + class_attribute, etc. | |||||
* | | | | | refactor | Jon Leighton | 2012-06-15 | 1 | -11/+5 | |
| |/ / / |/| | | | ||||||
* | | | | Remove unneded tests. | Rafael Mendonça França | 2012-06-14 | 1 | -11/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Before 7f4b0a1231bf3c65db2ad4066da78c3da5ffb01, this test are asserting that update_attribute does the dirty tracking. Since we remove this method and update_column write in the database directly this tests will always fail> | |||||
* | | | | Add CHANGELOG entry to the uuid datatype support to PostgreSQL adpter | Rafael Mendonça França | 2012-06-14 | 1 | -0/+2 | |
| | | | | ||||||
* | | | | Merge pull request #6713 from etehtsea/activerecord-uuid | Rafael Mendonça França | 2012-06-14 | 6 | -10/+39 | |
|\ \ \ \ | | | | | | | | | | | | | | | | Add uuid datatype support to PostgreSQL adapter | |||||
| * | | | | Add uuid type support to PostgreSQL adapter | Konstantin Shabanov | 2012-06-14 | 6 | -10/+39 | |
| | | | | | ||||||
* | | | | | registers the removal of update_attribute in the CHANGELOG | Xavier Noria | 2012-06-14 | 1 | -0/+6 | |
| | | | | | ||||||
* | | | | | Merge pull request #6738 from steveklabnik/master | Xavier Noria | 2012-06-14 | 7 | -87/+11 | |
|\ \ \ \ \ | |_|_|_|/ |/| | | | | Remove update_attribute. | |||||
| * | | | | Remove update_attribute. | Steve Klabnik | 2012-06-14 | 7 | -87/+11 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Historically, update_attribute and update_attributes are similar, but with one big difference: update_attribute does not run validations. These two methods are really easy to confuse given their similar names. Therefore, update_attribute is being removed in favor of update_column. See the thread on rails-core here: https://groups.google.com/forum/?fromgroups#!topic/rubyonrails-core/BWPUTK7WvYA | |||||
* | | | | | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-06-14 | 1 | -1/+1 | |
|\ \ \ \ \ | |/ / / / |/| | | | | ||||||
| * | | | | Fixed typo. | chrismcc | 2012-06-11 | 1 | -1/+1 | |
| | | | | | ||||||
* | | | | | removes item in the Active Record CHANGELOG | Xavier Noria | 2012-06-14 | 1 | -2/+0 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | That change to update_attribute was considered to be too subtle and was reverted in 30ea923 just before Rails 3 shipped. Later we introduced update_column (Rails 3.1). | |||||
* | | | | | Need a assert here in tests | Arun Agrawal | 2012-06-12 | 1 | -2/+2 | |
| | | | | | ||||||
* | | | | | Merge pull request #6676 from aurelian/master | Rafael Mendonça França | 2012-06-12 | 2 | -1/+5 | |
|\ \ \ \ \ | | | | | | | | | | | | | Don't assign the attributes if the list is empty | |||||
| * | | | | | Don't assign the attributes if the list is empty. | Aurelian Oancea | 2012-06-08 | 2 | -1/+5 | |
| | | | | | | ||||||
* | | | | | | Create hstore extension when building PostgreSQL databases. | kennyj | 2012-06-12 | 1 | -0/+10 | |
| |_|/ / / |/| | | | | ||||||
* | | | | | Remove warnings and unused code | Rafael Mendonça França | 2012-06-11 | 2 | -7/+2 | |
| | | | | | ||||||
* | | | | | No need to cache table metadata in advance now that #6683 was merged. | Rafael Mendonça França | 2012-06-11 | 2 | -16/+0 | |
| | | | | | ||||||
* | | | | | Merge pull request #6492 from pmahoney/fair-connection-pool2 | Rafael Mendonça França | 2012-06-11 | 5 | -38/+286 | |
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fair connection pool2 Conflicts: activerecord/test/cases/associations/eager_test.rb | |||||
| * | | | | | Make connection pool fair with respect to waiting threads. | Patrick Mahoney | 2012-05-25 | 4 | -38/+282 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The core of this fix is a threadsafe, fair Queue class. It is very similar to Queue in stdlib except that it supports waiting with a timeout. The issue this solves is that if several threads are contending for database connections, an unfair queue makes is possible that a thread will timeout even while other threads successfully acquire and release connections. A fair queue means the thread that has been waiting the longest will get the next available connection. This includes a few test fixes to avoid test ordering issues that cropped up during development of this patch. | |||||
| * | | | | | Cache metadata in advance to avoid extra sql statements while testing. | Yasuo Honda | 2012-05-25 | 1 | -0/+7 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Reason: If metadata is not cached extra sql statements will be executed, which causes failures tests with assert_queries(). | |||||
* | | | | | | Merge pull request #6709 from amatsuda/sqlite3_version_is_always_gt_125 | Rafael Mendonça França | 2012-06-11 | 1 | -1/+1 | |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | current AR::ConnectionAdapters::SQLite3Adapter supports only SQLite3 ~> 1.3.6 | |||||
| * | | | | | | current AR::ConnectionAdapters::SQLite3Adapter supports only SQLite3 ~> 1.3.6 | Akira Matsuda | 2012-06-12 | 1 | -1/+1 | |
| | | | | | | | ||||||
* | | | | | | | TimeZone format is always /[+-]\d{2}:\d{2}/ in Ruby 1.9 | Akira Matsuda | 2012-06-12 | 1 | -1/+1 | |
|/ / / / / / | ||||||
* | | | | | | Address ORA-00911 errors because of the heading underscore. | Yasuo Honda | 2012-06-11 | 2 | -2/+2 | |
| | | | | | | ||||||
* | | | | | | Fix that #exists? raises ThrowResult when called with an empty limited | Ben Woosley | 2012-06-10 | 2 | -1/+8 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | reflection. ActiveRecord::FinderMethods#construct_limited_ids_condition will raise ThrowResult if the limited reflection comes back empty. The other callers of #construct_limited_ids_condition handle this exception (more specifically, the callers of construct_relation_for*), but #exists? didn't until now. | |||||
* | | | | | | Remove bundle exec from the exception message | Rafael Mendonça França | 2012-06-10 | 1 | -1/+1 | |
| | | | | | | ||||||
* | | | | | | Add test to column alias in `exists?` SQL. | Rafael Mendonça França | 2012-06-10 | 2 | -1/+7 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This behavior was added in be4ecdcc87984e9421ff5d5c90d33f475e0fbc01. Closes #1139. Fixes #2553, #1141, #1623 and #2062. | |||||
* | | | | | | Minimal change to query generation of exists? that makes SQLServer and ↵ | iaddict | 2012-06-10 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | others happy that do not work without a column alias. Conflicts: activerecord/lib/active_record/relation/finder_methods.rb |