| Commit message (Collapse) | Author | Age | Files | Lines | ||
|---|---|---|---|---|---|---|
| ... | ||||||
| * | | | | adding requires for constant dependencies | Aaron Patterson | 2012-11-07 | 2 | -0/+6 | |
| | | | | | ||||||
| * | | | | Use flat_map when building AR order | Carlos Antonio da Silva | 2012-11-04 | 1 | -6/+4 | |
| |/ / / | ||||||
| * | | | Ensure nested attributes is restored in case of a test failure | Carlos Antonio da Silva | 2012-11-03 | 1 | -1/+1 | |
| | | | | ||||||
| * | | | Simplify query conditions a bit in nested attributes test | Carlos Antonio da Silva | 2012-11-03 | 1 | -5/+3 | |
| | | | | | | | | | | | | | Also refactor the test a bit. | |||||
| * | | | Check if the options value is present before to send the deprecation | Rafael Mendonça França | 2012-11-03 | 2 | -6/+8 | |
| | | | | | | | | | | | | | message | |||||
| * | | | Remove old comment | Rafael Mendonça França | 2012-11-02 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This comment is not valid since that `if` is there to make possible to do: remove_index :users, :name Instead of: remove_index :users, column: :name What is a valid use case. [ci skip] | |||||
| * | | | Deprecate passing a string as third argument of `add_index` | Rafael Mendonça França | 2012-11-02 | 3 | -0/+23 | |
| | | | | | | | | | | | | | | | | | | | | | | This was there due historical reasons since 7dc45818dc43c163700efc9896a0f3feafa31138 to give the user the possibility to create unique indexes passing "UNIQUE" as the third argument | |||||
| * | | | Raise an ArgumentError when passing an invalid option to add_index | Rafael Mendonça França | 2012-11-02 | 3 | -1/+14 | |
| | | | | | | | | | | | | | Closes #8104 | |||||
| * | | | Merge pull request #8106 from steveklabnik/fix_grammar | Carlos Antonio da Silva | 2012-11-02 | 1 | -1/+1 | |
| |\ \ \ | |/ / |/| | | Fixed grammar in migration pending error. | |||||
| | * | | Fixed grammar in migration pending error. | Steve Klabnik | 2012-11-02 | 1 | -1/+1 | |
| | | | | ||||||
| * | | | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-11-03 | 19 | -103/+161 | |
| |\ \ \ | |/ / |/| | | | | | | | | | | | | | | Conflicts: actionpack/lib/action_controller/metal/mime_responds.rb activerecord/lib/active_record/attribute_methods.rb guides/source/working_with_javascript_in_rails.md | |||||
| | * | | copy edits [ci skip] | Vijay Dev | 2012-11-03 | 1 | -6/+3 | |
| | | | | ||||||
| | * | | Revert "Updated activerecord test comments to new hash syntax" | Vijay Dev | 2012-11-03 | 2 | -4/+4 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 3b89052014c2bf3b8fbbcfb93f657a17dd7e7ca3. Reason: changes made to a test, albeit in commented lines - non-uniform change. [ci skip] | |||||
| | * | | This is comment for singular association. | kennyj | 2012-11-02 | 1 | -1/+1 | |
| | | | | ||||||
| | * | | update AR::ImmutableRelation documentation [ci skip] | Francesco Rodriguez | 2012-10-26 | 1 | -0/+14 | |
| | | | | ||||||
| | * | | fix a typo in comments to ActiveRecord::Associations::Association.stale_state | Andrii Dovgaliuk | 2012-10-24 | 1 | -1/+1 | |
| | | | | ||||||
| | * | | Migration of docs to 1.9 hash syntax | AvnerCohen | 2012-10-23 | 8 | -54/+54 | |
| | | | | ||||||
| | * | | Updated activerecord test comments to new hash syntax | AvnerCohen | 2012-10-23 | 2 | -4/+4 | |
| | | | | ||||||
| | * | | Another batch of hash syntax changes to comment, this time around, I tried ↵ | AvnerCohen | 2012-10-23 | 3 | -26/+26 | |
| | | | | | | | | | | | | | to keep 'output' messages untouched. | |||||
| | * | | Fixed typo on ActiveRecord nested_attributes. | Luis M | 2012-10-23 | 1 | -3/+3 | |
| | | | | ||||||
| | * | | Fix code example in AR::AttributeMethods::BeforeTypeCast. | Hendy Tanata | 2012-10-22 | 1 | -1/+1 | |
| | | | | ||||||
| | * | | Merge branch 'master' of https://github.com/lifo/docrails | Pablo Ifran | 2012-10-22 | 52 | -260/+729 | |
| | |\ \ | | | | | | | | | | | | | | | | | Conflicts: activerecord/lib/active_record/callbacks.rb | |||||
| | | * | | read_attribute is public [ci skip] | Francesco Rodriguez | 2012-10-21 | 1 | -1/+1 | |
| | | | | | ||||||
| | | * | | add docs to AR::AttributeMethods::BeforeTypeCast [ci skip] | Francesco Rodriguez | 2012-10-21 | 1 | -0/+23 | |
| | | | | | ||||||
| | | * | | improve AR::AttributeMethods documentation [ci skip] | Francesco Rodriguez | 2012-10-21 | 1 | -6/+10 | |
| | | | | | ||||||
| | | * | | fix typo and improve example [ci skip] | Francesco Rodriguez | 2012-10-21 | 1 | -1/+3 | |
| | | | | | ||||||
| | | * | | update AR::AttributeMethods::BeforeTypeCast docs [ci skip] | Francesco Rodriguez | 2012-10-21 | 1 | -0/+18 | |
| | | | | | ||||||
| | | * | | Fix AR::AttributeMethods#[] example [ci skip] | Francesco Rodriguez | 2012-10-21 | 1 | -1/+1 | |
| | | | | | ||||||
| | | * | | nodoc deprecated AR::Fixtures constant [ci skip] | Francesco Rodriguez | 2012-10-21 | 1 | -0/+1 | |
| | | | | | ||||||
| | * | | | Changeing some code-styles of the examples & fix a typo on dependent option | Pablo Ifran | 2012-10-22 | 1 | -18/+12 | |
| | | | | | ||||||
| * | | | | Fix issue with collection associations and first(n)/last(n) | Carlos Antonio da Silva | 2012-11-01 | 2 | -1/+16 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When calling first(n) or last(n) in a collection, Active Record was improperly trying to set the inverse of instance in case that option existed. This change was introduced by fdf4eae506fa9895e831f569bed3c4aa6a999a22. In such cases we don't need to do that "manually", since the way collection will be loaded will already handle that, so we just skip setting the inverse association when any argument is given to first(n)/last(n). The test included ensures that these scenarios will have the inverse of instance set properly. Fixes #8087, Closes #8094. Squashed cherry-pick from d37d40b and c368b66. Conflicts: activerecord/CHANGELOG.md activerecord/lib/active_record/associations/collection_association.rb | |||||
| * | | | | Revert "Don't allocate new strings in compiled attribute methods" | David Heinemeier Hansson | 2012-10-31 | 2 | -39/+20 | |
| | | | | | | | | | | | | | | | | | This reverts commit f1765019ce9b6292f2264b4601dad5daaffe3a89. | |||||
| * | | | | Remove extre count, preheat already happens during setup | Carlos Antonio da Silva | 2012-10-31 | 1 | -1/+0 | |
| | | | | | ||||||
| * | | | | Fix find_in_batches against string IDs when start option is not specified. | Alexis Bernard | 2012-10-31 | 3 | -2/+15 | |
| | | | | | ||||||
| * | | | | Fix `attributes_before_type_cast` for serialised attributes. | Nikita Afanasenko | 2012-10-31 | 3 | -3/+27 | |
| | | | | | | | | | | | | | | | | | Public method `attributes_before_type_cast` used to return internal AR structure (ActiveRecord::AttributeMethods::Serialization::Attribute), patch fixes this. Now behaves like `read_attribute_before_type_cast` and returns unserialised values. | |||||
| * | | | | Fix #6951. Use query cache/uncache, when using not only database.yml but ↵ | kennyj | 2012-10-31 | 3 | -6/+22 | |
| | | | | | | | | | | | | | | | | | also DATABASE_URL. | |||||
| * | | | | include_root_in_json allows inheritance. | kennyj | 2012-10-31 | 2 | -1/+16 | |
| | | | | | ||||||
| * | | | | Make caller attribute in deprecation methods optional | Alexey Gaziev | 2012-10-30 | 9 | -14/+12 | |
| | | | | | ||||||
| * | | | | Remove not assigned variable warning from sqlite3 adapter test | Carlos Antonio da Silva | 2012-10-29 | 1 | -1/+1 | |
| | | | | | ||||||
| * | | | | Fix bug when Column is trying to type cast boolean values to integer. | Rafael Mendonça França | 2012-10-29 | 2 | -6/+17 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This can occur if the user is using :integer columns to store boolean values. Now we are handling the boolean values but it still raises if the value can't type cast to integer and is not a boolean. See #7509. Fixes #8067. Conflicts: activerecord/CHANGELOG.md | |||||
| * | | | | Provide a call stack for deprecation warnings where needed. | Nikita Afanasenko | 2012-10-29 | 9 | -17/+21 | |
| | | | | | | | | | | | | | | | | | It's sometimes hard to quickly find where deprecated call was performed, especially in case of migrating between Rails versions. So this is an attempt to improve the call stack part of the warning message by providing caller explicitly. | |||||
| * | | | | Fix the skip code. | Rafael Mendonça França | 2012-10-28 | 1 | -4/+4 | |
| | | | | | | | | | | | | | | | | | Checking for the constant doesn't work | |||||
| * | | | | SQLite3Adapter#type_cast should not mutate arguments | Stefan Rusterholz | 2012-10-28 | 2 | -1/+7 | |
| | | | | | ||||||
| * | | | | ActiveRecord::Relation#none! method. | Juanjo Bazán | 2012-10-28 | 3 | -0/+16 | |
| | | | | | ||||||
| * | | | | loaded relations cannot be mutated by extending! | Juanjo Bazán | 2012-10-28 | 1 | -0/+9 | |
| | | | | | ||||||
| * | | | | Enable update_column(s) for the primary key attribute. | Henrik N | 2012-10-28 | 3 | -1/+20 | |
| | | | | | | | | | | | | | | | | | Didn't work before because it updated the model-in-memory first, so the DB query couldn't find the record. | |||||
| * | | | | raise `ArgumentError` when redefining the primary key column. Closes #6378 | Yves Senn | 2012-10-28 | 3 | -0/+34 | |
| | | | | | ||||||
| * | | | | refactor `SQLite3Adapter#copy_table` to prevent primary key redefinitions. #6378 | Yves Senn | 2012-10-28 | 2 | -6/+11 | |
| | | | | | ||||||
| * | | | | AR::AttributeMethods#[] raises AM::AttributeMissingError for missing attributes. | Francesco Rodriguez | 2012-10-28 | 3 | -3/+38 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes the following behaviour: class Person < ActiveRecord::Base belongs_to :company end # Before: person = Person.select('id').first person[:name] # => nil person.name # => ActiveModel::MissingAttributeError: missing_attribute: name person[:company_id] # => nil person.company # => nil # After: person = Person.select('id').first person[:name] # => ActiveModel::MissingAttributeError: missing_attribute: name person.name # => ActiveModel::MissingAttributeError: missing_attribute: name person[:company_id] # => ActiveModel::MissingAttributeError: missing_attribute: company_id person.company # => ActiveModel::MissingAttributeError: missing_attribute: company_id Fixes #5433. | |||||
| * | | | | Don't log on pending migration check | schneems | 2012-10-28 | 1 | -1/+3 | |
| | | | | | | | | | | | | | | | | | | | | | Conversation from: #6665 cc/ @rafaelfranca | |||||
 |
index : rails.git | |
| Mirror of official rails repo with custom fixes. | Harald Eilertsen |
| aboutsummaryrefslogtreecommitdiffstats |
path: root/activerecord