Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | push partion logic down and initialization logic up | Aaron Patterson | 2013-05-21 | 1 | -15/+11 |
| | |||||
* | partition the where values so we can access the removed ones | Aaron Patterson | 2013-05-20 | 1 | -1/+6 |
| | |||||
* | eliminate some conditionals | Aaron Patterson | 2013-05-20 | 1 | -3/+3 |
| | |||||
* | change method name to reflect what it actually does. | Aaron Patterson | 2013-05-20 | 1 | -2/+2 |
| | |||||
* | save the where values in variables so we don't need to look them up all | Aaron Patterson | 2013-05-20 | 1 | -4/+5 |
| | | | | the time | ||||
* | pass where values to the helper function rather than rely on internal state | Aaron Patterson | 2013-05-20 | 1 | -4/+4 |
| | |||||
* | Merge pull request #10692 from vipulnsward/fix_test_3 | José Valim | 2013-05-19 | 1 | -1/+1 |
|\ | | | | | Fix wrong `case_sensitive` in uniqueness validity test | ||||
| * | Fix wrong `case_sensitive` in uniqueness validity test | Vipul A M | 2013-05-20 | 1 | -1/+1 |
| | | |||||
* | | Fix typo in test name and documentation | Vipul A M | 2013-05-20 | 2 | -2/+2 |
|/ | |||||
* | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2013-05-19 | 7 | -10/+42 |
|\ | |||||
| * | copy edits[ci skip] | Vijay Dev | 2013-05-19 | 2 | -12/+9 |
| | | |||||
| * | Added some more documentation for define_readers and define_writer of the ↵ | aditya-kapoor | 2013-05-15 | 3 | -0/+15 |
| | | | | | | | | Association and its inherited classes | ||||
| * | Added some more documentation for ↵ | aditya-kapoor | 2013-05-15 | 1 | -0/+11 |
| | | | | | | | | ActiveRecord::Associations::Builder::Association class | ||||
| * | Added documentation for ActiveRecord::Associations::Builder::Association class | aditya-kapoor | 2013-05-15 | 1 | -0/+4 |
| | | |||||
| * | improved doc for ActiveRecord#find_by_sql method (Refs #10599) [ci skip] | Anton Kalyaev | 2013-05-14 | 1 | -3/+4 |
| | | |||||
| * | Added documentation for model migration generation | aditya-kapoor | 2013-05-14 | 1 | -0/+4 |
| | | |||||
| * | emphasize that callbacks are called in destroy_all | Neeraj Singh | 2013-05-13 | 2 | -7/+7 |
| | | | | | | | | | | | | | | Cleaned up rdoc a bit emphasizing that callbacks are called. Also removed the stress on the fact that records are always removed. If callbacks return false then records will not be deleted. | ||||
* | | Fxied some typos | Prathamesh Sonpatki | 2013-05-18 | 1 | -1/+1 |
| | | |||||
* | | Merge pull request #10676 from tkhr/add-test-to-counter_cache_test.rb | Rafael Mendonça França | 2013-05-18 | 5 | -4/+18 |
|\ \ | | | | | | | Add test to counter cache test.rb | ||||
| * | | Fix tests which started to fail due to commit ↵ | Takehiro Adachi | 2013-05-18 | 2 | -4/+4 |
| | | | | | | | | | | | | | | | | | | | | | | | | 0123c39f41e2062311b2197e6e230ef8ad67e20e Due to commit 0123c39f41e2062311b2197e6e230ef8ad67e20e, column topic.unique_replies_count has been added, and these test started to fail since the tests depends on the topic tables column info. | ||||
| * | | Add test to AR's counter_cache_test.rb | Takehiro Adachi | 2013-05-18 | 3 | -0/+14 |
| | | | | | | | | | | | | | | | | | | | | | According to https://github.com/rails/rails/blob/b601399b72ab56cc01368f02615af99f45d1 4f02/activerecord/lib/active_record/counter_cache.rb#L14, u can pass more then one association to the `reset_counters` method. | ||||
* | | | stop swallowing exceptions in assert_queries. Methods that raise an | Aaron Patterson | 2013-05-17 | 1 | -2/+2 |
| | | | | | | | | | | | | | | | exception are unlikely to pass this assertion, but since the assertions raise an exception, the original exception is lost. | ||||
* | | | stop doing assingments in an iterator | Aaron Patterson | 2013-05-17 | 1 | -2/+6 |
| | | | |||||
* | | | include bind values from the default scope | Aaron Patterson | 2013-05-17 | 2 | -6/+5 |
|/ / | |||||
* | | let Ruby do the is_a check for us | Aaron Patterson | 2013-05-16 | 1 | -3/+4 |
| | | |||||
* | | test refactor | Aaron Patterson | 2013-05-16 | 1 | -5/+2 |
| | | |||||
* | | Add more data to AR::UnknownAttributeError | Bogdan Gusiev | 2013-05-16 | 3 | -1/+22 |
| | | | | | | | | | | | | | | | | | | begin Topic.new("hello" => "world") rescue ActiveRecord::UnknownAttributeError => e e.record # => #<Topic ... > e.attribute # => "hello" end | ||||
* | | Merge pull request #10619 from alno/top_level_array_in_postgres_json | Aaron Patterson | 2013-05-16 | 3 | -1/+17 |
|\ \ | | | | | | | Support array as root element in Postgresql JSON columns | ||||
| * | | Support array as root element in JSON | Alexey Noskov | 2013-05-14 | 3 | -1/+17 |
| | | | |||||
* | | | Check if APP_RAKEFILE is defined | Piotr Sarnacki | 2013-05-16 | 1 | -1/+1 |
| | | | |||||
* | | | Fix detection of engine in rake db:load_config | Joel Cogen | 2013-05-16 | 1 | -1/+1 |
| | | | | | | | | | | | | Broken by d1d7c86d0c8dcb7e75a87644b330c4e9e7d6c1c1 | ||||
* | | | tiny types should only be integers when the length is <= 1. fixes #10620 | Aaron Patterson | 2013-05-15 | 1 | -3/+9 |
| | | | |||||
* | | | add failing test exposing mysql adapter tinyint bug | phinze | 2013-05-15 | 1 | -3/+16 |
| | | | | | | | | | | | | | | | | | | in myself, a column with type TINYINT(N) where N > 1 can be used to represent an integer, but the rails mysql adapter refuses to interpret as anything but a boolean. | ||||
* | | | require things we need | Aaron Patterson | 2013-05-15 | 1 | -0/+1 |
| | | | |||||
* | | | Merge pull request #10504 from kennyj/support_pg_91 | Rafael Mendonça França | 2013-05-15 | 3 | -6/+8 |
|\ \ \ | | | | | | | | | Also should supports PostgreSQL 9.1 about extensions. | ||||
| * | | | Remove unnecessary code, because this extension is created on demand in ↵ | kennyj | 2013-05-15 | 1 | -2/+0 |
| | | | | | | | | | | | | | | | | hstore_test.rb. | ||||
| * | | | Also support extensions in PostgreSQL 9.1, because this has been supported ↵ | kennyj | 2013-05-15 | 2 | -4/+8 |
| | | | | | | | | | | | | | | | | since 9.1. | ||||
* | | | | Merge pull request #10601 from Ichimonji10/fix-docs | Rafael Mendonça França | 2013-05-15 | 1 | -15/+27 |
|\ \ \ \ | |/ / / |/| | | | Rewrite `activerecord/RUNNING_UNIT_TESTS.rdoc` | ||||
| * | | | Rewrite `activerecord/RUNNING_UNIT_TESTS` | Jeremy Audet | 2013-05-15 | 1 | -15/+27 |
| |/ / | | | | | | | | | | | | | | | | | | | `RUNNING_UNIT_TESTS` is written in an unclear and confusing manner. This commit attempts to correct that. Thanks to zzak and vipulnsward for feedback. | ||||
* | | | deprecating string based terminators | Aaron Patterson | 2013-05-14 | 1 | -1/+3 |
| | | | |||||
* | | | Merge branch 'master' into normalizecb | Aaron Patterson | 2013-05-13 | 17 | -50/+137 |
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * master: (61 commits) add tests for reset_calbacks Fixing build broken by this change Extract variable out of loop Updated comment to Rails 4 Fixes NoMethodError: `alias_method_chain` when requiring just active_support/core_ext better error message when app name is not passed in `rails new` Code cleanup for ActionDispatch::Flash#call Fix typo: require -> requires Add CHANGELOG entry for #10576 Merge pull request #10556 from Empact/deprecate-schema-statements-distinct Some editorial changes on the documentation. respond_to -> respond to in a message from AM::Lint specify that dom_(id|class) are deprecated in controllers, views are fine copy edits [ci skip] Fix class and method name typos Replace multi_json with json ruby -> Ruby Adding documentation to the automatic inverse_of finder. Improve CHANGELOG entry [ci kip] Call assume_migrated_upto_version on connection ... Conflicts: activesupport/lib/active_support/callbacks.rb | ||||
| * | | Merge pull request #10577 from vipulnsward/fix_method_typos | Rafael Mendonça França | 2013-05-12 | 3 | -3/+3 |
| |\ \ | | | | | | | | | Fix class and method name typos | ||||
| | * | | Fix class and method name typos | Vipul A M | 2013-05-12 | 3 | -3/+3 |
| | | | | |||||
| * | | | Merge pull request #10556 from Empact/deprecate-schema-statements-distinct | Rafael Mendonça França | 2013-05-12 | 3 | -13/+31 |
| | | | | | | | | | | | | | | | | | | | | | | | | Deprecate SchemaStatements#distinct, and make SchemaStatements#columns_for_distinct nodoc. Conflicts: activerecord/CHANGELOG.md | ||||
| * | | | Some editorial changes on the documentation. | Rafael Mendonça França | 2013-05-12 | 2 | -27/+27 |
| | |/ | |/| | | | | | | | | | | | | | | | | | | | * Remove some autolinks * Fix the rendered result * Change sql to SQL [ci skip] | ||||
| * | | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2013-05-12 | 5 | -5/+13 |
| |\ \ | | |/ | |/| | | | | | | | Conflicts: activesupport/lib/active_support/callbacks.rb | ||||
| | * | copy edits [ci skip] | Vijay Dev | 2013-05-12 | 1 | -5/+1 |
| | | | |||||
| | * | Added documentation for ↵ | aditya-kapoor | 2013-05-10 | 1 | -0/+4 |
| | | | | | | | | | | | | ActiveRecord::Generators::MigrationGenerator.next_migration_number | ||||
| | * | Added documentation for ActiveRecord::Base#next_migration_number | aditya-kapoor | 2013-05-09 | 1 | -0/+5 |
| | | | |||||
| | * | minor rdoc cleanup for reflection methods | Neeraj Singh | 2013-05-09 | 1 | -4/+4 |
| | | |