aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | | Skips linked folder tests if symlink is invalidMikko Johansson2014-02-091-2/+6
| |/ / / |/| | |
* | | | Add test case for autosave HasMany with accepts_nested_attributes.Lauro Caetano2014-02-083-0/+33
| | | | | | | | | | | | | | | | | | | | | | | | | | | | It should not save the parent record when the nested attributes are invalid. Test case to cover #8194.
* | | | Adjust test value so that timezone has no effectAndrew White2014-02-071-1/+1
|/ / / | | | | | | | | | | | | | | | If the test is run in a timezone that is behind UTC it fails because the time generated is ahead of 0000-01-01 00:00:00. Just increase the time subtracted so that timezone has no effect.
* | | Merge branch 'dump-schema-after-migration-flag' of ↵Xavier Noria2014-02-063-1/+18
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | git://github.com/emilsoman/rails into emilsoman-dump-schema-after-migration-flag Conflicts: activerecord/CHANGELOG.md
| * | | Add config to disable schema dump after migrationEmil Soman2014-02-063-1/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Add a config on Active Record named `dump_schema_after_migration` * Schema dump doesn't happen if the config is set to false * Set default value of the config to true * Set config in generated production environment file to false * Update configuration guide * Update CHANGELOG
* | | | synchronize 4.1 release notes with CHANGELOGS. [ci skip]Yves Senn2014-02-061-9/+13
| | | | | | | | | | | | | | | | /cc @chancancode
* | | | Return sized enumerator from Enumerable#index_byMarc-Andre Lafortune2014-02-051-6/+1
| | | |
* | | | Return sized enumerator from Batches#find_eachMarc-Andre Lafortune2014-02-055-3/+25
| | | |
* | | | Return sized enumerator from Batches#find_in_batchesMarc-Andre Lafortune2014-02-053-4/+25
| | | |
* | | | Strengthen test with different nb of rows and columnsMarc-Andre Lafortune2014-02-051-2/+4
| | | |
* | | | Merge pull request #13949 from vajrasky/fix_typo_column_definition_testYves Senn2014-02-051-2/+2
|\ \ \ \ | | | | | | | | | | Fixed typos in column_definition_test.rb.
| * | | | Fixed typo in column_definition_test.rb.Vajrasky Kok2014-02-051-2/+2
| | | | |
* | | | | docs, AR already auto-detects primary keys. Closes #13946. [ci skip]Yves Senn2014-02-053-6/+8
|/ / / / | | | | | | | | | | | | | | | | This behavior was introduced since Rails 3.1 (207f266ccaaa9cd04cd2a7513ae5598c4358b510) but the docs were still out of date.
* / / / Document that enum conditions must use the ordinal valueRafael Mendonça França2014-02-041-0/+2
|/ / / | | | | | | | | | [ci skip]
* | | Add CHANGELOG entry for #13935 [ci skip]Rafael Mendonça França2014-02-041-0/+9
| | |
* | | Merge pull request #13935 from arthurnn/fix_12566Rafael Mendonça França2014-02-042-1/+16
|\ \ \ | | | | | | | | Make sure transaction state resets after commit
| * | | Make sure transaction state resets after commitArthur Neves2014-02-032-1/+16
| | | | | | | | | | | | | | | | [fixes #12566]
* | | | Merge pull request #13899 from ↵Rafael Mendonça França2014-02-042-1/+11
|\ \ \ \ | |/ / / |/| | | | | | | | | | | Fortisque/kevin/active_record_HABTM_with_belongs_to destruction errors out on HABTM w/out primary key
| * | | fix HABTM w/out primary key errors on destructionKevin Casey2014-02-022-1/+11
| | | |
* | | | some wording format changes. [ci skip]Yves Senn2014-02-032-6/+6
| | | |
* | | | pass `habtm :autosave` to underlying `hm:t` association. Closes #13923.Yves Senn2014-02-034-8/+35
| | | |
* | | | docs, revisit polymorphic associations with STI example. [ci skip]Yves Senn2014-02-031-2/+5
| | | | | | | | | | | | | | | | | | | | | | | | This is a follow up to #13926. /cc @fxn
* | | | Fixes the camelCase variable name in the docs [ci skip]Fred Wu2014-02-031-2/+2
| | | |
* | | | Remove warnings for already defined methodsRafael Mendonça França2014-02-011-1/+3
| | | |
* | | | Make arel methods private APIRafael Mendonça França2014-02-012-6/+5
| | | | | | | | | | | | | | | | | | | | | | | | Since its conception arel was made to be private API of Active Record. If users want to use arel features directly we should provide a way using the Active Record API without exposing the arel implementation.
* | | | Merge pull request #13688 from jbaudanza/psql-index-existsRafael Mendonça França2014-02-013-0/+35
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PostgreSQL implementation of SchemaStatements#index_name_exists? Conflicts: activerecord/CHANGELOG.md
| * | | | psql implementation of #index_name_exists?Jonathan Baudanza2014-01-163-0/+35
| | | | |
* | | | | Fixes issue with parsing whitespace content back from database - fixes #13907Mauricio Linhares2014-02-013-2/+26
| | | | |
* | | | | this class depends on JoinHelper, so we should require itAaron Patterson2014-01-311-0/+2
| |/ / / |/| | |
* | | | Minor changelog improvements [ci skip]Carlos Antonio da Silva2014-01-311-4/+4
| | | |
* | | | Merge pull request #13896 from laurocaetano/dangerous_association_namesCarlos Antonio da Silva2014-01-315-0/+52
|\ \ \ \ | | | | | | | | | | Associations now raises `ArgumentError` on name conflicts. Closes #13217.
| * | | | Associations now raise `ArgumentError` on name conflicts.Lauro Caetano2014-01-315-0/+52
| | | | | | | | | | | | | | | | | | | | | | | | | Dangerous association names conflicts include instance or class methods already defined by `ActiveRecord::Base`.
* | | | | Remove unused variable.Tim Fenney2014-01-311-1/+1
|/ / / /
* | | | Merge pull request #13859 from huoxito/let-it-goRafael Mendonça França2014-01-302-2/+10
|\ \ \ \ | | | | | | | | | | Let `unscope` ignore non Arel scope.where_values
| * | | | Let `unscope` ignore non Arel scope.where_valuesWashington Luiz2014-01-302-2/+10
| | | | |
* | | | | Merge pull request #13886 from arthurnn/fix_relation_arelRafael Mendonça França2014-01-308-18/+52
|\ \ \ \ \ | |/ / / / |/| | | | Fix regression on .select method
| * | | | Fix regression on `.select_*` methods.Arthur Neves2014-01-308-18/+52
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This was a common pattern: ``` query = author.posts.select(:title) connection.select_one(query) ``` However `.select` returns a ActiveRecord::AssociationRelation, which has the bind information, so we can use that to get the right sql query. Also fix select_rows on postgress and sqlite3 that were not using the binds [fixes #7538] [fixes #12017] [related #13731] [related #12056]
* | | | | Remove automatic removal of Date/Time stubs after each test caseRafael Mendonça França2014-01-301-1/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This behavior is only work out-of-box with minitest and also add a downside to run after each test case, even if we don't used the travel or travel_to methods
* | | | | Merge pull request #13878 from marcandre/leave_my_options_aloneRafael Mendonça França2014-01-302-2/+8
|\ \ \ \ \ | | | | | | | | | | | | find_in_batches should not mutate its argument
| * | | | | find_in_batches should not mutate its argumentMarc-Andre Lafortune2014-01-292-2/+8
| | | | | |
* | | | | | docs, `references` is only used with `includes`. Closes #13727.Yves Senn2014-01-301-9/+14
| |/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | There is no gain in `referencing` tables that are not used for preloading. Furthermore it will break if polymorphic associations are invloved. This is because `references_eager_loaded_tables?` uses all `reference_values` to decide wether to `eager_load` or `preload`.
* | | | | AestheticRafael Mendonça França2014-01-293-13/+13
| | | | |
* | | | | Fixing issue with activerecord serialization not being able to dump a record ↵Mauricio Linhares2014-01-295-1/+52
|/ / / / | | | | | | | | | | | | after loading it from YAML - fixes #13861
* | | | Merge pull request #13201 from marcandre/find_in_batch_enumeratorRafael Mendonça França2014-01-293-0/+27
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `find_in_batches` now returns an `Enumerator` Conflicts: activerecord/CHANGELOG.md activerecord/lib/active_record/relation/batches.rb
| * | | | `find_in_batches` now returns an `Enumerator` when called without a block, ↵Marc-Andre Lafortune2013-12-063-0/+27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | so that it can be chained with other `Enumerable` methods.
* | | | | Mention find_each in find_in_batches doc [ci skip]Marc-Andre Lafortune2014-01-291-0/+2
| | | | |
* | | | | `enum` now raises on "dangerous" name conflictsGodfrey Chan2014-01-293-3/+113
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Dangerous name conflicts includes instance or class method conflicts with methods defined within `ActiveRecord::Base` but not its ancestors, as well as conflicts with methods generated by other enums on the same class. Fixes #13389.
* | | | | `scope` now raises on "dangerous" name conflictsGodfrey Chan2014-01-294-4/+95
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Similar to dangerous attribute methods, a scope name conflict is dangerous if it conflicts with an existing class method defined within `ActiveRecord::Base` but not its ancestors. See also #13389. *Godfrey Chan*, *Philippe Creux*
* | | | | Fixed a bug in AR::Base#respond_to?Godfrey Chan2014-01-292-2/+11
| |_|/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Before: >> ActiveRecord::Base.respond_to?(:find_by_something) NoMethodError: undefined method `abstract_class?' for Object:Class After: >> ActiveRecord::Base.respond_to?(:find_by_something) => false
* | | | Correctly send the string given to lock! and reload(:lock) to the lock scope ↵Mauricio Linhares2014-01-293-1/+22
| | | | | | | | | | | | | | | | | | | | | | | | - fixes #13788 As per the documentation at lock!, if the :lock option is a string it should use the given SQL to generate the lock statement.
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-05 01:47:51 +0000