aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
Commit message (Collapse)AuthorAgeFilesLines
* Update callbacks executed on AR::Base#touch [skip ci]Washington Luiz2014-03-141-2/+2
| | | | | As of https://github.com/rails/rails/pull/12031 after_commit and after_rollback are also executed
* Avoid duplicated conditionalsCarlos Antonio da Silva2014-03-141-2/+1
|
* No need to binds be optionalRafael Mendonça França2014-03-131-2/+2
|
* Merge pull request #14372 from arthurnn/fix_query_cache_bindsRafael Mendonça França2014-03-134-12/+24
|\ | | | | Make select_all on query cache accept a Relation without binds.
| * Make select_all on query cache accept a Relation without binds.Arthur Neves2014-03-134-12/+24
| | | | | | | | | | [fixes #14361] [related #13886]
* | Add test for deprecation warning for passing an AR object to `find`.Lauro Caetano2014-03-131-0/+6
| |
* | Test deprecation warning for passing an ActiveRecord object toLauro Caetano2014-03-131-0/+6
|/ | | | `exists?`
* passing an instance of an AR object to `find` is deprecatedAaron Patterson2014-03-135-6/+13
| | | | please pass the id of the AR object by calling `.id` on the model first.
* passing an ActiveRecord object to `exists?` is deprecated.Aaron Patterson2014-03-135-4/+14
| | | | | Pass the id of the object to the method by calling `.id` on the AR object.
* make tests pass on Ruby 2.2Aaron Patterson2014-03-131-4/+4
| | | | | | Apparently we've been using a buggy feature for the past 6 years: https://bugs.ruby-lang.org/issues/9593
* Use Sqlite3 adapter in examplesJulian Simioni2014-03-121-2/+2
| | | | | | | | | | | | | | | | Two bits of example code use sqlite as an adapter, which doesn't exist. Using the code verbatim will raise a LoadError exception: ActiveRecord::Base.establish_connection( "adapter" => "sqlite", "database" => "db.sqlite" ) # => LoadError: Could not load 'active_record/connection_adapters/sqlite_adapter'... Considering this is code a lot of people new to Rails might be running, it's especially confusing. Closes #14367 [ci skip]
* Merge pull request #14364 from why-el/better-docs-for-update-attributeArthur Nogueira Neves2014-03-121-0/+2
|\ | | | | Enhance docs for update_attribute [skip ci]
| * Enhance docs for update_attribute [ci-skip]Mohamed Wael Khobalatte2014-03-121-0/+2
| |
* | Change usec to 0 on tests that compare secondsArthur Neves2014-03-121-3/+3
| | | | | | | | | | Avoid rounding problems with `.usec` method rounding the seconds when the field doesn't persist the `.usec` piece.
* | Unit test for mysql quote time usecArthur Neves2014-03-121-0/+7
|/
* Merge pull request #13040 from kamipo/case_sensitive_comparisonRafael Mendonça França2014-03-126-6/+62
|\ | | | | | | | | | | | | Only use BINARY for mysql case sensitive uniqueness check when column has a case insensitive collation. Conflicts: activerecord/CHANGELOG.md
| * Only use BINARY for mysql case sensitive uniqueness check when column has a ↵Ryuta Kamizono2013-11-266-6/+62
| | | | | | | | case insensitive collation.
* | Changelog entry for mysql56 microsecondsArthur Neves2014-03-121-0/+4
| |
* | Test microsecond on mysql 5.6Arthur Neves2014-03-123-2/+11
| |
* | MySQL 5.6 and later supports microsecond precision in datetime.Tatsuhiko Miyagawa2014-03-121-0/+8
| | | | | | | | | | You might want to branch it to include this only for 5.6, but passing these values to < 5.6 doesn't cause issues either.
* | Remove mocking on save, when not necessaryArthur Neves2014-03-111-3/+1
| |
* | Merge pull request #14345 from arthurnn/revert_14052Godfrey Chan2014-03-112-3/+16
|\ \ | | | | | | Fixes STI when 2+ levels deep.
| * | Fixes STI when 2+ levels deep.Arthur Neves2014-03-102-3/+16
| | | | | | | | | | | | | | | | | | PR #14052 Added a regression where it was only looking for methods in one level up, So when the method was defined in a 2+ levels up the inheritance chain, the method was not found as defined.
* | | `change_table` supports `citext`. Follow up to #12523.Yves Senn2014-03-112-8/+31
| | |
* | | register OID for PostgreSQL citex datatype [Troy Kruthoff & Lachlan Sylvester]lsylvester2014-03-116-2/+89
|/ / | | | | | | citext makes it possible to use AR Hash finders for case-insensitive matching as sql UPPER/LOWER functions are not needed.
* | Merge pull request #8313 from alan/only_save_changed_has_one_objectsRafael Mendonça França2014-03-103-2/+24
|\ \ | | | | | | | | | | | | | | | | | | Save has_one associations only if record has changes Conflicts: activerecord/CHANGELOG.md
| * | Save has_one associations only if record has changesAlan Kennedy2013-10-313-2/+24
| | | | | | | | | | | | | | | | | | Prevents save related callbacks such as `after_commit` being triggered when `has_one` objects are already persisted and have no changes.
* | | current_adapter? accepts multiple argumentsRafael Mendonça França2014-03-101-2/+2
| | |
* | | mysql adapter also fails with a number bigger than intRafael Mendonça França2014-03-101-2/+5
| | |
* | | Change the assertions depending in the database adapterRafael Mendonça França2014-03-101-14/+9
| | | | | | | | | | | | This will avoid the confusing flunk logic
* | | Do proper adapter checkRafael Mendonça França2014-03-101-2/+2
| | |
* | | WhitespacesRafael Mendonça França2014-03-101-2/+2
| | |
* | | Cleanup Parrot after each test.Guo Xiang Tan2014-03-091-7/+3
| | |
* | | Merge pull request #14262 from sferik/flat_mapAndrew White2014-03-095-8/+8
|\ \ \ | | | | | | | | Replace additional instances of map.flatten with flat_map
| * | | Replace map.flatten with flat_map in activerecordErik Michaels-Ober2014-03-035-8/+8
| | | |
* | | | Merge branch 'master' of github.com:rails/docrailsVijay Dev2014-03-071-4/+5
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | Conflicts: guides/source/4_1_release_notes.md
| * | | | fix typo app -> alldmathieu2014-03-071-1/+1
| | | | | | | | | | | | | | | | | | | | Thank you @bquorning
| * | | | unscope doesn't remove only the default_scope, but all of them.dmathieu2014-03-071-4/+5
| | | | | | | | | | | | | | | | | | | | | | | | | [ci-skip] Closes rails/rails#14294
* | | | | Introduce `Rails.gem_version`Prem Sichanugrist2014-03-052-7/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This method return `Gem::Version.new(Rails.version)`, suggesting a more reliable way to perform version comparison. Example: Rails.version #=> "4.1.2" Rails.gem_version #=> #<Gem::Version "4.1.2"> Rails.version > "4.1.10" #=> false Rails.gem_version > Gem::Version.new("4.1.10") #=> true Gem::Requirement.new("~> 4.1.2") =~ Rails.gem_version #=> true This was originally introduced as `.version` by @charliesome in #8501 but got reverted in #10002 since it was not backward compatible. Also, updating template for `rake update_versions`.
* | | | | Remove a reference to an issue [ci skip]Robin Dupret2014-03-051-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | This actually not an issue fixing ; the changelog is referring to the introducing pull request itself.
* | | | | get rid of intermediate arrays.Yves Senn2014-03-051-2/+3
| | | | | | | | | | | | | | | | | | | | origin: https://github.com/rails/rails/commit/f6aeb8b1a3687c8523e4a56309fe3736011b2935#commitcomment-5569649
* | | | | we only need to support `asc` and `ASC`. No need for mixed cases. #14263Yves Senn2014-03-052-34/+25
| | | | | | | | | | | | | | | | | | | | This is a result of the discussion at https://github.com/rails/rails/pull/14263/files#r10291489
* | | | | quick pass over Active Record CHANGELOG. [ci skip].Yves Senn2014-03-051-13/+10
| | | | |
* | | | | Merge pull request #14263 from robin850/allow_passing_string_to_order_hashYves Senn2014-03-053-5/+52
|\ \ \ \ \ | | | | | | | | | | | | Follow up of #10732 - Allow string hash values on AR order method
| * | | | | Allow string hash values on AR order methodMarcelo Casiraghi2014-03-043-5/+52
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This behavior has almost no performance impact: String not allowed 66.910000 0.030000 66.940000 ( 67.024976) String allowed 69.360000 0.030000 69.390000 ( 69.503096) Benchmarked with http://git.io/Y0YuRw.
* | | | | | Merge pull request #14261 from MSch/bound-parameters-for-existsAaron Patterson2014-03-042-3/+20
|\ \ \ \ \ \ | |/ / / / / |/| | | | | Make exists? use bound values.
| * | | | | Make exists? use bound values.Martin Schürrer2014-03-042-3/+20
| | |/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When we build a query with an inline value that is a numeric (e.g. because it's out of range for an int4) PostgreSQL doesn't use an index on the column, since it's now comparing numerics and not int4s. This leads to a _very_ slow query. When we use bound parameters instead of inline values PostgreSQL raises numeric_value_out_of_range since no automatic coercion happens.
* | | | | Inline block to fix indent [ci skip]Carlos Antonio da Silva2014-03-041-3/+1
| | | | |
* | | | | Fix enum test unused variable warning.Vipul A M2014-03-041-1/+1
| | | | | | | | | | | | | | | | | | | | Related - https://github.com/rails/rails/commit/5c55aafd38f45ac019573f98438ffdbdc8c580f9
* | | | | Add Enum type to postgresql adapter's oids to prevent unknown OID warnings.Dieter Komendera2014-03-044-0/+45
|/ / / /
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-09 20:33:54 +0000