Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | use the sql literal factory method | Aaron Patterson | 2010-12-24 | 1 | -1/+1 | |
| | ||||||
* | stop the recursive insanity | Aaron Patterson | 2010-12-24 | 1 | -5/+10 | |
| | ||||||
* | setting the primary key on the update manager | Aaron Patterson | 2010-12-24 | 1 | -0/+1 | |
| | ||||||
* | Verify that there is no unwanted implicit readonly set on ↵ | oleg dashevskii | 2010-12-23 | 1 | -1/+13 | |
| | | | | Model.has_many_through.find(id) [#5442 state:resolved] | |||||
* | Raise an error for associations which try to go :through a polymorphic ↵ | Jon Leighton | 2010-12-23 | 4 | -6/+22 | |
| | | | | association [#6212 state:resolved] | |||||
* | If a has_many goes :through a belongs_to, and the foreign key of the ↵ | Jon Leighton | 2010-12-23 | 14 | -35/+124 | |
| | | | | belongs_to changes, then the has_many should be considered stale. | |||||
* | Improved strategy for updating a belongs_to association when the foreign key ↵ | Jon Leighton | 2010-12-23 | 7 | -45/+37 | |
| | | | | changes. Rather than resetting each affected association when the foreign key changes, we should lazily check for 'staleness' (where fk does not match target id) when the association is accessed. | |||||
* | Test to verify that #2189 (count with has_many :through and a named_scope) ↵ | Jon Leighton | 2010-12-23 | 2 | -0/+7 | |
| | | | | is fixed | |||||
* | Revert "Optimize <association>_ids for hm:t with belongs_to source". The ↵ | Jon Leighton | 2010-12-23 | 2 | -14/+3 | |
| | | | | | | | | | | optimisation has too many edge cases, such as when the reflection, source reflection, or through reflection has conditions, orders, etc. [#6153 state:resolved] This reverts commit 373b053dc8b99dac1abc3879a17a2bf8c30302b5. Conflicts: activerecord/lib/active_record/associations.rb | |||||
* | Test demonstrating problem with foo.association_ids where it's a has_many ↵ | Jon Leighton | 2010-12-23 | 1 | -0/+4 | |
| | | | | :through with :conditions, with a belongs_to as the source reflection | |||||
* | When a has_many association is not :uniq, appending the same record multiple ↵ | Jon Leighton | 2010-12-23 | 3 | -3/+24 | |
| | | | | times should append it to the @target multiple times [#5964 state:resolved] | |||||
* | Fix behaviour of foo.has_many_through_association.select('custom select') ↵ | Michał Łomnicki | 2010-12-23 | 2 | -2/+7 | |
| | | | | [#6089 state:resolved] | |||||
* | Fix creation of has_many through records with custom primary_key option on ↵ | Szymon Nowak | 2010-12-23 | 5 | -2/+38 | |
| | | | | belongs_to [#2990 state:resolved] | |||||
* | Verify that has_one :through preload respects the :conditions [#2976 ↵ | Will Bryant | 2010-12-23 | 2 | -0/+13 | |
| | | | | state:resolved] | |||||
* | Don't allow a has_one association to go :through a collection association ↵ | Jon Leighton | 2010-12-23 | 5 | -9/+26 | |
| | | | | [#2976 state:resolved] | |||||
* | avoid duping and new objects | Aaron Patterson | 2010-12-23 | 1 | -2/+3 | |
| | ||||||
* | fixed retrieval of primary key value in Ralation#insert method | Raimonds Simanovskis | 2010-12-23 | 1 | -1/+1 | |
| | | | | previously primary key value was always assigned nil which caused Oracle enhanced adapter failing tests | |||||
* | Fix for default_scope tests to ensure comparing of equally sorted lists | Raimonds Simanovskis | 2010-12-23 | 2 | -2/+2 | |
| | | | | | | This is additional fix for commit ebc47465a5865ab91dc7d058d2d8a0cc961510d7 Respect the default_scope on a join model when reading a through association which otherwise was failing on Oracle (as it returned fixture comments in different order). | |||||
* | arel can escape the id, so avoid using the database connection | Aaron Patterson | 2010-12-22 | 1 | -1/+1 | |
| | ||||||
* | Arel::Table#[] always returns an attribute, so no need for || | Aaron Patterson | 2010-12-22 | 1 | -1/+1 | |
| | ||||||
* | probably should use the some_ids variable here. o_O | Aaron Patterson | 2010-12-22 | 1 | -1/+1 | |
| | ||||||
* | removing SQL interpolation, please use scoping and attribute conditionals as ↵ | Aaron Patterson | 2010-12-22 | 4 | -13/+4 | |
| | | | | a replacement | |||||
* | use arel to compile SQL rather than build strings | Aaron Patterson | 2010-12-22 | 1 | -1/+8 | |
| | ||||||
* | to_sym stuff before passing it to arel | Aaron Patterson | 2010-12-22 | 2 | -2/+2 | |
| | ||||||
* | build an AST rather than build SQL strings | Aaron Patterson | 2010-12-22 | 1 | -1/+10 | |
| | ||||||
* | returning id (for some yet to be discovered reason) | Aaron Patterson | 2010-12-20 | 1 | -1/+1 | |
| | ||||||
* | define_attr_method must serialize nil correctly | Aaron Patterson | 2010-12-20 | 4 | -2/+20 | |
| | ||||||
* | if there is no base name, we cannot determine a primary key | Aaron Patterson | 2010-12-20 | 2 | -2/+6 | |
| | ||||||
* | remove some lasigns | Aaron Patterson | 2010-12-20 | 1 | -6/+6 | |
| | ||||||
* | no use for set, no need to to_ary, reduce extra objects | Aaron Patterson | 2010-12-20 | 1 | -3/+2 | |
| | ||||||
* | use array arithmetic rather than create sets | Aaron Patterson | 2010-12-20 | 1 | -4/+2 | |
| | ||||||
* | Avoid Symbol#to_proc for performance reasons in Ruby 1.8 | Jon Leighton | 2010-12-20 | 1 | -3/+3 | |
| | ||||||
* | has_many associations with :dependent => :delete_all should update the ↵ | Jon Leighton | 2010-12-20 | 4 | -1/+18 | |
| | | | | counter cache when deleting records | |||||
* | Refactor delete_records in HasManyAssociation | Jon Leighton | 2010-12-20 | 1 | -7/+8 | |
| | ||||||
* | Fix problem where wrong keys are used in JoinAssociation when an association ↵ | Jon Leighton | 2010-12-20 | 5 | -9/+29 | |
| | | | | goes :through a belongs_to [#2801 state:resolved] | |||||
* | Remove unnecessary overloaded methods create, create! and create_record from ↵ | Jon Leighton | 2010-12-20 | 1 | -18/+0 | |
| | | | | HasAndBelongsToManyAssociation | |||||
* | Refactor create_record and build_record in AssociationCollection | Jon Leighton | 2010-12-20 | 1 | -17/+5 | |
| | ||||||
* | Delete create, create! and create_record from HasManyThroughAssociation in ↵ | Jon Leighton | 2010-12-20 | 2 | -30/+14 | |
| | | | | exchange for more generic versions in AssociationCollection | |||||
* | Specify insert_record with NotImplementedError in AssociationCollection, to ↵ | Jon Leighton | 2010-12-20 | 4 | -11/+14 | |
| | | | | indicate that subclasses should implement it. Also add save_record to reduce duplication. | |||||
* | Merge branch 'master' of git://github.com/lifo/docrails | Xavier Noria | 2010-12-20 | 1 | -2/+2 | |
|\ | ||||||
| * | changes in examples - reflect new mailer api and mysql2 adapter | Vijay Dev | 2010-12-18 | 1 | -2/+2 | |
| | | ||||||
| * | test for eager load of has_one association with condition on the through table | Pivotal Labs | 2010-12-15 | 1 | -1/+9 | |
| | | ||||||
| * | make sure that join nodes are uniq | Aaron Patterson | 2010-12-15 | 1 | -1/+1 | |
| | | ||||||
| * | Verify that creating a has_many through record where there is a ↵ | Jon Leighton | 2010-12-15 | 4 | -1/+22 | |
| | | | | | | | | default_scope on the join model works correctly (creates the join record with the default scope applied) | |||||
| * | Respect the default_scope on a join model when reading a through association | Jon Leighton | 2010-12-15 | 8 | -4/+34 | |
| | | ||||||
| * | Fix hm:t to self table aliasing in construct_scope | Ernie Miller | 2010-12-14 | 3 | -3/+12 | |
| | | ||||||
| * | add test which fails for has_many through self join [#4361 state:open] | Joe Hannon | 2010-12-14 | 1 | -0/+7 | |
| | | ||||||
| * | class names are already strings, so we do not need to call to_s on the ↵ | Aaron Patterson | 2010-12-14 | 1 | -2/+2 | |
| | | | | | | | | strings that are already strings | |||||
| * | build SQL AST nodes rather than generate strings | Aaron Patterson | 2010-12-14 | 1 | -10/+8 | |
| | | ||||||
| * | construct_joins no longer needs an argument | Aaron Patterson | 2010-12-14 | 1 | -1/+1 | |
| | |