Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | Fix ruby 1.8 compat. const_defined? only takes a second arg on 1.9. | Jon Leighton | 2011-11-29 | 1 | -3/+4 | |
| | ||||||
* | Deprecated `define_attr_method` in `ActiveModel::AttributeMethods` | Jon Leighton | 2011-11-29 | 3 | -24/+17 | |
| | | | | | This only existed to support methods like `set_table_name` in Active Record, which are themselves being deprecated. | |||||
* | Deprecate set_locking_column in favour of self.locking_column= | Jon Leighton | 2011-11-29 | 4 | -10/+56 | |
| | ||||||
* | Deprecate set_primary_key in favour of self.primary_key= | Jon Leighton | 2011-11-29 | 18 | -43/+71 | |
| | ||||||
* | Make sure the original_foo accessor still works (but deprecated) if we are ↵ | Jon Leighton | 2011-11-29 | 2 | -13/+86 | |
| | | | | using self.foo= | |||||
* | extract method | Jon Leighton | 2011-11-29 | 1 | -49/+25 | |
| | ||||||
* | Deprecate set_sequence_name in favour of self.sequence_name= | Jon Leighton | 2011-11-29 | 4 | -14/+36 | |
| | ||||||
* | Add tests for set_sequence_name etc | Jon Leighton | 2011-11-29 | 2 | -1/+23 | |
| | ||||||
* | Deprecate set_inheritance_column in favour of self.inheritance_column= | Jon Leighton | 2011-11-29 | 5 | -24/+48 | |
| | ||||||
* | Deprecate set_table_name in favour of self.table_name= or defining your own ↵ | Jon Leighton | 2011-11-29 | 18 | -61/+127 | |
| | | | | method. | |||||
* | respond_to? information of AR is not the responsibility of the spec | Aaron Patterson | 2011-11-29 | 2 | -8/+10 | |
| | | | | resolver. | |||||
* | Merge pull request #3636 from joshsusser/master | Jon Leighton | 2011-11-29 | 14 | -23/+112 | |
|\ | | | | | association methods are now generated in modules | |||||
| * | don't change class definition in test case | Josh Susser | 2011-11-29 | 2 | -6/+4 | |
| | | ||||||
| * | avoid warnings | Josh Susser | 2011-11-27 | 6 | -15/+15 | |
| | | | | | | | | | | | | | | This change uses Module.redefine_method as defined in ActiveSupport. Making Module.define_method public would be as clean in the code, and would also emit warnings when redefining an association. That is pretty messy given current tests, so I'm leaving it for someone else to decide what approach is better. | |||||
| * | changelog & docs for GeneratedFeatureMethods | Josh Susser | 2011-11-27 | 2 | -0/+26 | |
| | | ||||||
| * | use GeneratedFeatureMethods module for associations | Josh Susser | 2011-11-27 | 7 | -15/+57 | |
| | | ||||||
| * | add test for super-ing to association methods | Josh Susser | 2011-11-15 | 1 | -2/+12 | |
| | | ||||||
| * | association methods are now generated in modules | Josh Susser | 2011-11-15 | 9 | -30/+43 | |
| | | | | | | | | | | | | | | | | | | | | Instead of generating association methods directly in the model class, they are generated in an anonymous module which is then included in the model class. There is one such module for each association. The only subtlety is that the generated_attributes_methods module (from ActiveModel) must be forced to be included before association methods are created so that attribute methods will not shadow association methods. | |||||
* | | Fix resolver_test.rb on travis (postgresql isn't setup, so it can't load the ↵ | Jon Leighton | 2011-11-29 | 1 | -6/+6 | |
| | | | | | | | | connection adapter) | |||||
* | | Fix schema_cache_test.rb for sqlite3_mem | Jon Leighton | 2011-11-29 | 1 | -6/+0 | |
| | | ||||||
* | | splited a long line to shorter ones | Sergey Parizhskiy | 2011-11-29 | 1 | -1/+8 | |
| | | ||||||
* | | remove unused instance variable | Aaron Patterson | 2011-11-28 | 1 | -1/+0 | |
| | | ||||||
* | | just check in all connections | Aaron Patterson | 2011-11-28 | 1 | -6/+2 | |
| | | ||||||
* | | remove useless class_eval | Aaron Patterson | 2011-11-28 | 1 | -2/+0 | |
| | | ||||||
* | | Move connection resoluion logic to it's own testable class. | Aaron Patterson | 2011-11-28 | 3 | -92/+115 | |
| | | ||||||
* | | clean up string => hash conversion for connection pool | Aaron Patterson | 2011-11-28 | 1 | -19/+17 | |
| | | ||||||
* | | pools are 1:1 with spec now rather than 1:1 with class | Aaron Patterson | 2011-11-28 | 4 | -7/+8 | |
| | | ||||||
* | | break establish_connection to smaller methods | Aaron Patterson | 2011-11-28 | 2 | -33/+43 | |
| | | ||||||
* | | added information about callbacks created by autosave association (#3639) | Jakub Kuźma | 2011-11-28 | 1 | -4/+16 | |
| | | ||||||
* | | Merge pull request #3768 from janv/master | Aaron Patterson | 2011-11-28 | 2 | -1/+12 | |
|\ \ | | | | | | | Test and fix for Issue 3450 | |||||
| * | | Test case and fix for rails/rails#3450 | Jan Varwig | 2011-11-27 | 2 | -1/+12 | |
| | | | | | | | | | | | | Asssigning a parent id to a belongs_to association actually updates the object that is validated when the association has :validates => true | |||||
* | | | Merge pull request #3657 from arunagw/mysql2_bump_master | José Valim | 2011-11-28 | 1 | -1/+1 | |
|\ \ \ | | | | | | | | | Bump Mysql2! | |||||
| * | | | Bump Mysql2! | Arun Agrawal | 2011-11-22 | 1 | -1/+1 | |
| | | | | ||||||
* | | | | Revert "Use any instead of length" | José Valim | 2011-11-28 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | This reverts commit 1756629835d39f60ef4c96aff81ac503c71b98b7. | |||||
* | | | | Merge pull request #3748 from samsonasu/has_many_custom_pk_new_record | Jon Leighton | 2011-11-27 | 3 | -2/+33 | |
|\ \ \ \ | | | | | | | | | | | New records should load has_many relationships with custom primary keys | |||||
| * | | | | load has_many associations keyed off a custom primary key if that key is ↵ | Brian Samson | 2011-11-25 | 3 | -2/+33 | |
| |/ / / | | | | | | | | | | | | | present but the record is unsaved | |||||
* | / / | Use any instead of length | Rahul P. Chaudhari | 2011-11-27 | 1 | -1/+1 | |
| |/ / |/| | | ||||||
* | | | add the query to AR::Relation#explain output | Xavier Noria | 2011-11-25 | 4 | -2/+12 | |
| | | | | | | | | | | | | | | | | | | | | | Rationale: this is more readable if serveral queries are involved in one call. Also, it will be possible to let AR log EXPLAINs automatically in production mode, where queries are not even around. | |||||
* | | | Implement ArraySerializer and move old serialization API to a new namespace. | José Valim | 2011-11-23 | 2 | -4/+4 | |
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | The following constants were renamed: ActiveModel::Serialization => ActiveModel::Serializable ActiveModel::Serializers::JSON => ActiveModel::Serializable::JSON ActiveModel::Serializers::Xml => ActiveModel::Serializable::XML The main motivation for such a change is that `ActiveModel::Serializers::JSON` was not actually a serializer, but a module that when included allows the target to be serializable to JSON. With such changes, we were able to clean up the namespace to add true serializers as the ArraySerializer. | |||||
* | | oops! I suck! :bomb: | Aaron Patterson | 2011-11-20 | 1 | -1/+0 | |
| | | ||||||
* | | fixing tests on ruby 1.8 | Aaron Patterson | 2011-11-20 | 1 | -1/+3 | |
| | | ||||||
* | | Bump Arel | Arun Agrawal | 2011-11-20 | 1 | -1/+1 | |
| | | ||||||
* | | removing deprecated methods | Aaron Patterson | 2011-11-19 | 3 | -26/+0 | |
| | | ||||||
* | | adding visitors to the respective adapters | Aaron Patterson | 2011-11-19 | 2 | -0/+2 | |
| | | ||||||
* | | pushing caching and visitors down to the connection | Aaron Patterson | 2011-11-19 | 13 | -213/+181 | |
| | | ||||||
* | | Perf fix | Jon Leighton | 2011-11-19 | 2 | -2/+11 | |
| | | | | | | | | | | | | | | If we're deleting all records in an association, don't add a IN(..) clause to the query. Fixes #3672. | |||||
* | | Add missing CHANGELOG entry for #3678. Closes #3678. | Jon Leighton | 2011-11-19 | 1 | -0/+4 | |
| | | ||||||
* | | Merge pull request #3687 from kennyj/fix_3678-2 | Jon Leighton | 2011-11-19 | 2 | -21/+3 | |
|\ \ | | | | | | | Use `show index from`. We could fix `pk_and_sequence_for` method's performance problem (GH #3678) | |||||
| * | | Use `show index from`. We could fix `pk_and_sequence_for` method's ↵ | kennyj | 2011-11-19 | 2 | -21/+3 | |
| | | | | | | | | | | | | performance problem (GH #3678) | |||||
* | | | Verify that #3690 has been closed by previous changes to the mysql | Jon Leighton | 2011-11-19 | 3 | -2/+14 | |
|/ / | | | | | | | | | | | | | | | adapters. These tests fail on the v3.1.2 tag. Closes #3690. |