aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
Commit message (Collapse)AuthorAgeFilesLines
* Fix has_many assocation w/select load after createErnie Miller2012-10-052-1/+9
| | | | | | | | | | | | | | If you create a new record via a collection association proxy that has not loaded its target, and which selects additional attributes through the association, then when the proxy loads its target, it will inadvertently trigger an ActiveModel::MissingAttributeError during attribute writing when CollectionAssociation#merge_target_lists attempts to do its thing, since the newly loaded records will possess attributes the created record does not. This error also raises a bogus/confusing deprecation warning when accessing the association in Rails 3.2.x, so cherry-pick would be appreciated!
* Revert "Use flat_map { } instead of map {}.flatten"Santiago Pastorino2012-10-059-13/+13
| | | | | | | | | | | This reverts commit abf8de85519141496a6773310964ec03f6106f3f. We should take a deeper look to those cases flat_map doesn't do deep flattening. irb(main):002:0> [[[1,3], [1,2]]].map{|i| i}.flatten => [1, 3, 1, 2] irb(main):003:0> [[[1,3], [1,2]]].flat_map{|i| i} => [[1, 3], [1, 2]]
* Use flat_map { } instead of map {}.flattenSantiago Pastorino2012-10-059-13/+13
|
* Update activerecord/lib/active_record/persistence.rbAdam Haymond2012-10-041-2/+2
| | | - Changed the comments documentation for the update_column(s) methods to add a little bit of clarity
* Fix CHANGELOG entry [ci skip]Rafael Mendonça França2012-10-041-4/+4
|
* Count returns 0 without querying if parent is not savedFrancesco Rodriguez2012-10-035-0/+37
| | | | | | | | | | | | | | | | | | | | | | | | | | | Patches `CollectionAssociation#count` to return 0 without querying if the parent record is new. Consider the following code: class Account has_many :dossiers end class Dossier belongs_to :account end a = Account.new a.dossiers.build # before patch a.dossiers.count # SELECT COUNT(*) FROM "dossiers" WHERE "dossiers"."account_id" IS NULL # => 0 # after a.dosiers.count # fires without sql query # => 0 Fixes #1856.
* RefactorSantiago Pastorino2012-10-031-5/+4
|
* fix warning: method redefinedkennyj2012-10-022-2/+2
|
* Merge pull request #7822 from lulalala/reset-counter-cache-for-has-many-throughRafael Mendonça França2012-10-025-4/+28
|\ | | | | Fix reset_counters crashing on has_many :through associations.
| * Fix reset_counters() crashing on has_many :through associations.lulalala2012-10-025-4/+28
| | | | | | | | | | The counter column name in the intermediate model need to be access via the through reflection.
* | Merge pull request #7708 from bdurand/optimize_log_subscribersRafael Mendonça França2012-10-011-4/+6
|\ \ | |/ |/| Optimize log subscribers to check if the log level is sufficient
| * Optimize log subscribers to check if the log level is sufficient before ↵Brian Durand2012-09-301-4/+6
| | | | | | | | performing an operations.
* | small refactoring of build_relation in uniquenessAngelo Capilleri2012-09-291-5/+3
| | | | | | | | | | reflection init as 'if' stantment. column is always the same expression and depends from the changing of attributes
* | Change query pattern case insensitiveYasuo Honda2012-09-291-1/+1
| | | | | | | | because Oracle adapter uses upper case attribute/column name.
* | Fix syntax error with no US-ASCII charRafael Mendonça França2012-09-281-1/+1
| |
* | Merge branch 'master' of github.com:lifo/docrailsVijay Dev2012-09-2817-186/+161
|\ \ | | | | | | | | | | | | Conflicts: actionpack/lib/action_view/helpers/asset_tag_helper.rb
| * | remove added indentation from the last commit [ci skip]Francesco Rodriguez2012-09-221-1/+1
| | |
| * | update AR::Validations documentation [ci skip]Francesco Rodriguez2012-09-225-28/+28
| | |
| * | nodoc AR::Railtie [ci skip]Francesco Rodriguez2012-09-212-4/+4
| | |
| * | update AR::Scoping documentation [ci skip]Francesco Rodriguez2012-09-212-91/+77
| | |
| * | add :nodoc: directive to AR::Fixtures::File [ci skip]Francesco Rodriguez2012-09-211-1/+1
| | |
| * | fix AR::Coders::YAMLColumn nodoc [ci skip]Francesco Rodriguez2012-09-211-4/+2
| | |
| * | update AR/attribute_methods documentation [ci skip]Francesco Rodriguez2012-09-214-26/+36
| | |
| * | Better docs for overriding inheretance columnSteve Klabnik2012-09-221-5/+2
| | |
| * | fix AR::AttributeMethods::Dirty :nodoc: [ci skip]Francesco Rodriguez2012-09-211-4/+4
| | |
| * | fix AR::Associations::CollectionProxy#delete broken documentation [ci skip]Francesco Rodriguez2012-09-211-23/+2
| | |
| * | update AR::Associations::CollectionProxy#loaded? documentation [ci skip]Francesco Rodriguez2012-09-211-1/+6
| | |
* | | Add missing CHANGELOG entry removed by mistake at 7f3b475 [ci skip]Rafael Mendonça França2012-09-281-11/+20
| | |
* | | Add an explicit test for hot compatibilityJon Leighton2012-09-281-0/+54
| | |
* | | Support for partial inserts.Jon Leighton2012-09-289-15/+75
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When inserting new records, only the fields which have been changed from the defaults will actually be included in the INSERT statement. The other fields will be populated by the database. This is more efficient, and also means that it will be safe to remove database columns without getting subsequent errors in running app processes (so long as the code in those processes doesn't contain any references to the removed column).
* | | Add #update_columns entry to AR Changelog.Sebastian Martinez2012-09-281-0/+11
| | |
* | | Merge pull request #7394 from bobbyw/masterRafael Mendonça França2012-09-281-2/+2
|\ \ \ | | | | | | | | Use template0 option for creating activerecord test databases in build_database task with postgres
| * | | use template0 option for creating activerecord test databases in postgres ↵Bobby Wilson2012-08-191-2/+2
| | | | | | | | | | | | | | | | build_database task
* | | | Removing dead code. attribute_cast_code is not called.kennyj2012-09-282-25/+0
| | | |
* | | | Fix destructive side effects from marshaling an association caused by ↵Jeremy Kemper2012-09-252-7/+7
| | | | | | | | | | | | | | | | 65843e1acc0c8d285ff79f8c9c49d4d1215440be
* | | | Skip tests for non-supported isolation levelsYasuo Honda2012-09-261-2/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | i.e. Oracle database does not support these isolation levels. `:read_uncommitted` `:repeatable_read` This commit also works with other databases which do not support these isolation levels.
* | | | Skip tests for non-supported isolation levels with OracleYasuo Honda2012-09-251-0/+2
| | | |
* | | | Merge pull request #6936 from jfoley/callbacksSantiago Pastorino2012-09-242-0/+53
|\ \ \ \ | | | | | | | | | | Fix collisions with before and after validation callbacks.
| * | | | Add CHANGELOG entry and update the guideJohn Foley2012-09-231-0/+4
| | | | |
| * | | | Fix collisions with before and after validation callbacks.John Foley2012-09-231-0/+49
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit allows a user to do something like: before_validation :do_stuff, :on => [ :create, :update ] after_validation :do_more, :on => [ :create, :update ]
* | | | | make clear that expired db/schema_cache.dump are ignoredXavier Noria2012-09-241-1/+1
|/ / / /
* | | | Fix test_find_in_batches_should_use_any_column_as_primary_keySantiago Pastorino2012-09-221-11/+8
| | | |
* | | | start could be a stringSantiago Pastorino2012-09-212-3/+3
| | | | | | | | | | | | | | | | | | | | Related to 761bc751d31c22e2c2fdae2b4cdd435b68b6d783 and eb876c4d07130f15be2cac7be968cc393f959c62
* | | | Revert "Fix find_in_batches with customized primary_key"Santiago Pastorino2012-09-214-28/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 761bc751d31c22e2c2fdae2b4cdd435b68b6d783. This commit wasn't fixing any issue just using the same table for different models with different primary keys.
* | | | Style: remove hash noiseJeremy Kemper2012-09-211-10/+10
| | | |
* | | | Correct default charset/collation for mysql dbsJeremy Kemper2012-09-212-15/+30
| |/ / |/| |
* | | Use default charset/collation only if *neither* is specified. Otherwise we ↵Jeremy Kemper2012-09-211-4/+7
| | | | | | | | | | | | set utf8_unicode_ci collation on latin1 table.
* | | Merge branch 'master' of github.com:lifo/docrailsVijay Dev2012-09-213-20/+28
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Conflicts: actionmailer/lib/action_mailer/base.rb activesupport/lib/active_support/configurable.rb activesupport/lib/active_support/core_ext/module/deprecation.rb guides/source/action_controller_overview.md guides/source/active_support_core_extensions.md guides/source/ajax_on_rails.textile guides/source/association_basics.textile guides/source/upgrading_ruby_on_rails.md While resolving conflicts, I have chosen to ignore changes done in docrails at some places - these will be most likely 1.9 hash syntax changes.
| * | | Add extra note about :dependent => :destroy.Steve Klabnik2012-09-211-1/+4
| | | | | | | | | | | | | | | | Callbacks may interfere with each other.
| * | | fix :nodoc:s in AR::Timestamp [ci skip]Francesco Rodriguez2012-09-191-7/+7
| | | |
generated by cgit v1.2.3 (git 2.25.1) at 2025-04-04 05:32:59 +0000