Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
| * | | | | | | | | fix a typo | Ray Baxter | 2011-07-01 | 1 | -1/+1 | |
| | | | | | | | | | ||||||
| * | | | | | | | | minor changes | Vijay Dev | 2011-06-27 | 1 | -2/+2 | |
| | | | | | | | | | ||||||
| * | | | | | | | | replace find(all) with all | Vijay Dev | 2011-06-26 | 1 | -3/+3 | |
| | | | | | | | | | ||||||
| * | | | | | | | | fix typo in method name | Vijay Dev | 2011-06-25 | 1 | -1/+1 | |
| | | | | | | | | | ||||||
| * | | | | | | | | Revert "add missing methods supported by reversible migrations using the ↵ | Vijay Dev | 2011-06-25 | 1 | -4/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | change method" This reverts commit 7f91eebae361f2f3a1558f6d899b372524509a2d. Reason: Incorrect documenting. The newly added methods to the list are not actually supported by reversible migrations. | |||||
| * | | | | | | | | add missing methods supported by reversible migrations using the change method | Vijay Dev | 2011-06-24 | 1 | -1/+4 | |
| | |_|_|_|/ / / | |/| | | | | | | ||||||
* | | | | | | | | Only call set_owner_attributes for has_one association if target exists. | Dieter Komendera | 2011-07-04 | 2 | -1/+12 | |
| |/ / / / / / |/| | | | | | | ||||||
* | | | | | | | Use an instance variable to store the current masss assignment options | Andrew White | 2011-07-04 | 2 | -13/+18 | |
| |_|_|/ / / |/| | | | | | ||||||
* | | | | | | Reversing the changes done in c278a2c while still resolving #1857. | Vijay Dev | 2011-07-02 | 2 | -14/+8 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The changes broke bulk migration tests and were fixed in 4d256bc6; however that brought back the issue of #1857 and so this commit goes back to the original scenario and just adds change_table to the list of methods which are to be recorded in the CommandRecorder. The method_missing now delegates all calls to the underlying connection as before. | |||||
* | | | | | | a few minor performance improvements: fewer strings, fewer range objects, ↵ | Aaron Patterson | 2011-07-01 | 2 | -22/+13 | |
| | | | | | | | | | | | | | | | | | | | | | | | | fewer method calls | |||||
* | | | | | | calling super is super. if the other object is exactly equal, we can return ↵ | Aaron Patterson | 2011-07-01 | 1 | -1/+5 | |
| | | | | | | | | | | | | | | | | | | | | | | | | early | |||||
* | | | | | | remove unused codes | Aaron Patterson | 2011-07-01 | 1 | -4/+0 | |
| | | | | | | ||||||
* | | | | | | reduce calls to owners_by_key and to read_attribute, respond_to? etc | Aaron Patterson | 2011-07-01 | 1 | -2/+3 | |
| |_|_|/ / |/| | | | | ||||||
* | | | | | Remove AssociationReflection#create_association and ↵ | Jon Leighton | 2011-06-30 | 1 | -17/+0 | |
| | | | | | | | | | | | | | | | | | | | | AssociationReflection#create_association! - they are not called from anywhere. | |||||
* | | | | | Assign the association attributes to the associated record before the ↵ | Jon Leighton | 2011-06-30 | 8 | -12/+45 | |
| | | | | | | | | | | | | | | | | | | | | before_initialize callback of the record runs. Fixes #1842. | |||||
* | | | | | match method signature of the superclass | Aaron Patterson | 2011-06-30 | 2 | -4/+4 | |
| | | | | | ||||||
* | | | | | call super rather than delegating to the other objects equal? method | Aaron Patterson | 2011-06-30 | 1 | -1/+1 | |
| | | | | | ||||||
* | | | | | just alias eql? to == for frewer method calls | Aaron Patterson | 2011-06-30 | 1 | -5/+1 | |
| | | | | | ||||||
* | | | | | only calculate method name once | Aaron Patterson | 2011-06-30 | 1 | -2/+3 | |
| | | | | | ||||||
* | | | | | cache the plural name on the reflection so we do not pay pluralize costs on ↵ | Aaron Patterson | 2011-06-30 | 3 | -8/+15 | |
| | | | | | | | | | | | | | | | | | | | | joins | |||||
* | | | | | Master version is 3.2.0.beta | Santiago Pastorino | 2011-06-30 | 1 | -2/+2 | |
| | | | | | ||||||
* | | | | | Bump up rack-cache and tzinfo | Santiago Pastorino | 2011-06-30 | 1 | -1/+1 | |
| | | | | | ||||||
* | | | | | CommandRecorder should delegate in method_missing where possible. Fixes some ↵ | Jon Leighton | 2011-06-30 | 2 | -2/+11 | |
| | | | | | | | | | | | | | | | | | | | | tests in migration_test.rb under mysql. The problem was introduced in c278a2c5e109204ec8a47fcbfdfc327aad7996ce. | |||||
* | | | | | Define to_ary on ActiveRecord::Base to return nil. Improve performance of ↵ | Jon Leighton | 2011-06-30 | 1 | -0/+12 | |
| | | | | | | | | | | | | | | | | | | | | Array#flatten under 1.9, see comment for details. | |||||
* | | | | | Merge pull request #1574 from ↵ | Aaron Patterson | 2011-06-28 | 2 | -1/+13 | |
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | oriolgual/1571_ar_relation_order_no_longer_works_with_arel_nodes Fix #1571 ActiveRecord::Relation#order no longer works with arel ordering nodes | |||||
| * | | | | | Fix case | Oriol Gual | 2011-06-28 | 1 | -2/+1 | |
| | | | | | | ||||||
| * | | | | | Update reverse order with new Arel Nodes | Oriol Gual | 2011-06-28 | 1 | -1/+2 | |
| | | | | | | ||||||
| * | | | | | Add more test cases | Oriol Gual | 2011-06-28 | 1 | -0/+8 | |
| | | | | | | ||||||
| * | | | | | Add failing test | Oriol Gual | 2011-06-28 | 1 | -0/+4 | |
| | | | | | | ||||||
* | | | | | | Fix test_finding_with_cross_table_order_and_limit for Oracle | Raimonds Simanovskis | 2011-06-28 | 1 | -3/+3 | |
|/ / / / / | | | | | | | | | | | Use latest Arel syntax and pass each order by expression as separate argument to order method as otherwise invalid Oracle SQL is generated. | |||||
* | | | | | Merge pull request #1857 from vijaydev/irreversible-migration | Aaron Patterson | 2011-06-28 | 2 | -7/+9 | |
|\ \ \ \ \ | | | | | | | | | | | | | IrreversibleMigration is not raised when a method not supported by reversible migrations is called in the change method of a migration | |||||
| * | | | | | record unsupported methods in CommandRecorder instead of letting the ↵ | Vijay Dev | 2011-06-25 | 2 | -7/+9 | |
| | | | | | | | | | | | | | | | | | | | | | | | | unsupported methods go through to the underlying db causing errors like duplicate columns to occur when rolling back migrations | |||||
* | | | | | | Merge pull request #1860 from dmathieu/comparison | Aaron Patterson | 2011-06-28 | 2 | -0/+22 | |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | Allow comparison on model objects - Closes #1858 | |||||
| * | | | | | | comparing different classes returns nil | Damien Mathieu | 2011-06-26 | 2 | -1/+11 | |
| | | | | | | | ||||||
| * | | | | | | allow comparison on model objects - Closes #1858 | Damien Mathieu | 2011-06-26 | 2 | -0/+12 | |
| |/ / / / / | ||||||
* | | | | | | remove useless assignment | Aaron Patterson | 2011-06-28 | 1 | -2/+1 | |
| | | | | | | ||||||
* | | | | | | lock_optimistically is typically true, so evaluate the common failure case first | Aaron Patterson | 2011-06-28 | 1 | -1/+1 | |
| | | | | | | ||||||
* | | | | | | reduce object allocation during AR instantiation | Aaron Patterson | 2011-06-28 | 2 | -3/+8 | |
| | | | | | | ||||||
* | | | | | | remove the check for needs_type_condition? because ensure_proper_type will ↵ | Aaron Patterson | 2011-06-27 | 2 | -3/+4 | |
| | | | | | | | | | | | | | | | | | | | | | | | | pick up the type column | |||||
* | | | | | | stop using && for the short circuit side effect | Aaron Patterson | 2011-06-27 | 1 | -1/+1 | |
| | | | | | | ||||||
* | | | | | | let strings be converted to symbols inside the interpreter | Aaron Patterson | 2011-06-27 | 1 | -2/+2 | |
| | | | | | | ||||||
* | | | | | | avoice paying hash cost if there are no serialized attributes | Aaron Patterson | 2011-06-27 | 1 | -3/+4 | |
| | | | | | | ||||||
* | | | | | | cache column defaults for AR object instantiation | Aaron Patterson | 2011-06-27 | 3 | -3/+16 | |
| | | | | | | ||||||
* | | | | | | AR object instantiation is ~30% faster in the simple case | Aaron Patterson | 2011-06-27 | 2 | -1/+17 | |
| | | | | | | ||||||
* | | | | | | initialize instance variables | Aaron Patterson | 2011-06-27 | 1 | -0/+2 | |
| | | | | | | ||||||
* | | | | | | oops! remove debugging codes | Aaron Patterson | 2011-06-27 | 1 | -1/+0 | |
| | | | | | | ||||||
* | | | | | | default create_with_value to a hash so we can eliminate conditionals, add ↵ | Aaron Patterson | 2011-06-27 | 5 | -5/+14 | |
| | | | | | | | | | | | | | | | | | | | | | | | | test surrounding create_with(nil) behavior | |||||
* | | | | | | Bump ARel to 2.1.3 | Guillermo Iguaran | 2011-06-27 | 1 | -1/+1 | |
|/ / / / / | ||||||
* | | | | | Merge pull request #1848 from raviolicode/postgresql_order_multiple_params | Santiago Pastorino | 2011-06-24 | 2 | -1/+8 | |
|\ \ \ \ \ | | | | | | | | | | | | | Fix for complex ordering of multiple columns on postgresql | |||||
| * | | | | | Improve ordering of multiple columns on postgresql | Lucia Escanellas | 2011-06-24 | 2 | -1/+8 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Only on postgresql, order("first asc, second asc") was invalid * Closes #1720 |