aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | | | | | | | | Improve test without using anonymous classesEdgars Beigarts2016-12-061-27/+24
| | | | | | | | | | |
| * | | | | | | | | | Reload association scope inside autosaved associationsEdgars Beigarts2016-12-022-3/+30
| | |_|_|_|_|_|_|_|/ | |/| | | | | | | |
* | | | | | | | | | [ci skip] Document regex changeAlex Kitchens2016-12-061-0/+1
| |_|_|/ / / / / / |/| | | | | | | |
* | | | | | | | | Merge pull request #25451 from ↵Sean Griffin2016-12-067-8/+33
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | kamipo/translate_not_null_violation_to_specific_exception Translate NOT NULL violation to the specific exception
| * | | | | | | | | Translate NOT NULL violation to the specific exceptionRyuta Kamizono2016-12-067-8/+33
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Raise `ActiveRecord::NotNullViolation` when a record cannot be inserted or updated because it would violate a not null constraint.
* | | | | | | | | | Merge pull request #27275 from kamipo/should_inherit_statement_invalidSean Griffin2016-12-061-1/+1
|\ \ \ \ \ \ \ \ \ \ | |/ / / / / / / / / |/| | | | | | | | | Should inherit `StatementInvalid` rather than `WrappedDatabaseException`
| * | | | | | | | | Should inherit `StatementInvalid` rather than `WrappedDatabaseException`Ryuta Kamizono2016-12-061-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Because defunct wrapper class is kept for compatibility.
* | | | | | | | | | Merge pull request #26687 from kamipo/fix_add_index_to_normalize_optionsMatthew Draper2016-12-064-0/+9
|\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | Fix `add_index` to normalize column names and options
| * | | | | | | | | | Fix `add_index` to normalize column names and optionsRyuta Kamizono2016-10-034-1/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently does not work the following code. ```ruby add_index(:people, ["last_name", "first_name"], order: { last_name: :desc, first_name: :asc }) ``` Normalize column names and options to fix the issue.
* | | | | | | | | | | Merge pull request #27277 from kamipo/remove_unnecessary_variableMatthew Draper2016-12-061-2/+1
|\ \ \ \ \ \ \ \ \ \ \ | |_|_|_|/ / / / / / / |/| | | | | | | | | | Remove unnecessary `connection_name` variable
| * | | | | | | | | | Remove unnecessary `connection_name` variableRyuta Kamizono2016-12-061-2/+1
| | |/ / / / / / / / | |/| | | | | | | |
* | | | | | | | | | Merge pull request #27274 from kamipo/primary_key_with_auto_increment_and_bigintMatthew Draper2016-12-063-11/+25
|\ \ \ \ \ \ \ \ \ \ | |/ / / / / / / / / |/| | | | | | | | | Make `:auto_increment` option works on `:bigint`
| * | | | | | | | | Make `:auto_increment` option works on `:bigint`Ryuta Kamizono2016-12-063-11/+25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Follow up to #27272.
* | | | | | | | | | Make pg adapter use bigserial for pk by defaultPavel Pravosud2016-12-0510-2/+262
| | | | | | | | | |
* | | | | | | | | | Change MySQL and Postgresql to use Bigint primary keysJon McCartie2016-12-0515-75/+73
|/ / / / / / / / /
* | | | | | | | | Make `:auto_increment` to internal primary key optionRyuta Kamizono2016-12-064-1/+65
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Using `:auto_increment` option for abstracting the DB-specific auto incremental types. It is worth to ease to implement the compatibility layer.
* | | | | | | | | Don't try to run multiple insert queries at onceSean Griffin2016-12-051-5/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | SQLite's default query interface ignores anything after the first semicolon in a query. This is actually quite common behavior in database drivers, especially when dealing with code paths for prepared statements (which we are). While this should only affect SQLite, as I'm not aware of any drivers which don't support multi-insert. Even if this does affect other third party drivers though, I'd prefer not to assume that more than one query can be executed per call to `execute`. Fixes #26948. Close #27242.
* | | | | | | | | Fix that `change_column` lose a commentRyuta Kamizono2016-12-052-2/+5
| |/ / / / / / / |/| | | | | | |
* | | | | | | | Stop using the `pg` Float encoderSean Griffin2016-12-011-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PG's type map assumes that all Ruby floats are going to a field with an OID of type float4 or float8, and generates text which is invalid syntax for other types. Since the gem can handle floats properly without this encoder (albeit slightly slower), we can continue to use that as we have in prior versions of Rails. Fixes #27246
* | | | | | | | Fix issue number from becoming markdown headernanaya2016-12-011-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The alternative is escaping it but moving around the text seems a bit simpler.
* | | | | | | | Make the second argument to `attribute` optionalSean Griffin2016-11-303-1/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | While working on updating Paper Trail for 5.1 compatibility, I noticed that I was required to pass a second argument to `attribute`. I didn't intend for this to be the case, as `attribute :foo` is totally reasonable shorthand for "I want `attr_accessor :foo`, but also have it work with things like `.attributes` and `ActiveRecord::Dirty`"
* | | | | | | | Correct deprecation warnings in `ActiveRecord::Dirty`Sean Griffin2016-11-301-6/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I had pointed the messages at the new behavior, not the old.
* | | | | | | | Merge pull request #27126 from kamipo/fix_unsigned_with_zerofillRafael França2016-11-294-2/+9
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | Fix that unsigned with zerofill is treated as signed
| * | | | | | | | Fix that unsigned with zerofill is treated as signedRyuta Kamizono2016-11-274-2/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes #27125.
* | | | | | | | | Merge pull request #27195 from y-yagi/use_public_module_includeSantiago Pastorino2016-11-271-1/+1
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | use public Module#include instead of send :include
| * | | | | | | | | use public Module#include instead of send :includeyuuji.yaginuma2016-11-271-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Follow up to #18767
* | | | | | | | | | fixing update_all and delete_all when chained with left_joins. fixes #27192Diego Plentz2016-11-272-2/+28
| |/ / / / / / / / |/| | | | | | | |
* | | | | | | | | Merge pull request #26865 from ↵Matthew Draper2016-11-273-4/+23
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | sergey-alekseev/uniqueness-validation-scope-with-polymorphic-association fix the uniqueness validation scope with a polymorphic association
| * | | | | | | | | fix the uniqueness validation scope with a polymorphic associationSergey Alekseev2016-11-263-4/+23
| |/ / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | https://gist.github.com/sergey-alekseev/946657ebdb5e58d1bee115714056ec96
* | | | | | | | | abort_on_exception can't be disabled for a single threadMatthew Draper2016-11-272-6/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If it's enabled globally, it's on regardless of how individual threads are set.
* | | | | | | | | We expect exceptions; abort will just raise in the wrong placeMatthew Draper2016-11-272-9/+17
| | | | | | | | |
* | | | | | | | | Clear available connections immediatelyMatthew Draper2016-11-271-0/+2
|/ / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It'll be re-cleared when it's rebuilt in with_new_connections_blocked's ensure, but we still need to clear it inside this synchronize -- we've disconnected connections that may be available in the queue, and while other threads are not allowed to make *new* connections, they are still allowed to take existing ones from there. This was incorrectly removed in d314646c965b045724e6bdb9d61dcecfabc0ba8f.
* | | | | | | | Make the test that seems to be getting stuck noisierMatthew Draper2016-11-261-35/+55
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I assume it's upset because of the change in d314646c965b045724e6bdb9d61dcecfabc0ba8f, but I don't yet understand why.
* | | | | | | | We're not calling hooks here since 9e4c41c903e8e58721f2c41776a8c60ddba7a0a9Akira Matsuda2016-11-251-1/+0
| | | | | | | |
* | | | | | | | Merge pull request #27165 from ↵Rafael França2016-11-251-5/+15
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | prathamesh-sonpatki/followup-uuid-extension-change Followup of UUID default extension in the docs
| * | | | | | | | Followup of UUID default extension in the docs [ci skip]Prathamesh Sonpatki2016-11-241-5/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Mentioned clearly that for PostgreSQL < 9.4, you need to pass the default option with "uuid_generate_v4()" - Also updated PostgreSQL Active Record guide with this change. - https://github.com/rails/rails/pull/25395#r66877078
* | | | | | | | | Should test `test_change_column_default` in `PostgresqlUUIDTest`Ryuta Kamizono2016-11-251-13/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Follow up to #25395.
* | | | | | | | | Merge pull request #27171 from kamipo/suppress_migration_messageMatthew Draper2016-11-251-0/+4
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | Suppress migration message in the test
| * | | | | | | | | Suppress migration message in the testRyuta Kamizono2016-11-251-0/+4
| | | | | | | | | |
* | | | | | | | | | Remove blank else blockRyuta Kamizono2016-11-251-1/+0
|/ / / / / / / / /
* | | | | | | | | Merge pull request #27108 from matthewd/allocate-connections-after-blockingMatthew Draper2016-11-252-25/+17
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | Distribute connections to previously blocked threads when we're done
| * | | | | | | | | Distribute connections to previously blocked threads when we're doneMatthew Draper2016-11-252-25/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Two methods block new connections; we were already doing the right thing for clear_reloadable_connections, but it's better placed in with_new_connections_blocked, where it can work for disconnect too.
* | | | | | | | | | Add test for collection *_ids= setter when association primary key setDominic Cleal2016-11-244-1/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes casting of IDs to the data type of the association primary key, rather than then the data type of the model's primary key. (Tests use a string primary key on the association, rather than an int.) Tests issue #20995
* | | | | | | | | | Restore RecordNotFound when *_ids= can't find records by IDDominic Cleal2016-11-244-7/+17
| |/ / / / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 9c9fb19 changed the behaviour of the _ids= setters for associations to raise an AssociationTypeMismatch when unknown IDs are given: Class: <ActiveRecord::AssociationTypeMismatch> Message: <"Developer(#43811860) expected, got NilClass(#16732720)"> This restores the original ActiveRecord::RecordNotFound exception with a much clearer error message: Class: <ActiveRecord::RecordNotFound> Message: <"Couldn't find all Developers with 'id': (1, -9999) [WHERE \"contracts\".\"company_id\" = ?] (found 1 results, but was looking for 2)"> Fixes #25719
* | | | | | | | | For `PostgreSQL >= 9.4` use `gen_random_uuid()`Yaw Boakye2016-11-226-22/+86
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since 9.4, PostgreSQL recommends using `pgcrypto`'s `gen_random_uuid()` to generate version 4 UUIDs instead of the functions in the `uuid-ossp` extension. These changes uses the appropriate UUID function depending on the underlying PostgreSQL server's version, while maintaining `uuid_generate_v4()` in older migrations.
* | | | | | | | | Introduce `reload_<association>` reader for singular associations.Yves Senn2016-11-225-1/+51
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch brings back the functionality of passing true to the association proxy. The behavior was deprecated with #20888 and scheduled for removal in Rails 5.1. The deprecation mentioned that instead of `Article.category(true)` one should use `article#reload.category`. Unfortunately the alternative does not expose the same behavior as passing true to the reader did. Specifically reloading the parent record throws unsaved changes and other caches away. Passing true only affected the association. This is problematic and there is no easy workaround. I propose to bring back the old functionality by introducing this new reader method for singular associations.
* | | | | | | | | update bin/test scripts to prevent double runs.Yves Senn2016-11-211-2/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The test runner was updated to make use of autorun. This caused the `bin/test` scripts to run Minitest twice.
* | | | | | | | | changelog entry for fc4c15d [ci skip]Yves Senn2016-11-211-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://github.com/rails/rails/commit/fc4c15d823b112cc440cbd9a4288e1a389c138da
* | | | | | | | | `eager_autoload` needs to be triggered for nested constants.Yves Senn2016-11-211-0/+5
| |_|_|_|/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When `ActiveRecord::Associations.eager_load!` is called, it eager loads the `Preloader` but does not trigger a `eager_load!` on the `Preloader` itself. A eager loaded component is responsible to forward the `eager_load!` call to nested constants that make use of `eager_autoload` as well. This will also resolve the occasional `NameError` that we've observed in production: ``` NameError: uninitialized constant ActiveRecord::Associations::Preloader::BelongsTo ```
* | | | | | | | Fix prepared statements disabled test againPrathamesh Sonpatki2016-11-202-22/+25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Due to `assert_nothing_raised` this test was not really testing anything. - So updated it to assert that the query gives expected result. - Also in general we can use `connection.unprepared_statement` for testing queries w/o prepared statements but it can't be used in this case. This test cases was added because when prepared_statements config is set to false, then DetermineIfPreparableVisitor module does not extended by Arel visitor resulting into an error. Ref: https://github.com/rails/rails/pull/22748. - Because DetermineIfPreparableVisitor module does not get added to the visitor chain only if prepared_statements is false while **setting up connection**, not when `unprepared_statement` is used. - I have also added an assertion for making sure that prepared_config is set to false from the start, so that nobody accidentally removes the connection setup using `arunit_without_prepared_statements` and replaces it with stubs or unprepared_statement.
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-08 14:46:27 +0000