aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | | | | | Merge pull request #27402 from yui-knk/executeRafael França2016-12-281-1/+1
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | Use `#execute` instead of `@connection.query`
| * | | | | | | | Use `#execute` instead of `@connection.query`yui-knk2016-12-191-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `@connection.query` bypasses instrumenting "sql.active_record". This behavior preventing us from debugging SQLs which Rails generates.
* | | | | | | | | Fix Rubocop violations and fix documentation visibilityRafael Mendonça França2016-12-2817-153/+153
| |_|_|_|_|/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Some methods were added to public API in 5b14129d8d4ad302b4e11df6bd5c7891b75f393c and they should be not part of the public API.
* | | | | | | | Merge pull request #27442 from kamipo/fix_27434Eileen M. Uchitelle2016-12-273-14/+17
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | Add a record to target before any callbacks loads the record
| * | | | | | | | Add a record to target before any callbacks loads the recordRyuta Kamizono2016-12-233-14/+17
| | |_|/ / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `append_record` was added at 15ddd51 for not double adding the record. But adding `append_record` (checking `@target.include?(record)`) caused performance regression #27434. Instead of checking not double adding the record, add a record to target before any callbacks loads the record. Fixes #27434.
* | | | | | | | Small edits to activerecord/CHANGELOG.mdJon Moss2016-12-271-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [ci skip] - add period where necessary - add backticks where necessary
* | | | | | | | assert_equal takes expectation firstAkira Matsuda2016-12-268-19/+19
| | | | | | | |
* | | | | | | | "Use assert_nil if expecting nil from ...:in `...'. This will fail in MT6."Akira Matsuda2016-12-254-10/+10
| | | | | | | |
* | | | | | | | Merge pull request #27448 from kamipo/no_need_doc_for_nodoc_classesAkira Matsuda2016-12-255-15/+15
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | No need `:doc:` for `:nodoc:` classes [ci skip]
| * | | | | | | | No need `:doc:` for `:nodoc:` classes [ci skip]Ryuta Kamizono2016-12-255-15/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Follow up to 5b14129d8d4ad302b4e11df6bd5c7891b75f393c. http://edgeapi.rubyonrails.org/classes/ActiveRecord/Attribute.html
* | | | | | | | | "Use assert_nil if expecting nil. This will fail in minitest 6."Akira Matsuda2016-12-2522-77/+77
|/ / / / / / / /
* | | | | | | | AR::ConnectionAdapters::PostgreSQL::Name#parts is called from other instancesAkira Matsuda2016-12-251-4/+6
| | | | | | | |
* | | | | | | | Privatize unneededly protected methods in Active RecordAkira Matsuda2016-12-2426-158/+145
| | | | | | | |
* | | | | | | | No need to nodoc private methodsAkira Matsuda2016-12-2411-31/+31
| | | | | | | |
* | | | | | | | Privatize unneededly protected methods in Active Record testsAkira Matsuda2016-12-2411-11/+11
| | | | | | | |
* | | | | | | | Describe what we are protectingAkira Matsuda2016-12-2324-0/+50
|/ / / / / / /
* | | | | | | fix #create_fixtures when equal table names in different databasesJulia Lopez2016-12-216-3/+28
| | | | | | |
* | | | | | | Merge pull request #27400 from kamipo/remove_useless_test_supports_primary_keyEileen M. Uchitelle2016-12-191-6/+0
|\ \ \ \ \ \ \ | |/ / / / / / |/| | | | | | Remove useless `test_supports_primary_key`
| * | | | | | Remove useless `test_supports_primary_key`Ryuta Kamizono2016-12-191-6/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `supports_primary_key?` method is defined in `AbstractAdapter` so does not raise any errors.
* | | | | | | Consolidate duplicated elsif branchRyuta Kamizono2016-12-191-6/+1
|/ / / / / /
* | | | | | Merge pull request #27329 from kamipo/simplify_unsigned_regexEileen M. Uchitelle2016-12-172-3/+2
|\ \ \ \ \ \ | | | | | | | | | | | | | | Simplify the regex for `unsigned?` method
| * | | | | | Simplify the regex for `unsigned?` methodRyuta Kamizono2016-12-112-3/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It is enough to distinguish only the trailing `unsigned` and `unsigned zerofill`.
* | | | | | | Merge pull request #27375 from kirs/fixture-error-messageRafael França2016-12-163-4/+20
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Throw friendly error message when fixture is not a hash
| * | | | | | | Throw friendly error message when fixture is not a hashKir Shatrov2016-12-153-4/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Right now, when fixture is not a Hash we throw an error message saying "fixture is not a hash". This is not very user friendly because it's not saying which fixture is invalid.
* | | | | | | | fix QueryCache nil dupRichard Monette2016-12-155-5/+34
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | make sql statements frozen dup if arel is not our string expect runtime error dont wrap runtime error in invalid log errors will now be treated as runtime errors update changelog
* | | | | | | | fix new warning in ruby 2.4yuuji.yaginuma2016-12-141-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes the following warning. ``` test/caching_test.rb:986: warning: parentheses after method name is interpreted as test/caching_test.rb:986: warning: an argument list, not a decomposed argument test/cases/adapters/mysql2/reserved_word_test.rb:146: warning: parentheses after method name is interpreted as test/cases/adapters/mysql2/reserved_word_test.rb:146: warning: an argument list, not a decomposed argument ``` Ref: https://github.com/ruby/ruby/commit/65e27c8b138d6959608658ffce2fa761842b8d24
* | | | | | | | Add CHANGELOG entry to #27042Rafael Mendonça França2016-12-131-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [ci skip]
* | | | | | | | Merge pull request #27042 from kirs/yaml-schema-cacheRafael França2016-12-136-15/+433
|\ \ \ \ \ \ \ \ | |_|_|_|/ / / / |/| | | | | | | Schema cache in YAML
| * | | | | | | Use YAML to serialize schema cacheKir Shatrov2016-11-276-15/+433
| | | | | | | |
* | | | | | | | Add a changelog entry for #26687 [ci skip]Ryuta Kamizono2016-12-121-0/+7
| | | | | | | |
* | | | | | | | Remove duplicated lineRyuta Kamizono2016-12-111-1/+0
| |_|/ / / / / |/| | | | | |
* | | | | | | Merge pull request #27323 from kamipo/add_changelog_for_25227Matthew Draper2016-12-111-0/+4
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Add a changelog entry for #25227 [ci skip]
| * | | | | | | Add a changelog entry for #25227 [ci skip]Ryuta Kamizono2016-12-101-0/+4
| | |/ / / / / | |/| | | | |
* / | | | | | Fix CI failure caused by #25227 and #25280 were merged at the same timeRyuta Kamizono2016-12-102-2/+2
|/ / / / / /
* | | | | | Merge pull request #25280 from ↵Sean Griffin2016-12-102-0/+16
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | kamipo/prevent_range_error_for_belongs_to_associations Prevent `RangeError` for `belongs_to` associations
| * | | | | | Prevent `RangeError` for `belongs_to` associationsRyuta Kamizono2016-10-102-0/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently to access `belongs_to` associations raises a `RangeError` if foreign key attribute has out of range value. It should return a nil value rather than raising a `RangeError`. Fixes #20140.
* | | | | | | Merge pull request #25227 from kamipo/numeric_value_out_of_rangeSean Griffin2016-12-107-8/+26
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Translate numeric value out of range to the specific exception
| * | | | | | | Translate numeric value out of range to the specific exceptionRyuta Kamizono2016-12-067-8/+26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Raise `ActiveRecord::RangeError` when values that executed are out of range.
* | | | | | | | Add a changelog entry for #25451 [ci skip]Ryuta Kamizono2016-12-101-8/+13
| | | | | | | |
* | | | | | | | Emulate db trigger behaviour for after_commit :destroy, :updateStefan Budeanu2016-12-094-5/+67
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Race conditions can occur when an ActiveRecord is destroyed twice or destroyed and updated. The callbacks should only be triggered once, similar to a SQL database trigger.
* | | | | | | | Resolve association class correctly when assigning ids on a through associationMatthew Draper2016-12-093-1/+12
| | | | | | | |
* | | | | | | | Fix test breaking error uninitialized constant ActiveRecord::Type::Value.utilum2016-12-081-0/+1
| | | | | | | |
* | | | | | | | Merge pull request #26696 from iainbeeston/only-ruby-types-in-activemodelSean Griffin2016-12-086-4/+57
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | Moved database-specific ActiveModel types into ActiveRecord
| * | | | | | | | Moved database-specific ActiveModel types into ActiveRecordIain Beeston2016-10-146-3/+57
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ie. DecimalWithoutScale, Text and UnsignedInteger
* | | | | | | | | Check whether the current attribute being write is aliased or not before writingPrathamesh Sonpatki2016-12-093-2/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - If aliased, then use the aliased attribute name.
* | | | | | | | | Check whether the current attribute being read is aliased or not before readingPrathamesh Sonpatki2016-12-083-2/+24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - If aliased, then use the aliased attribute name. - Fixes #26417.
* | | | | | | | | Merge pull request #27278 from kamipo/should_be_sync_primary_key_definitionSean Griffin2016-12-081-1/+1
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | Should be sync the `primary_key` definition with actually created
| * | | | | | | | | Should be sync the `primary_key` definition with actually createdRyuta Kamizono2016-12-061-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Actually the `primary_key` definition is not used but the inconsistency is confusing. Actual definition is `bigint auto_increment PRIMARY KEY` so `UNSIGNED` and `(8)` is unnecessary. See also #21607.
* | | | | | | | | | Add some documentation around internal APIs [ci skip]Sean Griffin2016-12-081-0/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | While these method aren't public API, they are a non-trivial internal API which warrant a bit of explanation.
* | | | | | | | | | Merge pull request #27251 from ebeigarts/fix-autosaveSean Griffin2016-12-062-3/+27
|\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | Fix association scope inside autosaved association callbacks
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-08 11:53:07 +0000