aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | | | Changed change_column in PG schema_statements.rb to make sure that the ↵Eric Chahin2014-04-153-2/+30
| | | | | | | | | | | | | | | | | | | | | | | | uuid_generate function was not being quoted.
| * | | | | Merge pull request #14762 from dwo/masterArthur Nogueira Neves2014-04-151-1/+1
| |\ \ \ \ \ | | | | | | | | | | | | | | use YAML.load_file in database tasks example
| | * | | | | use YAML.load_file in database tasks exampleRobin Tweedie2014-04-151-1/+1
| | | |_|_|/ | | |/| | | | | | | | | | | | | | | | | | | | | rather than YAML.load(File.read(path)). YAML.load_file is also used in guides/rails_guides/helper.rb since 2011, the only other precedent I could find.
| * | | | | Make sure the column_name is different from 'all'.Lauro Caetano2014-04-141-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 968c581ea34b5236af14805e6a77913b1cb36238 have fixed the EagerLoadTest, but not in the correct way. The problem was when `empty?` or `size` was called on relation. It was triggering `count(:all)`, which was passing `:all` as the column name to `count` on Calculations. On the other hand, the method `calculate` on Calculations was calling `construct_relation_for_association_calculations` instead of `perform_calculation`, because `has_include?` was returning `true` since `column_name` was present. To prevent calling the wrong method to perform the calculation, we have to check if the `column_name` is present and if it is different from `:all` (which is now used to correctly do `count` with `select`). More information here: https://github.com/rails/rails/commit/968c581ea34b5236af14805e6a77913b1cb36238#commitcomment-6006135
| * | | | | The Association Relation should use `empty?` and `size` from Relation.Lauro Caetano2014-04-142-8/+11
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 968c581ea34b5236af14805e6a77913b1cb36238 have introduced this bug #14744 on Association Relation when the method `empty?` or `size` was called. Example: # Given an author that does have 3 posts, but none of them with the # title 'Some Title' Author.last.posts.where(title: 'Some Title').size # => 3 It was occurring, because the Association Relation had implemented these methods based on `@association`, this way giving wrong results. To fix it, was necessary to remove the methods `empty?` and `size` from Association Relation. It just have to use these methods from Relation. Example: # Given an author that does have 3 posts, but none of them with the # title 'Some Title' Author.last.posts.where(title: 'Some Title').size # => 0 # Now it will return the correct value. Fixes #14744.
| * | | | Remove outdated commentRafael Mendonça França2014-04-141-1/+0
| | | | |
| * | | | Merge pull request #14729 from akshay-vishnoi/doc_changesRichard Schneeman2014-04-141-4/+4
| |\ \ \ \ | | |/ / / | |/| | | [ci skip] Improve doc, fix grammatical issue
| | * | | [ci skip] Improve doc, fix grammatical issueAkshay Vishnoi2014-04-131-4/+4
| | | | |
* | | | | use cache queries for hm:t associationsAaron Patterson2014-04-151-1/+1
| | | | |
* | | | | oops. should probably double check in the DCLAaron Patterson2014-04-141-1/+3
| | | | |
* | | | | cache scope building on associationsAaron Patterson2014-04-145-12/+78
| | | | | | | | | | | | | | | | | | | | SQL statements for querying associations are now cached
* | | | | Merge branch 'master' into adequaterecordAaron Patterson2014-04-1438-80/+390
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * master: (70 commits) [ci skip] Added link to ruby-lang.org installation. Use the index on hidden field `collection_check_boxes` respects `:index` option for the hidden filed name. docs, double meaning of `serialize` argument. Closes #14284. Just call read_attribute, no need to use `send`. - Fix lingering reference to `:text` instead of the newer `:plain` - Section references `form_tag` instead of the `form_for` used in the example again, read_attribute is public, so just call it read_attribute is public, so we should just call it Disable assest cache store in docs [ci skip] Make counter cache decrementation on destroy idempotent Write the failing test case for concurrent counter cache [ci skip] Use plain underscore instead of "\_". Update documentation to use Rails.application instead Add a changelog entry for #14546 [ci skip] Move tests for deep_dup and duplicable to object directory Missing 'are' in note - [ci skip] CollectionHelpers now accepts a readonly option Fix a few typos [ci skip] Bundle tzinfo-data on :x64_mingw (64-bit Ruby on Windows). don't bother with an offset if the offset is zero ...
| * | | | Merge pull request #14735 from byroot/idempotent-counter-cachesAaron Patterson2014-04-143-4/+47
| |\ \ \ \ | | | | | | | | | | | | Idempotent counter caches, fix concurrency issues with counter caches
| | * | | | Make counter cache decrementation on destroy idempotentJean Boussier2014-04-132-4/+26
| | | | | |
| | * | | | Write the failing test case for concurrent counter cacheJean Boussier2014-04-131-0/+21
| | | | | |
| * | | | | docs, double meaning of `serialize` argument. Closes #14284.Yves Senn2014-04-141-5/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The second argument to serialize has double meaning: * `class_name` of the Type to serialize * `coder` to use then serializing. The new variable name and the docs better describe that behavior.
| * | | | | Just call read_attribute, no need to use `send`.Lauro Caetano2014-04-142-7/+7
| | | | | | | | | | | | | | | | | | | | | | | | Follow up to af549a1ad6692d7e2c756750651f0e1b293f5185
| * | | | | again, read_attribute is public, so just call itAaron Patterson2014-04-131-1/+1
| | | | | |
| * | | | | read_attribute is public, so we should just call itAaron Patterson2014-04-131-1/+1
| |/ / / /
| * | | | Merge pull request #14592 from ↵Rafael Mendonça França2014-04-134-0/+54
| |\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | laurocaetano/equality_between_relation_and_collection_proxy The comparison between `Relation` and `CollectionProxy` should be consistent. Conflicts: activerecord/CHANGELOG.md
| | * | | | Ensure that the comparison between 'CollectionProxy' and ↵Lauro Caetano2014-04-121-0/+9
| | | | | | | | | | | | | | | | | | | | | | | | 'AssociationRelation' is consistent.
| | * | | | Make the comparison between 'Relation' and 'AssociationRelation'Lauro Caetano2014-04-123-1/+14
| | | | | | | | | | | | | | | | | | | | | | | | consistent.
| | * | | | The comparison between `Relation` and `CollectionProxy` should be consistent.Lauro Caetano2014-04-113-0/+32
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Example: author.posts == Post.where(author_id: author.id) # => true Post.where(author_id: author.id) == author.posts # => true Fixes #13506
| * | | | | Add a changelog entry for #14546 [ci skip]Robin Dupret2014-04-131-0/+14
| | |/ / / | |/| | |
| * | | | don't bother with an offset if the offset is zeroAaron Patterson2014-04-121-6/+9
| | | | | | | | | | | | | | | | | | | | | | | | | we're guaranteed to pass a numeric value for offset, so if it's zero, just don't add an offset to the query
| * | | | only add the offset and index when we need toAaron Patterson2014-04-121-8/+9
| | | | |
| * | | | remove branching logic from calls to find_nthAaron Patterson2014-04-121-6/+10
| | | | |
| * | | | please use Ruby, not ActiveSupportAaron Patterson2014-04-111-1/+1
| |/ / /
| * | | Use assert_notRafael Mendonça França2014-04-111-1/+1
| | | |
| * | | New CHANGELOG entries are in to top of fileRafael Mendonça França2014-04-111-7/+7
| | | |
| * | | :scissors:Rafael Mendonça França2014-04-113-7/+7
| | | |
| * | | Merge pull request #14711 from ↵Rafael Mendonça França2014-04-115-3/+35
| |\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | swoker/activerecord_fix_aggregate_methods_with_select Activerecord fix aggregate methods with select
| | * | | fix exception on polymorphic associations with predicatesSimon Woker2014-04-112-0/+16
| | | | |
| | * | | Fix error for aggregate methods with select, see issue #13648Simon Woker2014-04-103-3/+19
| | | | |
| * | | | PostgreSQL, warn once per connection per missing OID. Closes #14275.Yves Senn2014-04-113-2/+19
| | | | | | | | | | | | | | | | | | | | [Yves Senn & Matthew Draper]
| * | | | PostgreSQL, adapter automatically reloads it's type map. Closes #14678.Yves Senn2014-04-118-16/+57
| | | | | | | | | | | | | | | | | | | | [Yves Senn & Matthew Draper]
| * | | | docs, make association `autosave: true` examples runnable. Closes #14700Yves Senn2014-04-111-6/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [ci skip] The examples are written in a way you expect them to be executable. However one snippet assumed there to be two comments when only one was created above. The defined models did not extend `ActiveRecord::Base` The example used `comments.last.mark_for_destruction`. This does no longer load the whole collection but just the last record. It is then refetcht on subsequent calls to `last`. This breaks the example.
| * | | | Merge pull request #12829 from iantropov/issue_insert_via_hmt_scope_3548Rafael Mendonça França2014-04-106-4/+32
| |\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix insertion of records for hmt association with scope Conflicts: activerecord/CHANGELOG.md
| | * | | | Fix insertion of records for hmt association with scope, fix #3548Ivan Antropov2013-11-176-4/+32
| | | | | |
| * | | | | Remove warning of unused variableRafael Mendonça França2014-04-101-1/+1
| | | | | |
| * | | | | No need to call sendRafael Mendonça França2014-04-101-1/+1
| | | | | |
| * | | | | Merge branch 'master' into rm-uuid-fixturesRafael Mendonça França2014-04-1036-115/+266
| |\ \ \ \ \ | | | |/ / / | | |/| | | | | | | | | | | | | | | | | | | | | Conflicts: activerecord/CHANGELOG.md activesupport/CHANGELOG.md
| | * | | | Only call uniq on the conditional that actually needs itCarlos Antonio da Silva2014-04-091-1/+1
| | | | | |
| | * | | | Remove extra collect callCarlos Antonio da Silva2014-04-091-1/+1
| | | | | |
| | * | | | Make sure the reflection test is passing a String to the reflectionLauro Caetano2014-04-091-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | cache.
| | * | | | Make the aggregate_reflections cache work with strings as its keys.Lauro Caetano2014-04-091-2/+2
| | | | | |
| | * | | | No need to call `to_sym` on reflection name, since the cache now worksLauro Caetano2014-04-091-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | with strings with string keys. Related #14668.
| | * | | | Make the reflections cache work with strings as its keys.Lauro Caetano2014-04-091-2/+2
| | | | | |
| * | | | | Merge pull request #12016 from roderickvd/uuid_fixesRafael Mendonça França2014-04-0410-10/+69
| |\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Auto-generate stable fixture UUIDs on PostgreSQL Conflicts: activerecord/CHANGELOG.md activerecord/lib/active_record/fixtures.rb activerecord/test/cases/adapters/postgresql/uuid_test.rb activesupport/CHANGELOG.md
| | * | | | | Auto-generate stable fixture UUIDs on PostgreSQL.Roderick van Domburg2014-01-0711-17/+74
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes: #11524
generated by cgit v1.2.3 (git 2.25.1) at 2025-04-07 15:31:47 +0000