| Commit message (Collapse) | Author | Age | Files | Lines |
|\
| |
| | |
Thread safety fixes
|
| |
| |
| |
| | |
TS::Cache#compute_if_absent guarantees that only a single thread will get to execute the provided block for a given key.
|
|\ \
| | |
| | |
| | |
| | | |
jetthoughts/11376_has_many_assoc_respect_scope_on_build
Removed where_values_hash from AR::NullRelation
|
| |/
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
In order to build associated records for owners which has not been saved
need to get where values to use as default attributes.
But for new record owner uses `ActiveRecord::NullRelation` which
override `where_values_hash` to return empty hash stub.
`where_values_hash` is not used to invoke any sql query, but good to
build others chains (even will be never executed) like:
```ruby
post = Post.new
admin_comment = post.admin_comments.build
assert_equal 'Admin', admin_comment.author
```
Closes #11376, #11676, #11675
|
|\ \
| | |
| | | |
Cleanup identitymap logger from LogSubscriber
|
| | |
| | |
| | |
| | | |
Also renaming ivar @odd_or_even to @odd
|
|\ \ \
| |_|/
|/| | |
|
| | | |
|
| |/
|/|
| |
| | |
side of a hm:t association along with preloading.
|
| | |
|
| |
| |
| |
| | |
.find([1]) should return an Array of entries, even when a invese object is in memory already
|
|\ \
| | |
| | | |
Make sure inverse_of is visible on the has_many callbacks
|
| | | |
|
| | | |
|
|\| |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
* master: (62 commits)
Getting Started Guide: Hello Rails! -> Hello, Rails! and wrap code tag
Add CHANGELOG entry for #12344
Add regression test to #12343
Fix typo in number_to_human docs: you -> your
[Documentation] Add a missing validation to I18n docs
Use the given name in html_options for the hidden field in collection_check_boxes
assign_attributes should return if argument is blank.
No need the else clause
Use join to concat the both side of the AST
Add a CHANGELOG entry about Web Console inclusion
added column type to example in section 2.3
Include web-console in new projects Gemfile
ActiveRecord::ConnectionAdapters::Column.string_to_time method respects string with timezone. Closes #12278.
add test_scoped_root_as_name
Getting Started Guide: update RubyGems Guides link [ci skip]
Deprecate unused quoted_locking_column method.
Update references to wycats/thor to erikhuda/thor.
bcrypt-ruby v3.1.2 supports Ruby 2.0 on Windows
Fix the model name in the association basics guides
We shouldn't override PostgreSQLAdapter's superclass inheritance while monkeypatching
...
|
| |\ \
| | | |
| | | | |
Closes #12278. AR::ConnectionAdapters::Column.string_to_time method respects string with timezone.
|
| | | |
| | | |
| | | |
| | | | |
string with timezone. Closes #12278.
|
| | | | |
|
| |/ /
| | |
| | |
| | |
| | |
| | | |
If you are passed an empty hash, then assign_attributes doesn't need to
do any work and can just return early. This should fix the failing Agile
Web Development tests.
|
| |\ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Raising an error when nil is passed to update_attributes.
Conflicts:
activerecord/CHANGELOG.md
|
| | | | |
|
| | | | |
|
| |\ \ \
| | | | |
| | | | | |
TypeError: superclass mismatch for class PostgreSQLAdapter
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
monkeypatching
Changing Inheritance section leads to following error on JRuby
TypeError: superclass mismatch for class PostgreSQLAdapter
After this change,
Jruby: The above error no longer appear. Tests are still failing but they do run. Progress!
MRI: No change, all green(tested by running take test_test_postgresql)
Thanks to Aditya Sanghi(@asanghi) for help
|
| |\ \ \ \
| | | | | |
| | | | | | |
Creating options for schema dumper.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
These options make it easier to change the config from
ActiveRecord::Base to use something else inside of the SchemaDumper.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Make AM::Dirty less dirty to plugin into AR or other library
|
| |\ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Dump UUID default functions to schema.rb [2nd version]. Fixes #10751.
Conflicts:
activerecord/CHANGELOG.md
|
| | | | | | | |
|
| | | | | | | |
|
| | | | | | | |
|
| |\ \ \ \ \ \
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
Fixed a bug in when using has_many association with :inverse_of option and UUID primary key.
Conflicts:
activerecord/CHANGELOG.md
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
UUID primary key.
|
| |\ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | | |
Fix typo. This test isn't executed even in the postgresql.
|
| | | |_|_|/ / /
| | |/| | | | | |
|
| |/ / / / / /
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
This will make easier to hook protected_attributes gem in our code
without making that gem fragile to change in Rails code base.
Closes #12243
|
| | | | | | | |
|
| | | | | | | |
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
owners once
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
the @associated_records_by_owner ivar
|
| | | | | | | |
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
code
|
| | | | | | | |
|
| | | | | | | |
|
| | | | | | | |
|
| | | | | | | |
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
conditionals from the individual preloaded classes
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
and possibly different rules for finding those objects
|
| | | | | | | |
|
| | | | | | | |
|