aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | | | | pg, clarify default behavior for composite types.Yves Senn2014-05-131-7/+94
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * by default composite types are mapped as `OID::Identity` and issue a warning * the user is advised to register his own `OID::Type` to make use of composite types Registering a new `OID::Type` does currently not allow to specify the type casting behavior when writing to the database. In order for it to work we need to use the values within `@attributes`. They are already being type casted and are ready to be written to the DB. See https://github.com/rails/rails/blob/57643c961feb24b662620d330e71103a830003e8/activerecord/lib/active_record/attribute_methods.rb#L460-L462
* | | | | | | extract pg type map initialization process to `TypeMapInitializer`.Yves Senn2014-05-132-65/+74
|/ / / / / /
* | | | | | test, move all pg array tests into `postgresql/array_test.rb`.Yves Senn2014-05-132-51/+29
| | | | | |
* | | | | | docs, explain usage of `count` + `select`. Closes #15065. [ci skip]Yves Senn2014-05-131-0/+8
|/ / / / /
* | | | | test, use `columns_hash[]` in place of `columns.find {}`.Yves Senn2014-05-128-12/+12
| | | | |
* | | | | pg, `change_column_default` accepts `[]`. Closes #11586.Yves Senn2014-05-124-3/+18
| | | | |
* | | | | pg, map `char` and `name` types as string. [dark-panda & Yves Senn]Yves Senn2014-05-123-0/+33
| | | | | | | | | | | | | | | | | | | | Closes #10802.
* | | | | pg, fix Infinity and NaN values conversion.Innokenty Mihailov2014-05-123-3/+30
|/ / / / | | | | | | | | | | | | Before this patch `Infinity`, `-Infinity` and `Nan` were read as `0`.
* | | | Handle other pk types in PostgreSQL gracefully.Patrick Robertson2014-05-123-1/+33
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In #10410 it was noted that you can no longer create PK's with the type of bigserial in PostgreSQL in 4.0.0.rc1. This is mostly because the newer adapter is checking for column type with the id column instead of just letting it pass through like it did before. Side effects: You may just create a PK column of a type that you really don't want to be your PK. As far as I can tell this was allowed in 3.2.X and perhaps an exception should be raised if you try and do something extremely dumb.
* | | | Merge pull request #14999 from yahonda/modify_bind_variable_nameYves Senn2014-05-121-2/+3
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Modify assert conditions not to be affected by each database bind variable naming conventions Closes #14999.
| * | | | Modify assert conditions not to be affectedYasuo Honda2014-05-121-2/+3
| | | | | | | | | | | | | | | | | | | | by each database bind variable naming conventions
* | | | | Update attribute_methods.rbGuillermo Iguaran2014-05-111-1/+1
| | | | | | | | | | | | | | | Improve documentation
* | | | | Merge pull request #15063 from cbeer/correct-attribute_present-docsGuillermo Iguaran2014-05-111-7/+7
|\ \ \ \ \ | | | | | | | | | | | | correcting method documentation [ci skip]
| * | | | | correcting method documentation [ci skip]Chris Beer2014-05-111-7/+7
| | | | | |
* | | | | | Merge pull request #10662 from ↵Carlos Antonio da Silva2014-05-111-9/+9
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | take/change-test-name-for-ActiveRecord--Validations#valid- Refactor AR's validations_test.rb
| * | | | | | Refactor AR's validations_test.rbTakehiro Adachi2013-12-031-9/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The `:context` switch feature is implemented in ActiveRecord::Validations#valid? method, so we should rename the test names, and execute `valid?` in the test. Change test name in AR's validations_test.rb This test is testing save method's code
* | | | | | | docs, fix typo in docs added by ed56e596a04673. [ci skip]Yves Senn2014-05-101-2/+2
| | | | | | |
* | | | | | | minor change in AR readme [ci skip]Vijay Dev2014-05-101-1/+1
| | | | | | |
* | | | | | | Merge branch 'master' of github.com:rails/docrailsVijay Dev2014-05-104-8/+22
|\ \ \ \ \ \ \
| * | | | | | | copy edits [ci skip]Vijay Dev2014-05-101-6/+5
| | | | | | | |
| * | | | | | | [ci skip] add example to AR#assign_attributesschneems2014-05-091-0/+10
| | | | | | | |
| * | | | | | | fix formatting errors [ci skip]Vijay Dev2014-05-091-6/+6
| | | | | | | |
| * | | | | | | copy edits [ci skip]Vijay Dev2014-05-081-1/+1
| | | | | | | |
| * | | | | | | [ci skip] document type_cast_for_writeschneems2014-05-072-0/+5
| | | | | | | |
| * | | | | | | Fix Formatting in AR ReadmeGaurish Sharma2014-05-041-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | Don't make free form text appear in code blocks [ci skip]
* | | | | | | | deprecate, join, preload, eager load of instance dependent associations.Yves Senn2014-05-106-4/+56
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Closes #15024. These operations happen before instances are created. The current behavior is misleading and can result in broken behavior.
* | | | | | | | Fix broken proc syntax for 1.9.3Arthur Neves2014-05-091-1/+1
| | | | | | | |
* | | | | | | | Documentation, add examples of using an Enum scopeZac2014-05-091-2/+4
| | | | | | | | | | | | | | | | | | | | | | | | When scanning the Enum API page I found it easy to miss that scopes are generated. Adding an example clarifies use and has more... *pop*...
* | | | | | | | test, regression test for has_many with instance dependent scope.Yves Senn2014-05-092-0/+12
| | | | | | | |
* | | | | | | | Reverts "Fix bugs with changed attributes tracking when transaction gets ↵Arthur Neves2014-05-093-52/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | rollback" We are reverting these commits, because there are other caveats related to dirty attributes not being restored when a transaction is rollback. For instance, nested transactions cannot proper restore the dirty attributes state after a rollback. At the moment, the dirty attributes are scoped by the transaction. When we call `.save` on a record, the dirty attributes will be reset even if the transaction gets rollback. [related #13166] [related #15018] [related #15016] [closes #15019] This reverts commits * bab48f0a3d53a08bc23ea0887219e8deb963c3d9 * b0fa7cf3ff8432cc2eef3682b34763b7f8c93cc8. * 73fb39b6faa9de593ae75ad4e3b8e065ea0e53af * 37c238927fbed059de3f26a90d8923fb377568a5. * 8d8d4f1560264cd1c74364d67fa0501f6dd2c4fa Revert "Merge pull request #13166 from bogdan/transaction-magic"
* | | | | | | | set a constant for the "anonymous" habtm model fixes #15022Aaron Patterson2014-05-082-0/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I wanted the middle model to be anonymous, but we have to give it a name for marshal support. :'(
* | | | | | | | test, regression test for unparsable PostgreSQL defaults.Yves Senn2014-05-081-0/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This test was inspired by #14866. That PR would break this functionality and we should make sure we notice that in the future.
* | | | | | | | Merge pull request #14992 from fredwu/habtm_relation_size_calculation_fixCarlos Antonio da Silva2014-05-084-1/+30
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | Habtm relation size calculation fix. Fixes #14913, Fixes #14914.
| * | | | | | | | Fixed HABTM's CollectionAssociation sizeFred Wu2014-05-084-1/+30
| | |_|/ / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | HABTM should fall back to using the normal CollectionAssociation's size calculation if the collection is not cached or loaded. This addresses both #14913 and #14914 for master.
* / | | | | | | test, reset changed state in PG's uuid tests.Yves Senn2014-05-081-2/+4
|/ / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This resulted in some unrelated errors on Traivs: 1) Error: PostgresqlUUIDTest#test_treat_blank_uuid_as_nil: ActiveRecord::StatementInvalid: PG::UndefinedColumn: ERROR: column "thingy" of relation "uuid_data_type" does not exist LINE 1: INSERT INTO "uuid_data_type" ("thingy") VALUES ($1) RETURNIN... ^ : INSERT INTO "uuid_data_type" ("thingy") VALUES ($1) RETURNING "id" /cc @zuhao
* | | | | | | Dup the changed_attributes otherwise we could lose themArthur Neves2014-05-071-1/+1
| | | | | | |
* | | | | | | Add CHANGELOG entry for #14989Rafael Mendonça França2014-05-071-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Closes #14989
* | | | | | | Return a non zero code when db has never been setup on statusPaul B2014-05-071-2/+1
| | | | | | |
* | | | | | | Keep track of dirty attrs after after rollback.Arthur Neves2014-05-074-20/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | [related #13166]
* | | | | | | Merge pull request #13166 from bogdan/transaction-magicRafael Mendonça França2014-05-073-1/+62
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | [Regression 3.2 -> 4.0] Fix bugs with changed attributes tracking when transaction gets rollback
| * | | | | | | Fix bugs with changed attributes tracking when transaction gets rollbackBogdan Gusiev2013-12-043-1/+62
| | |/ / / / / | |/| | | | |
* | | | | | | test, persist inherited class with different table name. Refs #14971.Yves Senn2014-05-071-0/+14
| |_|/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | This case prevents against regressions. The change was suggested in a recent PR but the all our tests passed.
* | | | | | Follow-up to #14990 [ci skip]Jon Atack2014-05-071-10/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Rewrite to avoid 'we'/'you', add missing period, and keep lines at 80 chars. Cheers :) Improve readability with help from @senny [ci skip]
* | | | | | Merge pull request #14982 from eric-chahin/GBV_refactorRafael Mendonça França2014-05-062-8/+6
|\ \ \ \ \ \ | | | | | | | | | | | | | | Refactored AssociationScope#get_bind_values
| * | | | | | Refactor AssociationScope#get_bind_valuesEric Chahin2014-05-052-8/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Added #join_id_for(owner) to reflection to avoid accessing the source_macro
* | | | | | | Fixed grammarFred Wu2014-05-061-1/+1
| | | | | | |
* | | | | | | refactor and clean up delete_all methodeileencodes2014-05-051-9/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Now that delete_all with destroy or delete_all dependency behave the same we no longer need this conditional. This means we can remove the new delete_all_with_dependency method I added and go straight to delete_records from delete_all, passing :all and the dependent directly.
* | | | | | | Add support for module-level table_suffix in modelsJenner LaFave2014-05-054-1/+63
|/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | This makes table_name_suffix work the same as table_name_prefix when using namespaced models. Pretty much the same as 67d1cec.
* | | | | | Improve CHANGELOG entry [ci skip]Rafael Mendonça França2014-05-051-3/+3
| | | | | |
* | | | | | Merge pull request #14978 from bogdan/relation-joinRafael Mendonça França2014-05-055-2/+17
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | [Regression 4.0 -> 4.1] Put back Relation#join method as a delegate to Array
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-09 13:02:44 +0000