aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
Commit message (Collapse)AuthorAgeFilesLines
* fix todo: use minitest skip instead of return nilFrancesco Rodriguez2012-05-131-9/+8
|
* Merge pull request #6193 from mhfs/fix_oracle_specRafael Mendonça França2012-05-121-1/+1
|\ | | | | Fix failing AR test on Oracle
| * Fix failing test on Oracle. Having a duplicated column specified in aMarcelo Silveira2012-05-071-1/+1
| | | | | | | | | | | | select with order on the same column makes Oracle complain about "column ambiguously defined" when an order is defined on such column (introduced by default order on `first`) (fixes #6147).
* | fixes a nodoc which swallowed the documentation for the rest of the methods ↵Vijay Dev2012-05-121-2/+1
| | | | | | | | [ci skip]
* | Merge pull request #6285 from ↵Vijay Dev2012-05-121-1/+1
|\ \ | | | | | | | | | | | | acapilleri/missplelling_error_in_abstract_mysql_adapter missplelling error in abstract_mysql_adapter
| * | missplelling error in abstract_mysql_adapterAngelo Capilleri2012-05-121-1/+1
| | |
* | | Merge branch 'master' of github.com:lifo/docrailsVijay Dev2012-05-123-6/+28
|\ \ \ | | | | | | | | | | | | | | | | Conflicts: activesupport/lib/active_support/callbacks.rb
| * | | copy edits [ci skip]Vijay Dev2012-05-121-4/+1
| | | |
| * | | Better document the difference between #clone and #dup.Erich Menge2012-05-111-1/+26
| | | | | | | | | | | | | | | | | | | | Add #nodoc to initialize_dup and use :method: to document the #dup method. Relates to issue #6235
| * | | better wordingHrvoje Šimić2012-05-111-4/+4
| | | |
| * | | missing 'with'Hrvoje Šimić2012-05-111-1/+1
| | | |
* | | | s/wether/whether [ci skip]Vijay Dev2012-05-121-1/+1
| | | |
* | | | mispelling errors in render_text_test.rb and sqlite_specific_schemaangelo giovanni capilleri2012-05-121-1/+1
| | | |
* | | | Remove #=== quirkJon Leighton2012-05-113-17/+0
| | | | | | | | | | | | | | | | Makes it consistent with Relation. Can't see a use for this.
* | | | Lazy load I18nSantiago Pastorino2012-05-111-2/+3
| | | |
* | | | this stuff can all be handled by RelationJon Leighton2012-05-111-38/+0
| | | |
* | | | extract deprecated codeJon Leighton2012-05-111-8/+1
| | | |
* | | | set_owner_attributes is covered by the scopingJon Leighton2012-05-111-4/+3
| | | |
* | | | CollectionProxy < RelationJon Leighton2012-05-1111-60/+79
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This helps bring the interfaces of CollectionProxy and Relation closer together, and reduces the delegation backflips we need to perform. For example, first_or_create is defined thus: class ActiveRecord::Relation def first_or_create(...) first || create(...) end end If CollectionProxy < Relation, then post.comments.first_or_create will hit the association's #create method which will actually add the new record to the association, just as post.comments.create would. With the previous delegation, post.comments.first_or_create expands to post.comments.scoped.first_or_create, where post.comments.scoped has no knowledge of the association.
* | | | Return false for exists? with new records - fixes #6199.Andrew White2012-05-103-2/+3
| | | |
* | | | remove unnecessary 'examples' noise [ci skip]Vijay Dev2012-05-112-28/+18
| | | |
* | | | Merge pull request #4254 from alexeymuranov/my-nicify-fixtures-rbJeremy Kemper2012-05-092-81/+82
|\ \ \ \ | | | | | | | | | | Rename variables and remove unused code in fixtures.rb
| * | | | Rename some variablesAlexey Muranov2012-05-092-78/+82
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Rename some parameters and instance and local variables, mostly in fixtures.rb. Also remove an unused assignment to an instance variable. There are minor code changes.
| * | | | Remove unused private method in fixtures.rbAlexey Muranov2012-05-091-3/+0
| | | | | | | | | | | | | | | | | | | | Remove the unused private method ActiveRecord::Fixtures#yaml_fixtures_key(path).
| * | | | Remove unused parameter in ::instantiate_fixturesAlexey Muranov2012-05-091-5/+5
| |/ / / | | | | | | | | | | | | Second parameter of Fixtures::instantiate_fixtures was not used, so i removed it.
* | | | Allow to run `connection_adapters/quoting_test.rb` independentlyPiotr Sarnacki2012-05-091-1/+3
| | | |
* | | | Merge pull request #5362 from zenprogrammer/quoting_bugAaron Patterson2012-05-092-0/+12
|\ \ \ \ | | | | | | | | | | Fixed bug in ActiveRecord that caused classes to be quoted incorrectly
| * | | | Fixed bug in Quoting that caused classes to be quoted incorrectlyRyan Oblak2012-03-092-0/+12
| | | | |
* | | | | make both cached and record_updated accessors in one lineHemant Kumar2012-05-091-2/+1
| | | | |
* | | | | after_commit :on => :update should be called when save isHemant Kumar2012-05-091-0/+7
| | | | | | | | | | | | | | | | | | | | called from after_commit callback
* | | | | Fix transaction state not changing when after record gets commitedHemant Kumar2012-05-092-6/+27
| |/ / / |/| | |
* | | | Merge branch 'master' of github.com:lifo/docrailsVijay Dev2012-05-082-2/+3
|\ \ \ \ | |_|_|/ |/| | |
| * | | Doc for ActiveRecord::Result empty? methodRob Zolkos2012-05-071-0/+1
| | | |
| * | | SpawnMethods#merge returns the intersection when passed an array, and not ↵Mitch Crowe2012-05-051-2/+2
| | | | | | | | | | | | | | | | the union. Update the documentation to reflect this.
* | | | Use deep_dup in aciverecord default columns assignmentPiotr Sarnacki2012-05-061-4/+2
| | | |
* | | | Merge pull request #6173 from mhfs/takes_instead_firstJeremy Kemper2012-05-053-5/+17
|\ \ \ \ | | | | | | | | | | Use `take` instead of `first` to avoid unwanted implicit ordering. Closes #6147.
| * | | | Use `take` instead of `first` to avoid unwanted implicit ordering (fixes #6147)Marcelo Silveira2012-05-053-5/+17
| | | | |
* | | | | Merge pull request #6069 from mipearson/use_strict_mode_in_mysqlJeremy Kemper2012-05-056-1/+54
|\ \ \ \ \ | | | | | | | | | | | | Use strict mode in mysql
| * | | | | Changelog entry regarding mysql(2) STRICT_ALL_TABLESMichael Pearson2012-05-051-0/+6
| | | | | |
| * | | | | Add config option, rdoc, tests for mysql(2) STRICT_ALL_TABLES mode.Michael Pearson2012-05-054-4/+38
| | | | | |
| * | | | | Default to 'strict mode' in MySQLMichael Pearson2012-05-052-0/+11
| | | | | |
| * | | | | Modify test schema.rb to use a VARCHAR rather than a TEXT when a default is ↵Michael Pearson2012-05-051-1/+3
| |/ / / / | | | | | | | | | | | | | | | required to keep MySQL happy.
* | | | | Merge pull request #6054 from flexoid/column-fixJon Leighton2012-05-052-3/+31
|\ \ \ \ \ | | | | | | | | | | | | Prevent creating valid time-like objects from blank string from db
| * | | | | Prevent creating valid time-like objects from blank string from dbEgor Lynko2012-05-052-3/+31
| | | | | | | | | | | | | | | | | | | | | | | | Issue #6045
* | | | | | Revert "Merge pull request #5494 from ↵Jon Leighton2012-05-054-43/+6
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | armstrjare/active_record_relation_keep_association_join_context_on_merge" This reverts commit dcd04e76179611a9db28c9e391aa7d6c2a5b046a, reversing changes made to 58a49875df63729f07a9a81d1ee349087d258df5.
* | | | | Merge pull request #5494 from ↵Jon Leighton2012-05-054-6/+43
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | | | | | | armstrjare/active_record_relation_keep_association_join_context_on_merge ActiveRecord::Relation - maintain context of joined associations on merges
| * | | | Allow ActiveRecord::Relation merges to maintain context of joined associationsJared Armstrong2012-05-044-6/+43
| | | | |
* | | | | Duplicate column_defaults properly (closes #6115)Piotr Sarnacki2012-05-043-2/+12
| | | | |
* | | | | Change unless + ! into ifPiotr Sarnacki2012-05-041-1/+1
| | | | |
* | | | | Merge pull request #3713 from kf8a/masterAaron Patterson2012-05-042-2/+19
|\ \ \ \ \ | | | | | | | | | | | | postgresql adapter should quote not a number and infinity correctly for float columns