Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Merge pull request #29253 from kamipo/prevent_extra_query | Matthew Draper | 2017-05-29 | 2 | -6/+12 |
|\ | | | | | Prevent extra `current_database` query for `encoding`/`collation`/`ctype` | ||||
| * | Prevent extra `current_database` query for `encoding`/`collation`/`ctype` | Ryuta Kamizono | 2017-05-28 | 2 | -6/+12 |
| | | |||||
* | | Merge pull request #28969 from ↵ | Matthew Draper | 2017-05-28 | 4 | -14/+16 |
|\ \ | | | | | | | | | | | | | kamipo/refactor_enum_to_use_value_instead_of_label Refactor enum to use `value` instead of `label` in the scope | ||||
| * | | Refactor enum to use `value` instead of `label` in the scope | Ryuta Kamizono | 2017-05-07 | 4 | -14/+16 |
| | | | |||||
* | | | Merge pull request #29003 from kamipo/delegate_ast_and_locked_to_arel_explicitly | Matthew Draper | 2017-05-28 | 4 | -1/+13 |
|\ \ \ | |_|/ |/| | | Delegate `ast` and `locked` to `arel` explicitly | ||||
| * | | Delegate `ast` and `locked` to `arel` explicitly | Ryuta Kamizono | 2017-05-06 | 4 | -1/+13 |
| | | | | | | | | | | | | | | | | | | | | | | | | Currently `ast` and `locked` are used in the internal but delegating to `arel` is depend on `method_missing`. If a model class is defined these methods, `select_all` will be broken. It should be delegated to `arel` explicitly. | ||||
* | | | Merge pull request #29197 from kamipo/enable_extending_even_if_scope_returns_nil | Matthew Draper | 2017-05-28 | 2 | -7/+7 |
|\ \ \ | | | | | | | | | Enable extending even if scope returns nil | ||||
| * | | | Enable extending even if scope returns nil | Ryuta Kamizono | 2017-05-24 | 2 | -7/+7 |
| | | | | |||||
* | | | | Merge pull request #29250 from kamipo/remove_unused_association_interpolate | Matthew Draper | 2017-05-28 | 1 | -8/+0 |
|\ \ \ \ | | | | | | | | | | | Remove unused `Association#interpolate` | ||||
| * | | | | Remove unused `Association#interpolate` | Ryuta Kamizono | 2017-05-28 | 1 | -8/+0 |
| | | | | | | | | | | | | | | | | | | | | Using `Association#interpolate` was removed since #11251. | ||||
* | | | | | Fix regression in Numericality validator where extra decimal places on | Bradley Priest | 2017-05-27 | 1 | -0/+14 |
|/ / / / | | | | | | | | | a user input for a decimal column were ignored by numerically validations | ||||
* | | | | Merge pull request #29240 from tjschuck/ar_batches_doc_updates | Rafael França | 2017-05-26 | 1 | -12/+12 |
|\ \ \ \ | | | | | | | | | | | Doc updates for ActiveRecord::Batches | ||||
| * | | | | Doc updates for ActiveRecord::Batches | T.J. Schuck | 2017-05-26 | 1 | -12/+12 |
| | | | | | | | | | | | | | | | [ci skip] | ||||
* | | | | | Merge pull request #29237 from mohitnatoo/arel-update-doc | Rafael França | 2017-05-26 | 1 | -3/+3 |
|\ \ \ \ \ | |/ / / / |/| | | | | [ci skip] Changed sentence formation for ActiveRecordRelation#update | ||||
| * | | | | [ci skip] Changed sentence formation for ActiveRecordRelation#update | Mohit Natoo | 2017-05-26 | 1 | -3/+3 |
| | | | | | |||||
* | | | | | Merge pull request #29239 from koic/remove_redundant_test_assertion | Matthew Draper | 2017-05-27 | 1 | -1/+0 |
|\ \ \ \ \ | | | | | | | | | | | | | Remove a redundant test assertion | ||||
| * | | | | | Remove a redundant test assertion | Koichi ITO | 2017-05-27 | 1 | -1/+0 |
| | | | | | | |||||
* | | | | | | Avoid circular require due to autoload | Matthew Draper | 2017-05-26 | 1 | -9/+9 |
|/ / / / / | |||||
* | | | | | Merge pull request #29176 from bogdanvlviv/define-path-with__dir__ | Matthew Draper | 2017-05-26 | 10 | -13/+13 |
|\ \ \ \ \ | | | | | | | | | | | | | Define path with __dir__ | ||||
| * | | | | | Define path with __dir__ | bogdanvlviv | 2017-05-23 | 10 | -13/+13 |
| | |/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | | ".. with __dir__ we can restore order in the Universe." - by @fxn Related to 5b8738c2df003a96f0e490c43559747618d10f5f | ||||
* | | | | | Merge pull request #29221 from koic/remove_duplicate_migration_test | Matthew Draper | 2017-05-26 | 1 | -27/+0 |
|\ \ \ \ \ | | | | | | | | | | | | | Remove a duplicate test of migration_test in AR | ||||
| * | | | | | Remove a duplicate test of migration_test in AR | Koichi ITO | 2017-05-25 | 1 | -27/+0 |
| | | | | | | |||||
* | | | | | | Merge pull request #29230 from koic/remove_duplicate_schema_authorization_test | Matthew Draper | 2017-05-26 | 1 | -11/+0 |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | Remove a duplicate test of schema_authorization_test in AR | ||||
| * | | | | | | Remove a duplicate test of schema_authorization_test in AR | Koichi ITO | 2017-05-25 | 1 | -11/+0 |
| | | | | | | | |||||
* | | | | | | | Merge pull request #29215 from voxmedia/ar_optimizations | Matthew Draper | 2017-05-26 | 3 | -3/+4 |
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | ActiveRecord initialization optimizations | ||||
| * | | | | | | | Make #deep_dup use #allocate instead of #new | Michael Lovitt | 2017-05-25 | 1 | -1/+3 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This change preserves the speedup made in a24912cb1d3 (by avoiding the wasted shallow dup of @attributes) while ensuring that the performance of #deep_dup won't be tied to the performance of #initialize | ||||
| * | | | | | | | Performance optimization for ActiveRecord#column_defaults | Michael Lovitt | 2017-05-24 | 1 | -1/+2 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Memoize the #column_defaults class property, as ActiveRecord does for other properties in this module. This change addresses slowness in ActiveRecord initialization introduced starting in Rails 5.0. This method's performance has not changed with Rails 5, but it is now called much more frequently than before: every time an STI model is instantiated. | ||||
| * | | | | | | | Performance optimization for ActiveRecord#subclass_from_attributes | Michael Lovitt | 2017-05-24 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This change addresses slowness in ActiveRecord initialization introduced starting in Rails 5.0. | ||||
| * | | | | | | | Performance optimization for AttributeSet#deep_dup | Michael Lovitt | 2017-05-24 | 1 | -3/+1 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Skip the call to #dup, since it does a shallow copy of attributes, which is wasted effort, since #deep_dup then replaces that shallow copy with a #deep_dup of the given attributes. This change addresses slowness in ActiveRecord initialization introduced starting in Rails 5.0. | ||||
* | | | | | | | | Merge pull request #29226 from koic/remove_duplicate_mysql_rake_test | Matthew Draper | 2017-05-26 | 1 | -7/+0 |
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | Remove a duplicate test of mysql_rake_test | ||||
| * | | | | | | | | Remove a duplicate test of mysql_rake_test | Koichi ITO | 2017-05-26 | 1 | -7/+0 |
| | |/ / / / / / | |/| | | | | | | |||||
* | | | | | | | | Merge pull request #29216 from matthewd/threadsafe-load-schema | Matthew Draper | 2017-05-26 | 3 | -3/+56 |
|\ \ \ \ \ \ \ \ | |/ / / / / / / |/| | | | | | | | Add a Monitor to ModelSchema#load_schema | ||||
| * | | | | | | | Add a Monitor to ModelSchema#load_schema | Matthew Draper | 2017-05-25 | 3 | -3/+56 |
| |/ / / / / / | | | | | | | | | | | | | | | | | | | | | | [Vikrant Chaudhary, David Abdemoulaie, Matthew Draper] | ||||
* | | | | | | | Merge pull request #29175 from kamipo/extract_json_shared_tests | Matthew Draper | 2017-05-25 | 3 | -351/+184 |
|\ \ \ \ \ \ \ | |_|/ / / / / |/| | | | | | | Extract `JSONSharedTestCases` | ||||
| * | | | | | | Extract `JSONSharedTestCases` | Ryuta Kamizono | 2017-05-22 | 3 | -351/+184 |
| | |/ / / / | |/| | | | | | | | | | | | | | | | | | | | | | | Both `mysql2/json_test.rb` and `postgresql/json_test.rb` have same test cases. | ||||
* | | | | | | Merge pull request #29181 from kamipo/fix_circular_left_joins_with_scoping | Matthew Draper | 2017-05-25 | 2 | -3/+10 |
|\ \ \ \ \ \ | |_|/ / / / |/| | | | | | Fix crashing on circular left join references with scoping | ||||
| * | | | | | Fix crashing on circular left join references with scoping | Ryuta Kamizono | 2017-05-24 | 2 | -3/+10 |
| | | | | | | | | | | | | | | | | | | | | | | | | Follow up of #25702. | ||||
* | | | | | | Fix a RuboCop offences using `rubocop -a` | Koichi ITO | 2017-05-24 | 3 | -5/+4 |
|/ / / / / | |||||
* | | | | | Merge pull request #29141 from kamipo/make_helper_methods_to_private | Matthew Draper | 2017-05-24 | 1 | -18/+19 |
|\ \ \ \ \ | | | | | | | | | | | | | Make helper methods in tests to private | ||||
| * | | | | | Make helper methods in tests to private | Ryuta Kamizono | 2017-05-19 | 1 | -18/+19 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `make_model` and `make_no_pk_hm_t` in `HasManyThroughAssociationsTest` are not a test case. it should be private. | ||||
* | | | | | | Merge pull request #29145 from kamipo/reference_type_should_be_not_null | Matthew Draper | 2017-05-24 | 2 | -1/+9 |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | Both reference id and type should be `NOT NULL` if `null: false` is specified | ||||
| * | | | | | | Both reference id and type should be `NOT NULL` if `null: false` is specified | Ryuta Kamizono | 2017-05-19 | 2 | -1/+9 |
| |/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a regression due to #28282. Fixes #29136. | ||||
* | | | | | | Merge pull request #29027 from mohitnatoo/foreign-key-name | Matthew Draper | 2017-05-24 | 1 | -2/+3 |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | Adding Foreing Key - Don't worry about building the identifier if name is already present. | ||||
| * | | | | | | [Foreign Key] Don't worry about the building identifier if name is already ↵ | Mohit Natoo | 2017-05-10 | 1 | -2/+3 |
| | |_|/ / / | |/| | | | | | | | | | | | | | | | | present. | ||||
* | | | | | | Merge pull request #29167 from koic/remove_duplicate_inverse_associations_test | Matthew Draper | 2017-05-24 | 1 | -14/+0 |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | Remove a duplicate test of inverse_associations_test in AR | ||||
| * | | | | | | Remove a duplicate test of inverse_associations_test in AR | Koichi ITO | 2017-05-21 | 1 | -14/+0 |
| | |_|/ / / | |/| | | | | |||||
* | | | | | | Merge pull request #29174 from kamipo/remove_unused_join_part_name | Matthew Draper | 2017-05-24 | 1 | -4/+0 |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | Remove unused `JoinPart#name` | ||||
| * | | | | | | Remove unused `JoinPart#name` | Ryuta Kamizono | 2017-05-22 | 1 | -4/+0 |
| |/ / / / / | |||||
* | | | | | | Merge pull request #29182 from kamipo/remove_unused_left_joins_values_generation | Matthew Draper | 2017-05-24 | 2 | -2/+2 |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | Remove unused `left_joins_values` generation | ||||
| * | | | | | | Remove unused `left_joins_values` generation | Ryuta Kamizono | 2017-05-23 | 2 | -2/+2 |
| |/ / / / / | | | | | | | | | | | | | | | | | | | This was added at #22125 but `left_joins_values` is never used. |