rails.git - Mirror of official rails repo with custom fixes.

	Commit message (Collapse)	Author	Age	Files	Lines
...
* \| \| \| \| \| \| \|	Merge pull request #29221 from koic/remove_duplicate_migration_test	Matthew Draper	2017-05-26	1	-27/+0
\|\ \ \ \ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Remove a duplicate test of migration_test in AR
\| * \| \| \| \| \| \| \|	Remove a duplicate test of migration_test in AR	Koichi ITO	2017-05-25	1	-27/+0
\| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \|	Merge pull request #29230 from koic/remove_duplicate_schema_authorization_test	Matthew Draper	2017-05-26	1	-11/+0
\|\ \ \ \ \ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Remove a duplicate test of schema_authorization_test in AR
\| * \| \| \| \| \| \| \| \|	Remove a duplicate test of schema_authorization_test in AR	Koichi ITO	2017-05-25	1	-11/+0
\| \| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \|	Merge pull request #29215 from voxmedia/ar_optimizations	Matthew Draper	2017-05-26	3	-3/+4
\|\ \ \ \ \ \ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	ActiveRecord initialization optimizations
\| * \| \| \| \| \| \| \| \| \|	Make #deep_dup use #allocate instead of #new	Michael Lovitt	2017-05-25	1	-1/+3
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	This change preserves the speedup made in a24912cb1d3 (by avoiding the wasted shallow dup of @attributes) while ensuring that the performance of #deep_dup won't be tied to the performance of #initialize
\| * \| \| \| \| \| \| \| \| \|	Performance optimization for ActiveRecord#column_defaults	Michael Lovitt	2017-05-24	1	-1/+2
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Memoize the #column_defaults class property, as ActiveRecord does for other properties in this module. This change addresses slowness in ActiveRecord initialization introduced starting in Rails 5.0. This method's performance has not changed with Rails 5, but it is now called much more frequently than before: every time an STI model is instantiated.
\| * \| \| \| \| \| \| \| \| \|	Performance optimization for ActiveRecord#subclass_from_attributes	Michael Lovitt	2017-05-24	1	-1/+1
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	This change addresses slowness in ActiveRecord initialization introduced starting in Rails 5.0.
\| * \| \| \| \| \| \| \| \| \|	Performance optimization for AttributeSet#deep_dup	Michael Lovitt	2017-05-24	1	-3/+1
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Skip the call to #dup, since it does a shallow copy of attributes, which is wasted effort, since #deep_dup then replaces that shallow copy with a #deep_dup of the given attributes. This change addresses slowness in ActiveRecord initialization introduced starting in Rails 5.0.
* \| \| \| \| \| \| \| \| \| \|	Merge pull request #29226 from koic/remove_duplicate_mysql_rake_test	Matthew Draper	2017-05-26	1	-7/+0
\|\ \ \ \ \ \ \ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Remove a duplicate test of mysql_rake_test
\| * \| \| \| \| \| \| \| \| \| \|	Remove a duplicate test of mysql_rake_test	Koichi ITO	2017-05-26	1	-7/+0
\| \| \|/ / / / / / / / / \| \|/\| \| \| \| \| \| \| \| \|
* \| \| \| \| \| \| \| \| \| \|	Merge pull request #29216 from matthewd/threadsafe-load-schema	Matthew Draper	2017-05-26	3	-3/+56
\|\ \ \ \ \ \ \ \ \ \ \ \| \|/ / / / / / / / / / \|/\| \| \| \| \| \| \| \| \| \|	Add a Monitor to ModelSchema#load_schema
\| * \| \| \| \| \| \| \| \| \|	Add a Monitor to ModelSchema#load_schema	Matthew Draper	2017-05-25	3	-3/+56
\| \|/ / / / / / / / / \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	[Vikrant Chaudhary, David Abdemoulaie, Matthew Draper]
* \| \| \| \| \| \| \| \| \|	Merge pull request #29175 from kamipo/extract_json_shared_tests	Matthew Draper	2017-05-25	3	-351/+184
\|\ \ \ \ \ \ \ \ \ \ \| \|_\|/ / / / / / / / \|/\| \| \| \| \| \| \| \| \|	Extract `JSONSharedTestCases`
\| * \| \| \| \| \| \| \| \|	Extract `JSONSharedTestCases`	Ryuta Kamizono	2017-05-22	3	-351/+184
\| \| \|/ / / / / / / \| \|/\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Both `mysql2/json_test.rb` and `postgresql/json_test.rb` have same test cases.
* \| \| \| \| \| \| \| \|	Merge pull request #29181 from kamipo/fix_circular_left_joins_with_scoping	Matthew Draper	2017-05-25	2	-3/+10
\|\ \ \ \ \ \ \ \ \ \| \|_\|/ / / / / / / \|/\| \| \| \| \| \| \| \|	Fix crashing on circular left join references with scoping
\| * \| \| \| \| \| \| \|	Fix crashing on circular left join references with scoping	Ryuta Kamizono	2017-05-24	2	-3/+10
\| \| \|_\|_\|_\|_\|/ / \| \|/\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Follow up of #25702.
* / \| \| \| \| \| \|	Fix a RuboCop offences using `rubocop -a`	Koichi ITO	2017-05-24	3	-5/+4
\|/ / / / / / /
* \| \| \| \| \| \|	Merge pull request #29141 from kamipo/make_helper_methods_to_private	Matthew Draper	2017-05-24	1	-18/+19
\|\ \ \ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Make helper methods in tests to private
\| * \| \| \| \| \| \|	Make helper methods in tests to private	Ryuta Kamizono	2017-05-19	1	-18/+19
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	`make_model` and `make_no_pk_hm_t` in `HasManyThroughAssociationsTest` are not a test case. it should be private.
* \| \| \| \| \| \| \|	Merge pull request #29145 from kamipo/reference_type_should_be_not_null	Matthew Draper	2017-05-24	2	-1/+9
\|\ \ \ \ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Both reference id and type should be `NOT NULL` if `null: false` is specified
\| * \| \| \| \| \| \| \|	Both reference id and type should be `NOT NULL` if `null: false` is specified	Ryuta Kamizono	2017-05-19	2	-1/+9
\| \|/ / / / / / / \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	This is a regression due to #28282. Fixes #29136.
* \| \| \| \| \| \| \|	Merge pull request #29027 from mohitnatoo/foreign-key-name	Matthew Draper	2017-05-24	1	-2/+3
\|\ \ \ \ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Adding Foreing Key - Don't worry about building the identifier if name is already present.
\| * \| \| \| \| \| \| \|	[Foreign Key] Don't worry about the building identifier if name is already ↵	Mohit Natoo	2017-05-10	1	-2/+3
\| \| \|_\|/ / / / / \| \|/\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	present.
* \| \| \| \| \| \| \|	Merge pull request #29167 from koic/remove_duplicate_inverse_associations_test	Matthew Draper	2017-05-24	1	-14/+0
\|\ \ \ \ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Remove a duplicate test of inverse_associations_test in AR
\| * \| \| \| \| \| \| \|	Remove a duplicate test of inverse_associations_test in AR	Koichi ITO	2017-05-21	1	-14/+0
\| \| \|_\|/ / / / / \| \|/\| \| \| \| \| \|
* \| \| \| \| \| \| \|	Merge pull request #29174 from kamipo/remove_unused_join_part_name	Matthew Draper	2017-05-24	1	-4/+0
\|\ \ \ \ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Remove unused `JoinPart#name`
\| * \| \| \| \| \| \| \|	Remove unused `JoinPart#name`	Ryuta Kamizono	2017-05-22	1	-4/+0
\| \|/ / / / / / /
* \| \| \| \| \| \| \|	Merge pull request #29182 from kamipo/remove_unused_left_joins_values_generation	Matthew Draper	2017-05-24	2	-2/+2
\|\ \ \ \ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Remove unused `left_joins_values` generation
\| * \| \| \| \| \| \| \|	Remove unused `left_joins_values` generation	Ryuta Kamizono	2017-05-23	2	-2/+2
\| \|/ / / / / / / \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	This was added at #22125 but `left_joins_values` is never used.
* \| \| \| \| \| \| \|	Merge pull request #29183 from kamipo/refactor_making_join_constraints	Matthew Draper	2017-05-24	1	-23/+6
\|\ \ \ \ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Refactor making join constraints
\| * \| \| \| \| \| \| \|	Refactor making join constraints	Ryuta Kamizono	2017-05-23	1	-23/+6
\| \|/ / / / / / / \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	The only difference between `make_inner_joins` and `make_left_outer_joins` is the `join_type`.
* / / / / / / /	More friendly exception in nested attributes	Kir Shatrov	2017-05-22	2	-2/+2
\|/ / / / / / /
* \| \| \| \| \| \|	Merge pull request #29156 from kamipo/make_valid_directions_to_set	Andrew White	2017-05-20	1	-3/+5
\|\ \ \ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Make `VALID_DIRECTIONS` to `Set`
\| * \| \| \| \| \| \|	Make `VALID_DIRECTIONS` to `Set`	Ryuta Kamizono	2017-05-20	1	-3/+5
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	```ruby require "benchmark/ips" require "set" array = [:asc, :desc, :ASC, :DESC, "asc", "desc", "ASC", "DESC"] set = array.to_set item = "DESC" Benchmark.ips do \|x\| x.report "array" do array.include?(item) end x.report "set" do set.include?(item) end end ``` ``` % ruby array_vs_set.rb Warming up -------------------------------------- array 188.441k i/100ms set 229.531k i/100ms Calculating ------------------------------------- array 3.508M (± 9.0%) i/s - 17.525M in 5.043058s set 5.134M (± 7.6%) i/s - 25.707M in 5.038921s ```
* \| \| \| \| \| \| \|	Fix `warning: assigned but unused variable - timestamp`	Ryuta Kamizono	2017-05-20	1	-1/+1
\|/ / / / / / /
* \| / / / / /	Add cache_key_with_version and use it in ActiveSupport::Cache.expand_cache_key	David Heinemeier Hansson	2017-05-19	3	-24/+45
\| \|/ / / / / \|/\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	This retains the existing behavior of ActiveSupport::Cache.expand_cache_key (as used by etaging) where the cache key includes the version.
* \| \| \| \| \|	Cleanup CHANGELOGs [ci skip]	Ryuta Kamizono	2017-05-19	1	-7/+7
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	* Fix indentation. * Add backticks.
* \| \| \| \| \|	Use recyclable cache keys (#29092)	David Heinemeier Hansson	2017-05-18	4	-11/+117
\| \| \| \| \| \|
* \| \| \| \| \|	Merge pull request #29118 from kamipo/remove_respond_to_reset_scope	Rafael França	2017-05-17	1	-1/+1
\|\ \ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Remove unneeded `association.respond_to?(:reset_scope)`
\| * \| \| \| \| \|	Remove unneeded `association.respond_to?(:reset_scope)`	Ryuta Kamizono	2017-05-17	1	-1/+1
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Since 86390c3 all associations have `reset_scope` so `respond_to?` is unneeded.
* \| \| \| \| \| \|	Set non 0 value to logger not to be affected by Ruby versions	Yasuo Honda	2017-05-17	1	-23/+23
\|/ / / / / / \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	Addresses #29021
* \| \| \| \| \|	Fix association documentation	Rafael Mendonça França	2017-05-16	1	-6/+5
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	The object inside the scope is of the class that define the association not the associated class. [ci skip]
* \| \| \| \| \|	Changelog entry [ci-skip]	Guillermo Iguaran	2017-05-15	1	-0/+4
\| \| \| \| \| \|
* \| \| \| \| \|	Improvements for SQLite rake task.	Guillermo Iguaran	2017-05-15	1	-7/+18
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	* Use NOT IN in SQL query * Quote table names propertly * Use array form of command invocation
* \| \| \| \| \|	Update SchemaDumper.ignore_tables docs	Guillermo Iguaran	2017-05-15	1	-2/+2
\| \| \| \| \| \|
* \| \| \| \| \|	Respect 'ignore_tables' in SQLite structure dump	Guillermo Iguaran	2017-05-15	2	-1/+30
\| \| \| \| \| \|
* \| \| \| \| \|	Respect 'ignore_tables' in MySQL structure dump	Guillermo Iguaran	2017-05-15	2	-0/+22
\| \| \| \| \| \|
* \| \| \| \| \|	Respect `ignore_tables` in Postgres structure dump	Rusty Geldmacher	2017-05-15	2	-0/+14
\| \|_\|_\|/ / \|/\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	When using `sql` as the schema format, or even just doing `rake db:structure:dump`, it would be good to respect the list of ignored tables that has been configured.
* \| \| \| \|	Merge pull request #28919 from ↵	Kasper Timm Hansen	2017-05-12	1	-1/+1
\|\ \ \ \ \ \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	meinac/fix_ambigious_exception_message_of_select_query_method Fix ambigious error message of select query method [ci skip]