aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | | | refactor checking out the connectionAaron Patterson2011-12-301-5/+6
| | | | | |
* | | | | | infinite loop is no longer necessaryAaron Patterson2011-12-301-20/+11
| | | | | |
* | | | | | connections must be checked in at the end of a threadAaron Patterson2011-12-303-31/+7
| | | | | |
* | | | | | Fixes for TestFixtures::setup_fixture_accessorsAlexey Muranov2011-12-301-6/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Renamed "fixture_name" to "accessor_name" and made fixture names in the form "admin/users" be used as the key for the hashes @fixture_cache and @loaded_fixtures. Previously the variable "fixture_name" here was getting a value of the form "admin_user", and this value was then used as the hash key.
* | | | | | Fixture's table name be defined in the modelAlexey Muranov2011-12-301-10/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Made the fixture's table name be taken from its model class whenever this class responds to table_name, instead of inferring it sometimes from the fixture's pass. The previous behavior seemed buggy because it depended on whether the model class was passed as a constant or as a name string. Improved Fixtures#initialize.
* | | | | | Test case: fixture table name is defined in modelAlexey Muranov2011-12-301-0/+5
| | | | | |
* | | | | | Use foo/bar instead of foo_bar keys for fixturesAlexey Muranov2011-12-301-12/+25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This solves an issue with set_fixture_class class method caused by create_fixtures method's overwriting passed to it fixture model classes, when the fixtures are "namespased": foo/bar or admin/users. The idea is to use "foo/bar" string as the name and identifier of a fixture file bar in directory foo. The model class of the fixture is either set with set_fixture_class method, or otherwise inferred from its name using camelize method. Also a bug is fixed in lines 487-489 when the table names were guessed by substitution from the fixture file names, ambiguously called table_names, instead of being taken from fixture attributes. Now they are taken from attributes. I plan to submit another fix so that the fixture's table name (for example foo_bar) be defined by the fixture's model whenever possible, instead of inferring it from the fixture's name ("foo/bar").
* | | | | | Test fixtures with custom model and table namesAlexey Muranov2011-12-307-0/+60
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Test using fixtures with random names and model names, that is not following naming conventions but using set_fixture_class instead. It is expected that the table name be defined in the model, but this is not explicitly tested here. This will need to be fixed.
* | | | | | Merge branch 'master' of github.com:lifo/docrailsVijay Dev2011-12-293-11/+4
|\ \ \ \ \ \
| * | | | | | typoJo Liss2011-12-281-1/+1
| | | | | | |
| * | | | | | Document that index names are made up of all columns, not just the first.Jo Liss2011-12-271-9/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | index_name has been using the following expression "index_#{table_name}_on_#{Array.wrap(options[:column]) * '_and_'}" since at least 2006 (bc7f2315), and that's how they come out in my DB. Please check that this is correct before merging into master, perhaps I'm misunderstanding the section I changed.
| * | | | | | Remove unnecessary comma.Uģis Ozols2011-12-261-1/+1
| | | | | | |
* | | | | | | Deprecate implicit eager loading. Closes #950.Jon Leighton2011-12-2927-99/+181
| | | | | | |
* | | | | | | Merge pull request #4216 from edgecase/master_fix_reorder_with_limited_idsAaron Patterson2011-12-282-1/+11
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | allow reorder to affect eager loading correctly
| * | | | | | | allow reorder to affect eager loading correctlyMatt Jones + Scott Walker2011-12-282-1/+11
| | | | | | | |
* | | | | | | | Fix CIJon Leighton2011-12-285-25/+25
| | | | | | | |
* | | | | | | | app code in general wants Time.current, not Time.nowXavier Noria2011-12-281-3/+3
| | | | | | | |
* | | | | | | | Merge pull request #4222 from amatsuda/ar_predicate_builder_refactorAaron Patterson2011-12-281-35/+37
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | refactor AR::PredicateBuilder.build_from_hash
| * | | | | | | | refactor AR::PredicateBuilder.build_from_hashAkira Matsuda2011-12-291-35/+37
| | | | | | | | |
* | | | | | | | | Delete some stray linesJon Leighton2011-12-282-3/+0
|/ / / / / / / /
* | | | | | | | Avoid deprecation warningJon Leighton2011-12-281-1/+1
| | | | | | | |
* | | | | | | | Support establishing connection on ActiveRecord::Model.Jon Leighton2011-12-2825-230/+251
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is the 'top level' connection, inherited by any models that include ActiveRecord::Model or inherit from ActiveRecord::Base.
* | | | | | | | Support configuration on ActiveRecord::Model.Jon Leighton2011-12-2821-208/+190
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The problem: We need to be able to specify configuration in a way that can be inherited to models that include ActiveRecord::Model. So it is no longer sufficient to put 'top level' config on ActiveRecord::Base, but we do want configuration specified on ActiveRecord::Base and descendants to continue to work. So we need something like class_attribute that can be defined on a module but that is inherited when ActiveRecord::Model is included. The solution: added ActiveModel::Configuration module which provides a config_attribute macro. It's a bit specific hence I am not putting this in Active Support or making it a 'public API' at present.
* | | | | | | | Merge pull request #4213 from amatsuda/ar_where_array_of_nil_and_a_valueJon Leighton2011-12-281-2/+5
|\ \ \ \ \ \ \ \ | |/ / / / / / / |/| | | | | | | AR#where with an Array of 2 elements including a nil
| * | | | | | | where(foo: [1, nil]) becomes "WHERE foo = 1 OR foo IS NULL"Akira Matsuda2011-12-281-1/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | was "WHERE foo IN (1) OR foo IS NULL" before
| * | | | | | | no need to compact an already compacted ArrayAkira Matsuda2011-12-281-1/+1
| | | | | | | |
* | | | | | | | Merge pull request #4153 from ↵Jon Leighton2011-12-283-25/+81
|\ \ \ \ \ \ \ \ | |/ / / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | alexeymuranov/my_fix_for_prefix_suffix_fixtures_test Fix a fixtures test case with table prefix/suffix
| * | | | | | | Use the correct table name from fixtureAlexey Muranov2011-12-281-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixed a bug in fixtures.rb where the table name was incorrectly inferred from the fixture path which was ambiguously called "table_name" but was also used as the fixture name. Now, the "correct" table name is taken from an instance variable.
| * | | | | | | Fix a fixtures test case with table prefix/suffixAlexey Muranov2011-12-272-23/+79
| |/ / / / / / | | | | | | | | | | | | | | | | | | | | | Make sure the table name of a model is reset in a test case after assigning ActiveRecord::Base.table_name_prefix and ActiveRecord::Base.table_name_suffix.
* / / / / / / Revert "This conditions is required to work with database create task. 1.9.2 ↵Arun Agrawal2011-12-271-2/+1
|/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | is having a bug with "Calling return within begin still executes else". " No need to worry about 1.9.2 with master This reverts commit fbf4bee6ed3682b361d6fbeca8e185e665e26b81.
* | | | | | Merge branch 'master' of github.com:lifo/docrailsVijay Dev2011-12-252-4/+6
|\ \ \ \ \ \
| * | | | | | Clarify what persisted? returns.Uģis Ozols2011-12-251-2/+2
| | | | | | |
| * | | | | | Remove extra 'be'.Uģis Ozols2011-12-251-1/+1
| | | | | | |
| * | | | | | Revert "Changelog release dates fixed according to rubygems.org"Vijay Dev2011-12-241-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit ae60475a41cb0f5b3f7e071b75a0b5c5214c9f85. Reason: Changelogs are not meant to be edited in docrails.
| * | | | | | Changelog release dates fixed according to rubygems.orgJosef Šimánek2011-12-241-2/+2
| | | | | | |
| * | | | | | Finished implementation of MIT license linking.Kristian Freeman2011-12-231-1/+3
| | | | | | |
* | | | | | | remove checks for encodings availabilitySergey Nartimov2011-12-256-67/+53
| | | | | | |
* | | | | | | Intercept sends in Model::DeprecationProxyJon Leighton2011-12-242-1/+5
| | | | | | |
* | | | | | | deprecate String#encoding_aware? and remove its usageSergey Nartimov2011-12-243-23/+11
| | | | | | |
* | | | | | | Fix position of load hook so that Base has been defined and included Model ↵Jon Leighton2011-12-242-3/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | before it runs
* | | | | | | Add some doc for ActiveRecord::ModelJon Leighton2011-12-242-3/+38
| | | | | | |
* | | | | | | Add test to ensure AR::Model initialization works correctlyJon Leighton2011-12-241-0/+5
| | | | | | |
* | | | | | | Add deprecation for the change to the active_record load hookJon Leighton2011-12-242-1/+38
| | | | | | |
* | | | | | | Support nested AR::ModelsJon Leighton2011-12-243-1/+13
| | | | | | |
* | | | | | | auto_explain_threshold_in_seconds should be a global config option so it can ↵Jon Leighton2011-12-241-8/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | be shared between AR::Base and AR::Model
* | | | | | | Don't include anything else if AR::Model has already been includedJon Leighton2011-12-242-0/+7
| | | | | | |
* | | | | | | Make PredicateBuilder recognise AR::ModelJon Leighton2011-12-242-2/+8
| | | | | | |
* | | | | | | Ensure attribute methods are included after all the AR stuffJon Leighton2011-12-243-2/+3
| | | | | | |
* | | | | | | Fix #exists? for AR::ModelJon Leighton2011-12-242-1/+6
| | | | | | |
* | | | | | | Make generated_feature_methods work with ActiveRecord::ModelJon Leighton2011-12-242-4/+13
| | | | | | |