Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | | Fix handling of dirty time zone aware attributes | Lilibeth De La Cruz | 2013-01-26 | 3 | -2/+32 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously, when `time_zone_aware_attributes` were enabled, after changing a datetime or timestamp attribute and then changing it back to the original value, `changed_attributes` still tracked the attribute as changed. This caused `[attribute]_changed?` and `changed?` methods to return true incorrectly. Example: in_time_zone 'Paris' do order = Order.new original_time = Time.local(2012, 10, 10) order.shipped_at = original_time order.save order.changed? # => false # changing value order.shipped_at = Time.local(2013, 1, 1) order.changed? # => true # reverting to original value order.shipped_at = original_time order.changed? # => false, used to return true end | |||||
* | | Merge remote-tracking branch 'docrails/master' | Xavier Noria | 2013-01-26 | 3 | -5/+5 | |
|\ \ | | | | | | | | | | | | | | | | Conflicts: actionpack/lib/action_view/helpers/form_options_helper.rb guides/code/getting_started/app/controllers/comments_controller.rb | |||||
| * | | Fix typo | Tatsuro Baba | 2013-01-22 | 1 | -1/+1 | |
| | | | ||||||
| * | | Remove useless number sign | Tatsuro Baba | 2013-01-18 | 1 | -2/+2 | |
| | | | | | | | | | | | | I think that these signs are probably mistake. | |||||
| * | | fix example of setting DEFAULTS in fixtures | Jonathan Garvin | 2013-01-16 | 1 | -2/+2 | |
| | | | ||||||
* | | | `#count` in conjunction with `#uniq` performs distinct count. | Yves Senn | 2013-01-26 | 3 | -1/+15 | |
| | | | | | | | | | | | | closes #6865 | |||||
* | | | Remove obsolete test file | Jon Leighton | 2013-01-25 | 1 | -35/+0 | |
| | | | | | | | | | | | | https://github.com/rails/rails/commit/4beb4dececcf10c642c74fbcb8548c833e921a86#commitcomment-2482869 | |||||
* | | | reduce the number of queries on IN clauses, fix relation queries in `where` | Aaron Patterson | 2013-01-24 | 3 | -2/+20 | |
| | | | ||||||
* | | | stop converting strings to symbols | Aaron Patterson | 2013-01-24 | 1 | -1/+1 | |
| | | | ||||||
* | | | Default dead_connection_timeout to 5 | Akira Matsuda | 2013-01-24 | 1 | -1/+1 | |
| | | | | | | | | | | | | or the ConnectionPool silently fails to close connections inside the Thread | |||||
* | | | Describing the reason for defining BlankTopic#blank? which will never be called | Akira Matsuda | 2013-01-24 | 1 | -0/+1 | |
| | | | ||||||
* | | | Revert "Unused methods, module, etc." | Akira Matsuda | 2013-01-24 | 4 | -0/+28 | |
| | | | | | | | | | | | | | | | | | | This reverts commit 4e05bfb8e254c3360a3ca4a6cb332995314338fe. Reason: BlankTopic#blank? should not be removed to check that dynamic finder with a bang can find a model that responds to `blank?` | |||||
* | | | Unused methods, module, etc. | Akira Matsuda | 2013-01-24 | 4 | -28/+0 | |
| | | | ||||||
* | | | Set Thread.abort_on_exception for the whole AS, AP, and AR tests | Akira Matsuda + Koichi Sasada | 2013-01-24 | 1 | -0/+2 | |
| | | | | | | | | | | | | this would give us some more clues in case a test silently dies inside Thread | |||||
* | | | Unused test model | Akira Matsuda | 2013-01-24 | 1 | -5/+0 | |
| | | | ||||||
* | | | Goodbye there, very special rubbish! | Akira Matsuda | 2013-01-24 | 4 | -19/+1 | |
| | | | ||||||
* | | | proxy_{owner,reflection,target} are no more available | Akira Matsuda | 2013-01-24 | 1 | -11/+1 | |
| | | | ||||||
* | | | Unused model DeprecatedPostWithComment | Akira Matsuda | 2013-01-24 | 1 | -7/+0 | |
| | | | ||||||
* | | | Fix PostgreSQL tests on Travis | Andrew White | 2013-01-24 | 3 | -11/+37 | |
| | | | | | | | | | | | | Travis only has PostgreSQL 9.1.x but 9.2 is required for range datatypes. | |||||
* | | | Merge pull request #7345 from slbug/master | Rafael Mendonça França | 2013-01-23 | 11 | -189/+431 | |
|\ \ \ | | | | | | | | | Postgresql range support | |||||
| * | | | Add postgresql range types support | bUg | 2013-01-23 | 11 | -189/+431 | |
| | | | | ||||||
* | | | | Remove warning by using a custom coder | Andrew White | 2013-01-23 | 1 | -2/+16 | |
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The native JSON library bypasses the `to_json` overrides in active_support/core_ext/object/to_json.rb by calling its native implementation directly. However `ActiveRecord::Store` uses a HWIA so `JSON.dump` will call our `to_json` instead with a `State` object for options rather than a `Hash`. This generates a warning when the `:encoding`, `:only` & `:except` keys are accessed in `Hash#as_json` because the `State` object delegates unknown keys to `instance_variable_get` in its `:[]` method. Workaround this warning in the test by using a custom coder that calls `ActiveSupport::JSON.encode` directly. | |||||
* | | | A test case name needs to start with "test_" | Akira Matsuda | 2013-01-23 | 1 | -1/+1 | |
| | | | ||||||
* | | | Less strict activerecord-deprecated_finders version | Rafael Mendonça França | 2013-01-22 | 1 | -1/+1 | |
| | | | ||||||
* | | | Revert "Round usec when writing timestamp attribute." | Andrew White | 2013-01-22 | 2 | -28/+5 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit e9d2ad395ec2ef929d74752f3d71c80674044fbe. Closes #8460 Conflicts: activerecord/lib/active_record/attribute_methods/time_zone_conversion.rb activerecord/test/cases/dirty_test.rb | |||||
* | | | Add failing test case for #8460 | Andrew White | 2013-01-22 | 1 | -0/+14 | |
| | | | | | | | | | | | | Add a test case to ensure that fractional second updates are detected. | |||||
* | | | Whitespaces :scissors: | Rafael Mendonça França | 2013-01-22 | 2 | -19/+16 | |
| | | | | | | | | | | | | [ci skip] | |||||
* | | | Just ignore all PRAGMA queries | Akira Matsuda | 2013-01-22 | 1 | -1/+1 | |
| | | | ||||||
* | | | Reset SchemaMigration after updating | Akira Matsuda | 2013-01-22 | 1 | -0/+1 | |
| | | | ||||||
* | | | Preload some join table schemas | Akira Matsuda | 2013-01-22 | 1 | -0/+9 | |
| | | | ||||||
* | | | Ignore schema queries on SQLite 3 as well | Akira Matsuda | 2013-01-22 | 1 | -1/+2 | |
| | | | ||||||
* | | | Be sure to clear schema cache | Akira Matsuda | 2013-01-22 | 1 | -0/+3 | |
| | | | ||||||
* | | | Ignore "SHOW search_path" when counting PostgreSQL queries | Akira Matsuda | 2013-01-22 | 1 | -1/+1 | |
| | | | ||||||
* | | | Reset table_name_{prefix,suffix}, and table_name after each test | Akira Matsuda | 2013-01-22 | 1 | -11/+4 | |
| | | | | | | | | | | | | because some tests were not resetting them, and thus the tests were order dependent | |||||
* | | | Missing repair_validations | Akira Matsuda | 2013-01-22 | 1 | -12/+14 | |
| | | | ||||||
* | | | Refactored transaction state into its own object. Each transaction creates a ↵ | wangjohn | 2013-01-21 | 2 | -7/+34 | |
| | | | | | | | | | | | | new transaction state object upon initialization. | |||||
* | | | Remove extra sort from test | Vipul A M | 2013-01-21 | 1 | -3/+3 | |
| | | | | | | | | | | | | Cleanup change_schema tests to remove extra sorts on columns. | |||||
* | | | Merge pull request #8913 from ↵ | Carlos Antonio da Silva | 2013-01-20 | 2 | -0/+10 | |
|\ \ \ | | | | | | | | | | | | | | | | | seejee/regression_test_for_chained_preloaded_scopes Added test case to prevent regression of chained, preloaded scopes. | |||||
| * | | | Added test case to prevent regression of chained, preloaded scopes. (#7490) | Chris Geihsler | 2013-01-19 | 2 | -0/+10 | |
| | | | | ||||||
* | | | | Merge pull request #9008 from ranjaykrishna/dbcreate | Guillermo Iguaran | 2013-01-20 | 1 | -0/+1 | |
|\ \ \ \ | | | | | | | | | | | Added a new rake task in activerecord | |||||
| * | | | | added db:drop task that executes mysql:drop_databses and ↵ | Ranjay Krishna | 2013-01-20 | 1 | -0/+1 | |
| | | | | | | | | | | | | | | | | | | | | postgresql:drop_databases | |||||
* | | | | | Merge pull request #9006 from wangjohn/activerecord_transaction_state | Aaron Patterson | 2013-01-20 | 4 | -11/+49 | |
|\ \ \ \ \ | | |_|_|/ | |/| | | | Created state for a transaction and added tests. | |||||
| * | | | | Added a changelog entry. | wangjohn | 2013-01-20 | 1 | -0/+5 | |
| | | | | | ||||||
| * | | | | Removed reflects_transaction_state. | wangjohn | 2013-01-20 | 1 | -1/+0 | |
| | | | | | ||||||
| * | | | | Created state for a transaction and added tests. | wangjohn | 2013-01-20 | 3 | -11/+45 | |
| | | | | | ||||||
* | | | | | Merge pull request #9005 from ranjaykrishna/dbcreate | Aaron Patterson | 2013-01-20 | 1 | -0/+4 | |
|\ \ \ \ \ | | |/ / / | |/| | | | added a db create rake task. | |||||
| * | | | | removed the puts statement and simplified the execute statement | Ranjay Krishna | 2013-01-20 | 1 | -6/+1 | |
| | | | | | ||||||
| * | | | | added rake db:create that executes mysql:build_databases and ↵ | Ranjay Krishna | 2013-01-20 | 1 | -0/+9 | |
| | | | | | | | | | | | | | | | | | | | | postgresql:build_databases | |||||
* | | | | | Don't use anonymous classes in connection tests | Guillermo Iguaran | 2013-01-19 | 1 | -3/+5 | |
| |/ / / |/| | | | ||||||
* | | | | Anonymous class is not allowed. For reference see #8934 and bc43763247e25 | Guillermo Iguaran | 2013-01-19 | 1 | -4/+6 | |
| | | | |