aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
Commit message (Collapse)AuthorAgeFilesLines
...
| * | Doc fix [ci skip]Sushruth Sivaramakrishnan2015-03-071-1/+1
| | |
* | | Merge pull request #19230 from prathamesh-sonpatki/fix-clear-docRobin Dupret2015-03-061-0/+3
|\ \ \ | | | | | | | | Updated documentation of CollectionProxy#clear [ci skip]
| * | | Updated documentation of CollectionProxy#clear [ci skip]Prathamesh Sonpatki2015-03-061-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - CollectionProxy#clear method calls delete_all so the SQL is directly run into the database. - So the updated_at column of the object on which its run is not updated. - Closes #17161
* | | | Merge pull request #19221 from matthewd/random-testsMatthew Draper2015-03-062-6/+1
|\ \ \ \ | | | | | | | | | | Run all our tests in random order
| * | | | Revert "For now, we will keep sorting the tests."Matthew Draper2015-03-061-1/+1
| | | | | | | | | | | | | | | | | | | | This reverts commit 7025d7769dc53f0a3ffab8b537727ef3fee367fc.
| * | | | Revert "Leave all our tests as order_dependent! for now"Matthew Draper2015-03-061-5/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 2f52f969885b2834198de0045748436a4651a94e. Conflicts: actionmailer/test/abstract_unit.rb actionview/test/abstract_unit.rb activemodel/test/cases/helper.rb activerecord/test/cases/helper.rb activesupport/test/abstract_unit.rb railties/test/abstract_unit.rb
* | | | | tests, sequences are derived from the base class.Yves Senn2015-03-061-7/+10
| | | | | | | | | | | | | | | | | | | | | | | | | Using a subclass to check the sequence name does not work in that case. The sequence name will be calucalted based on the base class.
* | | | | Revert ":cut: remove unnecessary rescue Exceptions"Yves Senn2015-03-063-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit ff18049ca6f27deb7e7f955478e1464f8d756332. This broke the AR build for every adapter: 1) Error: AssociationCallbacksTest#test_dont_add_if_before_callback_raises_exception: Exception: You can't add a post 2) Failure: QueryCacheTest#test_query_cache_doesnt_leak_cached_results_of_rolled_back_queries [/Users/senny/Projects/rails/activerecord/test/cases/query_cache_test.rb:235]: Expected: 1 Actual: 0 I'm reverting to get the build green again.
* | | | | replace `repair_validations` with a disposable subclass.Yves Senn2015-03-061-32/+33
| |/ / / |/| | |
* | | | tests, remove side effects on `Joke` during `base_test.rb`.Yves Senn2015-03-061-23/+28
| | | | | | | | | | | | | | | | prompted by #19221.
* | | | :cut: remove unnecessary rescue ExceptionsAaron Patterson2015-03-053-3/+3
| | | |
* | | | remove unnecessary rescueAaron Patterson2015-03-051-2/+0
|/ / /
* | | Some documentation edits [ci skip]Robin Dupret2015-03-052-12/+14
| | | | | | | | | | | | | | | | | | * Fix a few typos * Wrap some lines around 80 chars * Rephrase some statements
* | | add ActiveRecord::Enum testcase about multiple enums declaring at a timekeepcosmos2015-03-051-0/+14
| | |
* | | add regression test. Closes #18400.Yves Senn2015-03-051-0/+6
|/ /
* | Remove duplicated testRyuta Kamizono2015-03-041-20/+0
| | | | | | | | | | `PostgresqlLargeKeysTest` is duplicated `PrimaryKeyBigSerialTest` in `primary_keys_test.rb`.
* | Correctly dump `serial` and `bigserial`Ryuta Kamizono2015-03-046-4/+93
| |
* | Add `Column#bigint?` methodRyuta Kamizono2015-03-043-3/+7
| |
* | add CHANGELOG entry for #19176. [ci skip]Yves Senn2015-03-041-0/+4
|/
* Merge pull request #19176 from imajes/masterYves Senn2015-03-032-1/+17
|\ | | | | Fixes reference for schema_format to AR::Base from AS::Base
| * Fixes reference for schema_format to AR::Base from AS::BaseJames Cox2015-03-032-1/+17
| |
* | Remove unused lineRyuta Kamizono2015-03-031-1/+0
| |
* | Merge pull request #19171 from JuanitoFatas/doc/more-examplesSean Griffin2015-03-021-0/+16
|\ \ | | | | | | Add more documents for AR connection_adapters abstract schema_definitions. [ci skip]
| * | Add more documents for AR connection_adapters abstract schema_definitions. ↵Juanito Fatas2015-03-031-0/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | [ci skip] - Add example to column_exists? - Add example to index_exists? - Add document for foreign_key - Add document for foreign_key_exists?
* | | Revert "delete unused method"Carlos Antonio da Silva2015-03-021-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | This reverts commit a38732c8e6ab76ea0db4e1a617a1fa84b53a9750. Since the mutation logic was reverted in 07278519bb6db5579171fea70bccdfee1306f1d4, we must bring the reader method back as well, since the implementation relies on it.
* | | Merge pull request #19177 from gregmolnar/fixturesRafael Mendonça França2015-03-022-6/+4
|\ \ \ | | | | | | | | Added testcase for #18742
| * | | test reset_pk_sequence with multi connectionGreg Molnar2015-03-011-1/+1
| | | |
| * | | Use the correct connection for reset_pk_sequenceMontana Low2015-03-011-5/+3
| | | | | | | | | | | | | | | | When a fs.model_class.connection uses a different database than connection, connection.reset_pk_sequence will fail with an exception causing fixture load to rollback. This is reproducible for any ActiveRecord::Base class that calls establish_connection with a different database.
* | | | Revert "mutate the transaction object to reflect state"Aaron Patterson2015-03-023-37/+33
| |_|/ |/| | | | | | | | | | | | | | | | | | | | This reverts commit 393e65b4170608593ad82377a9eadc918e85698d and ec51c3fedd16b561d096dcc1a6705fdc02ab7666 We don't want the records to hold hard references to transactions because they point at records that have callbacks.
* | | delete unused methodAaron Patterson2015-03-021-4/+0
| | |
* | | mutate the transaction object to reflect stateAaron Patterson2015-03-021-25/+21
| | | | | | | | | | | | | | | this lets us keep singleton instances of "state" values and precalculate return values of things like `finalized?` and `completed?`.
* | | ask the txn for it's state, not a state objectAaron Patterson2015-03-023-8/+16
| | | | | | | | | | | | | | | this way we don't have to mutate a state object, we can just change the state of the txn
* | | change if! to unlessAaron Patterson2015-03-021-1/+1
| | |
* | | tests, favor `drop_table` and `:if_exists` over raw SQL.Yves Senn2015-03-024-14/+6
| | | | | | | | | | | | | | | We've replaced most querues using DROP TABLE in our tests already. This patch replaces the last couple calls.
* | | Merge pull request #19105 from amatsuda/array_takeSean Griffin2015-03-023-5/+18
|\ \ \ | | | | | | | | Preserve Array#take(n) behaviour of HasManyAssociation
| * | | Preserve Array#take(n) behaviour of HasManyAssociationAkira Matsuda2015-02-283-5/+18
| | | |
* | | | Merge pull request #19077 from robin850/unknown-attribute-errorSean Griffin2015-03-026-10/+15
|\ \ \ \ | | | | | | | | | | Move `UnknownAttributeError` to a more sane namespace
| * | | | Follow-up to #10776Robin Dupret2015-02-266-10/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The name `ActiveModel::AttributeAssignment::UnknownAttributeError` is too implementation specific so let's move the constant directly under the ActiveModel namespace. Also since this constant used to be under the ActiveRecord namespace, to make the upgrade path easier, let's avoid raising the former constant when we deal with this error on the Active Record side.
* | | | | Merge pull request #19172 from JuanitoFatas/doc/fix-typoRichard Schneeman2015-03-021-2/+2
|\ \ \ \ \ | | | | | | | | | | | | [ci skip] Fix a typo for PostgreSQL text limit, GB instead of Gb.
| * | | | | [ci skip] Fix a typo for PostgreSQL text limit, GB instead of Gb.Juanito Fatas2015-03-031-2/+2
| | |_|_|/ | |/| | |
* | | | | Make private methods privateArthur Neves2015-03-021-0/+2
| | | | |
* | | | | Remove !has_transactional_callbacks? checkArthur Neves2015-03-021-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We only set the state on the record if that condition is `false` in the first place, so we dont need to call that again. Also that call is expensive, follow benchmark with before and after this change: ``` Calculating ------------------------------------- persisted? 15.272k i/100ms ------------------------------------------------- persisted? 350.119k (± 4.6%) i/s - 1.756M ``` ``` Calculating ------------------------------------- persisted? 25.988k i/100ms ------------------------------------------------- persisted? 1.294M (± 5.3%) i/s - 6.445M ``` (benchmark borrowed from 57d35b2bf9e48173a5f97ccff5e6897f0c46411f)
* | | | | Merge pull request #19170 from ↵Carlos Antonio da Silva2015-03-021-1/+1
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | JuanitoFatas/doc/active_record/connection_adapters/abstract/schema_definitions.rb Clarify that t.references and t.belongs_to are interchangeable. [ci skip]
| * | | | | Clarify that t.references and t.belongs_to are interchangeable. [ci skip]Juanito Fatas2015-03-021-1/+1
| |/ / / /
* | | | | call `sync_with_transaction_state` inside `persisted?` then check ivarsAaron Patterson2015-03-021-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | directly calling `sync_with_transaction_state` is not fast, so if we call it once, we can improve the performance of the `persisted?` method. This is important because every call to `url_for(model)` will call `persisted?`, so we want that to be fast. Here is the benchmark: ```ruby require 'active_record' ActiveRecord::Base.establish_connection adapter: "sqlite3", database: ":memory:" ActiveRecord::Base.connection.instance_eval do create_table(:articles) end class Article < ActiveRecord::Base; end article = Article.new.tap(&:save!) Benchmark.ips do |x| x.report("persisted?") do article.persisted? end end ``` Before this patch: ``` $ bundle exec ruby -rbenchmark/ips persisted.rb Calculating ------------------------------------- persisted? 3.333k i/100ms ------------------------------------------------- persisted? 51.037k (± 8.2%) i/s - 253.308k ``` After: ``` $ bundle exec ruby -rbenchmark/ips persisted.rb Calculating ------------------------------------- persisted? 7.172k i/100ms ------------------------------------------------- persisted? 120.730k (± 5.1%) i/s - 602.448k ```
* | | | | remove useless instance variableAaron Patterson2015-03-021-9/+4
|/ / / / | | | | | | | | | | | | | | | | depth is always 0, so the index will always be false. No reason to create the instance variable if it isn't used
* | | | Move transaction code to transaction moduleArthur Neves2015-03-012-41/+41
| | | |
* | | | Remove parent transaction stateArthur Neves2015-03-012-7/+0
| | | | | | | | | | | | | | | | As far as I can tell nobody is setting this variable.
* | | | remove useless conditionalAaron Patterson2015-03-011-1/+1
| | | | | | | | | | | | | | | | | | | | `@reflects_state[depth+1]` will always be nil because we haven't made a method call that would make it true yet.
* | | | Spell PostgreSQL correctly :elephant:Akira Matsuda2015-02-282-2/+2
| |/ / |/| | | | | | | | [ci skip]
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-09 04:04:47 +0000