aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
Commit message (Collapse)AuthorAgeFilesLines
* Test add_index and remove_index with a symbol name #4891Étienne Barrié2010-09-282-4/+10
|
* porting 066518295032a8e3f3468737337b8c8299442867 to master. Thanks Marcelo ↵Aaron Patterson2010-09-281-1/+1
| | | | Giorgi
* porting 515917f5d8678af6c57842ca5dfd7c18e67ff1fe to masterAaron Patterson2010-09-281-0/+6
|
* use new skool Ruby instead of Ruby Classic™Aaron Patterson2010-09-271-5/+3
|
* be kind to the garbage collector: only instantiate objects when absolutely ↵Aaron Patterson2010-09-271-14/+17
| | | | necessary
* adding test cases for the dynamic finder matcher match methodAaron Patterson2010-09-271-0/+49
|
* constructor should not do so much work; avoid allocating object if possibleAaron Patterson2010-09-271-10/+5
|
* @klass also uses DynamicFinderMatch, so no need for it on the relationAaron Patterson2010-09-272-9/+5
|
* no need for a case / when statementAaron Patterson2010-09-271-11/+7
|
* do not need intermediate variable, avoid lasgnAaron Patterson2010-09-271-2/+3
|
* DRY up our regular expressionAaron Patterson2010-09-271-3/+3
|
* reduce method calls in the dynamic finder matcherAaron Patterson2010-09-271-4/+4
|
* make sure we use the engine assigned to the table when quotingAaron Patterson2010-09-272-1/+19
|
* Fix for #5579 involved the code change for both has_one and has_many ↵Neeraj Singh2010-09-271-1/+9
| | | | | | | | relationships. The path included test only for has_one. This patch adds test for has_many relationship. [#5706 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* Fix for nested_attributes with has_many association fails when a single ↵Neeraj Singh2010-09-272-1/+14
| | | | | | | | record is being updated. [#5705 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* Merge remote branch 'miloops/warnings'José Valim2010-09-271-3/+3
|\ | | | | | | | | Conflicts: actionpack/lib/action_controller/metal/url_for.rb
| * Prevent shadowing outer local variable.Emilio Tagua2010-09-271-3/+3
| |
* | adding a test for slug behaviorAaron Patterson2010-09-271-0/+4
| |
* | Three performance improvements:Neeraj Singh2010-09-271-10/+9
| | | | | | | | | | | | | | | | * for simple cases like User.last and User.order('name desc').last no need to perform Array#join operation. * Instead of performing String#blank? do Array#empty? * no need to create variable relation
* | depending on arel 2.0.0Aaron Patterson2010-09-271-1/+1
|/
* third parameter is not usedAaron Patterson2010-09-261-1/+1
|
* db:structure:dump should list current Rails.env adapter in errors, not ↵Nic Benders2010-09-261-1/+1
| | | | | | | | always the test adapter [#5710 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* Fix remove_index issue when provided :name is a symbolTim Connor2010-09-262-2/+2
| | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* Add namespacing for observer generatorPiotr Sarnacki2010-09-251-0/+2
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Generators fix: properly check if module should be created when creating a ↵Piotr Sarnacki2010-09-251-1/+1
| | | | | | namespaced model Signed-off-by: José Valim <jose.valim@gmail.com>
* Delegate ActiveRecord::Base.offset to scoped methods (analogous to limit) ↵Marcelo Giorgi2010-09-242-1/+7
| | | | | | [#5688 state:resolved] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* Fix warning message when db/schema.rb doesn't exist [#5625 state:resolved]Brian Candler2010-09-241-1/+1
| | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* Refactor namespaced generators to use module_namespacing block helperPiotr Sarnacki2010-09-243-2/+6
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* Generators are not aware of namespace of isolated engines and applicationsPiotr Sarnacki2010-09-241-2/+2
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* restore behavior of touch for models without :updated_xx [#5439 state:resolved]tnp2010-09-242-8/+15
| | | | Signed-off-by: José Valim <jose.valim@gmail.com>
* reject_id option should be respected while using nested_attributesNeeraj Singh2010-09-242-3/+12
| | | | | | [#5579 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com>
* Hash#to_s behaves differently between 1.8 and 1.9, so adjust accordinglyAaron Patterson2010-09-231-1/+1
|
* switch present in favor of emptyAaron Patterson2010-09-221-1/+1
|
* testing poor behavior of hash serializationAaron Patterson2010-09-221-0/+4
|
* Refactor association_collection uniq method.Emilio Tagua2010-09-221-4/+3
| | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* No need to use inject here.Emilio Tagua2010-09-221-5/+5
| | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* Perf: refactor method.Emilio Tagua2010-09-221-11/+8
| | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* No need to use inject here, use map instead.Emilio Tagua2010-09-221-4/+1
| | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* Goodbye inject, hello map.Emilio Tagua2010-09-221-7/+5
| | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* Use map instead inject.Emilio Tagua2010-09-221-4/+3
| | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* Missing the mysql2 gem hereSantiago Pastorino2010-09-221-1/+1
|
* Error message should advice to use 'mysql2' gem.Neeraj Singh2010-09-221-2/+2
| | | | | | | | | | | | | If I create a new app using command rails new demo -d mysql then Gemfile contains 'mysql2' gem by default. However if mysql gem is missing then error message says raise "!!! Missing the mysql gem. Add it to your Gemfile: gem 'mysql', '2.8.1'" [#5569 state:committed] Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
* avoid a proc objectAaron Patterson2010-09-221-1/+1
|
* avoid creating a range objectAaron Patterson2010-09-221-1/+1
|
* drying up construct_associationAaron Patterson2010-09-211-15/+15
|
* dry up some conditionalsAaron Patterson2010-09-211-3/+4
|
* fixing case / when indentationAaron Patterson2010-09-211-19/+19
|
* fix case / when indentationAaron Patterson2010-09-211-18/+18
|
* avoid a hash lookupAaron Patterson2010-09-211-2/+2
|
* remove more codesAaron Patterson2010-09-211-6/+4
|