aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
Commit message (Collapse)AuthorAgeFilesLines
* Callbacks fire before notifying observers [#230 state:resolved]Craig Demyanovich2008-06-032-2/+40
| | | | Signed-off-by: Joshua Peek <josh@joshpeek.com>
* Namespace Inflector, Dependencies, OrderedOptions, and TimeZone under ↵Joshua Peek2008-06-035-28/+28
| | | | ActiveSupport [#238 state:resolved]
* Ensure AR#sum result is typecasted properlyPratik Naik2008-06-022-2/+8
|
* Ensure Associations#sum returns 0 when no rows are returned. [#295 ↵Jonathan Viney2008-06-022-4/+5
| | | | | | state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* Added SQL escaping for :limit and :offset in MySQL [Jonathan Wiess]David Heinemeier Hansson2008-06-013-2/+8
|
* fix changelog conflictrick2008-05-317-7/+42
|\
| * revert mysql test credential changeJeremy Kemper2008-05-311-2/+2
| |
| * Merge branch 'master' of git@github.com:rails/railsDavid Heinemeier Hansson2008-05-312-1/+7
| |\
| | * Substitute value into validates_format_of messageJohn D. Hume2008-05-312-1/+7
| | | | | | | | | | | | Signed-off-by: Michael Koziarski <michael@koziarski.com>
| * | Making ready for release of 2.1David Heinemeier Hansson2008-05-314-7/+9
| |/
| * Added SQL escaping for :limit and :offset [#288 state:closed] (Aaron Bedra, ↵David Heinemeier Hansson2008-05-312-2/+27
| | | | | | | | Steven Bristol, Jonathan Wiess)
* | Add ActiveRecord::Base.sti_name that checks ↵rick2008-05-314-6/+32
|/ | | | ActiveRecord::Base#store_full_sti_class? and returns either the full or demodulized name. [rick] [#114 state:resolved]
* belongs_to polymorphic association assignments update the foreign_id and ↵Tim Harper2008-05-312-5/+30
| | | | | | | | | | | foreign_type fields regardless of whether the record being assigned is new or not. fixes the following scenarios: * I have validates_inclusion_of on the type field for a polymorphic belongs_to association. I assign a new record to the model's polymorphic relationship of the proper type. validation fails because the type field has not been updated. * I replace the value for a ppolymorphic association to a new record of another class. The type field still says its the previous class, and the id field points to the previous record as well. [#191 state:closed]
* Fix default nil tests for MySQL 5.0.51 [#192 state:resolved]Ryan Bates2008-05-311-1/+1
| | | | Signed-off-by: Joshua Peek <josh@joshpeek.com>
* Ensure query assertion counts are the same when partial updates are enabledJeremy Kemper2008-05-302-0/+3
|
* Enable partial updates by defaultJeremy Kemper2008-05-301-1/+1
|
* Ensure :select passed in options overrides the one from the scope. [#239 ↵Andrew White2008-05-292-1/+17
| | | | | | state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* Ensure AssociationCollection#count works with empty condition. [#271 ↵Pratik Naik2008-05-292-1/+5
| | | | state:resolved] [Jan De Poorter]
* Ensure correct db time is reported in production logs.Pratik Naik2008-05-281-9/+5
|
* Ensure named_scope#empty? uses count query. [#262 state:resolved]Ryan Bates2008-05-282-1/+13
| | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* Fix tests for postgres 8.3.xTarmo Tänav2008-05-262-5/+5
| | | | | | | | | Made test_with_limiting_with_custom_select not dependent on database default order. Fixed tests with non-US monetary locale. The monetary type is fixed precision so it should not expect the database to return a float. Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* Merge docrails.Pratik Naik2008-05-2523-256/+279
| | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* Fix faulty tests introduced in 8d0b4fa39Michael Koziarski2008-05-243-4/+5
|
* Create through associations can now work with blocks.Ryan Bates2008-05-242-8/+17
| | | | | | Signed-off-by: Michael Koziarski <michael@koziarski.com> [#248 state:resolved]
* add failing test case for block-setting of attributes via associationTrevor Turk2008-05-241-0/+9
| | | | Signed-off-by: Michael Koziarski <michael@koziarski.com>
* Added :select option to has_one and belongs_to, remove unused :order option ↵josevalim2008-05-247-13/+30
| | | | | | | on belongs_to. Signed-off-by: Michael Koziarski <michael@koziarski.com> [#241 state:resolved]
* Fix failing tests on mysql 4.1 & ruby 1.8.4. [#237 state:resolved]Frederick Cheung2008-05-221-2/+2
| | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* Fix mysql 4.1 incompatibility in the active record schema tests.Frederick Cheung2008-05-221-32/+41
| | | | | Signed-off-by: Michael Koziarski <michael@koziarski.com> [#233 state:resolved ]
* ActiveRecord::Base#reload should clear dirty attributes. [#231 state:resolved]Ryan Bates2008-05-212-0/+16
| | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* Verbose ActiveRecord::AssociationTypeMismatch exception message. [#189 ↵Pratik Naik2008-05-211-1/+2
| | | | state:resolved]
* Ensure nil to '' doesn't get recorded by dirty for nullable integer columns. ↵Pratik Naik2008-05-202-8/+26
| | | | [#150 state:resolved] [Jason Dew, Pratik]
* Add first/last methods to associations/named_scope. [#226 state:resolved]Ryan Bates2008-05-208-4/+149
| | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* Ensure add_column gives valid error for sqlite. [Gunnar Wolf, Pratik] [#197 ↵Pratik Naik2008-05-202-0/+30
| | | | | | | | state:resolved] SQLite#add_column executes "VACUUM", which fails if inside a live transaction. This patch ensures a valid exception is raised if add_column is executed within a live transaction for sqlite adapter.
* Don't rely on association proxying object_id. [#225 state:resolved]Jeremy Kemper2008-05-191-2/+2
|
* - Updated tzinfo to use Rational() instead of Rational.new! due to "private ↵Nate Wiger2008-05-192-3/+3
| | | | | | method new!" in Ruby 1.9 - Added ^object_id$ as ignore pattern to fixing "redefining object_id" issue in Ruby 1.9 Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* Adding documentation for time zone featuresgbuesing2008-05-181-0/+4
|
* Make sure clone_structure can load the results of dump_schema_informationSteven Soroka2008-05-171-1/+1
| | | | | | | | SchemaStatements#dump_schema_information joins inserts with a single \n, but is later split on \n\n, and fails when trying to execute all the inserts as a single sql statement. Signed-off-by: Michael Koziarski <michael@koziarski.com> [#201 state:resolved]
* Merge documentation changes from docrails.Pratik Naik2008-05-165-73/+81
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | commit 0fc3381aa5359f31b36057d7bfba2e0eb6a3c064 Author: Xavier Noria <fxn@hashref.com> Date: Fri May 16 23:44:51 2008 +0200 Conventions. Formatting. Revising docs all over the rails. This revision encourages the modern resource-oriented form_for usage. In addition corrects some markup and other details. commit 70e4bcf5cb039bea073851faed2df9f465e6f2f8 Author: Chris Kampmeier <chris@kampers.net> Date: Fri May 16 12:09:46 2008 -0700 Fix a couple spelling errors in docs commit 6ea5e4208f724b50e774e6a1af027336c3ee3de1 Author: Chris O'Sullivan <thechrisoshow@gmail.com> Date: Fri May 16 16:09:11 2008 +0100 Added docs about source_type for has_one association commit a01a0178be297b0eb62909819a15a01c6b69a841 Author: miloops <miloops@gmail.com> Date: Wed May 14 09:22:39 2008 +0000 Change migration generator USAGE to explain the timestamped migrations behaviour commit 4e2bc02163aa646ab1304b1b5bec98a7af8927f5 Author: Xavier Noria <fxn@hashref.com> Date: Fri May 16 00:43:03 2008 +0200 minor revision in url_for docs Made explicit that RESTful and controller/action styles are not interchangeable, and revised some markup. commit d6ecce66f4e125531875006eea8022b73fe135b5 Author: Michael Hartl <michael@michaelhartl.com> Date: Thu May 15 10:46:40 2008 -0700 Expanded and updated the link_to documentation commit b8c46c86f0b785f6afc3c58eeb1b347543f5901e Author: Cody Fauser <cody@jadedpixel.com> Date: Wed May 14 09:10:02 2008 -0400 Improve and cleanup ActionMailer documentation commit 9546ee299952c86329c4854f9b3776382c0575ff Author: Yehuda Katz <wycats@gmail.com> Date: Mon May 12 23:41:43 2008 -0700 Add documentation for Inflector.inflections commit cbd5db8f5165f013069b02414f9bf762d88f619f Author: Manik Juneja <mjuneja@manik-junejas-computer.local> Date: Mon May 12 23:43:31 2008 +0530 minor changes in railties/README. Added dbconsole introduction commit 130a280ddee1f96ccf378b52c17ee742b5e54f4a Author: Gaurav Sharma <gaurav@norbauer.com> Date: Mon May 12 18:00:19 2008 +0530 adding documentation for cached_attributes commit 164c9586480f0a02522ea15ec7fb42c6a783a74d Author: TomK32 <tomk32@tomk32.de> Date: Mon May 12 10:59:33 2008 +0200 proper heading for "Example:" commit 35634feb474cc55fbc95edeffe98cec241d45f23 Author: Matt Boehlig <thetamind@gmail.com> Date: Sun May 11 16:46:07 2008 -0500 Cleanup whitespace and change_table documentation commit 80bba28a1a56a0cafeb0fc94659905e88129bc31 Author: Xavier Noria <fxn@hashref.com> Date: Sun May 11 02:54:02 2008 +0200 documented the source annotation extractor commit e6823bb1650d9b0fea58bd2d355f388961a408b3 Author: Mike Mondragon <mikemondragon@gmail.com> Date: Fri May 9 13:49:56 2008 -0700 Added additional information about processing email with ActionMailer and the strategy one might want to employ to do so. commit e6afd8b2736364322b673bbdcca3e9b38b6d3da0 Author: Xavier Noria <fxn@hashref.com> Date: Thu May 8 23:49:36 2008 +0200 corrected and completed docs of increment/decrement/toggle in AR::Base commit 2fead68b3192332eee27945ed95a94a64ca73f70 Author: Austin Putman <austin@emmanuel.local> Date: Wed May 7 19:35:46 2008 -0700 Documented class methods on ActionController::Routing. These are dangerous, and mostly used for testing. commit f5b84182dbc39bea79c8ee319c688d00fa99f9d1 Author: Teflon Ted <github@rudiment.net> Date: Wed May 7 16:08:49 2008 -0400 Added explanation about errant inflections not being patched in the future in order to avoid breaking legacy applications. commit 370f4f51722cec49ace17093d29e9ce9e8f15cfb Author: Sunny Ripert <negatif@gmail.com> Date: Wed May 7 14:00:59 2008 +0200 Applied list conventions in AR::Base commit 5bd18429f09d44e75191bec42a6db04bd33f3030 Author: Sunny Ripert <negatif@gmail.com> Date: Wed May 7 13:53:35 2008 +0200 Renamed Options list to Attributes list whenever they weren't option hashes in AR::Base commit 2fa628e34b25166afb49e3afeea87e770ab84256 Author: Xavier Noria <fxn@hashref.com> Date: Wed May 7 11:52:33 2008 +0200 revised details in Exceptions section of AR::Base docs commit d912bd5672316454457ae83f6e9dda5197beeb6f Author: Yaroslav Markin <yaroslav@markin.net> Date: Wed May 7 13:50:28 2008 +0400 Add a filter_parameter_logging usage hint to generated ApplicationController. This may help to remind the developer to filter sensitive information from application logs. Closes #11578 commit f81d771f0657ae8375b84a77a059812cce5d6fd9 Author: Jack Danger Canty <git@6brand.com> Date: Tue May 6 23:35:05 2008 -0700 doc: ActiveRecord::Reflection::AssociationReflection#through_reflection Added documentation demonstrating the use of #through_reflection for finding intervening reflection objects for HasManyThrough and HasOneThrough. commit ae6b46f00b5b8b2939c6b37ce3329c83de7e71db Author: Cheah Chu Yeow <chuyeow@gmail.com> Date: Wed May 7 13:47:41 2008 +0800 Document AttributeAssignmentError and MultiparameterAssignmentErrors. commit 8f463550b597db2156b67733f31aed13487fbc3a Author: John Barnette <jbarnette@gmail.com> Date: Tue May 6 22:46:44 2008 -0700 Killing/fixing a bunch of outdated language in the AR README. commit 284a930a93fbee16e25d06392779dbf2f03e9e12 Author: Jonathan Dance <jd@wuputah.com> Date: Tue May 6 14:58:26 2008 -0400 improvements to the page caching docs commit 9482da621390c874da7c921c8bd6230caae7035a Author: Sunny Ripert <negatif@gmail.com> Date: Mon May 5 18:13:40 2008 +0200 validates_numericality_of() "integer" option really is "only_integer" commit e9afd6790a8f530528f6597a7f59bb283be754f6 Author: Sunny Ripert <negatif@gmail.com> Date: Mon May 5 12:11:59 2008 +0200 Harmonized hash notation in AR::Base commit 67ebf14a91ffd970b582be4ff2991d691a9cf3e1 Author: Sunny Ripert <negatif@gmail.com> Date: Mon May 5 12:06:19 2008 +0200 Turned options into rdoc-lists in AR::Base commit 0ec7c0a41d889d4e5382b9dff72f1aaba89bf297 Author: Marshall Huss <mwhuss@Macbook.local> Date: Sun May 4 23:21:33 2008 -0400 Added information of how to set element_name in the case the user has a name confliction with an existing model Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* Fixing test for named_scope through a has_many :throughRodrigo Kochenburger2008-05-151-2/+2
| | | | | The test that checks if a has_many :through association has access to named_scope had a typo and didn't have the proper fixtures loaded. [#190 state:resolved]
* DRY associations code and improve eager loading tests.Pratik Naik2008-05-152-21/+9
|
* Make sure needed table joins are included :select option. [#110 state:resolved]John Devine2008-05-152-4/+21
| | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* Prefer string core_ext inflector methods over directly accessing Inflector.Joshua Peek2008-05-142-29/+29
|
* Add ActiveRecord option to store the full class name on STI's type column, ↵Rodrigo Kochenburger2008-05-133-3/+39
| | | | | | allowing one to have STI subclasses in different namespaces [#114] Signed-off-by: rick <technoweenie@gmail.com>
* Fix tests broken by mocha absence [#186 state:resolved]Tim Pope2008-05-131-9/+11
| | | | | | | Two ActiveRecord tests depended on mocha but were not marked as such. Place them in a use_mocha block so the test suite passes. Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* Dirty attributes aren't cleared if save fails. [#174 state:resolved]Xavier Noria2008-05-123-9/+30
| | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
* Remove AR::Base#attributes argument. [#52 state:resolved]Frederick Cheung2008-05-121-1/+1
| | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* Updated copyright yearsDavid Heinemeier Hansson2008-05-112-2/+2
|
* Making ready for RC1 releaseDavid Heinemeier Hansson2008-05-113-3/+3
|
* When preloading group by reflection rather than by class [#125 state:resolved]Frederick Cheung2008-05-112-6/+12
| | | | | | | | This avoids extra queries when several subclasses inherit the association from their parent class, while still coping with subclasses redefining associations. Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
* Fix blank conditions on AssociationCollection#find. [#104 state:resolved]Jonathan Viney2008-05-112-1/+9
| | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com>