aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
Commit message (Collapse)AuthorAgeFilesLines
...
| * | fix exists? to return false if passed nil (which may come from a missing URL ↵Andrew Kaspick2011-08-102-1/+12
| | | | | | | | | | | | param)
* | | Merge pull request #2897 from rsutphin/ar31-remove_connectionAaron Patterson2011-09-063-3/+22
| | | | | | | | | | | | Patch for issue #2820
* | | Database adapters use a statement pool.Aaron Patterson2011-09-063-8/+46
| | | | | | | | | | | | | | | | | | Database adapters use a statement pool for limiting the number of open prepared statments on the database. The limit defaults to 1000, but can be adjusted in your database config by changing 'statement_limit'.
* | | adding a statement pool for mysql and sqlite3Aaron Patterson2011-09-063-9/+102
| | |
* | | Nested through associations: preloads from the default scope of a through ↵Jon Leighton2011-09-062-1/+10
| | | | | | | | | | | | model should not be included in the association scope. (We're already excluding includes.) Fixes #2834.
* | | Ensure we are not comparing a string with a symbol in ↵Jon Leighton2011-09-063-2/+12
| | | | | | | | | | | | HasManyAssociation#inverse_updates_counter_cache?. Fixes #2755, where a counter cache could be decremented twice as far as it was supposed to be.
* | | Make the logic easier to readJon Leighton2011-09-061-4/+7
| | |
* | | Disable active record marshalling tests on Ruby 1.8.7 on Travis CI, as they ↵Jon Leighton2011-09-062-0/+25
| | | | | | | | | | | | have been failing intermittently for a long while due to what appears to be a Ruby bug. If anyone has the skills/expertise/time to debug this, please speak to the Travis guys.
* | | #first doesn't take an order in this testDamien Mathieu2011-09-061-1/+1
| | |
* | | Merge pull request #2877 from dmathieu/fix_tests_pg_18Santiago Pastorino2011-09-051-2/+2
|\ \ \ | | | | | | | | Last orders the records by id
| * | | first and last orders the records by idDamien Mathieu2011-09-061-2/+2
| | | |
* | | | Merge pull request #2716 from jbbarth/fix_invert_rename_indexAaron Patterson2011-09-052-3/+3
|\ \ \ \ | | | | | | | | | | Fix bad options order in AR::Migration::CommandRecorder#invert_rename_index
| * | | | Fixed bad options order in ↵jbbarth2011-08-282-3/+3
| | | | | | | | | | | | | | | | | | | | ActiveRecord::Migration::CommandRecorder#invert_rename_index
* | | | | Don't find belongs_to target when the foreign_key is NULL. Fixes #2828Georg Friedrich2011-09-052-0/+10
| |/ / / |/| | |
* | | | Use LIMIT sql word in last when it's possibleDamien Mathieu2011-09-052-2/+23
| | | |
* | | | use LIMIT SQL word in first - Closes #2783Damien Mathieu2011-09-052-1/+10
| | | |
* | | | Sort here to make sure the order is ok.Arun Agrawal2011-09-051-1/+1
| | | |
* | | | We need to recorder here. Need to drop the order from default scope.Arun Agrawal2011-09-053-1/+31
| | | | | | | | | | | | Fixes #2832
* | | | Revert "Fixes bug in ActiveRecord::QueryMethods, #1697"Jon Leighton2011-09-042-7/+4
| | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 0df27c98d982ec87d2fb48cfda82694eb267993e. Reverted due to failing test, see #2845.
* | | | restores the API docs of AR::Fixtures, made a quick pass over them, revises ↵Xavier Noria2011-09-032-369/+362
| | | | | | | | | | | | | | | | link in fixture template [closes #2840]
* | | | Need to add here to pass the testArun Agrawal2011-09-031-0/+1
| | | | | | | | | | | | As in previous commit it's removed.
* | | | Merge branch 'master' of github.com:lifo/docrailsVijay Dev2011-09-021-1/+1
|\ \ \ \
| * | | | Improve examples: use each instead of for...inGabe Berke-Williams2011-08-311-1/+1
| | | | |
* | | | | * Psych errors with poor yaml formatting are proxied. Fixes #2645, #2731Aaron Patterson2011-09-013-2/+27
| | | | |
* | | | | make sure encoding_aware? is availableAaron Patterson2011-09-011-0/+2
| | | | |
* | | | | Fixes bug in ActiveRecord::QueryMethods, #1697Joshua Wehner2011-08-312-4/+7
|/ / / / | | | | | | | | Replace split on comma with a regexp that will reverse all ASC/DESC specifically
* | | / Ensure correct ordering of results in ↵Raimonds Simanovskis2011-08-301-1/+1
| |_|/ |/| | | | | | | | | | | | | | test_update_all_with_joins_and_offset_and_order Last two asserts in this test assume that all_comments are ordered by posts.id and then by comments.id therefore additional ordering is added. Without it test was failing on Oracle which returned results in different order.
* | | Merge pull request #2750 from rsim/fix_test_column_names_are_escaped_for_oracleJon Leighton2011-08-301-1/+7
| | | | | | | | | | | | Fix test column names are escaped for oracle
* | | Fix test failures on 1.8.7, since Object#initialize_dup is not defined there ↵Jon Leighton2011-08-291-1/+0
| | | | | | | | | | | | (and this call to super is no essential, so easiest to simply remove)
* | | Merge pull request #2021 from dasch/more_postgres_utilsAaron Patterson2011-08-293-16/+21
|\ \ \ | | | | | | | | Make #extract_schema_and_table an instance method in Utils
| * | | Make #extract_schema_and_table an instance method in UtilsDaniel Schierbeck2011-07-093-16/+21
| | | | | | | | | | | | | | | | Also, move the utils test into its own test case.
* | | | Move clear_timestamp_attributes into Timestamp moduleJon Leighton2011-08-292-10/+14
| | | |
* | | | The join_nodes must be passed to the JoinDependency initializer and ↵Jon Leighton2011-08-294-13/+20
| | | | | | | | | | | | | | | | therefore counted by the alias tracker. This is because the association_joins are aliased on initialization and then the tables are cached, so it is no use to alias the join_nodes later. Fixes #2556.
* | | | Move the bulk alter table code into the abstract mysql adapter, hence it is ↵Jon Leighton2011-08-293-47/+44
| | | | | | | | | | | | | | | | supported for mysql2 as well now.
* | | | Extract simplified_type into the abstract classJon Leighton2011-08-293-23/+24
| | | |
* | | | Create an AbstractMysqlAdapter to abstract the common code between ↵Jon Leighton2011-08-295-1117/+726
| | | | | | | | | | | | | | | | MysqlAdapter and Mysql2Adapter.
* | | | fixing typoAaron Patterson2011-08-281-1/+1
| | | |
* | | | clear and disable query cache when an exception is raised from called middlewareAaron Patterson2011-08-282-1/+33
| |/ / |/| |
* | | stop messing with the load path, load path should be adjusted in the test taskAaron Patterson2011-08-261-7/+0
| | |
* | | Force binary data inserted for a string data type to utf-8 and log anAaron Patterson2011-08-252-3/+34
| | | | | | | | | | | | | | | | | | | | | | | | error. Strings tagged as binary will be stored in sqlite3 as blobs. It is an error to insert binary data to a string column, so an error is emitted in the log file. People are highly encouraged to track down the source of the binary strings and make sure that the encoding is set correctly before inserting to the database.
* | | Merge pull request #2679 from amatsuda/nullify_abstract_class_table_nameAaron Patterson2011-08-242-0/+6
|\ \ \ | | | | | | | | do not compute table names for abstract classes
| * | | do not compute table names for abstract classesAkira Matsuda2011-08-242-0/+6
| | | |
* | | | Adding missing autoloadClaudio Poli2011-08-241-0/+1
|/ / /
* | | Merge pull request #2524 from JonathonMA/fix_ecd37084b28a05f05251Santiago Pastorino2011-08-221-1/+1
|\ \ \ | | | | | | | | Use mysql_creation_options inside rescue block
| * | | Use mysql_creation_options inside rescue blockJonathon M. Abbott2011-08-141-1/+1
| | | | | | | | | | | | | | | | | | | | Commit ecd37084b28a05f05251 did not take into account the use of creation_options inside the access denied exception handler.
* | | | Merge pull request #2600 from al/finder_sql_example_updateXavier Noria2011-08-211-6/+10
|\ \ \ \ | | | | | | | | | | Updated the docs for the has_many :finder_sql option
| * | | | Updated the docs for the has_many :finder_sql option to reflect changes made ↵Alan Larkin2011-08-201-6/+10
| | | | | | | | | | | | | | | | | | | | in #a7e19b30ca71f62af516, i.e. the use of Procs when interpolation of the SQL is required.
* | | | | Fix PredicateBuilder clobbering select_values in subquery.Ernie Miller2011-08-202-1/+14
| | | | |
* | | | | Fix assumption of primary key name in PredicateBuilder subquery.Ernie Miller2011-08-202-1/+11
|/ / / /
* | | | prevent sql injection attacks by escaping quotes in column namesAaron Patterson2011-08-164-3/+20
| | | |