Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Merge pull request #14126 from schuetzm/index_option_for_column | Rafael Mendonça França | 2014-05-19 | 3 | -6/+28 |
|\ | | | | | Make `:index` in migrations work with all column types | ||||
| * | Make `:index` in migrations work with all column types | Marc Schütz | 2014-05-18 | 3 | -6/+28 |
| | | |||||
* | | Merge pull request #15160 from sgrif/sg-destructured-each | Rafael Mendonça França | 2014-05-19 | 1 | -4/+4 |
|\ \ | | | | | | | Use destructured arguments when looping through pairs | ||||
| * | | Use destructured arguments when looping through pairs | Sean Griffin | 2014-05-17 | 1 | -4/+4 |
| | | | | | | | | | | | | Minor refactoring of looping behavior for aggregation | ||||
* | | | pg, re-introduce `PostgreSQL::Utils` to unify schema/table extraction. | Yves Senn | 2014-05-19 | 6 | -39/+51 |
| | | | | | | | | | | | | Partial revert of c0bfc3f412834ffe8327a15ae3a46602cc28e425 | ||||
* | | | pg, add missing nodocs for extracted modules. | Yves Senn | 2014-05-19 | 5 | -10/+10 |
| | | | |||||
* | | | Merge pull request #14962 from arunagw/aa-fix-rake-activerecord | Yves Senn | 2014-05-19 | 1 | -71/+74 |
|\ \ \ | | | | | | | | | Reorganize ActiveRecord tasks [Arun Agrawal & Abd ar-Rahman Hamidi] | ||||
| * | | | Reorganize ActiveRecord tasks [Arun Agrawal & Abd ar-Rahman Hamidi] | Arun Agrawal | 2014-05-16 | 1 | -71/+74 |
| | | | | |||||
* | | | | Merge pull request #15156 from sgrif/sg-postgres-timestamps | Yves Senn | 2014-05-18 | 1 | -6/+3 |
|\ \ \ \ | |_|_|/ |/| | | | PostgreSQL timestamps should always be datetimes | ||||
| * | | | PostgreSQL timestamps are always datetimes | Sean Griffin | 2014-05-17 | 1 | -6/+3 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The current behavior is that they are treated as `datetime` normally, but if they are part of an array, they are treated as `timestamp`. The only place that seems to be impacted by this is schema dumping, which shouldn't matter since `t.datetime` and `t.timestamp` are equivalent in the `PostgreSQL` adapter, anyway. | ||||
* | | | | Add a type object to Column constructor | Sean Griffin | 2014-05-17 | 14 | -57/+86 |
| |_|/ |/| | | | | | | | | | | | | | | Part of #15134. In order to perform typecasting polymorphically, we need to add another argument to the constructor. The order was chosen to match the `oid_type` on `PostgreSQLColumn`. | ||||
* | | | Remove dead test code for unsupported adapters | Sean Griffin | 2014-05-17 | 19 | -183/+82 |
|/ / | |||||
* | | Merge pull request #14428 from jnormore/reset_counters_alias | Rafael Mendonça França | 2014-05-17 | 3 | -8/+27 |
|\ \ | | | | | | | Updates reset_counters to allow counter name in params | ||||
| * | | Updates reset_counters to allow counter name in params | Jason Normore | 2014-05-16 | 3 | -8/+27 |
| | | | | | | | | | | | | | | | | | | | | | Add support for counter name to be passed as parameter on `CounterCache::ClassMethods#reset_counters`. This is to be consistent with the other methods in the module that all accept counter name. | ||||
* | | | Add missing tests for column type cast behavior | Sean Griffin | 2014-05-17 | 1 | -0/+36 |
| | | | |||||
* | | | fix typo [ci skip] | Vijay Dev | 2014-05-17 | 1 | -1/+1 |
| | | | |||||
* | | | Fix typo in CHANGELOG entry for #15071 | Leandro Facchinetti | 2014-05-17 | 1 | -1/+3 |
|/ / | |||||
* | | Add CHANGELOG entry for #15071 [ci skip] | Rafael Mendonça França | 2014-05-16 | 1 | -0/+8 |
| | | |||||
* | | Merge pull request #15071 from leafac/issues/11985 | Rafael Mendonça França | 2014-05-16 | 2 | -4/+18 |
|\ \ | |/ |/| | Fix `Relation#delete_all` inconsistency | ||||
| * | Fix `Relation#delete_all` inconsistency | Leandro Facchinetti | 2014-05-16 | 2 | -4/+18 |
| | | | | | | | | | | | | | | | | | | When relation scopes include one of `uniq`, `group`, `having` or `offset`, the generated query ignores them and that causes unintended records to be deleted. This solves the issue by restricting the deletion when those scopes are present. rails/rails#11985 | ||||
* | | Remove unecessary require | Arthur Neves | 2014-05-16 | 1 | -2/+0 |
| | | |||||
* | | Remove the assignment for real this time. | Zachary Scott | 2014-05-16 | 1 | -2/+2 |
| | | | | | | | | | | | | cc: https://github.com/rails/rails/commit/a11e2fcff8cdc9691b977d8330abe63024f8c732#commitcomment-6353614 and 0369dbf | ||||
* | | prepend mutates the string so we can remove the assignment | Rafael Mendonça França | 2014-05-16 | 1 | -1/+1 |
| | | |||||
* | | Reuse the force_clear_transaction_record_state | Rafael Mendonça França | 2014-05-16 | 1 | -1/+1 |
| | | |||||
* | | Missed if :bomb: | Rafael Mendonça França | 2014-05-16 | 1 | -1/+1 |
| | | |||||
* | | Add a specific method to force the transaction record state clear | Rafael Mendonça França | 2014-05-16 | 1 | -5/+8 |
| | | | | | | | | | | | | We are using that code path in only one place so we should not add a conditional to all the other cases. This will avoid performance regressions on the old paths. | ||||
* | | Merge pull request #15125 from arthurnn/small_refactoring_transaction_clear | Godfrey Chan | 2014-05-16 | 2 | -4/+19 |
|\ \ | | | | | | | Small refactoring on clear_transaction_record_state | ||||
| * | | Clear transaction state if callback raise rollback | Arthur Neves | 2014-05-15 | 2 | -1/+14 |
| | | | |||||
| * | | Small refactoring on clear_transaction_record_state | Arthur Neves | 2014-05-15 | 1 | -3/+5 |
| | | | | | | | | | | | | | | | | | | Make sure when we clean the `@_start_transaction_state` var we do it in the same code-path. Also this makes `clear_transaction_record_state`, more consistent with `restore_transaction_record_state` | ||||
* | | | Remove code related to adapter which are no longer in repo | Arun Agrawal | 2014-05-16 | 2 | -31/+1 |
| | | | | | | | | | | | | As we have remove code for these adapters so no need to have tasks | ||||
* | | | formatting pass through CHANGELOGS. [ci skip] | Yves Senn | 2014-05-16 | 1 | -5/+5 |
|/ / | |||||
* | | Changed extract_limit in class Column to return correct mysql float and ↵ | Aaron Nelson | 2014-05-16 | 3 | -0/+47 |
| | | | | | | | | double limits | ||||
* | | :scissors: | Rafael Mendonça França | 2014-05-14 | 3 | -4/+0 |
| | | |||||
* | | Methods of these modules are internal | Rafael Mendonça França | 2014-05-14 | 2 | -14/+14 |
| | | | | | | | | | | They should not be used on people application so they should not be present on the API documentation. | ||||
* | | Merge pull request #15088 from kares/shareable-modules | Rafael Mendonça França | 2014-05-14 | 11 | -68/+67 |
|\ \ | | | | | | | | | | [postgres] remove (outer) sub-class declarations with nested modules/classes | ||||
| * | | PostgreSQLAdapter::Utils seems to be only used from a single spot - quite ↵ | kares | 2014-05-14 | 4 | -40/+34 |
| | | | | | | | | | | | | redundant | ||||
| * | | move PostgreSQL's DatabaseStatements out of the PostgreSQLAdapter name-space | kares | 2014-05-14 | 2 | -7/+7 |
| | | | |||||
| * | | PostgreSQL's SchemaStatements seems a could candidate for re-use (with AR-JDBC) | kares | 2014-05-14 | 2 | -8/+7 |
| | | | |||||
| * | | introduce AR::ConnectionAdapters::PostgreSQL for sharing modules (with AR-JDBC) | kares | 2014-05-14 | 7 | -15/+21 |
| | | | | | | | | | ... 'shared' OID, ArrayParser and Cast helpers, also re-arranged Column's dependencies | ||||
* | | | Don't use Active Support where it is not needed. | Rafael Mendonça França | 2014-05-14 | 1 | -1/+3 |
| | | | | | | | | | | | | | | | parent_name is a string of nil, never a blank string so we don't need to use presence. | ||||
* | | | Merge pull request #14871 from kassio/kb-fixes-namespaced-habtm | Rafael Mendonça França | 2014-05-14 | 7 | -1/+43 |
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | Fix how to compute class name on habtm namespaced. Conflicts: activerecord/CHANGELOG.md | ||||
| * | | | Fix how to compute class name on habtm namespaced. | Kassio Borges | 2014-05-13 | 7 | -1/+42 |
| | | | | | | | | | | | | | | | | | | | | | | | | Thank's for @laurocaetano for the help with tests. :smiley: Fixes #14709 | ||||
* | | | | Merge pull request #15078 from nbudin/fix_merger_filter_binds_comparison_master | Rafael Mendonça França | 2014-05-14 | 5 | -1/+32 |
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Make filter_binds filter out symbols that are equal to strings Conflicts: activerecord/CHANGELOG.md | ||||
| * | | | | Make filter_binds filter out symbols that are equal to strings | Nat Budin | 2014-05-14 | 5 | -1/+32 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ActiveRecord::Relation::Merger's filter_binds method does not filter out bind variables when one of the attribute nodes has a string name, but the other has a symbol name, even when those names are actually equal. This can result in there being more bind variables than placeholders in the generated SQL. This is particularly an issue for PostgreSQL, where this is treated as an error. This patch changes the filter_binds method to make it convert both attribute names to strings before comparing. | ||||
* | | | | | rake, remove frontbase related tasks from Active Record Rakefile. | Yves Senn | 2014-05-14 | 1 | -46/+0 |
| | | | | | |||||
* | | | | | Merge pull request #15110 from kuldeepaggarwal/fix-warning | Rafael Mendonça França | 2014-05-14 | 1 | -1/+1 |
|\ \ \ \ \ | | | | | | | | | | | | | remove warning `ambiguous first argument; put parentheses or even spaces` | ||||
| * | | | | | remove warning `ambiguous first argument; put parentheses or even spaces` | Kuldeep Aggarwal | 2014-05-15 | 1 | -1/+1 |
| | | | | | | |||||
* | | | | | | [ci skip]add updated information, ref[#522c0fd] | Kuldeep Aggarwal | 2014-05-14 | 1 | -0/+2 |
|/ / / / / | |||||
* | | / / | Fix inheritance of stored_attributes (fixes #14672) | Jessica Yao | 2014-05-14 | 3 | -5/+37 |
| |_|/ / |/| | | | | | | | | | | | [Brad Bennett, Jessica Yao, & Lakshmi Parthasarathy] | ||||
* | | | | remove count var | eileencodes | 2014-05-13 | 1 | -4/+2 |
| | | | | | | | | | | | | | | | | this change was unneccsary as nothing was gained from it |