Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | push more mutations outside the factory method | Aaron Patterson | 2013-08-01 | 2 | -8/+6 |
| | |||||
* | push module building to the constructor | Aaron Patterson | 2013-08-01 | 1 | -14/+20 |
| | |||||
* | users should be warned if clobbering constants | Aaron Patterson | 2013-08-01 | 1 | -3/+1 |
| | |||||
* | no need to define the constant twice | Aaron Patterson | 2013-08-01 | 1 | -1/+0 |
| | |||||
* | this code is dead, removing | Aaron Patterson | 2013-08-01 | 1 | -6/+0 |
| | |||||
* | defning extensions happens once, no need to cache | Aaron Patterson | 2013-08-01 | 1 | -5/+3 |
| | |||||
* | assert that constants have been set rather than the names | Aaron Patterson | 2013-08-01 | 2 | -9/+11 |
| | |||||
* | remove dead code | Aaron Patterson | 2013-08-01 | 1 | -4/+0 |
| | |||||
* | pushing out more callback definitions | Aaron Patterson | 2013-08-01 | 1 | -2/+6 |
| | |||||
* | push more mutations out of the builder | Aaron Patterson | 2013-08-01 | 2 | -12/+15 |
| | | | | | `configure_dependency` actually defined callbacks, so rename the method and move it to the appropriate method. | ||||
* | remove dependency on @model when defining callbacks | Aaron Patterson | 2013-08-01 | 2 | -8/+8 |
| | |||||
* | extract more mutations to the caller | Aaron Patterson | 2013-08-01 | 2 | -13/+16 |
| | |||||
* | separate some mutations from reflection construction | Aaron Patterson | 2013-08-01 | 2 | -6/+6 |
| | |||||
* | oops! :bomb: | Aaron Patterson | 2013-07-31 | 1 | -1/+1 |
| | |||||
* | do is_a? tests on assignment so runtime is faster | Aaron Patterson | 2013-07-31 | 3 | -11/+14 |
| | |||||
* | Revert "all `scope_chain` methods allocate new arrays, no need to dup" | Aaron Patterson | 2013-07-31 | 1 | -1/+1 |
| | | | | This reverts commit 1468a4b89aa4bca99160bfa03572b2c0ab348db5. | ||||
* | callback should always have a value | Aaron Patterson | 2013-07-31 | 1 | -1/+1 |
| | |||||
* | no need to to_sym | Aaron Patterson | 2013-07-31 | 2 | -2/+2 |
| | |||||
* | pass the mixin in to the code generation methods | Aaron Patterson | 2013-07-31 | 3 | -11/+11 |
| | |||||
* | we should not allow invalid objects to be constructed | Aaron Patterson | 2013-07-31 | 1 | -1/+2 |
| | |||||
* | push some validation up to the factory method | Aaron Patterson | 2013-07-31 | 1 | -4/+5 |
| | |||||
* | use bind values for model types | Aaron Patterson | 2013-07-31 | 1 | -2/+3 |
| | |||||
* | Merge pull request #11606 from vipulnsward/refactor_array_parser | Rafael Mendonça França | 2013-07-30 | 1 | -15/+22 |
|\ | | | | | Refactor `ArrayParser` | ||||
| * | Refactor `ArrayParser` | Vipul A M | 2013-07-26 | 1 | -15/+22 |
| | | | | | | | | | | * Constantize parse token * Remove extra param passed to `parse_data` | ||||
* | | Merge pull request #11668 from neerajdotname/make_test_order_independent_2 | Rafael Mendonça França | 2013-07-30 | 2 | -3/+6 |
|\ \ | | | | | | | Make test order independent | ||||
| * | | assert_no_queries should ignore certain sqls | Neeraj Singh | 2013-07-30 | 1 | -1/+3 |
| | | | | | | | | | | | | | | | postgresql test if randomly executed then executes "SHOW max_identifier_length". Hence the need to ignore certain predefined sqls that deal with system calls. | ||||
| * | | assert_no_queries should allow to ignore some queries | Neeraj Singh | 2013-07-30 | 1 | -2/+3 |
| | | | |||||
* | | | all `scope_chain` methods allocate new arrays, no need to dup | Aaron Patterson | 2013-07-30 | 1 | -1/+1 |
| | | | |||||
* | | | Merge branch 'revert-order-prepending' | Rafael Mendonça França | 2013-07-30 | 6 | -17/+32 |
|\ \ \ | | | | | | | | | | | | | | | | | Conflicts: activerecord/CHANGELOG.md | ||||
| * | | | Revert change on ActiveRecord::Relation#order method that prepends new | Rafael Mendonça França | 2013-07-29 | 6 | -17/+32 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | order on the old ones The previous behavior added a major backward incompatibility since it impossible to have a upgrade path without major changes on the application code. We are taking the most conservative path to be consistent with the idea of having a smoother upgrade on Rails 4. We are reverting the behavior for what was in Rails 3.x and, if needed, we will implement a new API to prepend the order clauses in Rails 4.1. | ||||
* | | | | Merge pull request #10673 from sgrif/master | Rafael Mendonça França | 2013-07-29 | 5 | -35/+98 |
|\ \ \ \ | |/ / / |/| | | | Add ability to specify how a class is converted to Arel predicate when passed to where | ||||
| * | | | Add ability to specify how a class is converted to Arel predicate | sgrif | 2013-07-28 | 5 | -35/+98 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This adds the ability for rails apps or gems to have granular control over how a domain object is converted to sql. One simple use case would be to add support for Regexp. Another simple case would be something like the following: class DateRange < Struct.new(:start, :end) def include?(date) (start..end).cover?(date) end end class DateRangePredicate def call(attribute, range) attribute.in(range.start..range.end) end end ActiveRecord::PredicateBuilder.register_handler(DateRange, DateRangePredicate.new) More complex cases might include taking a currency object and converting it from EUR to USD before performing the query. By moving the existing handlers to this format, we were also able to nicely refactor a rather nasty method in PredicateBuilder. | ||||
* | | | | only calculate the klass once | Aaron Patterson | 2013-07-29 | 1 | -1/+2 |
| |/ / |/| | | |||||
* | | | Merge pull request #11651 from ↵ | Carlos Antonio da Silva | 2013-07-29 | 1 | -1/+1 |
|\ \ \ | | | | | | | | | | | | | | | | | neerajdotname/log_should_mimick_original_log_method interceptor should mimick original method | ||||
| * | | | interceptor should mimick original method | Neeraj Singh | 2013-07-29 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | This fix also makes the test order independent. | ||||
* | | | | Merge pull request #11649 from ↵ | Carlos Antonio da Silva | 2013-07-29 | 1 | -30/+20 |
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | neerajdotname/use_method_with_active_record_default_timezone use method with_active_record_default_timezone | ||||
| * | | | | use method with_active_record_default_timezone | Neeraj Singh | 2013-07-29 | 1 | -30/+20 |
| |/ / / | |||||
* / / / | remove duplicate method | Neeraj Singh | 2013-07-29 | 1 | -7/+0 |
|/ / / | | | | | | | | | | This method is already present in helper.rb | ||||
* | | | Merge pull request #11608 from arunagw/ruby-from-rubygems | Aaron Patterson | 2013-07-28 | 1 | -2/+1 |
|\ \ \ | |/ / |/| | | grab executable from rubygems | ||||
| * | | grab executable from rubygems | Arun Agrawal | 2013-07-26 | 1 | -2/+1 |
| | | | | | | | | | As done here d7fc97d3f90c0e30865d32ce202658f03248cacc | ||||
* | | | Avoid "uninitialized constant ActiveRecord::PendingMigrationError::Rails" | Akira Matsuda | 2013-07-29 | 1 | -1/+1 |
| | | | |||||
* | | | Revert "fix order dependent test related to migration" | Akira Matsuda | 2013-07-29 | 1 | -4/+0 |
| | | | | | | | | | | | | | | | | | | This reverts commit 10259c3e906da2191ef0d43cd664a3b5504d9f8c. reason: this causes rake test_mysql and test_mysql2 fail | ||||
* | | | Properly repair validations when dynamically added | Akira Matsuda | 2013-07-29 | 1 | -24/+30 |
| | | | |||||
* | | | Clear class ivar before testing | Akira Matsuda | 2013-07-29 | 1 | -0/+2 |
| | | | |||||
* | | | Unneeded assertion | Akira Matsuda | 2013-07-29 | 1 | -1/+1 |
| | | | |||||
* | | | Don't rewrite AR connection#commit_db_transaction method globally | Akira Matsuda | 2013-07-29 | 1 | -4/+4 |
| | | | |||||
* | | | Merge pull request #11641 from ankit8898/test_cleanup | Rafael Mendonça França | 2013-07-28 | 2 | -2/+2 |
|\ \ \ | | | | | | | | | Cleanup of class_name | ||||
| * | | | Cleanup of class_name | Ankit Gupta | 2013-07-28 | 2 | -2/+2 |
| | | | | | | | | | | | | | | | | Don't think class name is needed as by default belongs_to :select will be linked to Select class. | ||||
* | | | | Merge pull request #11634 from ↵ | Rafael Mendonça França | 2013-07-28 | 1 | -0/+4 |
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | neerajdotname/fix_order_dependent_test_for_migration fix order dependent test related to migration | ||||
| * | | | | fix order dependent test related to migration | Neeraj Singh | 2013-07-28 | 1 | -0/+4 |
| | |/ / | |/| | | | | | | | | | | | | | | | | | | If the order in which tests are executed is changed then test fails. This commit ensures that all migrations are run before ensuring that there are no pending migration. |