| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
with new transaction state. If AR object has a callback, the callback will be performed immediately (non-lazily) so the transaction still has to keep records with callbacks.
|
|
|
|
|
|
|
| |
make connection_url_to_hash a class method
This als prevents loading database.yml if it doesn't exist
but DATABASE_URL does
|
| |
|
| |
|
| |
|
|\
| |
| |
| |
| | |
Takehiro-Adachi/remove-unecessary-tests-from-ar-base_testrb
delete duplicated tests in AR base_test.rb
|
| |
| |
| |
| | |
These are duplicated with the tests which are in relations_test.rb
|
| | |
|
| | |
|
| |
| |
| |
| | |
arguments are meaningless.
|
|/
|
|
| |
see: https://github.com/blog/1406-namespaced-gists
|
| |
|
|
|
|
| |
[ci skip]
|
|
|
|
|
|
|
| |
This revision makes the terminology uniform with the rest of the file.
In general we describe these methods in terms of the adapter, rather
than the database. (As a side note, if we wanted to refer to the
database we would write "PostgreSQL".)
|
|
|
|
|
| |
It was supposed to be removed by the preceding two reversions but I did
them in the wrong order.
|
|\
| |
| |
| |
| | |
Conflicts:
guides/source/upgrading_ruby_on_rails.md
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| | |
This reverts commit 5d528f835e871f5f9d4b68e8a81cfbe900b7e718.
Relates to f8c8ad5 which is also getting reverted due to failing test.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This reverts commit c321b309a9a90bbfa0912832c11b3fef52e71840.
Conflicts:
activerecord/lib/active_record/connection_adapters/abstract_mysql_adapter.rb
activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb
Reason: failing test
1) Error:
test_valid_column(ActiveRecord::ConnectionAdapters::SQLite3AdapterTest):
NoMethodError: undefined method `column' for
test/cases/adapters/sqlite3/sqlite3_adapter_test.rb:29:in
`test_valid_column'
|
| |
| |
| |
| |
| |
| | |
This reverts commit 8aa4603a5adaa56c818a7bd1c0b761b4ecca3d3e.
Reverting the revert because I reverted the wrong thing! Fail.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This reverts commit 1fc6876b57f2e1d31731e74eb4271b5655e746d2, reversing
changes made to 0268b5d8cdc3c5a1337462135f0a326a2654ba1a.
Reason: failing test
1) Error:
test_valid_column(ActiveRecord::ConnectionAdapters::SQLite3AdapterTest):
NoMethodError: undefined method `column' for
test/cases/adapters/sqlite3/sqlite3_adapter_test.rb:29:in
`test_valid_column'
|
|\ \
| | |
| | | |
don't cache invalid subsets when preloading hmt associations
|
| | |
| | |
| | |
| | | |
closes #8423.
|
|/ / |
|
|\ \
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Before writing a numeric attribute value, ActiveRecord does an implicit conversion of boolean types (true => 1 and false => 0). If the numeric value being assigned is a BigDecimal, then ActiveRecord compares a BigDecimal to true and false.
This is known to be very slow in Ruby 1.9.3 (see http://www.ruby-forum.com/topic/4409452 and https://bugs.ruby-lang.org/issues/7645#change-35188).
The Ruby core team has implemented a fix for this issue that will be included in Ruby 2, but they appear to have no intention of back-porting this fix to Ruby 1.9.3. In my case, the performance impact of this issue was enormous (200% - 300% performance hit) for some of the pages in my application.
See c75b5a88a82c79fdf95dfea4d72bf3c5a829930e applied to 3-2-stable branch for more reasoning and a benchmark.
|
| | |
| | |
| | |
| | |
| | |
| | | |
conversion of boolean types (true => 1 and false => 0). If the numeric value
being assigned is a BigDecimal, then ActiveRecord compares a BigDecimal to
true and false. This is known to be very slow in Ruby 1.9.3.
|
|/ /
| |
| |
| | |
fixes #5802
|
|\ \
| | |
| | | |
schema dumper tests now conducted by ActiveRecord::Base.Connection
|
| | | |
|
|\ \ \
| | | |
| | | | |
Use define method instead of class_eval
|
| |/ / |
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Allow store accessors to be overrided like other attribute methods,
e.g.:
class User < ActiveRecord::Base
store :settings, accessors: [ :color, :homepage ], coder: JSON
def color
super || 'red'
end
end
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Describe better the changes related to raising errors with empty
array/hash values in where clauses.
[ci skip]
|
| | | |
|
| | | |
|
|\ \ \
| | | |
| | | | |
active_record: Quote numeric values compared to string columns.
|
| | | | |
|
|/ / /
| | |
| | |
| | |
| | | |
Travis failed because the postgresql version installed there does not
support extensions, so we just need to skip this for now.
|
| | |
| | |
| | |
| | |
| | | |
There is no need to create the extension in the database just to test if
it's dumped, we can stub that instead.
|
| | |
| | |
| | |
| | |
| | | |
When extensions are supported but there's no one enabled in the
database, we should not print anything related to them in schema.rb.
|