aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
Commit message (Collapse)AuthorAgeFilesLines
...
| * Mixin `CollectionProxy::DelegateExtending` after `ClassSpecificRelation`Ryuta Kamizono2017-04-223-10/+25
| | | | | | | | | | | | | | | | | | | | `ClassSpecificRelation` has `method_missing` and the `method_missing` is called first. if an associated class has the missing method in a relation, never reach to the `method_missing` in the `CollectionProxy`. I extracted `DelegateExtending` and included it to the delegate class that including `ClassSpecificRelation` to fix the issue. Fixes https://github.com/rails/rails/pull/28246#issuecomment-296033784.
* | Merge pull request #28831 from kamipo/respond_to_missing_should_be_privateRafael França2017-04-255-26/+18
|\ \ | | | | | | `respond_to_missing?` should be private
| * | `respond_to_missing?` should be privateRyuta Kamizono2017-04-225-26/+18
| |/ | | | | | | | | | | | | Follow up of 03d3f036. Some of `respond_to?` were replaced to `respond_to_missing?` in 03d3f036. But the visibility is still public. It should be private.
* | Fix MigratorTest#test_migrator_verbositybogdanvlviv2017-04-261-1/+1
| | | | | | | | | | | | | | Add `ActiveRecord::Migration.verbose = true` to be sure that verbose is turned on in the test. Related to #28865
* | Merge pull request #28853 from kamipo/replace_regexp_zRafael França2017-04-253-14/+14
|\ \ | | | | | | Replace \Z to \z
| * | Replace \Z to \zRyuta Kamizono2017-04-243-14/+14
| |/ | | | | | | \Z was a mistake of \z. Replace \Z to \z to prevent newly \Z added.
* | Merge pull request #28872 from eugeneius/enumerator_sizeRafael França2017-04-252-18/+12
|\ \ | | | | | | Remove checks for Enumerator#size method
| * | Remove checks for Enumerator#size methodEugene Kenny2017-04-252-18/+12
| |/ | | | | | | | | | | | | | | The Enumerator#size method was introduced in Ruby 2.0. These tests were added when Rails 4.1 was current, and Ruby 1.9.3 was still supported. Since Rails 5 only Ruby >= 2.2.2 is supported, so the checks are no longer necessary.
* / Fix typos [ci skip]Tobias Fankhänel2017-04-251-2/+2
|/ | | | | | | | | 'lookup' is the noun. 'to look up' is the verb. Looked it up just to be sure. cf. https://en.wiktionary.org/wiki/lookup https://en.wiktionary.org/wiki/look_up
* Don't attempt to create a new record that was already created.Isaac Betesh2017-04-203-0/+32
| | | | Fixes #24032
* Prevent double firing the before save callback of new object when the parent ↵Ryuta Kamizono2017-04-215-54/+70
| | | | | | | | | | | | | | | | | | association saved in the callback Related #18155, #26661, 268a5bb, #27434, #27442, and #28599. Originally #18155 was introduced for preventing double insertion caused by the after save callback. But it was caused the before save issue (#26661). 268a5bb fixed #26661, but it was caused the performance regression (#27434). #27442 added new record to `target` before calling callbacks for fixing #27434. But it was caused double firing before save callback (#28599). We cannot add new object to `target` before saving the object. This is improving #18155 to only track callbacks after `save`. Fixes #28599.
* Merge pull request #28681 from runephilosof/fix-mysql-grantRafael Mendonça França2017-04-203-2/+6
|\ | | | | | | Fix quoting in db:create grant all statement.
| * Fix quoting in db:create grant all statement.Rune Schjellerup Philosof2017-04-203-2/+6
| | | | | | | | | | | | The database name used in the test would have actually shown this if it had tried to execute on a real Mysql instead of being stubbed out (dashes in database names needs quotes).
* | Merge pull request #28733 from kamipo/dont_fallback_to_utf8mb3_after_mysql_8.0.0Rafael França2017-04-193-10/+12
|\ \ | | | | | | Don't fallback to utf8mb3 after MySQL 8.0.0
| * | Don't fallback to utf8mb3 after MySQL 8.0.0Ryuta Kamizono2017-04-173-10/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `internal_string_options_for_primary_key` is used for creating internal tables in newly apps. But it is no longer needed after MySQL 8.0.0. MySQL 5.7 has introduced `innodb_default_row_format` (default `DYNAMIC`) and has deprecated `innodb_large_prefix` and `innodb_file_format`. The purpose of the deprecated options was for compatibility with earlier versions of InnoDB. https://dev.mysql.com/doc/refman/5.7/en/innodb-parameters.html#sysvar_innodb_large_prefix > innodb_large_prefix is deprecated and will be removed in a future release. innodb_large_prefix was introduced in MySQL 5.5 to disable large index key prefixes for compatibility with earlier versions of InnoDB that do not support large index key prefixes. https://dev.mysql.com/doc/refman/5.7/en/innodb-parameters.html#sysvar_innodb_file_format > The innodb_file_format option is deprecated and will be removed in a future release. The purpose of the innodb_file_format option was to allow users to downgrade to the built-in version of InnoDB in MySQL 5.1. Now that MySQL 5.1 has reached the end of its product lifecycle, downgrade support provided by this option is no longer necessary. The deprecated options has removed in MySQL 8.0.0. It is no longer needed to take care newly created internal tables as a legacy format after MySQL 8.0.0. Fixes #28730.
* | | Merge pull request #28776 from kamipo/respect_limit_for_cache_keyRafael França2017-04-192-8/+44
|\ \ \ | | | | | | | | `cache_key` respects the limit in a relation even if a relation is not loaded
| * | | `cache_key` respects the limit in a relation even if a relation is not loadedRyuta Kamizono2017-04-172-8/+44
| |/ / | | | | | | | | | | | | | | | `cache_key` includes the size of a relation. But if a relation is not loadded, the size is not respected even if a relation has a limit. It should be respected for consistency.
* | | Add additional raise UnknownMigrationVersionErrorbogdanvlviv2017-04-192-5/+12
| | | | | | | | | | | | | | | Raise error on the movement of migrations when the current migration does not exist.
* | | Fix `bin/rails db:forward` first migrationbogdanvlviv2017-04-192-1/+11
| | |
* | | Fix `extract_expression_for_virtual_column` for MariaDBRyuta Kamizono2017-04-191-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I'm not sure why `Mysql2VirtualColumnTest#test_schema_dumping` passed previously. But now the test not pass at least in MariaDB 10.1.9. I fixed the regexp to respect `COLLATE`. ``` % ARCONN=mysql2 be ruby -w -Itest test/cases/adapters/mysql2/virtual_column_test.rb -n test_schema_dumping Using mysql2 Run options: -n test_schema_dumping --seed 7131 F Finished in 0.466304s, 2.1445 runs/s, 4.2890 assertions/s. 1) Failure: Mysql2VirtualColumnTest#test_schema_dumping [test/cases/adapters/mysql2/virtual_column_test.rb:55]: Expected /t\.virtual\s+"upper_name",\s+type: :string,\s+as: "UPPER\(`name`\)"$/i to match "# This file is auto-generated from the current state of the database. Instead\n# of editing this file, please use the migrations feature of Active Record to\n# incrementally modify your database, and then regenerate this schema definition.\n#\n# Note that this schema.rb definition is the authoritative source for your\n# database schema. If you need to create the application database on another\n# system, you should be using db:schema:load, not running all the migrations\n# from scratch. The latter is a flawed and unsustainable approach (the more migrations\n# you'll amass, the slower it'll run and the greater likelihood for issues).\n#\n# It's strongly recommended that you check this file into your version control system.\n\nActiveRecord::Schema.define(version: 0) do\n\n create_table \"virtual_columns\", force: :cascade, options: \"ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci\" do |t|\n t.string \"name\"\n t.virtual \"upper_name\", type: :string, as: \n t.virtual \"name_length\", type: :integer, as: \"LENGTH(`name`)\", stored: true\n end\n\nend\n". 1 runs, 2 assertions, 1 failures, 0 errors, 0 skips ``` ``` > select @@version; +--------------------+ | @@version | +--------------------+ | 10.1.9-MariaDB-log | +--------------------+ 1 row in set (0.00 sec) ```
* | | Use `quoted_scope` rather than `@config[:database]` to respect current databaseRyuta Kamizono2017-04-191-2/+3
| | | | | | | | | | | | Related #28399.
* | | Merge pull request #28161 from bogdanvlviv/add_test_attributesRafael França2017-04-181-0/+11
|\ \ \ | | | | | | | | Add test for method `#attributes`
| * | | Add test for method `#attributes`bogdanvlviv2017-02-251-0/+11
| | | | | | | | | | | | | | | | | | | | | | | | ActiveRecord::AttributeMethods#attributes Extracted from https://github.com/rails/rails/pull/28159
* | | | Fix the doc on the `IndexDefinition` [ci skip]Ryuta Kamizono2017-04-171-1/+1
| |/ / |/| | | | | | | | Since 1a92ae83 all `indexes` methods are under the `SchemaStatements`.
* | | Support Descending Indexes for MySQLRyuta Kamizono2017-04-164-4/+14
| | | | | | | | | | | | | | | | | | | | | MySQL 8.0.1 and higher supports descending indexes: `DESC` in an index definition is no longer ignored. See https://dev.mysql.com/doc/refman/8.0/en/descending-indexes.html.
* | | Refactor `indexes` things in connection adaptersRyuta Kamizono2017-04-166-67/+114
| | | | | | | | | | | | | | | | | | | | | * Use keyword arguments in `IndexDefinition` to ease to ignore unused options and to avoid to initialize incorrect empty value. * Place it in `SchemaStatements` for consistency. * And tiny tweaks.
* | | Merge pull request #28767 from kamipo/rename_to_association_query_valueAndrew White2017-04-153-8/+9
|\ \ \ | | | | | | | | Rename `association_query_handler.rb` to `association_query_value.rb`
| * | | Rename `association_query_handler.rb` to `association_query_value.rb`Ryuta Kamizono2017-04-153-8/+9
| | | | | | | | | | | | | | | | | | | | | | | | Since `AssociationQueryHandler` and `PolymorphicArrayHandler` has removed in #28715, only exists `AssociationQueryValue` and `PolymorphicArrayValue` in these files.
* | | | Early return in `PredicateBuilder::ArrayHandler`Ryuta Kamizono2017-04-151-4/+3
|/ / / | | | | | | | | | Partitioning to `values` and `nils` is unneeded before early return.
* | | Move around AR::Dirty and fix _attribute methodAaron Patterson2017-04-142-4/+22
| | | | | | | | | | | | | | | | | | We already have a _read_attribute method that can get the value we need from the model. Lets define that method in AM::Dirty and use the existing one from AR::Dirty rather than introducing a new method.
* | | Merge pull request #28661 from ↵Aaron Patterson2017-04-143-0/+27
|\ \ \ | | | | | | | | | | | | | | | | bogdanvlviv/fix-dirty-attributes-if-override-attr_accessor Fix inconsistency with changed attributes when overriding AR attribute reader
| * | | Fix inconsistency with changed attributes when overriding AR attribute readerbogdanvlviv2017-04-123-0/+27
| | | |
* | | | Merge pull request #28715 from ↵Andrew White2017-04-144-60/+32
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | kamipo/convert_association_queries_to_poro_queries Convert association queries to PORO queries
| * | | | `AssociationQueryValue#queries` returns an array for more concise ↵Ryuta Kamizono2017-04-112-14/+7
| | | | | | | | | | | | | | | | | | | | association handling
| * | | | Convert `PolymorphicArrayValue` to PORO queriesRyuta Kamizono2017-04-093-28/+19
| | | | |
| * | | | Convert `AssociationQueryValue` to PORO queriesRyuta Kamizono2017-04-092-35/+23
| | | | |
* | | | | Add a test case for #20802Ryuta Kamizono2017-04-132-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The issue #20802 has been fixed in cc0b566. Closes #20802.
* | | | | :scissors:Ryuta Kamizono2017-04-134-4/+1
| | | | | | | | | | | | | | | | | | | | [ci skip]
* | | | | Merge pull request #28726 from matthewd/transaction-lockingMatthew Draper2017-04-133-52/+70
|\ \ \ \ \ | | | | | | | | | | | | Add comprehensive locking around DB transactions
| * | | | | Add comprehensive locking around DB transactionsMatthew Draper2017-04-113-52/+70
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Transactional-fixture using tests with racing threads and inter-thread synchronisation inside transaction blocks will now deadlock... but without this, they would just crash. In 5.0, the threads didn't share a connection at all, so it would've worked... but with the main thread inside the fixture transaction, they wouldn't've been able to see each other. So: as far as I can tell, the set of operations this "breaks" never had a compelling use case. Meanwhile, it provides an increased level of coherency to the operational feel of transactional fixtures. If this does cause anyone problems, they're probably best off disabling transactional fixtures on the affected tests, and managing transactions themselves.
* | | | | | Merge pull request #28712 from kamipo/tweaks_28678Andrew White2017-04-121-4/+5
|\ \ \ \ \ \ | | | | | | | | | | | | | | Tweaks #28678
| * | | | | | Tweaks #28678Ryuta Kamizono2017-04-091-4/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Fix the comment on `formatted_version` * Extract `define_params` * Remove duplicated guard clause for `@version`
* | | | | | | Use a query that's compatible with PostgreSQL 9.2Matthew Draper2017-04-125-15/+27
| |_|_|/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Also, explicitly apply the order: generate_subscripts is unlikely to start returning values out of order, but we should still be clear about what we want.
* | | | | | Merge pull request #28721 from koic/oracle_does_not_support_limit_clauseRafael França2017-04-111-1/+1
|\ \ \ \ \ \ | |_|/ / / / |/| | | | | Fix an AR test of relations_test when using Oracle
| * | | | | Fix an AR test of relations_test when using OracleKoichi ITO2017-04-111-1/+1
| | | | | |
* | | | | | exclude ORDER BY clause for exists? (#28699)Boris Slobodin2017-04-102-1/+6
|/ / / / /
* | | | | Merge pull request #28713 from kamipo/expose_queries_for_association_queriesMatthew Draper2017-04-102-48/+44
|\ \ \ \ \ | |/ / / / |/| / / / | |/ / / Expose `queries` for `AssociationQueryValue` and `PolymorphicArrayValue`
| * | | Expose `queries` for `AssociationQueryValue` and `PolymorphicArrayValue`Ryuta Kamizono2017-04-092-21/+25
| | | |
| * | | Avoid to handle polymorphic association for `AssociationQueryHandler`Ryuta Kamizono2017-03-282-29/+21
| | | | | | | | | | | | | | | | It should be handled by `PolymorphicArrayHandler` if polymorphic association.
* | | | Merge pull request #28678 from hedgesky/use_formatted_number_as_schema_versionRafael França2017-04-081-1/+9
|\ \ \ \ | | | | | | | | | | use formatted number as schema version
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-03 01:51:07 +0000