aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
Commit message (Collapse)AuthorAgeFilesLines
* Use `select_rows` instead of `select_one` in `select_value`Ryuta Kamizono2015-05-051-2/+3
| | | | | `select_one` create `ActiveRecord::Result` instance. It is better to use `select_rows` instead of `select_one` for performance.
* More exercise the create index sql testsRyuta Kamizono2015-05-044-4/+79
|
* Do not use options that does not supportRyuta Kamizono2015-05-041-4/+4
| | | | | MySQL does not support partial index. And, the create index algorithm in create table can not be specified.
* Merge pull request #19994 from kamipo/dump_indexes_in_create_tableRafael Mendonça França2015-05-033-16/+21
|\ | | | | | | Dump indexes in `create_table` instead of `add_index`
| * Dump indexes in `create_table` instead of `add_index`Ryuta Kamizono2015-05-033-16/+21
| | | | | | | | | | If the adapter supports indexes in create table, generated SQL is slightly more efficient.
* | Merge pull request #17824 from ↵Rafael Mendonça França2015-05-034-5/+8
|\ \ | | | | | | | | | | | | yuki24/change-record-not-saved-and-not-destroyed-to-include-error-msg AR::RecordNotSaved & RecordNotDestroyed from save!/destroy! should include an error message
| * | AR::RecordNotSaved & RecordNotDestroyed should include an error messageYuki Nishijima2015-05-014-5/+8
| | | | | | | | | | | | | | | | | | | | | When `AR::Base.save!` or `AR::Base.destroy!` is called and an exception is raised, the exception doesn't have any error message or has a weird message like `#<FailedBulb:0x0000000907b4b8>`. Give a better message so we can easily understand why it's failing to save/destroy.
* | | Merge pull request #17569 from kamipo/dump_table_optionsRafael Mendonça França2015-05-036-0/+106
|\ \ \ | | | | | | | | | | | | Correctly dump `:options` on `create_table` for MySQL
| * | | Correctly dump `:options` on `create_table` for MySQLRyuta Kamizono2015-05-036-0/+106
| |/ /
* | | Merge pull request #19987 from kamipo/move_postgresql_specific_schemaRafael Mendonça França2015-05-032-14/+11
|\ \ \ | | | | | | | | Move PostgreSQL specific schema to postgresql_specific_schema.rb
| * | | Move PostgreSQL specific schema to postgresql_specific_schema.rbRyuta Kamizono2015-05-032-14/+11
| | |/ | |/|
* | | Merge pull request #19978 from kamipo/collation_option_support_for_postgresqlRafael Mendonça França2015-05-0310-32/+116
|\ \ \ | | | | | | | | PostgreSQL: `:collation` support for string and text columns
| * | | PostgreSQL: `:collation` support for string and text columnsRyuta Kamizono2015-05-044-3/+79
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Example: create_table :foos do |t| t.string :string_en, collation: 'en_US.UTF-8' t.text :text_ja, collation: 'ja_JP.UTF-8' end
| * | | Move the collation handling code from the MySQL adapter to common classesRyuta Kamizono2015-05-047-29/+37
| | | | | | | | | | | | | | | | | | | | Some databases like MySQL allow defining collation charset for specific columns.
* | | | Merge pull request #19989 from kamipo/change_visit_addcolumn_visibiltyRafael Mendonça França2015-05-033-11/+14
|\ \ \ \ | | | | | | | | | | Change the `visit_AddColumn` visiblity for the internal API
| * | | | Change the `visit_AddColumn` visiblity for the internal APIRyuta Kamizono2015-05-033-11/+14
| | |/ / | |/| |
* | | | Missing `:bigint` [ci skip]Ryuta Kamizono2015-05-041-1/+1
| |/ / |/| |
* | | Merge pull request #19988 from kamipo/move_comment_about_microsecondsZachary Scott2015-05-032-2/+3
|\ \ \ | | | | | | | | Move comment about microseconds [ci skip]
| * | | Move comment about microseconds [ci skip]Ryuta Kamizono2015-05-032-2/+3
| |/ / | | | | | | | | | The microseconds handling was already moved to `Quoting#quoted_date`.
* | | gem 'mysql2', '~> 0.3.18'Ryuta Kamizono2015-05-041-1/+1
| | | | | | | | | | | | Follow up #18914.
* | | `:nodoc:` postgresql's change_columnTony Miller2015-05-031-2/+1
|/ / | | | | | | | | Its nodoc'ed for the other implementations, and doc'ed in the base class, just like the other change_column* methods.
* | Merge pull request #19984 from mcfiredrill/nodoc-change-column-nullYves Senn2015-05-033-3/+3
|\ \ | | | | | | :nodoc: change_column_null in the implmenting adapters
| * | :nodoc: change_column_null in the implmenting adaptersTony Miller2015-05-033-3/+3
| |/ | | | | | | | | | | `change_column_null` is doc'ed only in ActiveRecord::ConnectionAdapters::SchemaStatements, so it would make sense to :nodoc: it elsewhere.
* / Remove unused requireRyuta Kamizono2015-05-032-2/+0
|/
* Merge pull request #19971 from thiagoaugusto/improve-activerecord-changelogYves Senn2015-05-011-1/+1
|\ | | | | Improvement on Activerecord CHANGELOG.md [ci skip]
| * Improvement on Activerecord CHANGELOGthiagoaugusto2015-05-011-1/+1
| |
* | Update documentation to contain a 24 char token [ci skip]Roberto Miranda2015-05-011-1/+1
| |
* | Merge pull request #19962 from prathamesh-sonpatki/nodoc-validate-index-lengthYves Senn2015-04-301-1/+1
|\ \ | | | | | | Nodoc validate_index_length! method
| * | Nodoc validate_index_length! methodPrathamesh Sonpatki2015-04-301-1/+1
| | | | | | | | | | | | - This method is used only by adapters to validate length of new index names.
* | | Merge pull request #19961 from prathamesh-sonpatki/pg-docsRichard Schneeman2015-04-302-2/+5
|\ \ \ | |_|/ |/| | Added documentation for PostGreSQL database_statements [ci skip]
| * | Added documentation for PostGreSQL database_statements [ci skip]Prathamesh Sonpatki2015-04-302-2/+5
| |/ | | | | | | | | | | - Added documentation for index_name_exists? and rename_index. - Also changed rails to \Rails in documentation of allowed_index_name_length.
* | Merge pull request #19945 from thenickcox/migration_generator_docsZachary Scott2015-04-281-4/+5
|\ \ | |/ |/| [ci skip] Correct grammar, add docs to ActiveRecord migration generator
| * [ci skip] Correct grammar, add docs to ActiveRecord migration generatorNick Cox2015-04-281-4/+5
| |
* | fixed typoBenny Klotz2015-04-281-2/+2
| |
* | Merge pull request #19546 from DianthuDia/fix_unscope_for_less_thanYves Senn2015-04-283-1/+17
|\ \ | | | | | | | | | Fix unscope for less than
| * | Fix unscope for less thanTAKAHASHI Kazuaki2015-03-272-1/+13
| | | | | | | | | | | | | | | | | | Code such as the following will be corrected. Developer.where(id: -Float::INFINITY...2).unscope(where: :id)
* | | Merge pull request #19718 from eagletmt/find_by-without-argYves Senn2015-04-283-4/+17
|\ \ \ | | | | | | | | | | | | Raise ArgumentError when find_by receives no arguments
| * | | Raise ArgumentError when find_by receives no argumentsKohei Suzuki2015-04-112-4/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It fixes the strange error saying undefined method `take'. ``` RelationTest#test_find_by_without_arg_behaves_same_with_find_by({}): NoMethodError: undefined method `take' for #<ActiveRecord::QueryMethods::WhereChain:0x007f9c55db1d68> ```
* | | | remove trailing whitespace. [ci skip]Yves Senn2015-04-271-1/+1
| | | |
* | | | Merge pull request #19918 from vngrs/becomes_missing_note_about_stiYves Senn2015-04-271-1/+3
|\ \ \ \ | | | | | | | | | | | | | | | Add note about sti column value to becomes method [ci skip]
| * | | | Add note about sti column value to becomes method [ci skip]Mehmet Emin İNAÇ2015-04-271-2/+4
|/ / / /
* | | | test, for `create_table` and `foreign_key: true` no-op. Closes #19794.Yves Senn2015-04-271-0/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add a test-case to make sure that `create_table` with a `foreign_key: true` and an adapter without foreign key support does not blow up. Motivated by #19794. Originating from: https://github.com/rails/rails/commit/99a6f9e60ea55924b44f894a16f8de0162cf2702#commitcomment-10855210
* | | | Revert "Merge pull request #17920 from ↵Yves Senn2015-04-272-1/+8
| |_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | calebthompson/dont-rely-on-environment-task-for-schema-load" This reverts commit 08ff4ccbbb3fb143a02e6752efb974a4bcfcd3bb, reversing changes made to 6c9ed6dbc62450cdb87559afd15798305e069146. Caused by #17920. Closes #19545. This patch introduced regressions because initializers were no longer loaded. Specifically missing inflections result in broken restores of the database.
* | | Don't document internal monkey patch for mysql gem [ci skip]Zachary Scott2015-04-261-1/+3
| | | | | | | | | | | | Also added reference for to_date, as it belongs historically.
* | | use a more descriptive example. [ci skip]Yves Senn2015-04-241-6/+4
| | | | | | | | | | | | follow up to 107526e809ea2b6de8b2775ecf83e55d60833206
* | | docs for `create_table` and non-int primary keys. [ci skip]Yves Senn2015-04-241-0/+17
| | |
* | | Silence warning from MySQL::Error object in testPrem Sichanugrist2015-04-231-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When running Active Record MySQL test, this warning is printed in the console: warning: instance variable errno not initialized It turns out that this is a warning from `mysql` gem in MySQL::Error object. However, since the `mysql` gem is no longer maintained, and there won't be a newer version, it make sense for us to just silence this warning to make the output cleaner.
* | | Merge pull request #18880 from mudge/timestamp-index-bugRafael Mendonça França2015-04-233-0/+20
|\ \ \ | | | | | | | | | | | | Fix missing index when using timestamps with index
| * | | Fix missing index when using timestamps with indexPaul Mucur2015-04-153-0/+24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The `index` option used with `timestamps` should be passed to both `column` definitions for `created_at` and `updated_at` rather than just the first. This was happening because `Hash#delete` is used to extract the `index` option passed to `timestamps`, thereby mutating the `options` hash in-place. Now take a copy of the `options` before deleting so that the original is not modified.
* | | | Fix a minor grammatical issue in the docRomain Goyet2015-04-231-1/+1
| | | |
generated by cgit v1.2.3 (git 2.25.1) at 2025-03-26 14:16:13 +0000