| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | |
| | |
| | |
| | | |
Also improve some of the code conventions
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
existence
Also:
- updates tests by stubbing table_exists? method
- adds entry for creating indexes in CREATE TABLE to changelog
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This is important, because adding an index on a temporary table after
it has been created would commit the transaction
Conflicts:
activerecord/CHANGELOG.md
|
| | | |
|
|\ \ \
| | | |
| | | |
| | | | |
Still touch associations when theres no timestamp
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Prior to Rails 4.0.4 when touching a object which doesn't have timestamp
attributes (updated_at / updated_on) rails would still touch all
associations. After 73ba2c14cd7d7dfb2d132b18c47ade995401736f it updates
associations but rollsback because `touch` would return nil since
there's no timestamp attribute
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This reverts commit 6e3ab3e15faf782f6a937ccf5574a4fb63e3e353, reversing
changes made to 39e07b64ce3f4bb55e60ba0266e677f8e4f4893a.
Conflicts:
activerecord/CHANGELOG.md
activerecord/test/cases/autosave_association_test.rb
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
ActiveRecord::Base.pluralize_table_names = false.
Previously, generation a migration like this:
rails g migration add_column_name_to_user name
would not generating the correct table name.
Fixes #13426.
|
| | | |
| | | |
| | | |
| | | | |
arel methods are not supposed to be public API for ActiveRecord
|
| | | |
| | | |
| | | |
| | | | |
This abstracts us from the actual construction of the nodes
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Follow-Up to https://github.com/rails/rails/pull/14400
This ensures that all tables are removed after each test and thereby
allowing us to run the tests in a random order.
|
| | | |
| | | |
| | | |
| | | | |
This setups the helper method which other tests can benefit from.
|
|\ \ \ \
| | | | |
| | | | | |
Postgres schema: Constrain sequence search classid
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
The pk_an_sequence_for query previously joined against pg_class's oid
for rows in pg_depend, but pg_depend's objid may point to other system
tables, such as pg_attrdef. If a row in one of those other tables
coincidentally has the same oid as an (unrelated) sequence, that
sequence name may be returned instead of the real one.
This ensures that only the pg_depend entries pointing to pg_class are
considered.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
assert_raise + assert_equal on the returned exception message work
just fine, there is no need for extra work, specially like this overly
complicated helper.
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
ActiveRecord#touch should accept multiple attributes
Conflicts:
activerecord/CHANGELOG.md
|
| |/ / / / |
|
|/ / / / |
|
| | | |
| | | |
| | | |
| | | | |
Backport test from #14410
|
| | | |
| | | |
| | | |
| | | |
| | | | |
Previously, any of the connection checkouts could have failed, and this
test would pass.
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
.. not a general timeout.
Now, if a thread checks out a connection then dies, we can immediately
recover that connection and re-use it.
This should alleviate the pool exhaustion discussed in #12867. More
importantly, it entirely avoids the potential issues of the reaper
attempting to check whether connections are still active: as long as the
owning thread is alive, the connection is its business alone.
As a no-op reap is now trivial (only entails checking a thread status
per connection), we can also perform one in-line any time we decide to
sleep for a connection.
|
| | | |
| | | |
| | | |
| | | | |
It wasn't doing anything beyond clearing the statement cache.
|
| | | |
| | | |
| | | |
| | | | |
Closes #14406.
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Allows fixtures to use their $LABEL as part of a string instead
of limiting use to the entire value.
mark:
first_name: $LABEL
username: $LABEL1973
email: $LABEL@$LABELmail.com
users(:mark).first_name # => mark
users(:mark).username # => mark1973
users(:mark).email # => mark@markmail.com
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
tgxworld/use_teardown_helper_method_in_activerecord
Use teardown helper method.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Follow-Up to https://github.com/rails/rails/pull/14348
Ensure that SQLCounter.clear_log is called after each test.
This is a step to prevent side effects when running tests. This will allow us to run them in random order.
|
| | | | |
| | | | |
| | | | |
| | | | | |
Fixes #14383.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Update callbacks executed on AR::Base#touch [skip ci]
|
| | |/ / /
| |/| | |
| | | | |
| | | | |
| | | | | |
As of https://github.com/rails/rails/pull/12031 after_commit and
after_rollback are also executed
|
|/ / / /
| | | |
| | | |
| | | | |
mitigates #14323
|
|/ / / |
|
| | | |
|
|\ \ \
| | | |
| | | | |
Make select_all on query cache accept a Relation without binds.
|
| | | |
| | | |
| | | |
| | | |
| | | | |
[fixes #14361]
[related #13886]
|
| | | | |
|
|/ / /
| | |
| | |
| | | |
`exists?`
|
| | |
| | |
| | |
| | | |
please pass the id of the AR object by calling `.id` on the model first.
|
| | |
| | |
| | |
| | |
| | | |
Pass the id of the object to the method by calling `.id` on the AR
object.
|
| | |
| | |
| | |
| | |
| | |
| | | |
Apparently we've been using a buggy feature for the past 6 years:
https://bugs.ruby-lang.org/issues/9593
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Two bits of example code use sqlite as an adapter, which doesn't exist.
Using the code verbatim will raise a LoadError exception:
ActiveRecord::Base.establish_connection(
"adapter" => "sqlite",
"database" => "db.sqlite"
)
# => LoadError: Could not load 'active_record/connection_adapters/sqlite_adapter'...
Considering this is code a lot of people new to Rails might be running,
it's especially confusing.
Closes #14367 [ci skip]
|
|\ \ \
| | | |
| | | | |
Enhance docs for update_attribute [skip ci]
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | | |
Avoid rounding problems with `.usec` method rounding the seconds when the
field doesn't persist the `.usec` piece.
|
|/ / / |
|
|\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Only use BINARY for mysql case sensitive uniqueness check when column has a case insensitive collation.
Conflicts:
activerecord/CHANGELOG.md
|
| | | |
| | | |
| | | |
| | | | |
case insensitive collation.
|