aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | | | | | | | Remove conditional adding a new methodRafael Mendonça França2013-09-112-6/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | At the point we want to add the reflection we already know the reflection is of the AggregateReflection type so we can call a specific method
* | | | | | | | | | Fix inverted conditionalRafael Mendonça França2013-09-111-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Oops, I should had run the tests
* | | | | | | | | | Remove invalid commentRafael Mendonça França2013-09-111-4/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is not valid anymore after 08477a651648ba4417ded128aa37b9ae0dcbc9ce
* | | | | | | | | | Check if the SQL is not a prepared statementRafael Mendonça França2013-09-1110-7/+29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When the adapter is with prepared statement disabled and the binds array is not empty the connection adapter will try to set the binds values and will fail. Now we are checking if the adapter has the prepared statement disabled. Fixes #12023
* | | | | | | | | | Merge pull request #12188 from SamSaffron/masterAaron Patterson2013-09-114-12/+16
|\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | Perf: avoid dupes add fallback logic for coders
| * | | | | | | | | | Perf: avoid dupes add fallback logic for codersSam2013-09-114-12/+16
| | | | | | | | | | |
* | | | | | | | | | | Merge pull request #12135 from dylanahsmith/avoid_empty_transactionRafael Mendonça França2013-09-113-1/+10
|\ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Avoid empty transaction from setting has_one association on new record. Conflicts: activerecord/CHANGELOG.md
| * | | | | | | | | | | Avoid empty transaction from setting has_one association on new record.Dylan Thacker-Smith2013-09-113-1/+9
| | | | | | | | | | | |
* | | | | | | | | | | | WhitespacesRafael Mendonça França2013-09-111-1/+2
| | | | | | | | | | | |
* | | | | | | | | | | | Merge pull request #12185 from SamSaffron/join_depRafael Mendonça França2013-09-111-1/+13
|\ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | Reduce allocations when extracting AR models
| * | | | | | | | | | | | Reduce allocations when extracting AR modelsSam2013-09-111-1/+13
| | | | | | | | | | | | |
* | | | | | | | | | | | | Merge pull request #12194 from thedarkone/readonly-merger-fixRafael Mendonça França2013-09-113-1/+17
|\ \ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | Relation#merge should not lose readonly(false) flag.
| * | | | | | | | | | | | | Relation#merge should not lose readonly(false) flag.thedarkone2013-09-113-1/+17
| |/ / / / / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The original code ignores the `false` value because `false.blank? # => true`.
* | / / / / / / / / / / / fix deleting join models with no pkAaron Patterson2013-09-112-6/+62
| |/ / / / / / / / / / / |/| | | | | | | | | | |
* | | | | | | | | | | | add a comment for sanity of other people to comeAaron Patterson2013-09-101-0/+8
| | | | | | | | | | | |
* | | | | | | | | | | | ask the association for records rather than calling `send`Aaron Patterson2013-09-101-1/+2
| | | | | | | | | | | |
* | | | | | | | | | | | More unused associations in AR test modelsAkira Matsuda2013-09-108-13/+0
| | | | | | | | | | | |
* | | | | | | | | | | | :scissors: [ci skip]Carlos Antonio da Silva2013-09-101-1/+1
| | | | | | | | | | | |
* | | | | | | | | | | | change function def self.table_name to self.table_nameRajarshi Das2013-09-102-5/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | change def self.primary_key to self.primary_key change def self.primary_key to self.primary_key
* | | | | | | | | | | | Clean up unused associations in AR test modelAkira Matsuda2013-09-101-3/+0
|/ / / / / / / / / / /
* | | | | | | | | | | let the class cache object clean up user inputAaron Patterson2013-09-091-8/+20
| | | | | | | | | | |
* | | | | | | | | | | make @bitsweat happy. :heart:Aaron Patterson2013-09-091-0/+6
| | | | | | | | | | |
* | | | | | | | | | | stop using deprecated api in the testsAaron Patterson2013-09-091-1/+1
| | | | | | | | | | |
* | | | | | | | | | | Typo in Changelog.Ryan Wallace2013-09-081-2/+2
| | | | | | | | | | |
* | | | | | | | | | | Fix fixtures regression that required table names to map to classes only, ↵Jeremy Kemper2013-09-082-2/+2
| |/ / / / / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | not class names
* | | | | | | | | | hm:t join tables may not have a primary keyAaron Patterson2013-09-062-1/+23
| | | | | | | | | |
* | | | | | | | | | use polymorphic proxies to remove duplicate codeAaron Patterson2013-09-061-24/+43
| | | | | | | | | |
* | | | | | | | | | reduce duplication somewhatAaron Patterson2013-09-061-14/+14
| | | | | | | | | |
* | | | | | | | | | make the duplicate code more similarAaron Patterson2013-09-061-4/+10
| | | | | | | | | |
* | | | | | | | | | auto link hm:t fixture join tables like habtmAaron Patterson2013-09-062-0/+51
| |_|_|_|/ / / / / |/| | | | | | | |
* | | | | | | | | don't depend on object state when reading fixture filesAaron Patterson2013-09-061-8/+7
| | | | | | | | |
* | | | | | | | | ensure @model_class is initializedAaron Patterson2013-09-061-0/+1
| | | | | | | | |
* | | | | | | | | no need to dupAaron Patterson2013-09-051-1/+1
| | | | | | | | |
* | | | | | | | | push logic outside the FixtureSet constructorAaron Patterson2013-09-051-3/+3
| | | | | | | | |
* | | | | | | | | only construct the FixtureSet with AR modelsAaron Patterson2013-09-051-2/+11
| | | | | | | | |
* | | | | | | | | push constant lookup in the a cache objectAaron Patterson2013-09-051-2/+21
| | | | | | | | |
* | | | | | | | | Add a test case for exists? with multiple valuesRafael Mendonça França + Kassio Borges2013-09-041-0/+1
| |_|/ / / / / / |/| | | | | | |
* | | | | | | | Merge pull request #11958 from jetthoughts/extract_pre_process_orders_argsYves Senn2013-09-045-15/+52
|\ \ \ \ \ \ \ \ | |_|_|/ / / / / |/| | | | | | | Re-use order arguments pre-processing for reorder
| * | | | | | | Extracted from `order` processing of arguments, and use it for `reorder` to ↵Paul Nikitochkin2013-09-045-15/+52
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | be consistent.
* | | | | | | | adding a hm:t test for singleton ar objectsAaron Patterson2013-09-031-0/+27
| | | | | | | |
* | | | | | | | support anonymous classes on has_many associationsAaron Patterson2013-09-033-1/+20
| | | | | | | |
* | | | | | | | Merge pull request #12065 from SamSaffron/result_optimisationAaron Patterson2013-09-031-1/+15
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | Perf: micro optimised Result column hash_row creation
| * | | | | | | | Perf: micro optimised Result column hash_row creationSam2013-08-291-1/+15
| | | | | | | | |
* | | | | | | | | Revert "Merge pull request #12085 from valk/master"Santiago Pastorino2013-09-031-3/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 15455d76c8d33b3767a61e0cdd2de0ff592098ef, reversing changes made to ffa56f73d5ae98fe0b8b6dd2ca6f0dffac9d9217.
* | | | | | | | | Remove useless comment and white spaces :scissors: [ci skip]Carlos Antonio da Silva2013-09-012-3/+2
| | | | | | | | |
* | | | | | | | | clear all connections before forkingAaron Patterson2013-08-311-0/+3
| | | | | | | | |
* | | | | | | | | Revert "Do not dup the binds when visiting the AST"Rafael Mendonça França + Kassio Borges2013-08-313-10/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 71ff7d9c6592b93e2c810a1f464943dd7bd02c7f. Reason: I need to check with @jeremy if we can do this.
* | | | | | | | | Don't need to check if the scope respond to callRafael Mendonça França + Kassio Borges2013-08-313-7/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We are checking this when defining the default scope and raising an ArgumentError
* | | | | | | | | Revert "reconnect after the fork returns"Rafael Mendonça França2013-08-311-2/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit baf5f47b8768c7ec0164ed5ab60e369cdd936d71. Reason: This is breaking the sqlite3 tests with a missing transacion. Could not investigate right now. cc @tenderlove
* | | | | | | | | Do not dup the binds when visiting the ASTRafael Mendonça França2013-08-313-3/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The visitor have to consume the bind parameters to make the statements work when the prepared statement option is disabled. Fixes #12023