aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
Commit message (Collapse)AuthorAgeFilesLines
* Cleanup CHANGELOGs [ci skip]Prathamesh Sonpatki2016-07-091-7/+7
| | | | | | - Cleanup Active Record CHANGELOG. - Add missing CHANGELOG for https://github.com/rails/rails/pull/25688. - Clarify that assets requests logging is suppressed.
* fix to_param to maximize contentRob Biedenharn2016-07-083-4/+41
| | | | | | | | | | | | | | | | | | | | | The documentation states that parameter values longer than 20 characters will be truncated by words, but the example shows that a parameter based on "David Heinemeier Hansson" (with id: 125) becomes "125-david" when "David Heinemeier".length == 16 so why so short? The answer lies in the use of the #truncate option omission: nil which seems to have been intended to mean "nothing", but which actually causes the default string "..." to be used. This causes #truncate to cleave words until the "..." can be added and still remain within the requested size of 20 characters. The better option is omission: '' (which is probably what was originally intended). Furthermore, since the use of #parameterize will remove non-alphanumeric characters, we can maximize the useful content of the output by calling parameterize first and then giving truncate a separator: /-/ rather than a space.
* [ci skip] Update documentation in AR SchemaStatementsAlex Kitchens2016-07-071-12/+12
| | | | This includes minor grammar fixes throughout the file.
* Merge pull request #25707 from matthewd/double-reapMatthew Draper2016-07-074-11/+50
|\ | | | | Don't reap connections that have already been reassigned
| * Make connection stealing more explicitMatthew Draper2016-07-063-6/+27
| |
| * Reduce locking by taking ownership of stale connectionsMatthew Draper2016-07-061-9/+8
| | | | | | | | | | | | This way, we aren't racing other threads, so we don't need to re-check the conditional. And we no longer need to hold the lock while calling remove (which can choose to make a new connection while we wait).
| * Re-check that the connection is still stale before we reap itMatthew Draper2016-07-062-0/+9
| | | | | | | | | | | | | | A concurrent thread may have also detected it to be stale, and already released (or even reassigned) it by now. Fixes #25585
| * Check connection ownership before allowing a thread to release itMatthew Draper2016-07-061-1/+11
| | | | | | | | | | A thread can only release a connection if it owns it, or it's owned by a thread that has died.
* | [ci skip] Update ConnectionPool documentation for readabilityAlex Kitchens2016-07-061-21/+21
| |
* | Merge pull request #24890 from vipulnsward/travel-to-raiseKasper Timm Hansen2016-07-051-6/+5
|\ \ | | | | | | `travel/travel_to` travel time helpers, now raise on nested calls
| * | `travel/travel_to` travel time helpers, now raise on nested calls,Vipul A M2016-07-021-6/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | as this can lead to confusing time stubbing. Instead of: travel_to 2.days.from_now do # 2 days from today travel_to 3.days.from_now do # 5 days from today end end preferred way to achieve above is: travel_to 2.days.from_now # 2 days from today travel_back travel_to 5.days.from_now # 5 days from today Closes #24690 Fixes #24689
* | | Merge pull request #25668 from kamipo/use_squish_rather_than_strip_heredocRafael França2016-07-052-4/+4
|\ \ \ | | | | | | | | Use `squish` rather than `strip_heredoc`
| * | | Use `squish` rather than `strip_heredoc`Ryuta Kamizono2016-07-042-4/+4
| | |/ | |/|
* | | Merge pull request #25680 from ↵Rafael França2016-07-041-7/+5
|\ \ \ | | | | | | | | | | | | | | | | HermanHiddema/fix/unnecessary-nesting-in-handle-dependency Fixed unnecessary nesting in handle_dependency
| * | | Fixed unnecessary nesting in handle_dependencyHerman Hiddema2016-07-041-7/+5
| |/ / | | | | | | | | | | | | This nested if checked the same value as the containing case statement. Moved the code in the if/else into when/else in the containing case.
* / / fix respond_to? documentationKivanio Barbosa2016-07-041-7/+7
|/ /
* | Merge pull request #25241 from aguynamedben/fix-touch-error-messagesRichard Schneeman2016-07-032-2/+12
|\ \ | | | | | | Improve error message when record touch fails.
| * | Improve error message when record touch fails.Ben Standefer2016-07-022-2/+12
| | | | | | | | | | | | | | | | | | The current error message only indicates that a touch can fail because the record is new. In practice, we saw cases where touches were failing because the record had been destroyed. `persisted?` checks `new_record?` *and* `destroyed?`. It was confusing to get a message about a new record when in reality we were destroying records. I also included a helpful tip for users to consider using `persisted?`, `new_record?`, or `destroyed?` before touching.
* | | Clarify Postgres initials. [skip ci]William Johnston2016-07-021-2/+2
|/ /
* | Fix typo: accidently -> accidentally.Hendy Tanata2016-07-021-1/+1
| |
* | Merge pull request #25638 from kamipo/remove_unused_predicate_builderSean Griffin2016-07-023-19/+3
|\ \ | | | | | | Remove unused `predicate_builder` for `BasicObjectHandler` and `RangeHandler`
| * | Remove unused `predicate_builder` for `BasicObjectHandler` and `RangeHandler`Ryuta Kamizono2016-07-023-19/+3
| | |
* | | Merge pull request #25507 from ↵Rafael França2016-07-023-14/+17
|\ \ \ | | | | | | | | | | | | | | | | bquorning/optimize-for-first-result-and-remove-mysql-select_one Remove #select_one from Mysql2Adapter
| * | | Optimize ActiveRecord::Result#lastBenjamin Quorning2016-06-242-1/+7
| | | | | | | | | | | | | | | | | | | | If you only want the last element of a result set, there's no need to create all of hash_rows. Also, add a test.
| * | | Remove MySQL::DatabaseStatements#select_oneBenjamin Quorning2016-06-241-13/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The implementation from abstract/database_statements.rb seems to work just fine. And with ActiveRecord::Result now implementing an optimized #first method, the performance concerns previously addressed in https://github.com/rails/rails/commit/bf79aa4fc14aeb2646331e767038acf0b77e9e7f should not be an issue.
| * | | Add ActiveRecord::Result#firstBenjamin Quorning2016-06-242-0/+10
| | | | | | | | | | | | | | | | | | | | When you only need the first element of a result set, you shouldn't need to instantiate all of hash_rows.
* | | | Merge pull request #25631 from yahonda/revert_rename_to_ar_internal_metadataRafael França2016-07-012-28/+0
|\ \ \ \ | | | | | | | | | | Revert "Rename `active_record_internal_metadatas` to `ar_internal_metadata"
| * | | | Revert "Rename `active_record_internal_metadatas` to `ar_internal_metadata`"Yasuo Honda2016-07-012-28/+0
| | |_|/ | |/| | | | | | | | | | This reverts commit 407e0ab5e5cddf6a8b6b278b12f50772d13b4d86.
* | | | Merge pull request #25633 from kamipo/remove_create_table_info_cacheRafael França2016-07-011-6/+1
|\ \ \ \ | |_|_|/ |/| | | Remove `create_table_info_cache` because it not be reused
| * | | Remove `create_table_info_cache` because it not be reusedRyuta Kamizono2016-07-021-6/+1
| |/ / | | | | | | | | | | | | | | | `create_table_info_cache` is used for sharing `create_table_info` both `table_options` and `foreign_keys`. But `foreign_keys` no longer uses `create_table_info_cache` by #25307. No need caching anymore.
* | | Merge pull request #25620 from kamipo/create_without_primary_keyRafael França2016-07-012-1/+9
|\ \ \ | |/ / |/| | Pass `pk: false` to `connection.insert` explicitly if do not have a primary key
| * | Pass `pk: false` to `connection.insert` explicitly if do not have a primary keyRyuta Kamizono2016-07-012-1/+9
| | | | | | | | | | | | | | | | | | Because causing an extra query by `sql_for_insert` for guessing a primary key. https://github.com/rails/rails/blob/v5.0.0/activerecord/lib/active_record/connection_adapters/postgresql/database_statements.rb#L121-L125
* | | Add regression test for foreign key schema dump cachingeileencodes2016-07-011-0/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If you had a foreign key set and then decided to add `on_delete: :cascade` later in another migration that migration would run but wouldn't refresh the schema dump. The reason for this was because `create_table_info` caches the statement and sets it to be the same as the original declaration for the foreign key (without the `on_delete: :cascade`. PR #25307 ended up fixing this bug because it removes the check for `create_table_info` and relies on reading from `information_schema`. The fix however was intended to patch another bug. The reason this fixes the issue is we're no longer parsing the regex from the cached `create_table_info`. This regression test is to ensure that the issue does not return if we for some reason go back to using `create_table_info` to set the foreign keys.
* | | Merge pull request #25307 from ↵Eileen M. Uchitelle2016-07-015-36/+46
|\ \ \ | |/ / |/| | | | | | | | kamipo/extract_foreign_key_action_from_information_schema Extract foreign key action from `information_schema`
| * | Extract foreign key action from `information_schema`Ryuta Kamizono2016-06-074-34/+44
| | | | | | | | | | | | Fixes #25300.
| * | Make `foreign_keys` queries to `SCHEMA`Ryuta Kamizono2016-06-072-2/+2
| | |
* | | Do not specal case inspecting associated arrays of over 10 elements, ↵Kevin McPhillips2016-06-294-10/+36
| | | | | | | | | | | | preventing infinite looping in some cases.
* | | Don't attempt to clear active connections unless we'ere connectedSean Griffin2016-06-291-1/+1
| | | | | | | | | | | | | | | | | | Right now with this middleware we are likely always connected, but I'm hoping to change that soon. This is an easy change to pull out on its own.
* | | Remove unused `ActiveRecord::Base.connection_id`Sean Griffin2016-06-295-28/+9
| | | | | | | | | | | | | | | | | | | | | | | | This method appears to have been partially used in connection pool caching, but it was introduced without much reasoning or any tests. One edge case test was added later on, but it was focused on implementation details. This method is no longer used outside of tests, and as such is removed.
* | | Merge pull request #25364 from kamipo/fix_serialize_for_date_typeRafael França2016-06-281-1/+13
|\ \ \ | | | | | | | | Fix `Type::Date#serialize` to return a date object correctly
| * | | Fix `Type::Date#serialize` to return a date object correctlyRyuta Kamizono2016-06-161-1/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently `Type::Date#serialize` does not cast a value to a date object. It should be cast to a date object for finding by date column correctly working. Fixes #25354.
* | | | [ci skip] Clarify DDL term in ActiveRecord::TransactionsAlex Kitchens2016-06-271-4/+4
| | | |
* | | | Remove unnecessary `assert_valid_default`Ryuta Kamizono2016-06-252-14/+0
| | | | | | | | | | | | | | | | | | | | This was added at c7c3f73 but it never raised because MySQL cannot create text/blob columns with a default value.
* | | | nodoc `ActiveRecord::AttributeSet::YAMLEncoder`Jon Moss2016-06-241-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As mentioned in 7b86ea6715ee987e61a7f3bd8e72b1bbfcfbbbe7, this is an internal class. [ci skip] r? @sgrif
* | | | Revert "[ci skip] better docs for ↵Jon Moss2016-06-241-17/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ActiveRecord::AttributeSet::YAMLEncoder#decode" This reverts commit 7ea502ae141fc26b736c7a73bdf7a676b1f9fc87, per internal discussion with @sgrif -- this is documenting the implementation of a class that isn't intended to be public API.
* | | | Merge pull request #25506 from y-yagi/return_correct_from_enum_typeSean Griffin2016-06-242-0/+6
|\ \ \ \ | |_|_|/ |/| | | return correct type from `EnumType`
| * | | return correct type from `EnumType`yuuji.yaginuma2016-06-242-0/+6
| | | |
* | | | Removed a forgotten `with_exclusive_scope` test:Edouard CHIN2016-06-241-6/+0
| | | | | | | | | | | | | | | | - `with_exclusive_scope` was removed in this commit d242e467819a428ad7e302968e4c9fa1e26d9326
* | | | [ci skip] Update Documentation on ActiveRecord::InheritanceAlex Kitchens2016-06-231-1/+2
|/ / /
* | | [ci skip] better docs for ActiveRecord::AttributeSet::YAMLEncoder#decodeDavid Elliott2016-06-211-0/+17
| | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-02 17:41:25 +0000