| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|\ \ \ \ \ \ \ \ \ \
| |/ / / / / / / / /
|/| | | | | | | | | |
Add a Monitor to ModelSchema#load_schema
|
| |/ / / / / / / /
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
[Vikrant Chaudhary, David Abdemoulaie, Matthew Draper]
|
|\ \ \ \ \ \ \ \ \
| |_|/ / / / / / /
|/| | | | | | | | |
Extract `JSONSharedTestCases`
|
| | |/ / / / / /
| |/| | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
Both `mysql2/json_test.rb` and `postgresql/json_test.rb` have same test
cases.
|
|\ \ \ \ \ \ \ \
| |_|/ / / / / /
|/| | | | | | | |
Fix crashing on circular left join references with scoping
|
| | |_|_|_|_|/
| |/| | | | |
| | | | | | |
| | | | | | | |
Follow up of #25702.
|
|/ / / / / / |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Make helper methods in tests to private
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
`make_model` and `make_no_pk_hm_t` in `HasManyThroughAssociationsTest`
are not a test case. it should be private.
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Both reference id and type should be `NOT NULL` if `null: false` is specified
|
| |/ / / / / /
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
This is a regression due to #28282.
Fixes #29136.
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Adding Foreing Key - Don't worry about building the identifier if name is already present.
|
| | |_|/ / / /
| |/| | | | |
| | | | | | |
| | | | | | | |
present.
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Remove a duplicate test of inverse_associations_test in AR
|
| | |_|/ / / /
| |/| | | | | |
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Remove unused `JoinPart#name`
|
| |/ / / / / / |
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Remove unused `left_joins_values` generation
|
| |/ / / / / /
| | | | | | |
| | | | | | |
| | | | | | | |
This was added at #22125 but `left_joins_values` is never used.
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Refactor making join constraints
|
| |/ / / / / /
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
The only difference between `make_inner_joins` and
`make_left_outer_joins` is the `join_type`.
|
|/ / / / / / |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Make `VALID_DIRECTIONS` to `Set`
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
```ruby
require "benchmark/ips"
require "set"
array = [:asc, :desc, :ASC, :DESC, "asc", "desc", "ASC", "DESC"]
set = array.to_set
item = "DESC"
Benchmark.ips do |x|
x.report "array" do
array.include?(item)
end
x.report "set" do
set.include?(item)
end
end
```
```
% ruby array_vs_set.rb
Warming up --------------------------------------
array 188.441k i/100ms
set 229.531k i/100ms
Calculating -------------------------------------
array 3.508M (± 9.0%) i/s - 17.525M in 5.043058s
set 5.134M (± 7.6%) i/s - 25.707M in 5.038921s
```
|
|/ / / / / / |
|
| |/ / / /
|/| | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This retains the existing behavior of
ActiveSupport::Cache.expand_cache_key (as used by etaging) where the
cache key includes the version.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
* Fix indentation.
* Add backticks.
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Remove unneeded `association.respond_to?(:reset_scope)`
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Since 86390c3 all associations have `reset_scope` so `respond_to?` is
unneeded.
|
|/ / / / /
| | | | |
| | | | |
| | | | | |
Addresses #29021
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
The object inside the scope is of the class that define the association
not the associated class.
[ci skip]
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
* Use NOT IN in SQL query
* Quote table names propertly
* Use array form of command invocation
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| |_|_|/
|/| | |
| | | |
| | | |
| | | |
| | | | |
When using `sql` as the schema format, or even just doing `rake
db:structure:dump`, it would be good to respect the list of ignored
tables that has been configured.
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
meinac/fix_ambigious_exception_message_of_select_query_method
Fix ambigious error message of select query method [ci skip]
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Don't eager loading if unneeded for `FinderMethods#exists?`
|
| | |/ / /
| |/| | |
| | | | |
| | | | | |
Fixes #29025.
|
|/ / / /
| | | |
| | | |
| | | |
| | | |
| | | | |
Because we don't need to load tasks for DBs that we don't use for the current app.
Also, these Tasks classes load AR::Base in their class level, and so immediately kick :active_record on_load hooks.
This used to happen when we were loading tasks, not when we run a task.
|
| |_|/
|/| | |
|
| |/
|/|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
```
% ARCONN=sqlite3 be ruby -w -Itest test/cases/quoting_test.rb
test/cases/quoting_test.rb:92: warning: ambiguous first argument; put parentheses or a space even after `/' operator
test/cases/quoting_test.rb:96: warning: ambiguous first argument; put parentheses or a space even after `/' operator
Using sqlite3
Run options: --seed 9495
.....................................
Finished in 0.046403s, 797.3622 runs/s, 1120.6172 assertions/s.
37 runs, 52 assertions, 0 failures, 0 errors, 0 skips
```
|
|\ \
| | |
| | | |
Clarify deprecation message for #quoted_id
|
| | |
| | |
| | |
| | |
| | | |
In this case, it's the method definition that's more at fault, rather
than the current caller.
|
| | |
| | |
| | |
| | | |
`DelegationTest#call_method` is no longer used since 9d79334a.
|
| | |
| | |
| | |
| | |
| | |
| | | |
The argument of `Arel::SelectManager.new` is `table`, not `engine`.
https://github.com/rails/arel/blob/v8.0.0/lib/arel/select_manager.rb#L10
|
|/ /
| |
| |
| | |
Since through association is always loaded by `preloader.preload`.
|