aboutsummaryrefslogtreecommitdiffstats
path: root/activerecord
Commit message (Collapse)AuthorAgeFilesLines
* Skip two tests with polymorphic if current adapter is Oracle Adapter.Yasuo Honda2012-06-081-0/+3
| | | | because Oracle Adapter does not support foreign keys if :polymorphic => true is used.
* Merge pull request #6629 from marcandre/destroyCarlos Antonio da Silva2012-06-065-0/+34
|\ | | | | Add ActiveRecord::Base#destroy!
| * + ActiveRecord::Base#destroy!Marc-Andre Lafortune2012-06-065-0/+34
| |
* | reduce number of StringsAkira Matsuda2012-06-061-1/+1
| |
* | Symbol responds_to :upcase & :downcase in Ruby >= 1.9Akira Matsuda2012-06-061-1/+1
| |
* | stop `to_s`ing method namesAkira Matsuda2012-06-062-3/+2
| | | | | | | | Module#methods are Symbols in Ruby >= 1.9
* | Merge pull request #6616 from dpassage/fix_resolver_test_sqlite3Carlos Antonio da Silva2012-06-051-0/+3
|\ \ | |/ |/| Resolver tests fail if mysql adapter not installed
| * The resolver tests fail if the mysql gem is not installed; this breaksDavid Paschich2012-06-031-0/+3
| | | | | | | | | | | | | | | | being able to run the sqlite3 tests without that gem. This fix ensures the tests will only run if the mysql gem is installed. A better solution might be to move these tests into the per-adapter tests, and test each adapter's resolver.
* | Fix #6591. If a field with timezone isn't changed, we don't call will_change!.kennyj2012-06-041-1/+2
| |
* | Add failing test for 3.2.5 datetime attribute regressionEvan Arnold2012-06-041-0/+11
|/
* a test case that ensures AR::Relation#merge can merge associationsAkira Matsuda2012-06-031-0/+8
|
* minor comment revisionXavier Noria2012-06-011-1/+1
|
* Sync CHANGLOG with the 3-2-stable branchRafael Mendonça França2012-06-011-0/+27
|
* improve readability of AR explain resultAkira Matsuda2012-06-011-1/+7
|
* unused method argumentsAkira Matsuda2012-06-011-7/+6
|
* modulize AR::NullRelationAkira Matsuda2012-06-013-4/+9
| | | | now we can invoke previously added scope extension methods
* Merge branch 'master-sec'Aaron Patterson2012-05-313-3/+37
|\ | | | | | | | | | | * master-sec: Strip [nil] from parameters hash. Thanks to Ben Murphy for reporting this! predicate builder should not recurse for determining where columns. Thanks to Ben Murphy for reporting this
| * predicate builder should not recurse for determining where columns.Aaron Patterson2012-05-303-3/+37
| | | | | | | | | | | | Thanks to Ben Murphy for reporting this CVE-2012-2661
* | Psych is always available on 1.9Jeremy Kemper2012-05-312-29/+23
| |
* | Fix changelog example for count method with block [ci skip]Carlos Antonio da Silva2012-05-311-1/+1
| | | | | | | | Missed that too, thanks again @splattael.
* | Fix wrong example for count method with block [ci skip]Carlos Antonio da Silva2012-05-311-1/+1
| | | | | | | | Thanks @splattael.
* | Work around undiagnosed bug that's draining a relation's bind_valuesJeremy Kemper2012-05-311-0/+1
| |
* | Fix backward compatibility with stored Hash values. Wrap coders to convert ↵Jeremy Kemper2012-05-303-15/+51
| | | | | | | | serialized values to indifferent access.
* | Merge pull request #6477 from steveklabnik/close_discovered_pg_connectionRafael Mendonça França2012-05-301-1/+2
|\ \ | | | | | | Properly discover a connection is closed in postgresql_adapter
| * | Properly discover a connection is closed in postgresql_adapterSteve Klabnik2012-05-241-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PQstatus doesn't properly test if future operations will succeed. A PQping function is added to libpq in PostgreSQL 9.1, but if we rely on it, everyone on earlier versions of Postgres is out of luck, and the pg gem wouldn't have the 'fix' until the next release. Thanks to @cbrecabarren and @ged for handling all the dirty details. Closes #3392.
* | | Merge pull request #5810 from kennyj/fix_5797Aaron Patterson2012-05-304-5/+15
|\ \ \ | | | | | | | | Fix #5797. Error calling dup method on AR model with serialized field
| * | | Fix #5797. Error calling dup method on AR model with serialized fieldkennyj2012-05-304-5/+15
| | | |
* | | | Merge pull request #6386 from kennyj/fix_logs_name_consistencyAaron Patterson2012-05-307-33/+123
|\ \ \ \ | | | | | | | | | | Fix logs name consistency.
| * | | | Fix logs name consistency.kennyj2012-05-197-33/+123
| | | | |
* | | | | Merge branch 'master' of github.com:lifo/docrailsVijay Dev2012-05-305-27/+37
|\ \ \ \ \ | |_|/ / / |/| | | |
| * | | | copy edit the batches docs [ci skip]Vijay Dev2012-05-301-9/+7
| | | | |
| * | | | change example on CollectionProxy#delete to accept multiple valuesFrancesco Rodriguez2012-05-281-1/+1
| | | | |
| * | | | Adds to Batch processing documentation [ci skip]Alvaro Pereyra2012-05-281-9/+20
| | | | |
| * | | | fix typo and remove 'examples' noise [ci skip]Francesco Rodriguez2012-05-281-18/+6
| | | | |
| * | | | Updates examples for FinderMethods [ci skip]Alvaro Pereyra2012-05-281-2/+14
| | | | |
| * | | | Merge branch 'master' of github.com:lifo/docrailsAlvaro Pereyra2012-05-2840-99/+798
| |\ \ \ \
| | * \ \ \ Merge pull request #102 from xenda/masterXenda2012-05-271-4/+4
| | |\ \ \ \ | | | | | | | | | | | | | | Small fix to update the README using more up to date conventions.
| | * | | | | "a sql" -> "an SQL" per API documentation guidelinesMark Rushakoff2012-05-271-1/+1
| | | | | | |
| * | | | | | Adds examples to FinderMethods#first [ci skip]Alvaro Pereyra2012-05-281-0/+1
| | |/ / / / | |/| | | |
| * | | | | Updates validations examples to be more attuned on the new Rails 3.0 conventionsAlvaro Pereyra2012-05-281-4/+4
| | | | | |
* | | | | | Fix #5847 and #4045 on master.kennyj2012-05-301-0/+2
| | | | | |
* | | | | | Use runner hook to load ActiveRecord::Base.kennyj2012-05-301-0/+4
| | | | | |
* | | | | | SchemaMigration should be loaded lazily.kennyj2012-05-293-2/+1
| | | | | |
* | | | | | Add tests to delete by fixnum or string id with has many through associationsFrancesco Rodriguez2012-05-281-0/+20
| | | | | |
* | | | | | Fix failing build related to change in CollectionAssociation#deleteCarlos Antonio da Silva2012-05-291-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | Merge commit 6f1d9d00ffd9d411b2bd488da4eb92b7e2fd972e
* | | | | | Yield only one argument instead of splatting.Carlos Antonio da Silva2012-05-282-2/+9
| | | | | | | | | | | | | | | | | | | | | | | | Add Changelog entry. Closes #4003
* | | | | | Allow blocks for count with ActiveRecord::Relation. Document and test that ↵chrisfinne2012-05-282-3/+30
| | | | | | | | | | | | | | | | | | | | | | | | sum allows blocks
* | | | | | Add support for CollectionAssociation#delete by Fixnum or StringFrancesco Rodriguez2012-05-284-3/+57
| |/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I found the next issue between CollectionAssociation `delete` and `destroy`. class Person < ActiveRecord::Base has_many :pets end person.pets.destroy(1) # => OK, returns the destroyed object person.pets.destroy("2") # => OK, returns the destroyed object person.pets.delete(1) # => ActiveRecord::AssociationTypeMismatch person.pets.delete("2") # => ActiveRecord::AssociationTypeMismatch Adding support for deleting with a fixnum or string like `destroy` method.
* | | | | remove unnecessary ruby 1.8 reference from active_record/core [ci skip]Francesco Rodriguez2012-05-261-3/+4
| | | | |
* | | | | add CollectionProxy#uniq documentationFrancesco Rodriguez2012-05-261-0/+21
| | | | |