Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Merge pull request #451 from baroquebobcat/fixing_last_for_issue_371 | Jon Leighton | 2011-05-08 | 2 | -1/+27 |
|\ | |||||
| * | Fix for #371 | Nick Howard | 2011-05-08 | 2 | -1/+27 |
| | | | | | | | | | | | | | | | | | | | | | | | | if a query contains a limit or an offset, ActiveRecord::FinderMethods#find_last had inconsistent behavior. If the records were loaded, it returned the last record in the cached list. If they were not, it reversed the order of the query and changed the limit to one. If the earlier limit was less than the total matching the query in the db, it would return a different record than if the records had been cached. This commit changes find_last so that it loads the records when getting the last record on a query containing a limit or an offset, which makes the behavior consistent. | ||||
* | | Ensure that ORDER BY clauses from default scopes are not included in ↵ | Jon Leighton | 2011-05-08 | 2 | -1/+5 |
| | | | | | | | | calculation queries. Fixes #406. | ||||
* | | Don't quote ID's as Arel will quote them -- follow same conventions as the ↵ | Christopher Meiklejohn | 2011-05-08 | 5 | -2/+52 |
| | | | | | | | | delete method. | ||||
* | | renamed mass-assignment scopes to roles, updated code, tests, docs and ↵ | Josh Kalderimis | 2011-05-08 | 3 | -34/+34 |
|/ | | | | security guide | ||||
* | Added deprecation warning for Fixture(s) (Use ActiveRecord::Fixture(s)) | Jason Noble | 2011-05-07 | 1 | -0/+3 |
| | |||||
* | Namespace Fixtures in ActiveRecord | Jason Noble | 2011-05-07 | 8 | -318/+320 |
| | | | [Fixes #439] | ||||
* | Class.new.name returns an empty string on 1.8 | José Valim | 2011-05-07 | 1 | -1/+1 |
| | |||||
* | Revert "Revert the merge because tests did not pass." | José Valim | 2011-05-07 | 3 | -5/+44 |
| | | | | This reverts commit 886818d2bab40585c0cea763002ffc16917dd0b3. | ||||
* | fix yield not working from around filter of observers, fixes Github#329 | Hemant Kumar | 2011-05-07 | 2 | -2/+27 |
| | |||||
* | Merge pull request #396 from asanghi/lh_4346 | Xavier Noria | 2011-05-06 | 2 | -29/+187 |
|\ | | | | | Multiparameter POLA (principle of least authority) with respect to time_select fixes. See LH4346 | ||||
| * | Multiparameter POLA, time_select fixes. See LH4346 | Aditya Sanghi | 2011-05-05 | 2 | -29/+187 |
| | | |||||
* | | Update CHANGELOGs. | José Valim | 2011-05-06 | 1 | -19/+16 |
| | | |||||
* | | Merge pull request #399 from ernie/join_conditions_on_join | Jon Leighton | 2011-05-05 | 2 | -3/+14 |
|\ \ | | | | | | | Add association join conditions to JOIN clause, not WHERE | ||||
| * | | Add a test for outer joins with conditions where value IS NULL | Ernie Miller | 2011-05-05 | 1 | -0/+5 |
| | | | |||||
| * | | Add join conditions to JOIN clause, not WHERE | Ernie Miller | 2011-05-05 | 2 | -3/+9 |
| |/ | |||||
* | | Merge pull request #358 from baroquebobcat/fix_find_or_create_master | Aaron Patterson | 2011-05-05 | 2 | -3/+30 |
|\ \ | |/ |/| | Fix for lighthouse #6741 | ||||
| * | Fix for lighthouse #6741 | Nick Howard | 2011-05-01 | 2 | -3/+30 |
| | | | | | | | | | | | | | | - adds tests for find_or_create_by and find_or_initialize_by on has_many associations - changes the behavior of ActiveRecord::Associations::CollectionProxy#method_missing to differ to ActiveRecord::FinderMethods#find_or_instantiator_by_attributes for arg processing and saving so find_or_create_by's api on associations will be consistent w/ the api for model classes. | ||||
* | | Prepare for beta1 | David Heinemeier Hansson | 2011-05-04 | 1 | -1/+1 |
| | | |||||
* | | ensure query cache is cleared when Rack body is closed, fixes bug reported ↵ | Aaron Patterson | 2011-05-04 | 2 | -0/+12 |
| | | | | | | | | on 951e18abea9c116fc5d6b330ca1dcd2890abe006 | ||||
* | | Bump up rack-cache, tzinfo and thor | Santiago Pastorino | 2011-05-04 | 1 | -1/+1 |
| | | |||||
* | | Move sandbox to AR and pass the sandbox as a value. This way, other ORMs ↵ | José Valim | 2011-05-04 | 2 | -1/+8 |
| | | | | | | | | like Datamapper can also have their own sandboxing in rails console. | ||||
* | | Remove defined?(ActiveRecord) and use the railtie hook instead. | José Valim | 2011-05-04 | 1 | -3/+4 |
| | | |||||
* | | Merge branch 'master' of git://github.com/lifo/docrails | Xavier Noria | 2011-05-04 | 5 | -33/+41 |
|\ \ | |||||
| * | | Remove extra whitespaces | Sebastian Martinez | 2011-05-03 | 1 | -9/+9 |
| | | | |||||
| * | | Improves Mysql2 adapter docs | Sebastian Martinez | 2011-05-03 | 1 | -0/+6 |
| | | | |||||
| * | | Added #recreate_database docs | Sebastian Martinez | 2011-05-03 | 1 | -0/+2 |
| | | | |||||
| * | | Fixes on schema_definitions docs | Sebastian Martinez | 2011-05-03 | 1 | -3/+3 |
| | | | |||||
| * | | fixed-fonts on SchemaDefinitions | Sebastian Martinez | 2011-05-02 | 1 | -3/+3 |
| | | | |||||
| * | | Remove extra whitespaces | Sebastian Martinez | 2011-05-02 | 1 | -18/+18 |
| | | | |||||
* | | | added the mysql schema test to mysql2 adapter, and fixed the corresponding ↵ | Josh Kalderimis | 2011-05-03 | 3 | -3/+54 |
| | | | | | | | | | | | | failures | ||||
* | | | make sure IM repository is cleared after body is closed | Aaron Patterson | 2011-05-03 | 2 | -0/+12 |
| | | | |||||
* | | | proxying the body in the IM middleware so that IM is available for streaming ERb | Aaron Patterson | 2011-05-03 | 2 | -3/+47 |
| | | | |||||
* | | | adding a test case for the identity map middleware | Aaron Patterson | 2011-05-03 | 1 | -0/+34 |
| | | | |||||
* | | | favor collect over each in mysql* adapters | Josh Kalderimis | 2011-05-03 | 2 | -8/+4 |
| | | | |||||
* | | | introduce a body proxy to ensure that query cache is enabled during streaming | Aaron Patterson | 2011-05-02 | 3 | -3/+58 |
| | | | |||||
* | | | more tests around caching | Aaron Patterson | 2011-05-02 | 1 | -1/+10 |
| | | | |||||
* | | | add a couple test cases surrounding query cache middleware | Aaron Patterson | 2011-05-02 | 1 | -0/+18 |
| | | | |||||
* | | | Fix failing AR test. | José Valim | 2011-05-02 | 2 | -17/+12 |
| | | | |||||
* | | | Make the identity map use the instrumentation infrastructure so we can style ↵ | David Heinemeier Hansson | 2011-05-01 | 3 | -10/+31 |
| | | | | | | | | | | | | the messages nicely with colors (FIXME: Can someone look into why the test is not working?) | ||||
* | | | Remove schema noise from logging (TODO: Deprecate/remove the name attribute ↵ | David Heinemeier Hansson | 2011-05-01 | 1 | -4/+4 |
| | | | | | | | | | | | | to all these methods -- will take a pull request!) | ||||
* | | | Merge pull request #357 from joshk/assign_attributes. | David Heinemeier Hansson | 2011-05-01 | 7 | -64/+464 |
|\ \ \ | | | | | | | | | Assign protected attributes with create/new and control the role. | ||||
| * | | | singular and collection relations in AR can now specify mass-assignment ↵ | Josh Kalderimis | 2011-05-01 | 6 | -59/+346 |
| | | | | | | | | | | | | | | | | security options (:as and :without_protection) in build, create and create! methods. | ||||
| * | | | Added mass-assignment security :as and :without_protection support to AR.new ↵ | Josh Kalderimis | 2011-05-01 | 2 | -29/+142 |
| | |/ | |/| | | | | | | | and AR.create | ||||
* | | | Merge pull request #340 from joshk/default_scope_changes. | David Heinemeier Hansson | 2011-05-01 | 3 | -56/+41 |
|\ \ \ | |/ / |/| | | removed the default_scope deprecations and updated the docs and tests to | ||||
| * | | removed the default_scope deprecations and updated the docs and tests to ↵ | Josh Kalderimis | 2011-04-28 | 3 | -56/+41 |
| | | | | | | | | | | | | reflect its use cases | ||||
* | | | assert_difference can take a callable piece of code rather than just evaling ↵ | Aaron Patterson | 2011-05-01 | 1 | -4/+4 |
| | | | | | | | | | | | | a string | ||||
* | | | Merge pull request #316 from arunagw/jdbc_postgresql. | Aaron Patterson | 2011-05-01 | 1 | -83/+83 |
|\ \ \ | |_|/ |/| | | Re-factored database.rake to allow Jdbcpostgresql. #jruby | ||||
| * | | Minor fixes in databases.rake | Arun Agrawal | 2011-04-27 | 1 | -71/+71 |
| | | | |||||
| * | | Allowing jdbcsqlite3 to drop database, clone structure. #jruby | Arun Agrawal | 2011-04-27 | 1 | -7/+7 |
| | | |