Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | disallow mutating a relation once loaded | Jon Leighton | 2012-06-22 | 3 | -18/+50 |
| | |||||
* | It's AR::Reflection not AR::Relation | Andrew White | 2012-06-22 | 1 | -1/+1 |
| | |||||
* | Improve the derivation of HABTM assocation join table names | Andrew White | 2012-06-22 | 13 | -52/+85 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Improve the derivation of HABTM join table name to take account of nesting. It now takes the table names of the two models, sorts them lexically and then joins them, stripping any common prefix from the second table name. Some examples: Top level models (Category <=> Product) Old: categories_products New: categories_products Top level models with a global table_name_prefix (Category <=> Product) Old: site_categories_products New: site_categories_products Nested models in a module without a table_name_prefix method (Admin::Category <=> Admin::Product) Old: categories_products New: categories_products Nested models in a module with a table_name_prefix method (Admin::Category <=> Admin::Product) Old: categories_products New: admin_categories_products Nested models in a parent model (Catalog::Category <=> Catalog::Product) Old: categories_products New: catalog_categories_products Nested models in different parent models (Catalog::Category <=> Content::Page) Old: categories_pages New: catalog_categories_content_pages Also as part of this commit the validity checks for HABTM assocations have been moved to ActiveRecord::Reflection One side effect of this is to move when the exceptions are raised from the point of declaration to when the association is built. This is consistant with other association validity checks. | ||||
* | Set the hash value directly instead of using merge! | Carlos Antonio da Silva | 2012-06-21 | 1 | -1/+1 |
| | |||||
* | changed the firm of changes_from_zero_to_string? | Angelo capilleri | 2012-06-21 | 1 | -2/+2 |
| | | | | delete *column* because is unused by the method. | ||||
* | explain listener does not care about time, so use evented listener | Aaron Patterson | 2012-06-20 | 2 | -7/+10 |
| | |||||
* | Refactor testcase codes. It's repeated. | kennyj | 2012-06-21 | 1 | -132/+38 |
| | |||||
* | Merge pull request #6798 from kennyj/db-rake-structure-load | Carlos Antonio da Silva | 2012-06-20 | 9 | -53/+133 |
|\ | | | | | Refactor db:structure:load task. | ||||
| * | Remove duplicated codes. | kennyj | 2012-06-21 | 1 | -41/+11 |
| | | |||||
| * | Refactor db:structure:load task. | kennyj | 2012-06-21 | 9 | -19/+129 |
| | | |||||
* | | Merge pull request #4396 from kennyj/fix_4259 | Rafael Mendonça França | 2012-06-20 | 2 | -4/+40 |
|\ \ | |/ |/| | | | Fix GH #4259. When we execute schema dumper, we must remove table_name_prefix and table_name_suffix. | ||||
| * | Fix GH #4259. We must remove table_name_prefix and table_name_suffix, when ↵ | kennyj | 2012-01-10 | 2 | -4/+40 |
| | | | | | | | | we execute schema dumper. | ||||
* | | Remove unneeded code since pluck is respecting joins now | Rafael Mendonça França | 2012-06-19 | 1 | -12/+1 |
| | | |||||
* | | Extract conditional to a method to avoid duplication | Rafael Mendonça França | 2012-06-19 | 2 | -15/+22 |
| | | | | | | | | Also use if/else block to not use short circuit return | ||||
* | | handle joins/includes correctly for pluck and calculation. | Andrey Deryabin | 2012-06-19 | 2 | -1/+49 |
| | | | | | | | | Fix #5990 | ||||
* | | Merge pull request #6782 from kennyj/db-rake-structure-dump | Rafael Mendonça França | 2012-06-19 | 9 | -14/+147 |
|\ \ | | | | | | | Refactor db:structure:dump task. | ||||
| * | | Refactor db:structure:dump task. | kennyj | 2012-06-20 | 9 | -14/+147 |
| | | | |||||
* | | | Merge pull request #6785 from kennyj/rename_testcase_name | Carlos Antonio da Silva | 2012-06-19 | 1 | -1/+1 |
|\ \ \ | | | | | | | | | Rename testcase name. It's wrong in the context. | ||||
| * | | | Rename testcase name. It's wrong in the context. | kennyj | 2012-06-20 | 1 | -1/+1 |
| |/ / | |||||
* / / | Rename MySQLTestPurge to MySQLPurgeTest for consistency. | kennyj | 2012-06-20 | 1 | -1/+1 |
|/ / | |||||
* | | Refactor db:charset task | Simon Jefford | 2012-06-19 | 9 | -20/+118 |
| | | | | | | | | | | In a similar vein to Pat's work on create, drop etc, the db:charset task is now a one liner in databases.rake | ||||
* | | Refactor the conditionals | Rafael Mendonça França | 2012-06-19 | 1 | -7/+7 |
| | | |||||
* | | Validates_numericality_of is skipped when changing 0 to to non-empty string | Angelo capilleri | 2012-06-19 | 2 | -5/+25 |
| | | | | | | | | | | | | | | | | | | | | This happens when A has_many many B and A accepts_nested_attributes B that has a numeric colum with initial 0 value. So a.update_attributes({:b_attributes => { :id => b.id, :numeric => 'foo' }}) passes the validation test but, the value of :numeric doesn't change. his commit forces that the update fails with the above conditions. Fixes #6393 Fixes #2331 | ||||
* | | Refactor and use class_attribute | Carlos Antonio da Silva | 2012-06-18 | 2 | -7/+15 |
| | | |||||
* | | Remember the stored attributes in a config attribute. | Joost Baaij | 2012-06-18 | 3 | -1/+23 |
| | | | | | | | | | | | | This allows you to retrieve the list of attributes you've defined. Usable for e.g. selects in the view, or interators based on the attributes you wish to store in the serialized column. | ||||
* | | Improve the CHANGELOG entry [ci skip] | Rafael Mendonça França | 2012-06-18 | 1 | -2/+19 |
| | | |||||
* | | Refactor Relation#update a bit to avoid an extra Enumerator instance | Carlos Antonio da Silva | 2012-06-18 | 1 | -1/+1 |
| | | |||||
* | | Make DatabaseTasks a module with real private methods | Carlos Antonio da Silva | 2012-06-18 | 1 | -13/+14 |
| | | |||||
* | | Add CHANGELOG entry to composed_of removal | Rafael Mendonça França | 2012-06-18 | 1 | -0/+6 |
| | | |||||
* | | Merge pull request #6743 from steveklabnik/remove_composed_of | Rafael Mendonça França | 2012-06-18 | 18 | -768/+9 |
|\ \ | | | | | | | | | | Removing composed_of | ||||
| * | | Removing composed_of from ActiveRecord. | Steve Klabnik | 2012-06-18 | 18 | -768/+9 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This feature adds a lot of complication to ActiveRecord for dubious value. Let's talk about what it does currently: class Customer < ActiveRecord::Base composed_of :balance, :class_name => "Money", :mapping => %w(balance amount) end Instead, you can do something like this: def balance @balance ||= Money.new(value, currency) end def balance=(balance) self[:value] = balance.value self[:currency] = balance.currency @balance = balance end Since that's fairly easy code to write, and doesn't need anything extra from the framework, if you use composed_of today, you'll have to add accessors/mutators like that. Closes #1436 Closes #2084 Closes #3807 | ||||
* | | | Add ensure Joke.reset_sequence_name | Yasuo Honda | 2012-06-19 | 1 | -0/+2 |
|/ / | | | | | | | | | to avoid ORA-02289: sequence does not exist for `SELECT "BLACK_JOKES_SEQ".NEXTVAL FROM dual` | ||||
* | | Change minimum (default) log level in PostgreSQL to warning. | kennyj | 2012-06-18 | 3 | -1/+11 |
| | | |||||
* | | Merge branch 'dp_docs' | Carlos Antonio da Silva | 2012-06-18 | 1 | -0/+92 |
|\ \ | | | | | | | | | | Closes #6697 | ||||
| * | | Documentation for where and where! methods on relations. | David Paschich | 2012-06-18 | 1 | -0/+92 |
| | | | | | | | | | | | | Based on examples seen in the Rails test suite. [ci skip] | ||||
* | | | fix invalid syntax and sqlite rake failing tests | Francesco Rodriguez | 2012-06-18 | 4 | -6/+9 |
| | | | |||||
* | | | add :nodoc: to AR::Tasks and update to follow the coding conventions | Francesco Rodriguez | 2012-06-18 | 4 | -208/+226 |
| | | | |||||
* | | | check if sqlite3 file exists before remove | Francesco Rodriguez | 2012-06-18 | 1 | -3/+3 |
| | | | |||||
* | | | Merge pull request #6761 from freelancing-god/db-rake | Jon Leighton | 2012-06-17 | 10 | -156/+983 |
|\ \ \ | | | | | | | | | Get logic out of db rake tasks, and into classes and objects | ||||
| * | | | Rails is the default (but now override able) source for environment and path. | Pat Allan | 2012-06-17 | 4 | -43/+57 |
| | | | | |||||
| * | | | Cleaning up after some warnings, adding slightly higher-level tests. | Pat Allan | 2012-06-17 | 6 | -9/+309 |
| | | | | |||||
| * | | | One line db:create/db:drop tasks. | Pat Allan | 2012-06-17 | 2 | -55/+50 |
| | | | | | | | | | | | | | | | | | | | | | | | | Now isn't that better? And yes, I know that private has no impact on class methods - it's a visual distinction, not a technical one. | ||||
| * | | | db:drop and some of db:test:purge. | Pat Allan | 2012-06-17 | 8 | -52/+243 |
| | | | | |||||
| * | | | db:create for PostgreSQL pulled out into a class. | Pat Allan | 2012-06-17 | 6 | -36/+99 |
| | | | | |||||
| * | | | db:create for MySQL now much cleaner. | Pat Allan | 2012-06-17 | 6 | -37/+230 |
| | | | | |||||
| * | | | Confirm connection is not established if file exists. | Pat Allan | 2012-06-17 | 1 | -1/+10 |
| | | | | |||||
| * | | | A beginning of sorts. | Pat Allan | 2012-06-17 | 4 | -12/+74 |
| | | | | | | | | | | | | | | | | Minimal implementation that supports db:create SQLite replacement | ||||
* | | | | Merge pull request #6759 from dylanahsmith/only-catch-standard-error | Santiago Pastorino | 2012-06-17 | 3 | -6/+6 |
|\ \ \ \ | | | | | | | | | | | Avoid unnecessary catching of Exception instead of StandardError. | ||||
| * | | | | Avoid unnecessary catching of Exception instead of StandardError. | Dylan Smith | 2012-06-17 | 3 | -6/+6 |
| | | | | | |||||
* | | | | | Adding `load_config` task as dependency. | Cairo Noleto | 2012-06-16 | 1 | -14/+14 |
|/ / / / | | | | | | | | | | | | | Without this, some tasks won't load configurations like custom engines. |