Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
| * | | | Don't rely on `Time.current` in tests | Sean Griffin | 2014-06-07 | 1 | -5/+10 | |
| | |/ | |/| | | | | | | | Millisecond inequality causes failures on Travis | |||||
* / | | changelog for #15556 and credit @kuldeepaggarwal [Kuldeep Aggarwal] | Yves Senn | 2014-06-07 | 2 | -2/+6 | |
|/ / | | | | | | | | | | | This is a follow up to #15556 @kuldeepaggarwal did submit this patch way back (#13624). | |||||
* | | Merge pull request #15556 from sgrif/sg-time-zone-aware-arrays | Yves Senn | 2014-06-07 | 2 | -1/+29 | |
|\ \ | | | | | | | Add array support when time zone aware attributes are enabled | |||||
| * | | Add array support when time zone aware attributes are enabled | Sean Griffin | 2014-06-07 | 2 | -1/+29 | |
| | | | ||||||
* | | | Merge branch 'master' of github.com:rails/docrails | Vijay Dev | 2014-06-07 | 1 | -3/+4 | |
|\ \ \ | ||||||
| * | | | [ci skip] remove double "in your" | schneems | 2014-06-04 | 1 | -1/+1 | |
| | | | | ||||||
| * | | | [ci skip] less derogatory explanation of defaults | schneems | 2014-06-02 | 1 | -2/+3 | |
| | | | | ||||||
| * | | | [ci skip] fix "note" syntax | schneems | 2014-06-02 | 1 | -1/+1 | |
| | | | | ||||||
* | | | | Merge pull request #15542 from Gaurav2728/gaurav-remove_shutdown_link | Arthur Nogueira Neves | 2014-06-06 | 1 | -4/+4 | |
|\ \ \ \ | | | | | | | | | | | remove rubyforge.org that was shut down [ci skip] | |||||
| * | | | | remove rubyforge.org that was shut down [ci skip] | Gaurav Sharma | 2014-06-06 | 1 | -4/+4 | |
| | |_|/ | |/| | | ||||||
* | | | | Removed unused `klass` definitions from types | Sean Griffin | 2014-06-06 | 6 | -21/+0 | |
| |_|/ |/| | | | | | | | | Only `Date` and `Time` are handled. | |||||
* | | | Merge pull request #15552 from sgrif/sg-remove-klass-special-case | Rafael Mendonça França | 2014-06-06 | 2 | -4/+7 | |
|\ \ \ | | | | | | | | | Remove composed_of special case from multi-parameter attributes | |||||
| * | | | Remove composed_of special case from multi-parameter attributes | Sean Griffin | 2014-06-06 | 2 | -4/+7 | |
| |/ / | | | | | | | | | | | | | As we move towards removing the `klass` method from `column`, the else clause as it stands right now will become the only case. | |||||
* / / | Don't mess with `_before_type_cast` for numeric types | Sean Griffin | 2014-06-06 | 2 | -9/+9 | |
|/ / | ||||||
* | | Merge pull request #15533 from sgrif/sg-missing-schema-tests | Yves Senn | 2014-06-06 | 1 | -0/+29 | |
|\ \ | | | | | | | Add missing test cases for schema dumping defaults | |||||
| * | | Add missing test cases for schema dumping defaults | Sean Griffin | 2014-06-06 | 1 | -0/+29 | |
| | | | ||||||
* | | | credit JoseLuis Torres for #15051. [JoseLuis Torres] | Yves Senn | 2014-06-06 | 1 | -1/+1 | |
| | | | | | | | | | | | | [ci skip] | |||||
* | | | `ActiveRecord::SchemaMigration` has no primary key. | Yves Senn | 2014-06-06 | 3 | -0/+24 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Before this patch, using `ActiveRecord::Base.primary_key_prefix_type` with `:table_name_with_underscore` would change the `SchemaMigration` model to have a primary key. This resulted in broken queries for PG because it tried to return the inserted PK (which does not exist). Closes #15051. Closes #15419. | |||||
* | | | test refactor, don't hardcode default for `table_name_prefix`. | Yves Senn | 2014-06-06 | 1 | -1/+2 | |
| | | | ||||||
* | | | test refactor, don't hardcode `primary_key_prefix_type` default. | Yves Senn | 2014-06-06 | 1 | -0/+3 | |
| | | | | | | | | | | | | /cc @zuhao | |||||
* | | | serialized Type should delegate `type_cast_for_write` to underlying Type | Yves Senn | 2014-06-06 | 2 | -1/+36 | |
|/ / | | | | | | | | | | | | | This adds a regression test for #14411, which was fixed by #15503. Closes #14411 Closes #14595 | |||||
* | | Merge pull request #15503 from sgrif/sg-json-hstore-storage | Yves Senn | 2014-06-06 | 9 | -20/+29 | |
|\ \ | | | | | | | Bring type casting behavior of hstore/json in line with serialized | |||||
| * | | Bring type casting behavior of hstore/json in line with serialized | Sean Griffin | 2014-06-04 | 9 | -20/+29 | |
| | | | | | | | | | | | | | | | `@raw_attributes` should not contain the type-cast, mutable version of the value. | |||||
* | | | `bin/rake db:migrate:status` works with legacy migration numbers. | Yves Senn | 2014-06-06 | 5 | -4/+22 | |
| | | | | | | | | | | | | | | | | | | | | | The migration numbers were normalized different ways. This left the task output in an inconsistent state. Closes #15538. | |||||
* | | | Merge pull request #14971 from versioncontrol/#14785 | Yves Senn | 2014-06-06 | 3 | -1/+26 | |
|\ \ \ | | | | | | | | | | | | | Baseclass becomes! subclass | |||||
| * | | | Fix Baseclass becomes! subclass. | Edo Balvers | 2014-05-13 | 3 | -1/+26 | |
| | | | | ||||||
* | | | | Remove optimization that was required with whiny nils | Sean Griffin | 2014-06-05 | 1 | -8/+0 | |
| | | | | | | | | | | | | | | | | Whiny nils is no longer a thing, so we no longer need this optimization | |||||
* | | | | Fix behavior of handling BC era dates. | edogawaconan | 2014-06-05 | 3 | -3/+17 | |
| | | | | | | | | | | | | | | | | BC era year is (astronomical year + 1) and starts from 1 BC. | |||||
* | | | | Merge pull request #15512 from akshay-vishnoi/delete-deprecated-method | Yves Senn | 2014-06-05 | 3 | -54/+5 | |
|\ \ \ \ | | | | | | | | | | | | | | | | Remove deprecated method ActiveRecord::Migrator.proper_table_name | |||||
| * | | | | Remove deprecated method ActiveRecord::Migrator.proper_table_name | Akshay Vishnoi | 2014-06-05 | 3 | -54/+4 | |
| | | | | | ||||||
* | | | | | Fix inverse associations test | Leandro Facchinetti | 2014-06-04 | 1 | -1/+1 | |
|/ / / / | | | | | | | | | | | | | | | | | | | | | `InverseHasManyTests#test_parent_instance_should_be_shared_within_create_block_of_new_child` was mistakenly the same as `InverseHasManyTests#test_parent_instance_should_be_shared_within_build_block_of_new_child`. | |||||
* | | | | have an actual `NullColumn` object and update docs accordingly. | Yves Senn | 2014-06-04 | 4 | -5/+16 | |
| | | | | | | | | | | | | | | | | | | | | | | | | Follow up to #15438 and #15502. /cc @sgrif | |||||
* | | | | Merge pull request #15502 from sgrif/sg-use-null-column | Yves Senn | 2014-06-04 | 2 | -23/+23 | |
|\ \ \ \ | | | | | | | | | | | | | | | | Use null column for association key types | |||||
| * | | | | Use null column for association key types | Sean Griffin | 2014-06-04 | 2 | -23/+23 | |
| | |/ / | |/| | | ||||||
* | | | | Merge pull request #15504 from sgrif/sg-postgres-defaults | Rafael Mendonça França | 2014-06-04 | 2 | -48/+11 | |
|\ \ \ \ | | | | | | | | | | | Collapse PG default extractoin of most types to single regex | |||||
| * | | | | Collapse PG default extractoin of most types to single regex | Sean Griffin | 2014-06-04 | 2 | -48/+11 | |
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | For any type that is represented as a string and then type cast, we do not need separate regular expressions for the various types. No function will match this regex. User defined types *should* match this, so that the type object can decide what to do with the value. | |||||
* | | | | Merge pull request #15463 from geopet/refactor_xml_compute_type | Rafael Mendonça França | 2014-06-04 | 2 | -6/+7 | |
|\ \ \ \ | |/ / / |/| | | | Refactor XML serializer to not depend on `serialized_attributes` | |||||
| * | | | Refactor XML serializer to not depend on `serialized_attributes` | Geoff Petrie & Sean Griffin | 2014-06-01 | 1 | -3/+5 | |
| | | | | ||||||
| * | | | Test the serialized types of virtual columns in XML | Geoff Petrie & Sean Griffin | 2014-06-01 | 2 | -4/+3 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | The previous tests were passing, because nothing ever looked at the generated XML. What was previously being generated was `<firstname type="NilClass">...`, which is not consistent with all other cases where there is not a known type. | |||||
* | | | | Merge pull request #15500 from ↵ | Yves Senn | 2014-06-04 | 1 | -2/+2 | |
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | prathamesh-sonpatki/change-wording-of-explanation-about-precision-and-scale-of-decimal-numbers Change wording of explanation about precision & scale of decimal numbers [ci skip] | |||||
| * | | | | Change wording of explanation about precision & scale of decimal numbers [ci ↵ | Prathamesh Sonpatki | 2014-06-04 | 1 | -2/+2 | |
| | | | | | | | | | | | | | | | | | | | | skip] | |||||
* | | | | | Merge pull request #15482 from laurocaetano/fix-regression-for-eager-load | Carlos Antonio da Silva | 2014-06-04 | 4 | -2/+27 | |
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | Fix regression on eager loading association based on SQL query rather than existing column. Conflicts: activerecord/CHANGELOG.md | |||||
| * | | | | Fix regression on eager loading association based on SQL query rather | Lauro Caetano | 2014-06-03 | 4 | -2/+27 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | than existing column. Fixes #15480. | |||||
* | | | | | Cleaned up duplicated CHANGELOG entry [ci skip] | Godfrey Chan | 2014-06-03 | 1 | -3/+2 | |
| | | | | | ||||||
* | | | | | reuse available belongs_to? method | eileencodes | 2014-06-03 | 3 | -5/+4 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Reflection has a `belongs_to?` method. Instead of checking for `macro == :belongs_to` throughout the source reuse existing method. I also bumped `foreign_key_present?` method onto on line because the `belongs_to?` makes it shorter than other longer lines in the same class. | |||||
* | | | | | Merge pull request #15438 from sgrif/sg-null-column | Rafael Mendonça França | 2014-06-03 | 5 | -14/+40 | |
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Return a null column when no column exists for an attribute Conflicts: activerecord/CHANGELOG.md | |||||
| * | | | | | Return a null column when no column exists for an attribute | Sean Griffin | 2014-06-03 | 5 | -14/+40 | |
| | | | | | | ||||||
* | | | | | | Merge pull request #15172 from notEthan/active_record_pretty_print | Rafael Mendonça França | 2014-06-03 | 3 | -0/+95 | |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | implement ActiveRecord::Base#pretty_print Conflicts: activerecord/CHANGELOG.md | |||||
| * | | | | | | implement ActiveRecord::Base#pretty_print + changelog | Ethan | 2014-05-29 | 3 | -0/+95 | |
| | | | | | | | ||||||
* | | | | | | | Merge pull request #15492 from sgrif/sg-dirty-defaults | Rafael Mendonça França | 2014-06-03 | 5 | -2/+40 | |
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | Keep column defaults in type cast form |